Commit Graph

2589 Commits

Author SHA1 Message Date
Adeeb Shihadeh a9626f95b6 add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
2023-08-20 20:49:55 -07:00
Shane Smiskol ac07c205ed Nissan: add alt request for engine on Rogue (#29477)
* get engine

* \xda should work

* fix issue

* Update selfdrive/car/nissan/values.py

* bump ref

* other ref
2023-08-18 23:47:58 -07:00
Jason Wen 2bd4e71b24 Hyundai longitudinal (CAN): don't send FCA11 on non-FCA cars (#28479)
* Hyundai longitudinal (CAN): don't send FCA messages to non-FCA cars

* Update comments

* outside

* change to FCA11 only

* move down

* add todos

* Apply suggestions from code review

* add todo

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-18 23:38:36 -07:00
Shane Smiskol 1a08c2986e Revert "radard: tie radard frequency to modelV2 vol. 2 (#29240)" (#29474)
* Revert "static analysis fixes"

This reverts commit a1e85f3661.

* Revert "radard: tie radard frequency to modelV2 vol. 2 (#29240)"

This reverts commit 460f5c8e0b.

* update refs
2023-08-18 22:56:43 -07:00
Shane Smiskol 38f1523742 add Kia Niro Hybrid 2019 to legacy safety mode list (#29472)
* add Kia Niro Hybrid 2019 to legacy safety mode list

* list

* test

* update docs

* space
2023-08-18 20:57:42 -07:00
Shane Smiskol 6253dca9eb CAN fingerprint: timing test (#29461)
* test fingerprint frames (timing)

* guess not needed

* it checks both buses

* use case list

* this is safe since we call current test only in the current loop, never after

* prof

* test this too
2023-08-18 14:33:13 -07:00
Terry Huang 0c50dd9d0f Ford: Kuga 2022 fingerprint (#29449)
Ford: Kuga 2022 fingerprint
2023-08-18 13:11:50 +01:00
Shane Smiskol 19767da668 CAN fingerprint: test fingerprint response (#29462)
* test finger

* split up
2023-08-18 00:37:32 -07:00
Jason Young f76ffbdbbc interfaces: add common STD_CARGO_KG to mass (#29416)
* cleanup std_cargo_kg

* fix Sonata mass

* remove snowflake construct

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-17 21:06:07 -07:00
Shane Smiskol 8dcd108972 Rename CivicParams (#29459)
* CivicParams -> ReferenceCarParams

* remove usage in interface

* better name

* revert
2023-08-17 21:02:09 -07:00
Shane Smiskol 3563292e65 test_models: remove body standstill exception (#29453)
* remove body exception

* bump to master
2023-08-17 16:26:30 -07:00
Shane Smiskol fd8f8d8785 CAN fingerprinting test (#29427)
* timing test

* test

* fix

* print

* loop

* clean up

* wider range

* Update selfdrive/car/tests/test_models.py

* Apply suggestions from code review

* run many times

* Update selfdrive/car/tests/test_models.py

* run for many its

* run with unittest and print as list

* Update .github/workflows/selfdrive_tests.yaml

* Update .github/workflows/selfdrive_tests.yaml

* total time is super inconsistent (body)

* Update selfdrive/car/tests/test_models.py

* clean up

* clean up

* clean up

* this works!

* draft

* test suite not as modular

* try something like this

* can do kb, but not too representative

* clean up

* remove kb? it depends on signals

* clean up

* more clean up

* rename

* just measure all CANParsers

* can do all this manually

* but this is way simpler

* comment

* stash

* draft

* draft

* remove old script

* clean up

* revert

* use it

* remove test

* opt

* no partial

* remove

* revert test_models

* test can fingerprinting

* so much simpler!

* fix dict resizing

* simplify

* need to do this

* fix

* move to new file

* rename

* comment

* ignore function-uses-loop-variable
2023-08-17 00:57:12 -07:00
Shane Smiskol 9d0d59ac9b Hyundai: match panda standstill check (#29442)
* bump panda

* clean up

* common?

* Revert "common?" (not now)

This reverts commit 197af7cdbb6a8c8e58fcbccca94f7db004ce91e4.

* fix

* no failures!

* remove time

* bump

* bump

* undo
2023-08-17 00:06:38 -07:00
Shane Smiskol 25ac9e2148 fingerprints: prevent global from changing (#29438)
prevent _FINGERPRINTS from changing
2023-08-16 19:52:41 -07:00
Justin Newberry d6c682b401 Subaru: Global gen1 experimental longitudinal (#28872)
* Add longitudinal support for Subaru Crosstrek and Impreza

* Update experimentalLongitudinalAvailable check

* Update supported cars list

* bump panda

* Remove/rename es_lkas_msg to es_lkas_state_msg

* Use stockAeb for AEB passthrough

* bump panda

* bump panda

* remove stockFcw from stockAeb

* Subaru: Add FCW_Cont_Beep to stockFcw signals

* bump panda

* bump panda

* update poetry deps: shellingham

* bump panda

* bump panda

* Revert "update poetry deps: shellingham"

This reverts commit 6e9b20964890c8a5c416a17b8aaad4cc16fddcfc.

* Merge fixes

* bump panda

* bump panda

* update supported cars list

* dont use counters for long control

* fix unittests

* submodules update

* only soft disable in long control

* use common functions and cleanup

* apply hystersis correctly

* move to comma repo

* use CanBus

* cleanup

* explicit copy

* behind a flag

* remove unrequired rpm checks

* add comment

* fix flag issue

* we still need to check rpm

* update docs

* enable long for a test route

* unit tests

* inactive throttle fix

* Update subarucan.py

* Update carcontroller.py

* Update carcontroller.py

* inactive throttle fix

* Delete settings

* fix rate limit

* bump submodules

* bump panda

* bump panda

* bump panda

* bump panda

* simplify initial implementation, remove AEB

* reduce initial complexity by not intercepting cruisecontrol or brake_status

* fix fwd hook test

* show pcb off warning

* cleanup and setup for tuning

* fix sumobuldes

* revert unrelated changes

* only whats required

* only whats required

* clean that up

* better comments

* behind the flag for now

* comments and minimize diff

* align stuff

* cleanup for PR

* apply review suggestions

---------

Co-authored-by: Martin Lillepuu <martin@mlp.ee>
2023-08-16 12:58:09 -07:00
Shane Smiskol b9e36b7faa car_helpers: common CAN fingerprint function (#29417)
* timing test

* test

* fix

* print

* loop

* clean up

* wider range

* Update selfdrive/car/tests/test_models.py

* Apply suggestions from code review

* run many times

* Update selfdrive/car/tests/test_models.py

* run for many its

* run with unittest and print as list

* Update .github/workflows/selfdrive_tests.yaml

* Update .github/workflows/selfdrive_tests.yaml

* total time is super inconsistent (body)

* Update selfdrive/car/tests/test_models.py

* clean up

* clean up

* clean up

* this works!

* draft

* test suite not as modular

* try something like this

* can do kb, but not too representative

* clean up

* remove kb? it depends on signals

* clean up

* more clean up

* rename

* just measure all CANParsers

* can do all this manually

* but this is way simpler

* comment

* stash

* draft

* draft

* remove old script

* clean up

* revert

* use it

* remove test

* opt

* no partial

* remove

* revert test_models
2023-08-16 03:28:50 -07:00
Shane Smiskol 2d636deb4e test_models: check panda cruise state (#29423)
* cruise state test

* add todo

* rename

* clean up

* remove
2023-08-15 23:55:53 -07:00
Shane Smiskol 4073ffb02b test_models: add full internal segment list (#29425)
full internal test models seg list

remove avalon and sienna

volt with ascm on

another volt with ascm on

9bc2ee633c361c3d|2023-07-28--20-17-51--2

dashcam mode

c4e21532b6fe3847|2023-07-05--08-34-05--1

can invalid (missing PSCMStatus)

cf6ba99592c48848|2023-07-01--11-36-56--20
2023-08-15 23:33:52 -07:00
Jason Young e1a64260d3 HKG: Vehicle mass corrections (#29418)
* HKG: Vehicle mass corrections

* not gross

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-15 20:46:57 -07:00
Shane Smiskol e2910d0720 CANParser: perf benchmark on route script (#29324)
* timing test

* test

* fix

* print

* loop

* clean up

* wider range

* Update selfdrive/car/tests/test_models.py

* Apply suggestions from code review

* run many times

* Update selfdrive/car/tests/test_models.py

* run for many its

* run with unittest and print as list

* Update .github/workflows/selfdrive_tests.yaml

* Update .github/workflows/selfdrive_tests.yaml

* total time is super inconsistent (body)

* Update selfdrive/car/tests/test_models.py

* clean up

* clean up

* clean up

* this works!

* draft

* test suite not as modular

* try something like this

* can do kb, but not too representative

* clean up

* remove kb? it depends on signals

* clean up

* more clean up

* rename

* just measure all CANParsers

* can do all this manually

* but this is way simpler

* comment

* fix mypy

* this is correct too

* 3 seconds instead of 1.5
2023-08-15 20:06:15 -07:00
Shane Smiskol 6ec00f5ee2 test_models: more typing (#29420)
* not type checked, but we set this in test_car_model

* type this
2023-08-15 20:01:33 -07:00
Justin Newberry 7ec52da33a Subaru: calculate steering angle rate (#29409)
* calculate rate

* added adeeb's comment

* move to selfdrive/car

* that makes way more sense

* much simpler

* fix rate

* preglobal doesn't have a counter

* update ref

* merge

* update ref after merging
2023-08-15 15:28:46 -07:00
Shane Smiskol 936f8b9817 test_models: some typing (#29413)
* type

* also type check this func

* unused
2023-08-15 15:25:36 -07:00
Jason Young 90c4bbe8e4 car interfaces: cleanup tire stiffness calculation (#28263)
* cleanup tire stiffness calculation

* bump cereal

* think these todos still apply

* gm: same default

* revert comments

* bump

* update refs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-15 14:17:08 -07:00
Shane Smiskol fb235238ad jenkins: re-enable test_models (#29394)
* re-enable test_models

* now?

* Remove bad Volt segment

* Update Jenkinsfile

* use first n segments
2023-08-14 16:08:34 -07:00
quinnp8703 c74daad0b9 volkswagen/audi: Additional S3 2015 firmware (#29366)
Update values.py

fingerprinting for early production 2015 audi s3
2023-08-14 13:34:44 -07:00
Justin Newberry c8cae714c6 Subaru: ES_Distance cruise cancel safety (#29362) 2023-08-13 22:14:13 -07:00
Justin Newberry 106f49a00f Ford: Explorer 2020 fingerprint (#29372) 2023-08-13 16:41:35 -07:00
Jason Wen 3a00149f56 Hyundai CAN-FD: carState cleanup (#29326)
* Hyundai CAN-FD: carstate cleanup

* Looks nicer

* Rearrange

* Fix

* Update selfdrive/car/hyundai/carstate.py

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-08-13 11:28:09 -07:00
Marcus Millspaugh 2c13dea1c8 additional Subaru fwVersion (#29365)
* Update Car/Subaru values.py to support 2022 Crosstrek

Tested via SP, just want support via stock OP

* remove duplicates

* started adding support for toyota bZ4X

* Add files via upload

* Update values.py

* Update values.py

* Update values.py

* Update values.py

* remove duplicates and mistakes

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2023-08-12 22:05:33 -07:00
morrislee 060aa33b99 Closer Silverado 1500 Weight (#29355) 2023-08-12 17:24:12 -07:00
Jason Young c76d24cec9 VW MQB: Add FW for 2017 Volkswagen Golf R (#29360) 2023-08-12 13:30:40 -07:00
Shane Smiskol f5a361a111 FPv2: fingerprint on current brand's candidates (#28435)
* pass in brand

* needs to be flipped for exact matching since it's subtractive

* new helper

* makes more sense flipped

* clean up
2023-08-11 18:47:12 -07:00
Shane Smiskol 09ce869ee7 fw_versions: clean up some typing (#29350)
* another common type

* here too

* unused
2023-08-11 18:37:17 -07:00
Shane Smiskol 001d4e8729 test_models: match online fingerprinting behavior (#29306)
* draft

* 1x

* clean up

* final clean up

* fix

* self explan

* space

* space
2023-08-11 18:33:11 -07:00
Shane Smiskol a1e85f3661 static analysis fixes 2023-08-11 18:22:42 -07:00
Shane Smiskol 1099b3486a test_models: check relay malfunction (#29270)
* check relay malfunction in test_models

* draft

* actual relay malfunction (or ASCM was turned on)

* rav4: not dashcam and op enabled, but we're not sending anything

* clean up

* spaces

* more space

* flip

* better?

* combine

* for

* move up
2023-08-11 18:10:27 -07:00
Kacper Rączy 460f5c8e0b radard: tie radard frequency to modelV2 vol. 2 (#29240)
* radard: tie radard frequency to modelV2

Accumulate parsed messages until state is updated (toyota)

Same for honda

Rename rr to something more descriptive

* Change _update method name, since signature has changed

* Update ref commit

* Some renames

* Check for number of cans
2023-08-11 18:07:06 -07:00
Justin Newberry e4ead4f183 Ruff: b905 (strict zip) (#29336)
* added mutable default args

* most of the Bs

* add comment about lrucache

* b905
2023-08-11 16:13:51 -07:00
Justin Newberry 62c1e65924 Ruff: enable most of bugbear (#29320)
* added mutable default args

* most of the Bs

* add comment about lrucache
2023-08-11 15:33:49 -07:00
Shane Smiskol 2a38f38be1 common_fault_avoidance: take a bool (#29328) 2023-08-11 00:27:53 -07:00
Shane Smiskol cbfcc40571 Car interfaces: remove hard-coded signal definitions (#27773)
* What if: no signals! 🙅🤌🎆

* do hyundai

* honda!

* do gm

* and vw! (sorry comments)

* do those

* -500

* little more

* fix subie

* change back

* bumpopendbc

* oof lol

* messages

* some clean up

* here too

* clean up honda radar_interface.py

fix

rm

* bump opendbc to master

* add todo

* rename checks in tesla/radar_interface

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-08-10 20:30:35 -07:00
Justin Newberry 8793cbff40 Ruff: enable flake8-builtins (#29315)
* enable flake8-builtins

* replace any with contains

* fix typo in pack

* fix type

* format is from the parent module, has to be enabled

* item_id

* fix item_id

* disable for id since that's what the remote server returns
2023-08-10 18:58:22 -07:00
Justin Newberry 4a9afd7554 Ruff: comprehensions conventions (#29317)
ignore c408
2023-08-10 16:40:30 -07:00
Shane Smiskol 70b1e9dd75 test_models: run on route list (#26226)
* move to openpilot

* draft

* support internal urls

* not used

* update seg list

* regen segment list

* regen seg list

* regen

* regen

* regen

* no dirty segments

* regen seg list with no fuzzy or fixed fp

* regen segments with hda2 exception

* regen with added filters

* regen without bad dongle

* regen

* regenerate!

* regenerate, only OP enabled

* regen

* regenerate!

* regenerate!

* stash

* use SegmentName

* new route list

* add temp comment

* remove comment

* let's see if this works

* comment out other tests to speed up

* fix agent

* ?

* hmm

* oh whoops...

* add matrix

* fix

* how many levels do we need?

* fix values

* matrix can't be in parallel

* how about this

* try this

* Revert matrix

Revert "try this"

This reverts commit 8d0d91fd70c467c1fbb4e4e9aed511d15b2a30ef.

Revert "how about this"

This reverts commit a8e4fc53234824e77cbfb1e471277bc033e9dea1.

Revert "matrix can't be in parallel"

This reverts commit daaa6fcc3c75c74cbb90e97c565099a94123994c.

Revert "fix values"

This reverts commit df554b6a3371d124a574eb8d26bc51ef5b5b8fde.

Revert "how many levels do we need?"

This reverts commit 1a17320fa1c5e7220ef60e29981bbb3bb7da16c6.

Revert "fix"

This reverts commit e7eb6e404358fbd2eac3fea1901a8d30ea92d729.

Revert "add matrix"

This reverts commit a1b57e5725417d3c2f639f8edfc0c889b84b6753.

* use pytest instead! (5 jobs is ~150 mins)

* split lines, uncomment

* This Sienna seg has a fault SDSU that stopped forwarding/sending msgs

* picked a route with no PSCMStatus and no panda errors, recent routes are working

* this cadillac was dashcammed (no radar)

* opened an issue for this, it's 'expected' right now

* small clean up

* small clean up

* i don't think that worked

* is this needed?

* add to new PC tests

* cache

* draft

* Revert "draft"

This reverts commit 3b7f740dd4883118747300bc3687074c2d3c2116.

* probably should be function

* draft

* clean up

* add todo

* 600 random segments

* debug

* does this fix pythonpath issues?

fix

* try this

* mount?

* pytest again!

* no need for PYTHONPATH now

* Update Jenkinsfile

* ?

* convention

* clean up

* would be even more complex (have to unset ci which is class level)

* track

* is lfs pulled at all?

* ah no it's not
2023-08-10 00:45:23 -07:00
Cruise Brantley e8f33fb5b7 Hyundai: Additional Ioniq 5 firmware (#29307)
added fwdCamera
2023-08-09 23:10:54 -07:00
Shane Smiskol 6ffdc32bfc Toyota: set stop and go if TSS2 car (#29303)
we should assume all TSS2 have stop and go (because we set them all manually)
2023-08-09 17:46:06 -07:00
Shane Smiskol 225ed2ed5a interfaces: test interface attributes (#29301)
* test

* draft

* draft

* clean up

* clean up

* better test

* clean up

* check car info

* uncomment

* rm space

* no loop

* use dbc

* more clear

* one line
2023-08-09 17:01:38 -07:00
Adeeb Shihadeh 51831d03a3 Revert "interfaces: test interface attributes (#29297)"
This reverts commit 6a678cde6c.
2023-08-09 16:28:12 -07:00
Shane Smiskol 6a678cde6c interfaces: test interface attributes (#29297)
* test

* draft

* draft

* clean up

* clean up

* better test

* clean up

* check car info

* uncomment

* rm space

* no loop

* use dbc

* more clear

* one line
2023-08-09 16:10:30 -07:00