Commit Graph

228 Commits

Author SHA1 Message Date
HaraldSchafer cf466222f6 Road Roll Compensation Rebased (#23251)
* first commit

* update refs
2021-12-16 17:34:12 -08:00
Ewout ter Hoeven 55390d273f Convert format strings strings to f-strings (#23241)
* Convert all text strings to f-strings

Reformats all the text from the old "%-formatted" and .format(...) format to the newer f-string format, as defined in PEP 498. This requires Python 3.6+.

Flynt 0.69 was used to reformat the strings. 120 f-strings were created in 51 files.

F-strings are in general more readable, concise and performant. See also: https://www.python.org/dev/peps/pep-0498/#rationale

* revert pyextra changes

* revert ublox.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-12-16 14:58:17 +01:00
Willem Melching 4f1eb4278a Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
2021-12-16 13:08:20 +01:00
Adeeb Shihadeh 1638975627 Merge 2021 Accords into 2018 Accords (#23174)
* Merge 2021 Accords into 2018 Accords

* last of them
2021-12-08 14:40:14 -08:00
Willem Melching 0ec68a5a09 0.8.11-release FW batch (#23167)
* 0.8.11-release FW batch

* those toyota also dont always return esp

* attempt to clean up 2018 & 2021 accord
2021-12-08 14:44:00 +01:00
Adeeb Shihadeh 0283942a95 Honda: use new Bosch LKAS_HUD messages (#23000)
* Honda: use new Bosch LKAS_HUD messages

* enum value

* better name

* flip that
2021-12-05 13:51:33 -08:00
Chris McCammon 9e51befe18 Honda Pilot fw (#23119) 2021-12-03 16:11:15 -08:00
Willem Melching e6180738fd add CarParams.wheelSpeedFactor (#23079)
* add CarParams.wheelSpeedFactor

* Fudge speed for Lexus RX

* should have been the TSS2 model

* bump cereal

* refactor into function

* update refs
2021-12-03 14:57:53 +01:00
Adeeb Shihadeh 239c7c1d4e Bring back Accord 2021 + 2021 Hybrid (#23021)
Co-authored-by: Chris Souers <csouers@gmail.com>
2021-11-23 23:19:11 -08:00
Adeeb Shihadeh 7746130a1e Honda Bosch cleanup (#22999) 2021-11-21 14:52:35 -08:00
Adeeb Shihadeh b07ddad6ed comma pedal: rename create_gas_command -> create_gas_interceptor_command 2021-11-20 20:13:58 -08:00
Brett Sanderson 8b25551c7f Honda: rename HONDA_NIDEC_ALT_MAIN to HONDA_PARAM_NIDEC_ALT_SCM_MESSAGES (#22970)
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-18 14:52:37 -08:00
Adeeb Shihadeh 14651866c2 Honda: handle ACC state consistent with ISO 15622:2018 (#22958) 2021-11-17 17:30:50 -08:00
Adeeb Shihadeh 70c1f19304 pedal: only send command while actuators active (#22942) 2021-11-16 22:38:23 -08:00
Willem Melching 8a8cee5e54 Batch of ECU FW from cars that fuzzy fingerprinted (#22883)
* honda

* hyundai

* toyota

* VW
2021-11-12 16:31:29 +01:00
Adeeb Shihadeh 8933859e35 Remove remaining Toyota + Honda CAN fingerprints (#22827) 2021-11-08 14:37:25 -08:00
sshane a0e5eccb70 Toyota: handle brake hold (#22810)
* disallow engagement if brake hold active

* we can check once

* move to common events

revert

* fix

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-08 14:26:30 -08:00
justinmccaffrey 28e16c7b84 Add 2021 Honda Passport (#22781)
* update values.py

* add passport to carstate, interface, values

* add a test route with mostly green

* switch to newer route

* update readme

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-11-04 15:28:04 +01:00
Adeeb Shihadeh c85c8fee3c Remove CAN fingerprints + FW dump (#22647)
* add missing pilot fw

* toyotas

* camry hybrid
2021-10-20 23:12:04 -07:00
Adeeb Shihadeh 66c20026f6 remove unused can fingerprints (#22646) 2021-10-20 22:32:51 -07:00
Willem Melching 17067549bc Honda Bosch longitudinal: show AEB disabled status on HUD (#22617)
* Honda Bosch longitudinal: show AEB disabled status on HUD

* also set acc hud
2021-10-19 16:09:14 +02:00
Robbe Derks 91987f38d4 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
2021-10-08 17:54:34 +02:00
Harald Schafer 0e4058d0ec remove unused line in honda carcontroller 2021-10-07 11:18:55 -07:00
HaraldSchafer e5da7cc04b no throttle when not enabled (#22474) 2021-10-07 11:15:08 -07:00
Willem Melching 6c29a4c7fb Honda Bosch longitudinal tuning (#22407)
* revert changes to standstill logic

* start with mostly open loop

* Revert "revert changes to standstill logic"

This reverts commit d737d858e7708aedaf09cfc068b85398161e9bbe.

* proper clipping

* less lag

* less gas command

* start gas from -0.2

* controls should take care of that

* use CarControllerParams

* switch to braking sooner

* Revert "switch to braking sooner"

This reverts commit cf11dae334ccb369f625d4b13b7cd4176156a446.

* 2.5x more P

* use active

* engage on rising edge

* Revert "engage on rising edge"

This reverts commit c972956cb460eedaff3d0169a40673a6ea933385.

* update ref
2021-10-07 16:37:02 +02:00
Erich Moraga 519fdc0816 RIDGELINE add missing combinationMeter f/w (#22458)
`elliot sharpe <elliot2345@hotmail.com>`  2021 Ridgeline  DongleID/route 03ba90562055a83e|2021-10-06--08-27-30
2021-10-06 11:56:46 -07:00
Willem Melching 26ce0fa0cb Honda Bosch: switch ACC_HUD between metric/imperial (#22428)
* Honda Bosch: switch ACC_HUD between metric/imperial

* bump opendbc
2021-10-04 18:42:06 +02:00
Kamil Klimkiewicz 2ab0d52fda Add fingerprint for 2019 Honda Civic Hatchback (#22400)
Honda Civic Hatchback 1.0T Elegance (Europe - Poland)
2021-10-01 15:02:26 -07:00
Adeeb Shihadeh 4c0b82308d honda nidec: fix no acceleration with pedal (#22368) 2021-09-28 16:31:12 -07:00
Adeeb Shihadeh 3b8fa4b7fd controls: only send cruise cancel while cruise is enabled (#22359)
* controls: only send cruise cancel while cruise is enabled

* cleanup

* might actually do something

* update refs

* update refs again

* update refs
2021-09-28 12:30:50 -07:00
John Belmonte 29edd56049 honda: replace hard-coded address for STEERING_CONTROL check (#22352) 2021-09-27 10:11:58 -07:00
John Belmonte edabca193d Car Port: Honda Freed 2020 (#22003)
* car port: Honda Freed

Popular 3-row compact minivan in Japan based on Fit platform.

test route: 2c4292a5cd10536c|2021-08-19--21-32-15

* missing DRIVERS_DOOR_OPEN signal on FREED

* remove redundant long parameters

* additional FW; confirm lack of stop-and-go

* restore gateway ECU to fingerprint

* corrected mass and wheelbase

* add another forwardRadar id
2021-09-24 17:11:47 -07:00
HaraldSchafer 4e939a9648 NIDEC pedal, good gas/brake transition (#22314)
* need gas to combat windbrake

* coasting deadzone

* no pcm gas and no pedal when braking
2021-09-24 11:24:49 -07:00
Willem Melching c68fc8ef9c set Honda Bosch long lag to 1s (#22335)
* set Honda Bosch long lag to 1s

* update ref
2021-09-24 10:28:00 -07:00
Adeeb Shihadeh 649af76fd4 remove community supported cars from community features (#22330)
* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
2021-09-23 17:34:52 -07:00
Chris McCammon 5f85ea09cd Add Odyssey fw versions (#22266)
* 6a492387bdfcb4ba

* rerun ci
2021-09-17 16:55:34 -07:00
John Belmonte 7ee9ba34dd Honda carstate: refactor MAIN_ON signal (#22226)
* Honda carstate: refactor MAIN_ON signal

MAIN_ON handling was scattered throughout the code since
the enclosing message differed by model.  Store the message
name in the instance.

Several cases in get_can_signals() and update() were
subsequently collapsed.

* remove duplicate BRAKE_HOLD_ACTIVE signal

* Update selfdrive/car/honda/carstate.py

* add some whitespace

* cleanup carstate

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-15 19:00:44 -07:00
John Belmonte f07e1ae99e Honda carstate: use common gas pedal signal (#22010)
* Honda carstate: refactor GAS_PEDAL handling

* collapse SCM signal cases

* stop using CAR_GAS signal (combined user pedal + computer)

* cleanup

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-13 22:41:50 -07:00
Willem Melching c4bac6bd68 Hyundai longitudinal prerequisites (#22121)
* panda

* bring over changes

* dont check car model

* remove comment

* fix typo

* more stuff gated behind long

* not

* not used

* gate that too

* try honda tuning

* clip accel values

* fix up merge

* fix stopping

* add retry logic around knockout

* increase timeout

* keep flipping lead bit

* true for now

* less tuning

* update comment

* 0.1 s is fine now

* merge honda and hyundai knockout

* more lead fields

* another obj bit

* increase timeout

* fix stopping flag

* only lag compensate for braking

* no lead

* less tuning

* only do knockout if not readonly

* try controlling using jerk

* tuning

* try higher stopping rate

* set stopping flag at higher speed

* clip upper jerk when stopping

* remove comments

* tester present 1hz

* use positive start accel

* 1.0 to maybe improve low speed stuff

* no point going over 0

* bump panda

* bump panda

* revert that change

* update ref
2021-09-13 22:03:08 -07:00
Willem Melching 1e62b09e5d Use CP.vEgoStopping and clean up CP.startAccel (#22199)
* use CP.vEgoStopping and clean up

* update ref
2021-09-11 17:13:30 -07:00
HaraldSchafer 74b6c87254 cleanup old nidec accel override logic (#22181)
* cleanup old nidec accel override logic

* add ref without deprecated fields

* no more override
2021-09-10 10:34:18 -07:00
vanillagorillaa bcb8a11d7f Honda e Port (#22108)
* Honda e Port

* Test route for Honda e

* remove

* Update README.md

* update values based on logs

* no need for Honda e specific DBC

* fix tests

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-07 16:46:44 -07:00
HaraldSchafer 449a28b9aa Speed only ACC control for NIDEC Odyssey (#22156)
* speed only nidec control

* mergeable
2021-09-06 21:11:26 -07:00
Willem Melching 21ae64868e put LongControlState in CarControl.Actuators (#22154) 2021-09-06 18:45:59 -07:00
Willem Melching f941111dcd Clean up PID controller ACCEL_MIN/ACCEL_MAX (#22148)
* use ISO 15622:2018 limits in PID controller

* allow more for nidec

* limit PID inputs

* CP is not needed

* add GM

* not used

* update ref

* fix honda bosch
2021-09-06 17:29:32 -07:00
Harald Schafer 054c912b9a need to add gas here 2021-09-03 14:01:24 -07:00
John Belmonte e7c4992900 Honda CarState: clean up unnecessary instance attributes (#22117) 2021-09-03 09:43:30 -07:00
HaraldSchafer ebf2a2279d Prevent PID windup on Honda NIDEC (#22112)
* add higher set speed

* freeze when close to cruise

* dont bias this

* higher set speed

* start high

* 2mph might be needed

* better condition

* limit accel windup like this

* wrong name
2021-09-02 14:16:44 -07:00
John Belmonte 44c546c92a Honda HR-V: set standstill (#22009)
* fix apparent Honda HR-V bugs

  * CarState.standstill was not set
  * CarState.gas was not derived from GAS_PEDAL/CAR_GAS

* revert gas change

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-02 14:05:00 -07:00
HaraldSchafer c93f3b10f7 no more old nidec (#22104) 2021-09-02 12:05:03 -07:00