Commit Graph

51 Commits

Author SHA1 Message Date
Shane Smiskol c8f5b21744 Clean up CarInterface.apply and CarControllers (#24060)
* do tesla

* parentheses

* Do Chrysler

* Make sure Hyundai long never actuates when long inactive

.

* clean up Hyundai

* more clear

* formatting

* Stock sets these to zero

* fix params

* move jerk logic into CC

clean up
2022-04-05 23:38:45 -07:00
Shane Smiskol 7a2f3c023e Hyundai: clean up CarInterface apply function (#24000)
* clean up Hyundai CarController

* remove
2022-03-18 21:08:15 -07:00
Adeeb Shihadeh 2219cb4478 cars: cleanup CS usage (#23957) 2022-03-18 15:39:22 -07:00
Shane Smiskol 6c7d178d96 Hyundai: send driver override state when gas is pressed (#23745)
* send pre-enable state when gas is pressed

formatting and it's out

forgot one

allow gas press

show toggle

revert changes

revert changes

* revert change
2022-03-18 14:54:20 -07:00
Adeeb Shihadeh 5c3f3e44bc break up selfdrive.config (#23959)
* break up selfdrive.config

* add to release files

* fix import order
2022-03-13 21:42:39 -07:00
Shane Smiskol 629399a449 carControl: add long and lat active fields (#23859)
* proof of concept

* actuators packet describes which actuators are active

* bump cereal

* fixes

* not needed for this PR

* Do Toyota

* add back controlsState.active

* bump cereal

* rest of cars

* in actuators

* add active back

* which

* use controlsState.active for now

* will make an issue

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move local lat_active checks into CC.latActive

* remove redundant checks

* move comment

move comment

* fix joystick mode

* get enabled from carcontrol

* do standstill check in controlsd

* make sure we consider the gas press case for GM

* use CC.actuators

* fix

* capitalization

* Bump cereal

Bump cereal

* make intermediate actuators

* similar convention to before

* clean that up

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-13 20:58:44 -07:00
Adeeb Shihadeh 87849f93b1 better steer fault names (#23890)
* better steer fault names

* bump cereal
2022-03-01 22:53:55 -08:00
Adeeb Shihadeh 72e00a0768 No actuation while in pre-enabled state (#23658)
* No actuation while in pre-enabled state

* update refs
2022-01-28 16:03:44 -08:00
Dean Lee a653461dec check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2022-01-10 16:36:51 +01:00
Jason Wen bd399693b6 Hyundai: Car Port for 2022 Santa Fe Plug-in Hybrid (#23332)
* Add car port: Hyundai Santa Fe Plug-in Hybrid 2022

* Add test route
2021-12-31 17:28:07 -08:00
Willem Melching 4f1eb4278a Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
2021-12-16 13:08:20 +01:00
Andrew 2a6816b893 Genesis G70 2020 port (#22692)
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-18 20:45:32 -08:00
Jason Wen 73d66ada8d Hyundai: Car Port for 2022 Santa Fe Hybrid (#22962)
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-18 17:33:10 -08:00
Jason Wen d01c340f1f Hyundai: Car Port for 2022 Hyundai Ioniq Hybrid (#22610)
* Add car port: Hyundai Ioniq Hybrid 2022

* Update RELEASES.MD

* Update CARS.md

* Add test route: Hyundai Ioniq Hybrid 2022
2021-10-19 16:59:10 -07:00
Jason Wen 6018bda2ba HKG: Car Port for 2021 Kia K5 (#22347)
* HKG: Kia K5 2021 Car Port

* Update CARS.md and RELEASES.md

* Add test route: Kia K5 2021

* Update firmware format due to recent query change

* Update CARS.md: not all 2021 Kia K5 have SCC

* Update test_routes.py
2021-09-30 14:35:14 -07:00
Jason Wen 9acc592cd9 Hyundai: Car Port for 2022 Hyundai Santa Fe (#22325)
* Add fingerprint: Hyundai Santa Fe 2022

* Update LFAHDA_mfc: Add 2022 Hyundai Santa Fe

* Add car port: Hyundai Santa Fe 2022

* Add test route: Hyundai Santa Fe 2022

* Update RELEASES.md

* Update CARS.md

* Update RELEASES.md

* Remove FPv1 due to deprecation
2021-09-23 16:03:28 -07:00
Willem Melching c4bac6bd68 Hyundai longitudinal prerequisites (#22121)
* panda

* bring over changes

* dont check car model

* remove comment

* fix typo

* more stuff gated behind long

* not

* not used

* gate that too

* try honda tuning

* clip accel values

* fix up merge

* fix stopping

* add retry logic around knockout

* increase timeout

* keep flipping lead bit

* true for now

* less tuning

* update comment

* 0.1 s is fine now

* merge honda and hyundai knockout

* more lead fields

* another obj bit

* increase timeout

* fix stopping flag

* only lag compensate for braking

* no lead

* less tuning

* only do knockout if not readonly

* try controlling using jerk

* tuning

* try higher stopping rate

* set stopping flag at higher speed

* clip upper jerk when stopping

* remove comments

* tester present 1hz

* use positive start accel

* 1.0 to maybe improve low speed stuff

* no point going over 0

* bump panda

* bump panda

* revert that change

* update ref
2021-09-13 22:03:08 -07:00
Greg Lincoln 1bb46d0cc8 Kia Niro HEV 2021 port (#21779)
* Initial Niro HEV 2021 port.

* Add test route and update readme.

* Tweak configuration.
2021-08-12 10:45:37 -07:00
Adeeb Shihadeh e598b78b5d Car Port: Kona Hybrid 2020 (#21912)
* Update carcontroller.py

* Update hyundaican.py

* Update interface.py

* Update interface.py

* Update values.py

* add test route

* merge the konas

* add to readme

Co-authored-by: haram-KONA <88036668+haram-KONA@users.noreply.github.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-11 22:48:12 -07:00
Matthew Washburn e364084fa6 Sonata Hybrid 2021 (#21850)
* Add support for Hyundai Sonata Hybrid

* Update test_routes.py

* whitespace

* same params as sonata

* Update README.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-08-11 22:03:49 -07:00
Jason Young cfe97fcc49 HKG: 2019 Kia Niro PHEV (#21481)
* Testing addition of 2019 Kira Niro PHEV

* Testing addition of 2019 Kia Niro PHEV

* Fix typos

* Remove bad Optima fw, switch Niro to FPv2

* Set minimum steer speed for 2019 Kia Niro HEV/PHEV

* Add 2019 Kia Niro PHEV to README

* Fix typo

* apparently we get trailing garbage sometimes

* No FCA11 message, also use ELECT_GEAR

* i am not good with alphabet

* Add test route for Niro HEV

* Remove LFA for 2019; no legacy safety

* minSteerSpeed handling

* vehicle disengages SCC below 10mph

* no longer need Genesis specific code for minSteerSpeed

* simplify
2021-07-07 19:24:13 -07:00
Andrew 9124a83900 2021 Hyundai Elantra Hybrid port (#21354)
* add support for hyundai elantra hev 2021

* add car to README. adjust tuning params.

* adjust weight

* update fingerprint with value from remote start

* update fingerprint to value of BEFORE getting in car (more reliable)

* add fingerprint v2

* remove fingerprint 1.0

* add test route

* Update README.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/test/test_routes.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/hyundai/values.py

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-21 16:03:19 -07:00
ShaneSmiskol e7df9adfe3 2020 Ioniq PHEV Support (#21147)
* use DriverOverride

* keep using EMS16 msg which is available on manuals, TCS13 is not

* Need to differentiate between hybrid ev and ev

* bump opendbc

* add to release files

* try this

* try this

* fixup

* shouldn't need multiple dbc's

* update comments

* combine phev into ev_hybrid

* clean up

* accel_pedal_pos is a percent

* bump

* bump

* update list name

* do this in another PR

* not 2020+

* explicitly set safety param

* full hyundai gas press test coverage

* bump

* bump

* bump

* bump

* like this convention better

* bump

* revert some null gas_signal changes for now

* revert style change

* Add Ioniq PHEV 2020

* Use appropriate signals

* can't verify this to be true

* defaults

* order should really be opposite...

* original style

* bump panda

* bump

* update releases

* bump panda

* Update test route

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-10 23:25:02 -07:00
CrispinFlowerday 7458e143e3 Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
2021-06-07 15:06:28 -07:00
Greg Hogan 6e300aaf57 hyundai: disable steering on all steer warnings (#20657)
* hyundai: set CF_Lkas_ToiFlt for wind down

* hyundai: disable steering on all steer warnings

* Revert "hyundai: set CF_Lkas_ToiFlt for wind down"

This reverts commit 065f0a996db9e52511013c7011ed95876966d134.

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-03 15:34:25 -07:00
Adeeb Shihadeh 9740052378 Kona EV: send LFA MFA message (#20320) 2021-06-01 18:11:46 -07:00
Cruise Brantley 42cd7b2b09 2021 Hyundai Elantra port (#20916)
* Elantra addition without fingerprint

* FPv1

* ignore fpv2 for fingerprint

* remove blank fpv2 troubleshooting

* FPV2

* missing commas

* added additional detected transmission

* Added to ignored fingerprints

* Test Route added

* Possible fixex for issues stated

* eps detected differently, added second detection

* Updated Naming
2021-05-18 15:52:22 -07:00
qadmus 0d61d8a4b6 int(round()) on apply_steer for correct comparison after rate limiting (#20425) 2021-03-22 13:01:33 +01:00
speedking456 e59f7e0540 Kia Seltos 2021 (#20321)
* Update hyundaican.py

* Update carcontroller.py

* Update interface.py

* Update values.py

* Update interface.py

* Update interface.py

* Update values.py

* Update values.py

* Update values.py

* Update values.py

* Update interface.py

* Update values.py

* Update values.py

* Merge 4 conflict resolution

* Update README.md

* Update test_car_models.py

* Update values.py
2021-03-11 15:56:14 -08:00
Adeeb Shihadeh 62512d6265 Kia Ceed 2019 (#20283)
* Update values.py

* Update interface.py

* Update values.py

* Update README.md

* Update README.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update test_car_models.py

* Update test_car_models.py

* passes tests

* only fw

* add to release notes

* move that

* send lfa mfa

Co-authored-by: ZanZaD13 <65367004+ZanZaD13@users.noreply.github.com>
2021-03-10 17:02:31 -08:00
Adeeb Shihadeh 312b681a46 cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65ebd01abfa8493ae12c9e6b14f7ada976.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
2021-02-16 21:39:32 -08:00
Greg Hogan 2da6bb482e hyundai: increase steering angle limit for custom eps fw (#19744)
* hyundai: increase steering angle limit for custom eps fw

* update commit_ref
2021-01-14 13:09:23 -08:00
Greg Hogan f205f97be0 hyundai: support for controlling cruise speed via HDA (#19635) 2021-01-12 11:50:08 -08:00
Willem Melching e4cf43c6fc Move all CarControllerParams into values.py (#19663)
* toyota

* use scale from values.py

* nissan

* subaru

* honda

* gm

* toyota combine into CarControllerParams

* nissan refactor

* chrysler refactor

* mazda refactor

* hyundai refactor

* subaru refactor
2021-01-06 11:20:44 +01:00
Greg Hogan 97bfd91955 hyundai: increase number of resume messages sent at a time (#19634)
* make hyundai resume reliable

* typo

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-01-05 21:10:21 -08:00
baldwalker 43c05aa2c6 Separate Hyundai Ioniq Hybrid and EV 2020 Premium SE (#19500)
* Update carcontroller.py

* Update hyundaican.py

* Update interface.py

* Update values.py

* Update values.py

* Update values.py

* Update values.py

* Update values.py

* Update README.md

* Update test_car_models.py

* cleanup interface
2020-12-17 11:25:56 -08:00
Adeeb Shihadeh 5f472acf4c hyundai cleanup (#2486)
* small hkg cleanup

* little more
2020-11-05 14:35:28 -08:00
NiCK.n17 b1abb47fbd Car bug fix: 2020 Kia Niro EV orange lanes icon and LKAS error on cluster display (#2454) 2020-10-30 17:45:57 -07:00
Adeeb Shihadeh 725e3b78ea HKG fixups (#2342)
* fix hyundai blinker state

* consistency with update_speed

* update refs

* make hyundai resume reliable

* update refs

* 20 works

* don't need that

Co-authored-by: Greg Hogan <gregjhogan@gmail.com>
2020-10-14 18:27:27 -07:00
Adeeb Shihadeh 67aec50b88 Increase HKG torque limit (#2249)
* increase hkg torque limit

* update refs

* bump panda
2020-10-01 13:16:51 -07:00
Adeeb Shihadeh 284938cd43 fix hyundai editing can parser values 2020-08-28 21:34:34 -07:00
Adeeb Shihadeh b81f404457 Simplify hyundai resume logic (#1852)
* simplify hyundai resume logic

* more reliable

* SCC doesn't resume under 3.7m
2020-07-10 12:53:14 -07:00
Adeeb Shihadeh 57deb3a893 Hyundai Ioniq SE 2020 (#1786)
* Update values.py

* Update carcontroller.py

* Update values.py

* Update interface.py

* Update carcontroller.py

* add test route

* readme

Co-authored-by: baldwalker <insigniadesign@yahoo.co.uk>
2020-06-26 12:25:09 -07:00
xx979xx c8377131dc fix auto resume logic (#1657) 2020-06-08 14:15:22 -07:00
Adeeb Shihadeh f3dcf861c7 enable flake8 E303: too many blank lines 2020-05-31 17:21:11 -07:00
Adeeb d9bf9f0a40 Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
2020-05-30 20:14:58 -07:00
Scott Adair de910e93d5 Car Support - 2020 Hyundai Palisade (#1382)
* Added support for the 2020 Hyundai Palisade

* Updated

* Apply suggestions from code review

Co-Authored-By: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-04-17 11:45:07 -07:00
Willem Melching 7d78cef34b Hyundai-Kia-Genesis (HKG) (#1362)
* hkg

* Cleanup

* Update readme

* more fixes and cleanup

* Old genesis

* Typoe

* Test car models

* Update comment

* Fix brake pressed

* Update release notes

* Fix vEgo

* Add sonata

* Add sonata values

* Temporarily remove doors check. It doesn't work

* Sonata uses crc8

* Fix tests

* Changes for LFA

* Add comment

* Does this improve the hud?

* Proper signal name

* Force the right value

* some ui stuff

* more comments

* Show lane lines on sonata

* cleanup dash

* fix last ui issues

* Fix doors

* update CI

Co-authored-by: Comma Device <device@comma.ai>
2020-04-15 19:33:24 -07:00
Adeeb 13f60eae91 Abstract CarInterface init (#1131)
* abstract CarInterface init

* unused

* subaru

* gm cleanup

* vw

* typo

* carcontroller

* more cleanup

* fix vw
2020-02-19 20:37:07 -08:00
rbiasini 0c67143c92 Carstate returns capnp struct (#1115)
* Before abstraction, adding speed init from VW as well

* strting to abstract carstate class

* fix bug and update lock?

* revert pipfile change

* another bug

* fix linter

* bug fix

* remove a bunch of diplicated kf code

* better to not have class vars. will abstract __init__ anyway later

* abstract common instance vars in carstate init and a generic gear parser static method

* abstract gear parser for chrysler

* abstract gm gear parser too

* remove unnecessary random vars

* Chrysler: carstate returns capnp struct directly

* revert ref commit

* test ref

* WIP

* more WIP

* ops, missed this conflict

* ford as well

* not sure why this got deleted

* no need to copy

* remove copy

* remove copy import

* remove unnecessary intermediate variable

* remove obsolete comments

* GM: have carstate returning capnp struct directly

* Honda carstate also outputing capnp struct

* hyundai too now returns capnp from carstate

* ops, not meant this

* Subaru carstate also returning capnp

* Toyota: capnp struct as output of carstate

* fix bool

* minor simplififcation in Honda

* no need to negate

* VW carstate returning capnp struct (#1118)

* VW carstate also returning capnp struct

* fixed typo

* Remove unused blinker button (#1119)

* remove unused blinker button

* ops, this wasn't meant

* remove blinker button for VW as well

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-02-18 15:28:15 -08:00