Commit Graph

110 Commits

Author SHA1 Message Date
Adeeb 367155168a Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
2020-06-03 16:13:34 -07:00
Adeeb ab83e48ec4 Add pre-commit hooks (#1629) 2020-06-03 12:54:49 -07:00
Willem Melching 843a64c72f Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
2020-06-02 16:29:32 -07:00
Willem Melching a108e7f211 paramsd output at 20 Hz instead of 100 Hz 2020-06-01 13:47:17 -07:00
Adeeb Shihadeh f3dcf861c7 enable flake8 E303: too many blank lines 2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Adeeb Shihadeh efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Adeeb 6051061ff8 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
2020-05-31 00:48:47 -07:00
Adeeb d9bf9f0a40 Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
2020-05-30 20:14:58 -07:00
Willem Melching 3d08dcc3b2 Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
2020-05-28 15:05:04 -07:00
Willem Melching 29aaa44740 flake8 in pre-commit(#1583) 2020-05-27 20:33:05 -07:00
Willem Melching bd06434243 pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
2020-05-27 20:00:14 -07:00
Harald Schafer 5a841c2856 Revert "better values"
This reverts commit 109ba298b1.
2020-05-27 17:11:27 -07:00
Willem Melching 8ea8f405db add gpsOK flag to liveLocationKalman 2020-05-27 15:14:13 -07:00
Harald Schafer 109ba298b1 better values 2020-05-27 12:16:05 -07:00
HaraldSchafer 7c8d6cbdef pure init (#1569) 2020-05-26 20:49:14 -07:00
Harald Schafer 00e05bc7d8 needed for stability 2020-05-21 17:47:05 -07:00
Willem Melching ab5af232b2 Use C++ version of SubMaster and PubMaster (#1548)
* add PubMaster & SubMaster

remove 'delete msg'

remove headers

* use constructor to initial all submster

* modify drain sockets

* fix typo in ssconscript.remove lines

no checkValid in loggerd

last modify

handle_message:event->&event

fix type

remove heads

event to auto

* new interface

* api changed

* Revert "use constructor to initial all submster"

This reverts commit 73be7ea46250a325ce41d3a0445e34395a2ae692.

* change to new api

* revert loggerd

* dd

* use new PubSub api

* update to new interface

don't modify loggerd

reset panda

reset opendbc

remove empty lines

* switch to new pubMaster

* update to the new inteface

change

remove error code

. to ->

merge paramsd.cc

update panda

fix typo

simplify

fix typo

* Fix build

* always conflate

Co-authored-by: deanlee <deanlee3@gmail.com>
2020-05-21 16:04:33 -07:00
HaraldSchafer 7ffaff029f Calib in settings (#1543)
* test test

* yo dawg

* yo dawg 2

* yo dawg 3

* calib in ui

* no pitch and yaw

* no more drive rating

* stricter

* param is no longer a vp

* less wall of test

* less is more

* better language

* cleaner
2020-05-20 19:21:03 -07:00
Willem Melching 8f3e932f96 Locationd fixes 2020-05-20 14:18:28 -07:00
Willem Melching f69f200178 Rename enum 2020-05-19 18:13:11 -07:00
Willem Melching 44484102db Paramsd handle liveLocation not valid and add alerts 2020-05-19 17:00:30 -07:00
Willem Melching d099e09fb7 Handle posenet and sensor alerts in locationd (#1541)
* handle posenet and senor alerts in locationd

* defaults now set in capnp file

* Cleanup c++ version of params learner

* update ref commit
2020-05-19 16:45:20 -07:00
HaraldSchafer 81686547cc Locationd cleanup (#1517)
* way cleaner take 2

* cleanup

* be more relaxed

* just let it be

* don't drive backwards or upside down

* do this more

* vNED sometyimes invalid

* use reasonble stds

* stability in nonlinear zone

* previous metrics were without publishing
2020-05-17 20:59:53 -07:00
Willem Melching 896bd1b5c7 use base class in car_kf 2020-05-15 15:48:48 -07:00
Harald Schafer 273e81715a xRevert "way cleaner"
This reverts commit a4ffd8c226.
2020-05-15 14:29:34 -07:00
Harald Schafer a4ffd8c226 way cleaner 2020-05-15 14:24:11 -07:00
Willem Melching 2cc218e144 lane kf was not built 2020-05-15 14:22:36 -07:00
Paweł Goliński 8b0ab73fef Use Conversions in calibrationd (#1511) 2020-05-14 17:56:45 -07:00
Bruce Wayne f8a0eb0f7a make linter happy 2020-05-14 17:38:52 -07:00
Harald Schafer 013e49bf90 too complex 2020-05-14 16:30:00 -07:00
Willem Melching 28bf5d1dd8 Rednose (#1503)
* add rednose

* update rednose

* This compiles

* Add rednose to release

* cleanup

* Extract generated dir as argument

* Add constants.py to release

* Add rednose to dockerfile

* Fix that
2020-05-14 15:36:56 -07:00
Willem Melching add784a7df remove eigen from phonelibs (#1505) 2020-05-13 16:41:52 -07:00
Adeeb 008700a6b3 LGTM fixes (#1480) 2020-05-09 16:40:43 -07:00
robbederks 71bebc4fca Ambient light calibration parameters on persist partition (#1429)
* WIP: light sensor persistent params

* fix params writing

* Persistent params argument in C params lib. Fixed symlink flow

* Removed debug prints

* fix boardd

* fix ui

* remove debug print
2020-05-08 19:39:18 -07:00
Adeeb Shihadeh 9670f8fb9f these don't need json 2020-05-04 23:37:07 -07:00
George Hotz d5ca841b0f Revert "Bypass alignment related copy whenever possible (#1443)"
This reverts commit b225016628.
2020-05-04 09:54:05 -07:00
George Hotz e568d3cadc More LGTM fixups (#1457)
* exclude lib dirs, fix 3 cpp errors

* fix more alerts, exclude mkvparse

Co-authored-by: George Hotz <geohot@gmail.com>
2020-05-02 20:00:41 -07:00
George Hotz 1295cfe06c Using lgtm.com and fixing found alerts (#1452)
* lgtm in readme, and mac nui fixes

* call super inits in radars

* unused imports, dup lines

* more radars, more unused imports

* pass CP into RadarInterfaceBase

* more fixups

* unused imports

* delete unused lines

* ugh, new unused import

Co-authored-by: George Hotz <geohot@gmail.com>
2020-05-02 12:07:34 -07:00
Dean Lee b225016628 Bypass alignment related copy whenever possible (#1443)
remove blank lines

add file messagehelp.h

remove blank line

simplify

after review
2020-05-01 19:21:00 -07:00
Willem Melching 8db89a6b04 Return avg angle offset 2020-04-28 17:47:04 -07:00
Willem Melching 9159a8d701 Retune stiffness 2020-04-28 15:30:11 -07:00
Willem Melching b2aefd252f Faster sR and stiffness factor 2020-04-27 16:39:27 -07:00
HaraldSchafer 368b65e29b angles instead of vp (#1421)
* angles instead of vo

* clean migration
2020-04-27 13:58:36 -07:00
Willem Melching f15d55c2b1 Car_kf tuning 2020-04-23 14:48:14 -07:00
Willem Melching 12af1f9175 Refactor locationd message building 2020-04-21 17:13:54 -07:00
Harald Schafer 3aab9facaa mixed up 2020-04-20 14:39:18 -07:00
Harald Schafer 438b03d9f2 no param reads in pipeline 2020-04-20 14:00:06 -07:00
HaraldSchafer 28d8b4abac Fallback publish calib (#1392)
* if no inputs still publish

* better
2020-04-17 17:05:54 -07:00
HaraldSchafer a18832748c rely on carstate to be sure (#1363)
* rely on carstate to be sure

* relies on carstate now too

* don't know how else to make this work

* update ref

* clean up hacks

* prev ref was weirdly bad?

* lets try that from my machine

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-04-15 13:14:23 -07:00