Commit Graph

1039 Commits

Author SHA1 Message Date
pencilpusher 472151b6a0 ui/map: keep the car icon aligned to its bearing (#29482)
* rotate icon with current bearing

When user is rotating the map, the car icon should stay fixed on the cars bearing, not the map.

* spacing

* comment

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-23 17:33:58 -07:00
Dean Lee 5fcb7e9038 ui/PrimeUserWidget: cleanup layout (#29492)
cleanup layout

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-23 16:34:18 -07:00
Dean Lee 5480d32bb5 cpplint: add filter whitespace/parens (#29565) 2023-08-23 14:25:05 -07:00
Dean Lee 2d99521e75 cpplint: build/include_what_you_use (#29556)
* include_what_you_use

* remove comments

* include <memory>

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-08-23 13:25:17 -07:00
Dean Lee 363740a497 cpplint: add readability/braces filter (#29554) 2023-08-23 10:13:46 -07:00
Dean Lee 5765c1d978 ui/settings: Don't apply styles to more elements than needed. (#29463) 2023-08-22 14:00:01 -07:00
Adeeb Shihadeh 952d720b6e add cpplint (#26855)
* setup cpplint

* only start that

* check line length

* check these

* rm exceptions
2023-08-22 13:55:23 -07:00
Adeeb Shihadeh a9626f95b6 add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
2023-08-20 20:49:55 -07:00
Dean Lee 9ea2cd8d0b ui/map_instructions: center lanes (#29465)
* center lanes

* test

* similar spacing and no need for stretchj

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-19 01:23:42 -07:00
pencilpusher f2d22075eb ui/map: interactive counter fix (#29470)
* use interactive_counter instead of separate zoom and pan counters

* use interaction_counter instead of separate zoom and pan counters

* same styling

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-19 00:07:52 -07:00
Dean Lee efefcfdca5 ui/map: better rounding for distances (#29151)
* round distance

* use same format in ETA

* remove vanish

* restore translate

* use nearbyint

* update translations

* mark finished

* consistent style

* we don't include this anywhere in ui, needed?

* fix missing std

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-17 22:58:18 -07:00
Shane Smiskol d827cd6a83 map eta: use pair (#29460)
use pair
2023-08-17 22:42:12 -07:00
Shane Smiskol 6d2922b8e6 ui/map: slight turn lane types (#29446)
* add slight turns

* bump cereal

* revert

* hmm, i like this better

* whops

* fix

* bump
2023-08-17 20:51:52 -07:00
Dean Lee b8b1e17a21 ui/networking: do not skip the connected network (#29396)
* do not skip connected network

* simplify

* revert

* revert

* no implicit

* ifwt

* fix missing ssid

* makes more sense to only update security_type once (first vs. last)

* better comment

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-17 14:43:40 -07:00
Dean Lee 1887d9197a ui/networking: pass network by value (#29448) 2023-08-17 11:37:42 -07:00
Dean Lee 202b2f2113 ui/map: hide icon if no maneuver type (#29084)
hide icon if no maneuver type
2023-08-17 02:05:19 -07:00
Dean Lee 3a277f1b81 ui/map: show map on destination set/change (#29327)
* show map on dest set/change

* check for rcv_frame

* clear current_nav_dest

* restore allow_open

* use requestShow

* cleanup

* one check

* revert behavior changes

* Update selfdrive/ui/qt/maps/map.cc

* more obvious

* Update selfdrive/ui/qt/maps/map.cc

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-17 01:32:22 -07:00
Shane Smiskol da38aed483 map: set destination marker visibility once (#29444)
set visibility once
2023-08-17 01:02:59 -07:00
Dean Lee f1568b960a ui: longer screen timeout for driver view (#27457)
* longer driverview timeout

* Update ui.cc

* reset timeout

* do cleanup

* Apply suggestions from code review

* Update selfdrive/ui/ui.cc

* reset to default timeout on hidden

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-16 22:22:39 -07:00
Dean Lee 613bbb7e6d ui/map: assign the return value to last_position (#29341)
assign the return value directly to last_position
2023-08-14 16:39:43 -07:00
Dean Lee 29f2389cce ui/networking: bolding the connected network (#29385) 2023-08-14 15:18:41 +01:00
Dean Lee 9071c8a4fc ui/map_instructions: set margin-top to UI_BORDER_SIZE (#29387) 2023-08-14 12:43:32 +01:00
Dean Lee 01089cf4bf UI: make wifi network sorting more stable (#29376)
* stable sort

* fix typo,rename to strengthLevel
2023-08-13 21:12:23 -07:00
Dean Lee 878d3f4cfc ui/sidebar: break long line for readability (#29379) 2023-08-13 18:03:38 -07:00
Dean Lee 373171afd0 ui/networking: remove dynamic property and style sheet (#29377) 2023-08-13 14:48:06 -07:00
Dean Lee fd8a9c8520 ui/networking: remove call to clearLayout (#29037)
* build list inplace

* move clearLayout to cabana

* cleanup include

* polish style

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-08-13 11:57:40 -07:00
Shane Smiskol cc747e2166 ui/map_instructions: round <500 distances (#29333)
round
2023-08-11 03:33:40 -07:00
Dean Lee 4a89928a9a ui/map: fix CSS error (#29332)
fix css error
2023-08-11 03:31:13 -07:00
Shane Smiskol 52675b2739 ui/map_instructions: clean up lane icon selection (#29330)
* draft

* revert

* remove extra directions

* more clean up

* add todo

* revert rename

* I assume this is moot, but preserve behavior

* spacing
2023-08-11 03:27:32 -07:00
Dean Lee 80356b34f1 ui/map: check NavDestination only if navInstruction is invalid (#29331)
* check NavDestination only if navInstruction is invalid

* Update selfdrive/ui/qt/maps/map.cc

Co-authored-by: Shane Smiskol <shane@smiskol.com>

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-11 03:26:08 -07:00
Dean Lee 15bb9dd096 ui/map: set WA_NoMousePropagation to prevent mouse event from propagating up (#29329)
set WA_NoMousePropagation
2023-08-11 02:45:54 -07:00
Jason Wen 22cf5421d6 ui onroad: utilize local variables for repeated capnp reader access (#29325) 2023-08-10 23:13:45 -07:00
Dean Lee cef693f309 ui/onroad: move duplicated code to drawIcon() (#29149)
* move duplicate code to function drawIcon

* fix center point
2023-08-10 23:08:46 -07:00
eFini 8d7e909b53 map ui: Fixed ETA text alignment issue in CJK (#29311)
fixed ETA text alignment issue in CJK
2023-08-10 02:15:43 -07:00
Cameron Clough 748238f87c ui/map: update mapbox style (#29186) 2023-08-08 20:18:49 +01:00
Shane Smiskol cffc14e4d8 map: fix exit lane direction when active (#29159)
* fix

* clean up

* comment
2023-08-05 04:02:18 -07:00
Dean Lee da91555056 ui/OnroadWindow: do not update state when offroad (#29134)
do not updateState when offroad
2023-07-31 20:25:15 -07:00
Shane Smiskol 6fe480b232 Experimental mode toggle description: missing spaces (#29167)
* Update settings.cc

* more missing spaces

* scons

* vanish

* fix that
2023-07-27 14:00:41 -07:00
Adeeb Shihadeh 0922a1040f ui: less confusing wifi training (#29137)
* ui: less confusing wifi training

* update

* cleanup

---------

Co-authored-by: Comma Device <device@comma.ai>
2023-07-25 13:32:00 -07:00
Harald Schäfer 9c3c7f0dda Experimental mode description: update nav (#29130)
* Update description

* Update releases

* Update RELEASES.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/ui/qt/offroad/settings.cc

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* small tweaks

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-07-25 10:31:25 -07:00
Shane Smiskol 412ed6a017 navd: don't use empty last step banner instructions (#29034)
* fix empty banner instructions when arriving at destination

* bug fixes

* hide distance on arrival

* stash

* simpler

* can also do this, but i don't like modifying the response

* clean up

* rm

* revert

* rm

* flip this order

* move up

* need to flip order

* Revert "need to flip order"

This reverts commit ba961b8e6aa5d9490ab0dc661866cff9c72db91d.

* Revert "move up"

This reverts commit f1a4d8ae883080d52547fdaf9472457050e40669.

* Update selfdrive/navd/navd.py
2023-07-25 01:28:17 -07:00
Shane Smiskol 0dd1dcc7d0 ui: new nav settings button (#29068)
* add image

* remove extra spacing

* add images

* use nav-settings-square-smaller.png

* draft

* clean up

* kinda works!

* nop need to update state

* can just use clicked

* MORE

* remove old button

* slightly smaller (todo change image))

* this works but is ugly

* remove old settings button

* draft

* no it's not

* draft 2.0

* clean up

* clean up

* let's make map_settings_btn public

* since we don't have map, use enabled

* fix image size

* can do clean up in another PR

show

* add line

* rename

* useless spacing

* use old nav icon

* handle DM icon (and test)

* clean up

* no reason

* remove old image

* don't use setCurrentIndex

* Revert "don't use setCurrentIndex"

This reverts commit 6fde765a3cd3a9ee39205614587a23fbfbc60950.

* also can use a ternary

* seems cleanest

This reverts commit f9287230704b94f46b6bb5376d9a17075a20caf7.
2023-07-24 22:27:01 -07:00
Shane Smiskol 13dc0325b2 ui/map: hide settings with showing map (#29127)
consistent map showing behavior
2023-07-24 18:25:46 -07:00
Dean Lee bcfb9d6940 ui/settings: use existing params instance (#29109)
use exsting params
2023-07-23 17:45:19 -07:00
Dean Lee 980ba1312f ui/map: remove unused variables (#29098) 2023-07-22 12:24:16 -07:00
Dean Lee cc551fe24b ui/MapSettings: remove function shorten (#29078) 2023-07-21 19:51:25 +01:00
Shane Smiskol d70c4916db nav: improve no route alert text (#29076)
* kind of

* Revert "kind of"

This reverts commit 25abbbf1764b0f7e8fbcb83e37159ba6f8cdf641.

* more generic alert text, whenever we're waiting for navd.

* actual better comment

* update translations
2023-07-20 22:40:31 -07:00
Dean Lee 0b8d35b132 ui/map: fix ETA widget text spacing (#29065)
* fix eta spacing

* fix unit color

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2023-07-20 21:10:17 -07:00
Shane Smiskol e4dc86f44d ui: set global map transition duration (#29061)
* this works!

* revert properties

* more clean up

* more

* more

* add comment

* final
2023-07-20 16:11:23 -07:00
Dean Lee 942a2f9760 ui/map: move MapInstructions & MapETA to separate files (#28976) 2023-07-20 21:58:46 +01:00