Commit Graph

411 Commits

Author SHA1 Message Date
Jason Wen 7bc2667ab6 Hyundai: Car Port for Ioniq 6 2023 (HDA2) (#29486)
* Hyundai: Car Port for Ioniq 6 2023

* Update docs

* bump panda

* Attempt to block laneline information to suppress LFA

* Try 0x364

* Block 0x364|BYTE7

* Attempt to block LFA on 0x364

* Block all bus 2/6 messages

* Lowercase to match DBC

* Aight

* we don't use this

* Final test to block LFA

* No byte 7

* Fix

* Fix tx

* This platform does SCC from radar

* Generate CARS.md

* cleanup

* Fix

* Fix 2

* bump submodules

* add test route for HDA2

* Support non-HDA2 trims in future PR

* segment 6

* bump opendbc

* Update username

* Check for new LKAS addr instead

* Update comment

* sync with dbc

* Combine LFA suppress can sends

* Add new tx to unit test

* bump opendbc

* we'd need a new DBC for that

* update docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-30 01:10:28 -07:00
leZudiste c65027635c HKG: Add FW versions for EU Tucson Hybrid 2021 (#29655)
* Add Tucson Hybrid 2021 fingerprint

* Fix missing doc

* revert

---------

Co-authored-by: florian alles <florian.alles@csgroup.eu>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-30 00:23:41 -07:00
baldwalker 395be482a1 HKG: Add FW Versions for Kona EV 2022 (#29683)
* Update values.py

* shorter request already exists

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-30 00:16:50 -07:00
Jason Wen 030b47fd24 HKG: Add FW Versions for Kia Sorento ICE 2023 (#29707) 2023-08-30 00:13:05 -07:00
Jason Wen fafca0e44d Hyundai: Car Port for Kona EV 2nd Generation (HDA2, 2023 Korean Ver.) (#28725)
* Hyundai: Car Port for Kona EV 2nd Generation (2023 Korean Ver.)

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* gate with flag

* new blinker signals for 2nd Gen Kona

* add test route

* Update CARS.md

* bump opendbc

* match opendbc definition

* Attempt to block laneline information to suppress LFA

* Try 0x364

* Block 0x364|BYTE7

* Block all bus 2/6 messages

* Lowercase to match DBC

* Aight

* we don't use this

* Final test to block LFA

* No byte 7

* Fix

* Fix tx

* cleanup

* HDA2 support

* Update RELEASES.md

* bump opendbc

* from `liveTorqueParameters`

* add test route

* bump panda

* official spec

* Check for new LKAS addr instead

* Update comment

* sync with dbc

* Combine LFA suppress can sends

* bump opendbc

* Add new tx to unit test

* linter

* Consolidate

* rename and update torque params

* add note for blinker weirdness

* bump

* bump

* clean up block msg

* it uses LFA if long

* not used in multiple places

* bump panda

* correct name

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-30 00:02:19 -07:00
Shane Smiskol 3b69187b67 Kia: add test route for Optima Hybrid (#29520)
* add Optima H FW

* undashcam

* add to routes, but keep in dashcam mode for now

* rearrange
2023-08-25 20:12:57 -07:00
multikyd 5c6a8ac7cc HKG: Add Optima Hybrid to HEV and legacy safety mode lists (#29644)
* add Optima H FW

* undashcam

* HKG: Add to Hev and Legacy safety mode for Optima Hybrid

* remove extras

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-25 19:20:49 -07:00
Shane Smiskol 2c835b81d9 Hyundai: remove Ioniq EV 2022 from legacy safety mode (#29531)
* fw

* remove from legacy

* update docs
2023-08-22 12:59:56 -07:00
Shane Smiskol f546e92774 Kia: move Optima Gen 4 FL out of legacy safety mode (#29530)
move Optima Gen 4 Facelift out of legacy
2023-08-22 12:41:52 -07:00
Felixowns 0c4b91975b Remove Sonata LF from LEGACY_SAFETY_MODE_CAR (#29521)
* Update values.py

remove sonata_lf from legacy safety mode. added sonata_lf to unsupported longitudinal car

* Update selfdrive/car/hyundai/values.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-21 21:28:13 -07:00
Jason Wen bfa714ef3b HKG: Car Port for Kia Sorento Hybrid 2023 (#29322)
* HKG: Car Port for Kia Sorento Hybrid 2023

* Update CARS.md

* Oops

* add test route

* specify segment

* all packages

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-21 14:34:53 -07:00
Shane Smiskol de7bcb04fc add enhancement todo for hyundai fuzzy FP 2023-08-21 14:32:56 -07:00
Shane Smiskol 229c43a808 Kia: update supported Sorento PHEV package (#29509)
* Sorento PHEV includes all

* update docs
2023-08-21 14:11:32 -07:00
Caleb Stultz 551b0cc8f2 Remove Kia Sorento from LEGACY_SAFETY_MODE_CAR (#29502)
* Remove Kia Sorento from LEGACY_SAFETY_MODE_CAR

* Update values.py

* Added Kia Sorento to UNSUPPORTED_LONGITUDINAL_CAR
2023-08-21 10:43:31 -07:00
Adeeb Shihadeh a9626f95b6 add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
2023-08-20 20:49:55 -07:00
Shane Smiskol 38f1523742 add Kia Niro Hybrid 2019 to legacy safety mode list (#29472)
* add Kia Niro Hybrid 2019 to legacy safety mode list

* list

* test

* update docs

* space
2023-08-18 20:57:42 -07:00
Cruise Brantley e8f33fb5b7 Hyundai: Additional Ioniq 5 firmware (#29307)
added fwdCamera
2023-08-09 23:10:54 -07:00
Justin Newberry 7fdd9fc37c CI: Pylint to ruff (#29294)
* pylint to riff

* pylint to riff

* pylint to riff

* revert more

* undo exclude removal

* exclude tinygrad

* set line length

* pylint exclusions to ruff

* same excludes as old linter

* fix tools QA

* remove unrequired check

* revert linting third_party

* ignore e402
2023-08-09 13:26:54 -07:00
Justin Newberry cf64b27168 Linter: Fix >160 line length test (#29287)
* test

* fix line length

* fix line length

* fix file size

* revert poetry

* cleanup for PR
2023-08-08 17:13:35 -07:00
Cameron Clough 2762a088f1 docs: CAN FD cars require a comma 3X or CAN FD panda kit (#29182) 2023-07-30 20:29:56 +01:00
Jason Wen 682a240c36 HKG: Add FW Versions for China Kia Carnival 2023 (#28918) 2023-07-13 17:51:58 -07:00
Shane Smiskol bc24783657 Hyundai: add Ioniq 6 platform (#28915) 2023-07-13 12:49:38 +01:00
joshslater f345d393cc 2023 Hyundai Sonata Hybrid Fingerprint (#28851)
* Update values.py

add 2023 hyundai sonata hybrid

* Include 2023 Sonata Hybrid

* remove duplicates

* fix and sort

* Revert "fix and sort"

This reverts commit 9fdd3c6b18d119284e4f2792705e43086afe72eb.

* fix

* update docs

* update docs again

* fix

* sort

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-07-09 21:31:12 +01:00
Shane Smiskol 398dd77114 Hyundai: blacklist bad camera FW (#28318)
* cmt

* common parts

* add code and date

* Revert "add code and date"

This reverts commit 47f9ac84cae8d1e73dc2b5af7d5701adc83da6eb.

* Revert "common parts"

This reverts commit aa5683bbce5b5e8e8414f5b90df9add3998e98ab.

* add back to santa cruz

* todo

* part number test

* pass test

* Update selfdrive/car/hyundai/tests/test_hyundai.py
2023-07-08 01:33:41 -07:00
Jason Wen f1c604bde7 HKG: Car Port for Kia Carnival 2023 (HDA1) (#27785)
* HKG: Car Port for Kia Carnival (China only) 2023 (HDA1)

* add FW

* seems to be radar SCC

* Update CARS.md

* Update CARS.md

* Add test route

* Fix docs

* New route

* Fix docs formatting

* update with US model

* 2 total

* Update RELEASES.md

* add FW for US carnival 2023

* fix docs

* update test routes

* no rlogs for chinese route

* update docs

* revert chinese to merge now

* Apply suggestions from code review

* fine to fully remove

* less precise

* remove from releases

* Apply suggestions from code review

* Update selfdrive/car/tests/routes.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-07-06 00:37:49 -07:00
junhee Ahn 0e73c2db99 Hyundai: Add FW for Sonata 2020 (#28820)
Hyundai : Add fw for SONATA 2021
2023-07-05 21:10:14 -07:00
Jason Wen 799c6f513d Hyundai: Add FW versions for Santa Fe ICE 2023 (#28727)
* Hyundai: Add FW Versions for Santa Fe ICE 2023

* fix fw
2023-06-28 13:58:05 -07:00
Shane Smiskol f788edb6a5 HKG: use platform codes to fuzzy fingerprint (#28531)
* get gas/ev/hev from FW (not all correct, poc)

* add test for essential ecus for fuzzy fingerprinting

* kinda works

* stash

* clean up

* add code

* simpler

* use the function

* test it with our cars

* no re

no re

no re

* debugging

* handle empty dict

* simpl

* this is promising

start on making existing fingerprinting functions use the config, instead of entirely replacing them

* needs to allow 1 match

* lay out how this should look

* changes

* executable

* some work

* use config

* fuzzy ecus

* config test

* comment and some clean up

* test platform codes

* use regex, simpler and fixes bug

* in func

* rm bad func

* typing for new func and remove old from dc

* todo done

* tested!

* remove fake platform codes

* thought we needed this, but actually...

* not needed

* not applicable any more

* use config for essential ecus

* first draft of test to make adding/removing fuzzy FP platform intentional

* compile

* clean up test

* even cleaner

* fix default ecus type

* temp fix

* this is mostly in tests now

* test every fuzzy ecu fw returns one platform code

* experiment with dates

* Revert "experiment with dates"

This reverts commit 3251b9cc5c3ca41ca92c8b75ad9b2234b720aa0b.

* clean that up

* comment

* test

* work on all cars

* fix fuzz_fw_fingerprint

* comment

* get first by search

* bit more clean up

* and more

* use compiled pattern for nicer syntax

* default

* flip dat around, much cleaner

* clean up hyundai test a bit

* flip order

same here

* rename test and flip subTest

* fix pylint

* revert fw changes

revert fw changes

* line

* add original functions to test

* needs to be a list

* cmt

* draft (need to count one ecu as a match)

* tiny clean up

* todo: date range

* only in notebook

* remove comment (still can be either list or set)

* same, only notebook

* more consistent signature

* copilot inspired

* copilot no good

* test for date parsing

* better name

* good, now we don't have to worry about the dates mismatching in another test/logic

* comment up+

* some stuff

* clean up

fix test

fix test

* test

* comment

* use utils

* clean up (utils are cleaner and less buggy)

* clean up (utils are cleaner and less buggy)

* fixup test

* use a dash (prettier) and remove some platforms that can fingerprint now!

* compile global pattern

* same as what we do in values

* remove comments

* fuzzy_get_platform_codes is one or none here

* more clean up

* sort imports

* woah woah woah

* add comment

* fix reassigning different types

* add types

* adapt fuzzy test recently added (nice it caught this!)

* update lock

* options

comments

* stash

* comments and fixes

* better comments

* better

* test: run on exact fuzzy matching logic, same results!

* use match_fw_to_car

* test all fw

* ex

* unused random

* this is a possibility

* this is more clear

* fix

* revert

* revert to needing both ECUs to match to reduce false positives, test

* fix excluded platform test :( but it's ok

* add comment

* we actually want to only test fuzzy ecus to make it explicit

* fix mypy

* comment for tomorrow

* just add matches with fuzzy FP

* add comment

* this was the cleanest I could think of, but still working on it. not very easy to understand

* think this is better, but also worse...

* comment: reframing how this works

* revert back to what we did before

* was swapped

* else set

* remove old comment

* fixes from merge

* remove fuzzy_min_match_count from this pr

* fix static analysis

* also unused

* different method first draft

* copy existing fuzzy func

* check all possible ecus exist, only platform codes, slightly refactor main loop

* fix

* Revert recent

Revert "fix"

This reverts commit 5cdb7bda835f1e48e750ab4195e891afe08e11ea.

Revert "check all possible ecus exist, only platform codes, slightly refactor main loop"

This reverts commit d3e918fa20fa4ce881445850f5f7428a3c11adf8.

Revert "copy existing fuzzy func"

This reverts commit 34c8c0545097c84f55f4b4f61907606c93760ddd.

Revert "different method first draft"

This reverts commit b91139055d7d1802c1eb726504798c156a183c9c.

* new func

* fixup test

* remove changes from v1 from fw_versions.py

* clean up a bit

* return part as part of code

* fix test

* add original fuzzy function

* add an ecu match if the date is within range (or date doesn't exist)

* add format for what we're going to do

* not working stash

* the exact matching function does more of what we want with less code and less custom logic

* we don't care about found versions, only codes and dates

* actually we do have an exception

* this works pretty nicely now

* up here

* this is better

* some minor clean up

* old function=now junk

* fix platform code test

* remove old platform code function

* now rename _new to

* use FW_QUERY_CONFIG

* clean up imports

* rename that too

* one line

* correct typing

correct typing

* draft tests

* so that works

* fixup excluded platform test now too

* this is tested by excluded platform test

* test parts and dates

* remove old comment

* old import

* take platform code stuff out of FwQueryConfig

* fix test

* revert debug script

* flip order

* make this a set by default

* revert this part

* correct typing

* clean up comments

* clean that test up too/pylint

* combine these three tests ina clean way

* not right

* more general

* be consistent with quotes

* comment

* comment

* comment in fw_versions

* flip order

* this is more readable

* could test all this, but it's tested in test_hyundai and doesn't do a lot here

* only assert brands which use this

* invalidate all CAN FD ICE and hybrid

* tuple

* can get away without filtering

* add comment reasons

* fix

* some review suggestions

* this works (first draft)

* this is better

* script to print platform codes and dates

* sanity check for dates are in correct ecus and platforms

* mypy

* better variable name and comment

* rename

* same

* slightly better name

* subset

* exclude platforms and live car without dates

* consistent

* self explan

* better name

* test to make sure the functions agree

* clean that up

* comment

* we get other responses from queries not in DB, only check any

* not used or typed
2023-06-15 02:50:45 -07:00
Shane Smiskol 2166adda5f HKG: test list of platforms with no fwdCamera dates (#28555)
* no dates test

* sorted
2023-06-15 02:14:33 -07:00
Shane Smiskol 572a221a86 FwQueryConfig: remove platform codes (#28538)
* bring platform codes out of config for now (can re-introduce later)

* clean that up

* flake8

* comment

* comments and better test names

* typo

* Update selfdrive/car/hyundai/tests/test_hyundai.py

* Update selfdrive/car/hyundai/tests/test_hyundai.py
2023-06-13 20:41:03 -07:00
Shane Smiskol 55e489db7c HKG: split up platform code parsing (#28532)
* test diff

* clean up

* clean up

* doesn't work :(

* fix mypy
2023-06-13 14:47:45 -07:00
Shane Smiskol e54d05b42f HKG: FW part number test (#28525)
* start on test

* better regex

* lookbehind

* comments to choose from

* i did not know that!

* common patterns in values.py

* messy messy

* need to remove these

* rmrmrm

* clean up test

* fixups

* not used yet

* none should be good enough

* Update selfdrive/car/hyundai/values.py
2023-06-13 02:01:40 -07:00
Shane Smiskol 7fffb892e4 Hyundai: remove old Sonata FW (#28527)
* Update values.py

* can't find last 2 years
2023-06-13 00:26:02 -07:00
Shane Smiskol 8c784ae558 Hyundai: remove old Elantra FW (#28526)
* Update values.py

* don't see this fw last 2 years

* add version from 3ea622c3c0ec3055

* Update selfdrive/car/hyundai/values.py
2023-06-13 00:14:49 -07:00
Shane Smiskol f5e032b67f FwQueryConfig: add platform code support and tests (#28475)
* add config options

* you know what, platform codes don't need to be related to fuzzy fingerprinting at all

* better comment?

* add comment

* add test from other PR

* add platform code function to hyundai

* comment and add eps!

* clean up config test

* fix test

* add error message to test

* until we have multiple ways a brand can set up fuzzy FP, let's leave func name fuzzy-specific

* rename in comment too

* hyundai tests

* simpler test!

* check all ecus with platform codes

* add types-python-dateutil = "^2.8.19.13"

* these aren't used any more

* Update selfdrive/car/hyundai/tests/test_hyundai.py

* not to imply this is active yet
2023-06-09 22:51:55 -07:00
Shane Smiskol 5736cb8a7e FPv2: fix accidental FW version concatenation (#28462)
* fix missing commas

* more

* Revert "more"

This reverts commit ebe481fee44f284a598ad9d5a83da37653faee99.

* only
2023-06-08 19:53:45 -07:00
John Paull 80623956ae Hyundai: add missing FW for Santa Fe Hybrid 2022 (#28410)
* values.py

added additional Firmware

* add fwdCamera too

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-06-06 13:07:48 -07:00
Shane Smiskol d9ebea4bdd Hyundai: remove some old FW (#28376)
* Update values.py

* Update values.py
2023-06-02 16:01:27 -07:00
Shane Smiskol 024abe6455 car docs: document parts of parts (#28292)
* more stuff

* even more

* all parts func

* start to use it

* include self in parts

* use car_parts_new

* not used

* more usages

* remove get_parts

* remove more commented stuff

* remove iter

* clean up some more stuff

* more

more

* ford

* optional

optional

* nissan

* use new classes

* fix tests

* fix

* order

* no more required

* connector

* CARS.md

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
2023-05-31 21:30:50 -07:00
Shane Smiskol 897b9c117a HKG: add missing FW for 2020 G70 (#28323)
missing g70
2023-05-27 18:49:03 -07:00
wileytom65 2f625f64f0 Car Port for Hyundai Santa FE Hybrid 2023 (non-HDA2) (#28279)
* Added 2023 Hyundai Santa Fe HEV

* Added 2023 Hyundai Sante_FE_HEV 

Additional info added for 2023my of Hyundai SANTA_FE_HEV (nonHDA2)

* fix FW versions

* update docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-25 00:06:54 -07:00
Maxime Desroches 9f5f8b603c car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-22 10:17:33 -07:00
johangithub 184e224a6a HKG: add 2017 Genesis G90 Fingerprint (#28230) 2023-05-19 18:30:43 -07:00
Maxime Desroches 70677fe5fc add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-15 15:33:54 -07:00
AlexandreSato 0c00099437 Hyundai: add missing FW for Sonata 2023 (#28191)
3ab09aae5a9310b2 AppleExpl01t#5323 SONATA fingerprint

Co-authored-by: Comma Device <device@comma.ai>
2023-05-15 13:02:25 -07:00
teknonut 7268926e54 HKG: Add missing FW for 2022 Hyundai Santa Fe (#28150)
Update values.py

Add 2022 Hyundai Santa Fe FW values
2023-05-12 21:44:09 -07:00
heemanshoe d845c79f7c HKG: Genesis GV70 2023 support (#28154)
* Updated values.py

Added fingerprinting for 2023 Genesis GV70

* Updated values.py

2023 GV70: needed a different harness than the one originally listed (M instead of L)

* Update values.py

Removed L harness line (just in case)

* should be good

* fix

* update docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-10 15:10:07 -07:00
JWingate80 758a9d7c24 HKG: Genesis GV80 2023 support (#28069)
* Update values.py

* Update values.py

* Update routes.py

* Update values.py

* Update values.py

* Update interface.py

* Update override.yaml

* Updated car name in torque settings to the correct one

* Removed unused ECU's from GV80

Fix AssertionError: 3 != 0 : GENESIS GV80 2023: Car model has ECUs not in auxiliary request whitelists: Ecu.eps, Ecu.transmission, Ecu.engine

* Update routes.py

Updated to a better route

* Update routes.py

* Update test_models.py

* Update test_models.py

* Hopefully this route will work...

* Update selfdrive/car/hyundai/values.py

* Update selfdrive/car/hyundai/values.py

* this could use some cargo

* don't need to combine just yet

* add to docs and releases

* Update routes.py

* Update RELEASES.md

* Update routes.py

Updated route, hopefully this one works...

* Update selfdrive/car/tests/routes.py

* alphabetical

* update docs

* Update routes.py

Hopefully this route works

* Update routes.py

Trying segment 1 for GV80

* bump

* no need

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-05-06 23:18:06 -07:00
BrandonHacks 7e672a6344 HKG: Add new fw for Kia Sportage 5th Gen (#28100)
Update values.py

New radar fw
2023-05-04 05:42:50 +00:00
Shane Smiskol fb743ab10f Hyundai: remove duplicate fwdRadar for Santa Fe (#28088)
this is a dup
2023-05-03 19:44:59 +00:00