Commit Graph

95 Commits

Author SHA1 Message Date
Adeeb Shihadeh fb028041cd remove alert for stock fcw (#21834) 2021-08-02 21:59:03 -07:00
HaraldSchafer 049a1bca34 Better localizer unstable alert (#21660)
* use canonical language

* filter out when gps signal is flaky

* Update selfdrive/locationd/locationd.cc

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-07-20 19:20:00 -07:00
Adeeb Shihadeh 092c728e76 fix unnecessary harsh steering unavailable alerts (#21541) 2021-07-10 01:53:14 -07:00
HaraldSchafer 2aadf8beb2 Remove DM high std alert (#21501)
* cleaner

* no face and high stds is the same

* change test

* final clean

* need to deprecate
2021-07-07 17:08:55 -07:00
Adeeb Shihadeh 8dce135279 update speedTooHigh alert sound (#21484) 2021-07-04 19:23:09 -07:00
Adeeb Shihadeh 8e36a7d07c fix warning -> userPrompt 2021-06-28 21:46:26 -07:00
Adeeb Shihadeh 880435f6a2 make speed too high alert orange 2021-06-28 21:42:25 -07:00
Chris McCammon 317afa335f steer unavailable below speed audible alert (#21209) 2021-06-17 14:10:24 -07:00
ShaneSmiskol ae77f693a2 Fixup joystick (#21129)
* some common changes

* rename to joystick

* add alert and update controlsd to work with joystick

* update joystickd

* Update Joystick readme

* assume we have inputs

* only send gb or steer when engaged_toggle is true

* Update instructions

* fix --ip

* Easier to understand at a glance

* much better

* -a

* receive events and send msg in same loop

* always import

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* combine logic and clean up

* use argparse

* outdated, and use normal class

* rm

* bit of a refactor

* refactor part 2 / 3

* much better (3 / 3)

* Simplify

* bump cereal and update readme

* capitalize

* Update tools/joystick/joystickd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update tools/joystick/joystickd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* make joystick abstraction class clearer

* use interp, clearer without comments

* no need to use apply_deadzone

* more explicit

* define btns and axes once

* split function by use_keyboard again, but simpler

* we can use handle_button as a reset function

* need to flip sign

* remove

* invert axes map for kb, easier to read the button mapping

* apply changes from review

* new lateral log for debug mode

* bump

* add saturated

* static alert

* joystick_mode

* conditionally subscribe

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move params instantiation

* Spoof active and enabled

* Only allow car to engage

* no startup alert if joystick

* Update controlsd.py

* Should be orange not enabled, green enabled

* no more button states

* should work

* blue

* submaster conflates, so only send when we have an update

* final change

* remove msg

* clean up a bit

sort of clean up

clean up a bit

remove msg

* this was right

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* lowercase

* suggestions from code review

* forgot laptop

* bump to latest

* fixes

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: vanillagorillaa <31773928+vanillagorillaa@users.noreply.github.com>
2021-06-11 14:33:17 -07:00
Willem Melching ec17fad41a Alerts documentation (#21172)
* Alerts documentation

* fingerprinting

* comment not necessary

* spelling

* openpilot

* Apply suggestions from code review

Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>

* Apply suggestions from code review

Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>
2021-06-09 10:58:01 +02:00
CrispinFlowerday 7458e143e3 Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
2021-06-07 15:06:28 -07:00
Adeeb Shihadeh d4ab1f1e27 startup alert for no fw returned (#21177) 2021-06-07 14:15:09 -07:00
speedking456 24b6b4a341 Add chime to lane changed blocked alert (#21159)
* Update carcontroller.py

* Lane change blocked orange + audible alert

* Actually make it make sound

* Update carcontroller.py

* leave priority the same
2021-06-07 01:38:08 -07:00
Adeeb Shihadeh f2a9b13498 bump cereal 2021-06-04 16:06:57 -07:00
HaraldSchafer 1c926d23da Many localizer resets alert (#21116)
* add excessive reset

* add alert

* add event
2021-06-03 09:26:53 -07:00
Adeeb Shihadeh 12ed986333 per camera alerts (#20992)
* per camera alert

* bump cereal

* cleanup

* space
2021-05-21 14:53:30 -07:00
Adeeb Shihadeh 2defc730db alert for errors in camera stack (#20932)
* camera error alert

* check crcs

* cleanup

* bump cereal

Co-authored-by: Comma Device <device@comma.ai>
2021-05-19 21:28:16 -07:00
Adeeb Shihadeh e694f0b4d6 boardd: set can and pandaState valid flags (#20899)
* boardd: set can and pandaState valid flags

* add event

* bump cereal

* consistency
2021-05-14 21:26:02 -07:00
Willem Melching b38e57eb2b Improve community feature alert text (#20803) 2021-05-03 11:59:01 +02:00
Adeeb Shihadeh f9a961f6fb delay controls start (#20761)
* delay controls start

* shouldn't need this stuff anymore

* only delay board

* bail after 2s

* fix loopback test

* fix process replay

* update refs

* bump cereal

Co-authored-by: Comma Device <device@comma.ai>
2021-04-30 13:55:17 -07:00
Adeeb Shihadeh 836668f105 less harsh steering unavailable alert when overriding (#20718)
* less harsh steering unavailable alert when overriding

* just steer

* 1s

* orange

* update refs
2021-04-20 21:01:28 -07:00
Willem Melching e4f73fbda5 Fuzzy match on ECU FW versions (#20687)
* Fuzzy match on 3+ ECUs

* reuse dict

* exclude some shared ecus to be sure

* show alert for fuzzy match

* use title case

* require community toggle

* refactor

* do both exact and fuzzy in test script

* update test script

* add fuzz test and lower matches to >= 2

* strip alert length

* sort mismatches

* add fw tests to test_startup

* bump cereal
2021-04-20 12:00:36 +02:00
Adeeb Shihadeh 2fa1b2572d Alerts update (#20567)
* steer temp unavailable should be a soft disable

* no mute

* these should be no entries

* sound

* better name

* deprecated

* make vehicleModelInvalid a soft disable

* update refs

* bump cereal

* bump cereal

* update refs
2021-04-07 12:18:58 -07:00
Adeeb Shihadeh 367aec54d1 show persistent dashcam mode alert (#20483)
* always show dashcam mode alert

* show persistent dashcam mode alert

* lowest

Co-authored-by: Comma Device <device@comma.ai>
2021-03-25 21:37:38 -07:00
Willem Melching 2ca5bf9992 make vehicleModelInvalid a NoEntry 2021-03-15 12:15:27 +01:00
HaraldSchafer 0223578461 Better high speed alert message (#20322) 2021-03-11 17:01:29 -08:00
Adeeb Shihadeh 312b681a46 cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65ebd01abfa8493ae12c9e6b14f7ada976.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
2021-02-16 21:39:32 -08:00
Adeeb Shihadeh 000bd226aa Cereal cleanup (#20003)
* start cleanup

* fan speed

* cleanup dm

* fix cereal

* hwType -> pandaType

* update refs

* update refs

* bump cereal

* freeSpacePercent

* cereal master
2021-02-03 19:57:30 -08:00
Willem Melching b6a220a133 manager.py broadcast process states (#19880)
* broadcast managerstate

* Remove boardd

* show alert

* only trigger on actually receiving a manager state

* add managerstate to simulation exclude for longitudinal test

* broadcast managerState in process replay

* update alert text

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-01-26 14:49:55 +01:00
Adeeb Shihadeh c114316d94 GPS malfunction alert (#19756)
* GPS malfunction alert

* fix process replay

* fix long tests

* fix long tests again
2021-01-14 14:45:10 -08:00
Adeeb Shihadeh 389649d6ac remove old event 2020-12-21 15:55:30 -08:00
Adeeb Shihadeh 41b31a1756 don't go onroad if internet needed (#19572) 2020-12-21 15:13:20 -08:00
Willem Melching 776a67ad2e remove commIssueWarning from events 2020-12-17 22:25:22 +01:00
Shane Smiskol 89a6008841 don't wait for 4 seconds before it starts steering again after steering fault (#19520) 2020-12-16 12:24:42 -08:00
Adeeb Shihadeh 6a151dcd9c oneplus deprecation (#2748)
* oneplus deprecation

* lowercase

* too long

* no udpates
2020-12-12 12:51:12 -08:00
Willem Melching d5a806e564 fix typo in event name 2020-12-03 17:07:03 +01:00
Willem Melching 93e90898dd Add event for commIssueWarning 2020-12-03 16:54:54 +01:00
Adeeb Shihadeh 9d18b45cd0 don't need that 2020-11-24 22:47:44 -08:00
Willem Melching 40acdc4524 Typing experiments (#1633)
* add more types

* car

* no abc

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-11-24 22:45:37 -08:00
George Hotz 160fd207a5 remove model lag warning, leave red alert at 20 2020-11-24 13:02:56 -08:00
Adeeb Shihadeh 2d7a194f9f model lag warning (#2608) 2020-11-23 13:42:18 -08:00
Adeeb Shihadeh 47c21f10f5 grey panda is unsupported (#2458) 2020-11-03 19:56:25 -08:00
Adeeb Shihadeh d92ec9642e grey panda deprecation (#2406) 2020-10-26 23:09:06 -07:00
Adeeb Shihadeh 88b956528e camera malfunction alert (#2391)
* camera malfunction alert

* bump cereal

* fix process replay

* ugh, needs refactor
2020-10-22 16:28:54 -07:00
ZwX1616 53bd3050ee infinite sound (#2372)
* make sound infinite loopable

* Update selfdrive/ui/android/sl_sound.cc

* fix loop

* fix test threshold

* more fix

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
2020-10-20 17:42:19 -07:00
Adeeb Shihadeh ae4b4bd125 Alert cleanup (#2274)
* no more focus recover active

* consistency

* more permanent

* dm alerts

* sanity check test

* no please

* clean that up

* update refs

* one more

* bump cereal
2020-10-14 15:56:18 -07:00
Adeeb Shihadeh 1c6905cac1 clear irrelevant alerts on state transition (#2318)
* cleanup

* clear warnings

* more types

* needs refactor

* update refs

* update refs
2020-10-14 14:08:15 -07:00
Logan Lasiter 1a2efdc139 Present alert if fan isn't spinning (#2258)
* Present alert if fan isn't spinning

* allow entry

* Small updates

Moving to fan malfunction event

Only trigger event for uno or dos

* Changed checking fanSpeed > 50%

* Update text for fan malfunction alert.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Alert if fan isn't spinning for 5 sec

* Alert edit

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-10-07 12:15:09 +02:00
Adeeb Shihadeh 70bc935210 bump cereal 2020-10-05 18:43:21 -07:00
cydia2020 6d5b2af3f2 add 1 second delay to acc pedal alert (#2221)
So that the screen wouldn't appear to "flicker" when openpilot is engaged while the acc pedal is being released
2020-09-28 16:17:21 -07:00