Commit Graph

112 Commits

Author SHA1 Message Date
Justin Newberry b0eae8c1b7 platformconfig and carspecs are now required, carspecs no longer kwarg (#31667)
* required

* mock can be a platform!

* default is mock

* fix that

* and that one
2024-03-01 11:31:51 -08:00
Shane Smiskol 690dc55ea2 Car flags: label static flags (#31639)
* comment, consistent source

* no caps not global

* no field

* label rest
2024-02-29 15:36:40 -08:00
Justin Newberry ac16c5518a add CAR.print_debug (#31652)
print debug
2024-02-29 15:01:47 -08:00
Shane Smiskol 5d291cb64d Subaru: group steer rate limited with GEN2 (#31640)
* remove sideways diff

* make a subclass

* fix

* fix
2024-02-29 14:45:31 -08:00
Justin Newberry 3a6c3315ab Subaru: move to flags within PlatformConfig (#31584)
* flags

* update ref

* use the flags directly

* use post_init (don't freeze)

* we can maintain frozen with custom class

* not preglobal

* move to common

* cleanup
2024-02-28 20:12:14 -08:00
Justin Newberry 9ecff49118 platformconfig: freeze all dataclasses (#31605)
* frozen

* frozen
2024-02-26 21:16:05 -08:00
Justin Newberry cdd4d418aa Subaru: fix forester weight (#31585)
fix weight
2024-02-24 23:15:16 -08:00
Cameron Clough 995250ae49 use pyupgrade to update to new typing syntax (#31580)
* add pyupgrade hook

* run pyupgrade (pre-commit run -a)

* ruff --fix

* Revert "add pyupgrade hook"

This reverts commit 56ec18bb6b8602a0b612f3803d96cdad14b52066.

* revert changes to third_party/

* manual type fixes

* explicit Optional wrapping capnp objects
2024-02-24 16:41:23 -08:00
Justin Newberry 1161d33c18 Subaru: move carspecs to PlatformConfig (#31550)
* subaru platform config

* forester wrong dbc

* spacing

* subaru car specs

* someday!

* more red diff

* all brands can be done like this

* but this should be done first and thats subaru specific

* that seems very low but we shouldn't change it here

* as long as it subclasses str its fine

* fix
2024-02-23 13:23:40 -08:00
Justin Newberry 73a497ded8 cleanup PlatformConfig (#31551)
cleanup
2024-02-22 17:49:27 -08:00
Justin Newberry 015eed5d61 Subaru: move to PlatformConfig (#31547)
* subaru platform config

* forester wrong dbc

* spacing
2024-02-22 17:17:00 -08:00
Justin Newberry 51e3daf244 Subaru: add 2024 forester (#31520)
* also angle based

* 24 forester
2024-02-20 15:02:56 -08:00
Justin Newberry 54fe19206e Subaru: eps is non-essential for gen2 cars (#31220)
* eps non essential

* comment

* suggestions
2024-01-29 16:48:03 -08:00
Justin Newberry aff3d5ae09 Subaru: move non-obd requests out of logging (#31174)
enable
2024-01-27 09:07:14 -08:00
Justin Newberry 28eed156e0 Move all fingerprints to fingerprints.py (#30790)
* move fingerpints

* fix circular imports

* fix circular imports

* fix auto fingerprint

* fix those tests

* and controlsd

* add labeler rule

* no defaultdict
2023-12-18 14:04:27 -08:00
Justin Newberry 5f24078a48 Subaru: enable alpha longitudinal for gen1 cars (#30714)
* enable alpha long

* update docs

* added footnote about eyesight

* only for these cars

* add alpha

Co-authored-by: Shane Smiskol <shane@smiskol.com>

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-12-13 20:17:33 -08:00
Justin Newberry a2bb41e0ec Subaru: non-obd FW queries logging (#30552)
* add subaru logging fw

* whitelist + comma

* whitelist is empty for the other requests

* all whitelisted
2023-11-29 17:47:09 -08:00
Justin Newberry 44ef143ae7 Subaru: add 2023 forester (#30554)
23
2023-11-29 14:53:43 -08:00
Nickolas Komarnitsky cf2d4fd7ea Subaru: Add FW for 2022 Legacy (#30434)
Update values.py
2023-11-09 17:42:36 -08:00
Justin Newberry 60b21b55d2 Subaru: initial eyesight disable support (#30373)
* initial eyesight disable

* disable_eyesight

* comment
2023-11-06 22:13:39 -08:00
Justin Newberry ace14698c4 Subaru: 2019-2020 forester is also rate limited (#30391)
* forester rate limited

* better comment

* better comment
2023-11-06 13:22:58 -08:00
Justin Newberry df79ec5314 Subaru: improve longitudinal tuning (#30389)
subaru long tuning
2023-11-05 17:53:42 -08:00
Justin Newberry 0fbc36bce1 Subaru: forester 2017 fingerprint (#30388)
forester fw
2023-11-05 01:21:46 -07:00
Justin Newberry 1463fd3917 Subaru: 2015 outback fingerprint (#30387)
subaru outback fw
2023-11-04 22:31:09 -07:00
Justin Newberry b791c0296b Subaru: 2016 legacy fingerprint (#30386)
legacy fw
2023-11-04 22:09:43 -07:00
Stephen Marin 240f43b421 Subaru: Fingerprint for 2021 Outback XT (#30380)
* Fingerprint for 2021 Outback XT

* that one already exists

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2023-11-04 22:04:54 -07:00
Justin Newberry 998763b4bc Subaru: 2021 impreza fingerprint (#30249) 2023-10-15 17:15:41 -04:00
Justin Newberry 7f945f10c6 Subaru: Outback 2023 fingerprint (#30190)
fingerprint
2023-10-05 17:15:26 -07:00
Justin Newberry 8cc8952d81 Subaru: crosstrek hybrid is a B harness (#30150)
its a b harness
2023-10-03 13:29:07 -07:00
Justin Newberry 6ae465e4af Use StrEnum for car classes (#30114)
* str enum

* import sort

* fix car helpers

* fix that

* fix static analysis
2023-09-30 17:15:34 -07:00
Justin Newberry fb06b98667 Subaru: remove 2020+ temporary steering faults (#29116)
* subaru steer faults

* it takes a bool now

* Update selfdrive/car/subaru/carcontroller.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* that was removed

* should be abs

* bump panda

* bump panda

* subaru faults

* add fixme

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* review suggestions

* still want zero steer when lat not active

* bump submodules

* move it under the non-preglobal section

* better comment for steer limited

Co-authored-by: Shane Smiskol <shane@smiskol.com>

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-09-07 15:28:46 -07:00
Justin Newberry f4f92f1a2f Subaru: impreza 22 fingerprint (#29765)
add fingerprint
2023-09-03 13:12:31 -07:00
martinl a1bf66a0d2 Subaru: Ascent 2023 dashcam mode (#27583)
* Subaru: Add support for 2023 Ascent

* Update supported cars list

* Remove tester present from fw query

* merge master

* fix merge issues

* minimize diff

* add comment about 23 ascent

* add comment

* correct spot

* fix name

* nocap

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-25 20:55:21 -07:00
Shane Smiskol 3719be8b76 Subaru: Forester Hybrid 2020 dashcam (#24770)
* Add support for Forester Hybrid 2020

Co-authored-by: martinl <martin@mlp.ee>

* it's a param now

* make it work

* fix

* merge and cleanup

* remove duplicate

* should be forester

* bump submodules

* should be abs

* add missing params

* still need a test route

* still need a test route

* consitent

* here too

* todo

* more

* Update selfdrive/car/tests/routes.py

* clean up

---------

Co-authored-by: martinl <martin@mlp.ee>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2023-08-23 21:30:12 -07:00
Adeeb Shihadeh 973d90be77 Subaru: Crosstrek Hybrid dashcam mode (#25378)
* Subaru: Crosstrek Hybrid support

* hybrid cars in dashcam only

* revert that

* just dashcam

* tah should be abs

* remove unused import

* use the old dbc for now

* hybrid car exceptions in carstate

* need dashstatus until we get a proper cruiseactivated bit

* missing CP

* merge conflicts

* lets be consistent about extend

* cleanup

* fix and comments

* preglobal fix

* and the rest

* and this

* added hybrid to release

---------

Co-authored-by: Justin Newberry <justin@comma.ai>
2023-08-23 18:50:55 -07:00
Adeeb Shihadeh a9626f95b6 add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
2023-08-20 20:49:55 -07:00
Justin Newberry d6c682b401 Subaru: Global gen1 experimental longitudinal (#28872)
* Add longitudinal support for Subaru Crosstrek and Impreza

* Update experimentalLongitudinalAvailable check

* Update supported cars list

* bump panda

* Remove/rename es_lkas_msg to es_lkas_state_msg

* Use stockAeb for AEB passthrough

* bump panda

* bump panda

* remove stockFcw from stockAeb

* Subaru: Add FCW_Cont_Beep to stockFcw signals

* bump panda

* bump panda

* update poetry deps: shellingham

* bump panda

* bump panda

* Revert "update poetry deps: shellingham"

This reverts commit 6e9b20964890c8a5c416a17b8aaad4cc16fddcfc.

* Merge fixes

* bump panda

* bump panda

* update supported cars list

* dont use counters for long control

* fix unittests

* submodules update

* only soft disable in long control

* use common functions and cleanup

* apply hystersis correctly

* move to comma repo

* use CanBus

* cleanup

* explicit copy

* behind a flag

* remove unrequired rpm checks

* add comment

* fix flag issue

* we still need to check rpm

* update docs

* enable long for a test route

* unit tests

* inactive throttle fix

* Update subarucan.py

* Update carcontroller.py

* Update carcontroller.py

* inactive throttle fix

* Delete settings

* fix rate limit

* bump submodules

* bump panda

* bump panda

* bump panda

* bump panda

* simplify initial implementation, remove AEB

* reduce initial complexity by not intercepting cruisecontrol or brake_status

* fix fwd hook test

* show pcb off warning

* cleanup and setup for tuning

* fix sumobuldes

* revert unrelated changes

* only whats required

* only whats required

* clean that up

* better comments

* behind the flag for now

* comments and minimize diff

* align stuff

* cleanup for PR

* apply review suggestions

---------

Co-authored-by: Martin Lillepuu <martin@mlp.ee>
2023-08-16 12:58:09 -07:00
Marcus Millspaugh 2c13dea1c8 additional Subaru fwVersion (#29365)
* Update Car/Subaru values.py to support 2022 Crosstrek

Tested via SP, just want support via stock OP

* remove duplicates

* started adding support for toyota bZ4X

* Add files via upload

* Update values.py

* Update values.py

* Update values.py

* Update values.py

* remove duplicates and mistakes

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2023-08-12 22:05:33 -07:00
Justin Newberry 1e1cc638d8 Car Docs: (optionally) Display a list of tools (#28782)
* display tools

* 5/16 also works

* cleanup

* static fix

* fix static analysis

* merge

* just use basepart

* use filter
2023-08-01 00:06:21 -07:00
Justin Newberry 38954418f0 Subaru: New LKAS Angle based cars in dashcam only (#29190)
* dashcam mode only

* fix name

* added those cars in dashcam mode only
2023-07-31 13:58:33 -07:00
Marcus Millspaugh d7e8577301 Update Car/Subaru values.py to support 2022 Crosstrek (#29177)
* Update Car/Subaru values.py to support 2022 Crosstrek

Tested via SP, just want support via stock OP

* remove duplicates

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2023-07-30 10:05:21 -07:00
JeanPierre Rousseau b349a8c940 Subaru: add footnote to docs for international models (#26381)
* Update Cars.md

Updated Subaru required specs

* Update values.py

* update docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-07-08 05:17:10 -07:00
Maxime Desroches e85acfa365 car: use default_factory for mutable fields in dataclasses (#28669)
* call me

* copy
2023-06-27 16:48:43 -07:00
Justin Newberry 803c077dc1 Subaru: Signals Cleanup (#28602)
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-06-23 21:24:27 +01:00
Shane Smiskol 024abe6455 car docs: document parts of parts (#28292)
* more stuff

* even more

* all parts func

* start to use it

* include self in parts

* use car_parts_new

* not used

* more usages

* remove get_parts

* remove more commented stuff

* remove iter

* clean up some more stuff

* more

more

* ford

* optional

optional

* nissan

* use new classes

* fix tests

* fix

* order

* no more required

* connector

* CARS.md

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
2023-05-31 21:30:50 -07:00
Maxime Desroches 9f5f8b603c car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-22 10:17:33 -07:00
Kyle Greenlaw 7a684da47f Subaru: Add fw for 2020 Subaru Outback (#28240)
Route: a4e8e925930fce2c|2023-05-19--20-47-32
2023-05-19 22:49:46 -07:00
Maxime Desroches 70677fe5fc add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-15 15:33:54 -07:00
martinl 2ad352d299 Subaru: FPv2: Add Crosstrek Limited 2023 missing FW values (#28014)
* Subaru: FPv2: Add Crosstrek Limited 2023

* trailing comma

* remove duplicate

* prefer hex

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-04-26 20:21:50 -07:00
goatstalker a5d0d7b069 Add additional fingerprints for Subaru Outback 2022 model (#27995)
* Fingerprint Subaru outback 2022

Add fingerprint for carFw abs, engine, transmission, and fwdCamera.

* fingerprint two more values

* order values properly before submitting a PR

* remove hyundai fw responses

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-04-21 19:24:24 -07:00