Commit Graph

2565 Commits

Author SHA1 Message Date
Shane Smiskol fb235238ad jenkins: re-enable test_models (#29394)
* re-enable test_models

* now?

* Remove bad Volt segment

* Update Jenkinsfile

* use first n segments
2023-08-14 16:08:34 -07:00
quinnp8703 c74daad0b9 volkswagen/audi: Additional S3 2015 firmware (#29366)
Update values.py

fingerprinting for early production 2015 audi s3
2023-08-14 13:34:44 -07:00
Justin Newberry c8cae714c6 Subaru: ES_Distance cruise cancel safety (#29362) 2023-08-13 22:14:13 -07:00
Justin Newberry 106f49a00f Ford: Explorer 2020 fingerprint (#29372) 2023-08-13 16:41:35 -07:00
Jason Wen 3a00149f56 Hyundai CAN-FD: carState cleanup (#29326)
* Hyundai CAN-FD: carstate cleanup

* Looks nicer

* Rearrange

* Fix

* Update selfdrive/car/hyundai/carstate.py

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-08-13 11:28:09 -07:00
Marcus Millspaugh 2c13dea1c8 additional Subaru fwVersion (#29365)
* Update Car/Subaru values.py to support 2022 Crosstrek

Tested via SP, just want support via stock OP

* remove duplicates

* started adding support for toyota bZ4X

* Add files via upload

* Update values.py

* Update values.py

* Update values.py

* Update values.py

* remove duplicates and mistakes

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2023-08-12 22:05:33 -07:00
morrislee 060aa33b99 Closer Silverado 1500 Weight (#29355) 2023-08-12 17:24:12 -07:00
Jason Young c76d24cec9 VW MQB: Add FW for 2017 Volkswagen Golf R (#29360) 2023-08-12 13:30:40 -07:00
Shane Smiskol f5a361a111 FPv2: fingerprint on current brand's candidates (#28435)
* pass in brand

* needs to be flipped for exact matching since it's subtractive

* new helper

* makes more sense flipped

* clean up
2023-08-11 18:47:12 -07:00
Shane Smiskol 09ce869ee7 fw_versions: clean up some typing (#29350)
* another common type

* here too

* unused
2023-08-11 18:37:17 -07:00
Shane Smiskol 001d4e8729 test_models: match online fingerprinting behavior (#29306)
* draft

* 1x

* clean up

* final clean up

* fix

* self explan

* space

* space
2023-08-11 18:33:11 -07:00
Shane Smiskol a1e85f3661 static analysis fixes 2023-08-11 18:22:42 -07:00
Shane Smiskol 1099b3486a test_models: check relay malfunction (#29270)
* check relay malfunction in test_models

* draft

* actual relay malfunction (or ASCM was turned on)

* rav4: not dashcam and op enabled, but we're not sending anything

* clean up

* spaces

* more space

* flip

* better?

* combine

* for

* move up
2023-08-11 18:10:27 -07:00
Kacper Rączy 460f5c8e0b radard: tie radard frequency to modelV2 vol. 2 (#29240)
* radard: tie radard frequency to modelV2

Accumulate parsed messages until state is updated (toyota)

Same for honda

Rename rr to something more descriptive

* Change _update method name, since signature has changed

* Update ref commit

* Some renames

* Check for number of cans
2023-08-11 18:07:06 -07:00
Justin Newberry e4ead4f183 Ruff: b905 (strict zip) (#29336)
* added mutable default args

* most of the Bs

* add comment about lrucache

* b905
2023-08-11 16:13:51 -07:00
Justin Newberry 62c1e65924 Ruff: enable most of bugbear (#29320)
* added mutable default args

* most of the Bs

* add comment about lrucache
2023-08-11 15:33:49 -07:00
Shane Smiskol 2a38f38be1 common_fault_avoidance: take a bool (#29328) 2023-08-11 00:27:53 -07:00
Shane Smiskol cbfcc40571 Car interfaces: remove hard-coded signal definitions (#27773)
* What if: no signals! 🙅🤌🎆

* do hyundai

* honda!

* do gm

* and vw! (sorry comments)

* do those

* -500

* little more

* fix subie

* change back

* bumpopendbc

* oof lol

* messages

* some clean up

* here too

* clean up honda radar_interface.py

fix

rm

* bump opendbc to master

* add todo

* rename checks in tesla/radar_interface

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-08-10 20:30:35 -07:00
Justin Newberry 8793cbff40 Ruff: enable flake8-builtins (#29315)
* enable flake8-builtins

* replace any with contains

* fix typo in pack

* fix type

* format is from the parent module, has to be enabled

* item_id

* fix item_id

* disable for id since that's what the remote server returns
2023-08-10 18:58:22 -07:00
Justin Newberry 4a9afd7554 Ruff: comprehensions conventions (#29317)
ignore c408
2023-08-10 16:40:30 -07:00
Shane Smiskol 70b1e9dd75 test_models: run on route list (#26226)
* move to openpilot

* draft

* support internal urls

* not used

* update seg list

* regen segment list

* regen seg list

* regen

* regen

* regen

* no dirty segments

* regen seg list with no fuzzy or fixed fp

* regen segments with hda2 exception

* regen with added filters

* regen without bad dongle

* regen

* regenerate!

* regenerate, only OP enabled

* regen

* regenerate!

* regenerate!

* stash

* use SegmentName

* new route list

* add temp comment

* remove comment

* let's see if this works

* comment out other tests to speed up

* fix agent

* ?

* hmm

* oh whoops...

* add matrix

* fix

* how many levels do we need?

* fix values

* matrix can't be in parallel

* how about this

* try this

* Revert matrix

Revert "try this"

This reverts commit 8d0d91fd70c467c1fbb4e4e9aed511d15b2a30ef.

Revert "how about this"

This reverts commit a8e4fc53234824e77cbfb1e471277bc033e9dea1.

Revert "matrix can't be in parallel"

This reverts commit daaa6fcc3c75c74cbb90e97c565099a94123994c.

Revert "fix values"

This reverts commit df554b6a3371d124a574eb8d26bc51ef5b5b8fde.

Revert "how many levels do we need?"

This reverts commit 1a17320fa1c5e7220ef60e29981bbb3bb7da16c6.

Revert "fix"

This reverts commit e7eb6e404358fbd2eac3fea1901a8d30ea92d729.

Revert "add matrix"

This reverts commit a1b57e5725417d3c2f639f8edfc0c889b84b6753.

* use pytest instead! (5 jobs is ~150 mins)

* split lines, uncomment

* This Sienna seg has a fault SDSU that stopped forwarding/sending msgs

* picked a route with no PSCMStatus and no panda errors, recent routes are working

* this cadillac was dashcammed (no radar)

* opened an issue for this, it's 'expected' right now

* small clean up

* small clean up

* i don't think that worked

* is this needed?

* add to new PC tests

* cache

* draft

* Revert "draft"

This reverts commit 3b7f740dd4883118747300bc3687074c2d3c2116.

* probably should be function

* draft

* clean up

* add todo

* 600 random segments

* debug

* does this fix pythonpath issues?

fix

* try this

* mount?

* pytest again!

* no need for PYTHONPATH now

* Update Jenkinsfile

* ?

* convention

* clean up

* would be even more complex (have to unset ci which is class level)

* track

* is lfs pulled at all?

* ah no it's not
2023-08-10 00:45:23 -07:00
Cruise Brantley e8f33fb5b7 Hyundai: Additional Ioniq 5 firmware (#29307)
added fwdCamera
2023-08-09 23:10:54 -07:00
Shane Smiskol 6ffdc32bfc Toyota: set stop and go if TSS2 car (#29303)
we should assume all TSS2 have stop and go (because we set them all manually)
2023-08-09 17:46:06 -07:00
Shane Smiskol 225ed2ed5a interfaces: test interface attributes (#29301)
* test

* draft

* draft

* clean up

* clean up

* better test

* clean up

* check car info

* uncomment

* rm space

* no loop

* use dbc

* more clear

* one line
2023-08-09 17:01:38 -07:00
Adeeb Shihadeh 51831d03a3 Revert "interfaces: test interface attributes (#29297)"
This reverts commit 6a678cde6c.
2023-08-09 16:28:12 -07:00
Shane Smiskol 6a678cde6c interfaces: test interface attributes (#29297)
* test

* draft

* draft

* clean up

* clean up

* better test

* clean up

* check car info

* uncomment

* rm space

* no loop

* use dbc

* more clear

* one line
2023-08-09 16:10:30 -07:00
Justin Newberry 7fdd9fc37c CI: Pylint to ruff (#29294)
* pylint to riff

* pylint to riff

* pylint to riff

* revert more

* undo exclude removal

* exclude tinygrad

* set line length

* pylint exclusions to ruff

* same excludes as old linter

* fix tools QA

* remove unrequired check

* revert linting third_party

* ignore e402
2023-08-09 13:26:54 -07:00
Justin Newberry cf64b27168 Linter: Fix >160 line length test (#29287)
* test

* fix line length

* fix line length

* fix file size

* revert poetry

* cleanup for PR
2023-08-08 17:13:35 -07:00
LC 5ace930c5c Toyota: Lexus IS 2023 port (#29257)
* added LEXUS_IS_TSS2 to values.py

* added LEXUS_IS_TSS2 to interface.py

* Apply suggestions from code review

* add torque params

* add test route

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-08 16:34:37 -07:00
Irene 2bceb2425f Toyota: rename ACC_HUD to PCS_HUD (#29150)
* Toyota: rename ACC_HUD to PCS_HUD

* bump opendbc

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-08 15:24:57 -07:00
Justin Newberry a91764954b Revert "CI: pylint to ruff (#29276)" (#29284)
This reverts commit cb31a53d8a.
2023-08-08 14:24:04 -07:00
Justin Newberry cb31a53d8a CI: pylint to ruff (#29276)
* pylint to riff

* pylint to riff

* pylint to riff

* revert more

* undo exclude removal

* exclude tinygrad
2023-08-08 13:41:30 -07:00
Cameron Clough 95289cb180 Ford: update Maverick 2022 docs (#29280) 2023-08-08 11:47:23 +01:00
Shane Smiskol 8d3e661f79 Toyota: rename Toyota A harness (#29269)
* add toyota b harness

* not used yet
2023-08-07 15:31:50 -07:00
Saber fa504b7bae VW MQB: Add FW for 2023 Skoda Karoq (#29264)
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-08-07 22:38:59 +01:00
Shane Smiskol 8bff75c010 GM: remove unused CANParser flag (#29244)
setting to 0 does same thing
2023-08-04 21:42:34 -07:00
Kacper Rączy 1774b4fc61 Revert "radard: tie radard frequency to modelV2 (#29063)" (#29243)
This reverts commit 255f5c13f2.
2023-08-04 20:25:40 -07:00
David Peterson b50ffc4360 Nissan: allow B drive mode for Nissan Leaf (#29228)
* CAR.LEAF: NissanCarInfo("Nissan Leaf 2018-22”), video_link= "https://youtu.be/vaMbtAh_0cY&t=0s"),

Add Youtube video 2019 Leaf

* Update selfdrive/car/nissan/values.py

* Update interface.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-04 20:21:04 -07:00
Shane Smiskol 082fe6868d FPv2: fast fuzzy fingerprinting (#29233)
* fast fuzzy fingerprinting

* use match_fw_to_car helper

* fix and comment

* alone

* Update selfdrive/car/fw_versions.py

* Update selfdrive/car/fw_versions.py
2023-08-04 16:10:49 -07:00
Shane Smiskol fffc4ae446 Chrysler: add new diagnostic address for Jeep Grand Cherokee 2016-18 (#29235)
not a standard diag address, or anything we query. only 2 messages

900dfa83b4addfe6|2023-07-31--08-33-51
2023-08-04 14:29:00 -07:00
Kacper Rączy 255f5c13f2 radard: tie radard frequency to modelV2 (#29063) 2023-08-03 22:10:21 -07:00
Saber 8332abf015 VW MQB: Add FW for 2019 Skoda Kodiaq (#29225)
route name:0bbe367c98fa1538|2023-08-01--12-21-06--0
2023-08-03 16:37:54 -07:00
Saber 2ff53a62eb VW MQB: Add FW for 2018 Skoda Superb (#29222)
route name:77478022b2ebc4b6|2023-07-31--19-00-38--45
2023-08-03 16:37:34 -07:00
Tenebrous c438f2ba17 Toyota: add missing C-HR Hybrid 2020 (UK) FW (#29223) 2023-08-03 15:05:10 +01:00
Christian Bull Gjertsen 24bfb2b44b car docs: update Toyota vote link (#29218)
* Update CARS.md

Dead link

* fix link

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-03 03:05:59 -07:00
Maxime Desroches f18ff752d3 docs: fix 3x shop link (#29212)
fix link
2023-08-02 10:50:07 -07:00
Shane Smiskol dba4492aa0 Clean up common steer fault avoidance code (#29200)
* fix spacing

* more spacing

* better names and comments

* this default doesn't make sense

* or this

* explicitly boolean since latActive is
2023-08-01 14:02:15 -07:00
Shane Smiskol 4474cb734f Car docs: clean up docs_definitions (#29201)
* two spaces around class

* inch

* easier to read
2023-08-01 13:24:51 -07:00
Justin Newberry a19f8dce92 Homogenize Steering Fault Avoidance (#29140)
* fix subaru fault

* try this!

* wip

* try this

* this more or less worked

* this is all under gen2

* that needs to be up there

* comment

* steer_angle

* test

* wip

* wip

* sync

* wip

* cleanup

* remove print

* use sets and fix unittests

* common fault avoidance

* common fault avoidance

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* revert subaru to get this part merged

* revert name change

* revert name change

* revert name change

* same as before

* add test case

* also verify zero tolerance

* keep the current behavior

* split into multiple tests for easier debugging

* added comments and remove tests

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Comma Device <device@comma.ai>
2023-08-01 10:27:06 -07:00
Justin Newberry 1e1cc638d8 Car Docs: (optionally) Display a list of tools (#28782)
* display tools

* 5/16 also works

* cleanup

* static fix

* fix static analysis

* merge

* just use basepart

* use filter
2023-08-01 00:06:21 -07:00