This status was defined as a bump error, but it isn't actually due to bumps. It's also triggered by driver overrides that are somewhat higher than the "steer_override" threshold. By removing this temporary disengagement, the car is much more predictable on bumpy roads AND in turns that require assistance from the driver.
* Eliminate brake oscillations when using Pedal
* Simplified code
* syntax error fix
* Grinding code as applied to Honda Pilot only
Each model may need its own setting due to USER_BRAKE noise disengagements
* correction: self.CP.carFingerprint instead of CP.carFingerprint
* Add Ridgeline to Pedal Grinding fix
Confirmed to work also on Ridgeline
* fingerprint and new car
* you know the drill
* fix
* mod civic hatch to work for now
* try to merge hatch and other bosch
* fix
* fixed spaces
* comma (heh)
* make mass civic
* Add to readme. Need to confirm speed
* steering dropout at ~3.3 kph
* Remove additional fingerprint
* combined comment. fixed formatting to match
* Added EX-L subsection for the existing 2019 Pilot
Verified working with @Hitmantw25 12/20... and again 12/27 (VG w/ "Josh").
* Update selfdrive/car/honda/values.py
@energee wants to revert a change he made in a previous PR.
Co-Authored-By: ErichMoraga <33645296+ErichMoraga@users.noreply.github.com>
* Removed an extra space @energee included.
Tuned kP and kI and Tire Stiffness Factor settings.
Fixes lane centering issues in the following situations:
1. Hugging of left lane line during fast left curving roads
2. Hugging of right lane line during fast right curving roads
3. Left bias in fast lane on crowned roads (sloping down to the left)
4. Right bias in slow lane on crowned roads (sloping down to the right)
Works better when lane_width = 2.85 (vs 3.7 default) in pathplanner.py
* Honda Odyssey 2019 EX-L PID Tuning.
* Update interface.py - Increased Kp for Odyssey
Increases response from 0.4, but oscillation still occurs in very sharp curves.
* Move vehicle state values (that get sent to radar) into values.py file, its a better place for it :)
* idx with offset should only be applied to 0x300
* Adds new honda pilot to vehicle state msg array
* Adds Joel's Changes to values, sorted as Rick wanted.
* Adds space at end of file.
* Adds Changes to Steering Ratio for Pilot testing.
* Adding this to steer ratio makes it even 3.33
Not sure if this should go into this PR though or not.
This makes the ratio match the other vehicles in the file. Otherwise it's 3.454545...
* Changes the RAV4 back to not include pedal.
* Updated Comments for Pedal Support
* - Adds menuever test output to gitignore.
- Slight comment update to Ridgeline
* - Cleanup steer status comments
- Adds steering warning for interceptor cars in low speed lockout.
* Cleans up comments.
* Update README.md
* Corrects verbiage in README regarding Comma Pedal on Honda's
* Updates Odyssey and MDX to not add extra warnings for low-speed-lockout.
* Updates Comma Pedal references to use anchor links.
* Minor tweak to README
* Updates RDX to warn no steering below 12mph
* Reverts changes to README, carstate.py, and interface.py
* Removes extra libraries from a prior experiment.
* Replaces README with one from current devel. Hope this fixes spacing issues.
* Adds Pedal back to Honda Cars and sorts fingerprint values
* Fixes spacing changes that were not intentional.
* Fixed carstate no newline at end of file.
* Fixes new line at end of file issue.
* Converted the Long's to Int's
* Adds Honda Ridgeline
Replaced trim level placeholder
Adding 0x301 ridgeline message
(I restructured this slightly since we don't need to repeat `commands.append(make_can_msg(0x300, msg_0x300, idx, 1))` so many times
Updated dbc name
Use pedal_gas to detect gas pressed
Remove unnecessary signal check
Fix array notation
* Tire stiffness factor bumped to 1.5x
* Adds safety tests at line 133
* Revert "Adds safety tests at line 133"
This reverts commit 349edf5b1a879cac704db3786d0626211497bcb7.
* fix failing build due to syntax
* update variables for failing build
* Update interface.py
* Update Tire Slip Factor
* Interpolate ki/kp for steering PID loop
Very much needed for the Volt port: car ping-pongs with low kp
on high speeeds, and the loop is unstable with high kp on
low speeds.
Also, removes "number or array?" logic from PIController,
now that all the callers use interpolation ofr ki/kp.
* Pass speed to steering PID loop for ki/kp interpolation
* Remove unused numbers import
dekerr