Commit Graph

2609 Commits

Author SHA1 Message Date
Shane Smiskol 365bdd3422 Revert "FW query: query one sub-address in parallel" (#29550)
Revert "FW query: query one sub-address in parallel (#28675)"

This reverts commit 861ceb2fee.
2023-08-23 01:41:28 -07:00
Shane Smiskol 861ceb2fee FW query: query one sub-address in parallel (#28675)
* put one subaddr in parallel_addrs

* p

* remove print

* update test refs

* test

* revert test changes

* do same in present ECU query, lower threshold to catch (~0.82 to ~0.72 right within bounds)

* type

* clean up

* update test ref
2023-08-23 01:31:04 -07:00
Shane Smiskol 1ea310b202 Update FW query total time 2023-08-22 23:58:29 -07:00
Shane Smiskol 7de9842245 FW Query: test noOBD queries on aux panda (#29547)
* huh, this test just works!

* fix

* Update selfdrive/car/tests/test_fw_fingerprint.py
2023-08-22 23:43:52 -07:00
Shane Smiskol 0aa6e2ce41 Toyota: prepare to disable radar (#29542)
* try to disable radar

* fix bug and bump panda

* prep

* always attempt longitudinal for testers

* fix rav4

* send ACC_HUD

* bump panda

* revert

* check for failure to disable

* fix arg

* bump to master

* revert to master

* comments only

* correct check

* carcontroller

* something like this

* or this

* use flag

* send PCS HUD

* clean up

* carstate checks

* fix from test models

* consistent
2023-08-22 21:17:30 -07:00
Shane Smiskol 16a8c9fbf1 Toyota: remove redundant car set union (#29546)
remove confusing union
2023-08-22 21:09:33 -07:00
Shane Smiskol cb36816315 Revert "Toyota: prepare to disable radar (#29541)"
This reverts commit 61653bf343.
2023-08-22 19:50:24 -07:00
Shane Smiskol 61653bf343 Toyota: prepare to disable radar (#29541)
* try to disable radar

* fix bug and bump panda

* prep

* always attempt longitudinal for testers

* fix rav4

* send ACC_HUD

* bump panda

* revert

* check for failure to disable

* fix arg

* bump to master

* revert to master

* comments only
2023-08-22 17:16:38 -07:00
Vivek Aithal 2fe3231b49 CHEVROLET SILVERADO 1500 2020: Make Silverado lateral tune non-linear (#29540)
add nonlinear values to silverado
2023-08-22 16:11:21 -07:00
Shane Smiskol 2c835b81d9 Hyundai: remove Ioniq EV 2022 from legacy safety mode (#29531)
* fw

* remove from legacy

* update docs
2023-08-22 12:59:56 -07:00
Shane Smiskol f546e92774 Kia: move Optima Gen 4 FL out of legacy safety mode (#29530)
move Optima Gen 4 Facelift out of legacy
2023-08-22 12:41:52 -07:00
Cameron Clough 92a7d702fc Ford: test FW query config and versions (#29016)
* Ford: test FW query config and versions

* comments about software p/n

* should keep it in bytes

* don't need car_model

* it prints nicely

* add todo

* Update selfdrive/car/ford/tests/test_ford.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-21 23:29:15 -07:00
Felixowns 0c4b91975b Remove Sonata LF from LEGACY_SAFETY_MODE_CAR (#29521)
* Update values.py

remove sonata_lf from legacy safety mode. added sonata_lf to unsupported longitudinal car

* Update selfdrive/car/hyundai/values.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-21 21:28:13 -07:00
Shane Smiskol b373e5d5ec Revert "Subaru: always show LKAS active (#27945)" (#29515)
This reverts commit 8f1e67f625.
2023-08-21 16:25:13 -07:00
Justin Newberry b20eba5f1d Subaru: longitudinal incorrect "inactive" rpm (#29496)
* fix incorrect base rpm issue

* "min" name is better
2023-08-21 14:54:42 -07:00
Jason Wen bfa714ef3b HKG: Car Port for Kia Sorento Hybrid 2023 (#29322)
* HKG: Car Port for Kia Sorento Hybrid 2023

* Update CARS.md

* Oops

* add test route

* specify segment

* all packages

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-21 14:34:53 -07:00
Shane Smiskol de7bcb04fc add enhancement todo for hyundai fuzzy FP 2023-08-21 14:32:56 -07:00
Shane Smiskol 229c43a808 Kia: update supported Sorento PHEV package (#29509)
* Sorento PHEV includes all

* update docs
2023-08-21 14:11:32 -07:00
Justin Newberry fc9a623d69 Subaru: remove unused backoff rate calculation (#29368)
* cancel rate

* Update selfdrive/car/subaru/carcontroller.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* leave it as it was for now

* cleanup

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-21 13:31:57 -07:00
Caleb Stultz 551b0cc8f2 Remove Kia Sorento from LEGACY_SAFETY_MODE_CAR (#29502)
* Remove Kia Sorento from LEGACY_SAFETY_MODE_CAR

* Update values.py

* Added Kia Sorento to UNSUPPORTED_LONGITUDINAL_CAR
2023-08-21 10:43:31 -07:00
Adeeb Shihadeh a9626f95b6 add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
2023-08-20 20:49:55 -07:00
Shane Smiskol ac07c205ed Nissan: add alt request for engine on Rogue (#29477)
* get engine

* \xda should work

* fix issue

* Update selfdrive/car/nissan/values.py

* bump ref

* other ref
2023-08-18 23:47:58 -07:00
Jason Wen 2bd4e71b24 Hyundai longitudinal (CAN): don't send FCA11 on non-FCA cars (#28479)
* Hyundai longitudinal (CAN): don't send FCA messages to non-FCA cars

* Update comments

* outside

* change to FCA11 only

* move down

* add todos

* Apply suggestions from code review

* add todo

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-18 23:38:36 -07:00
Shane Smiskol 1a08c2986e Revert "radard: tie radard frequency to modelV2 vol. 2 (#29240)" (#29474)
* Revert "static analysis fixes"

This reverts commit a1e85f3661.

* Revert "radard: tie radard frequency to modelV2 vol. 2 (#29240)"

This reverts commit 460f5c8e0b.

* update refs
2023-08-18 22:56:43 -07:00
Shane Smiskol 38f1523742 add Kia Niro Hybrid 2019 to legacy safety mode list (#29472)
* add Kia Niro Hybrid 2019 to legacy safety mode list

* list

* test

* update docs

* space
2023-08-18 20:57:42 -07:00
Shane Smiskol 6253dca9eb CAN fingerprint: timing test (#29461)
* test fingerprint frames (timing)

* guess not needed

* it checks both buses

* use case list

* this is safe since we call current test only in the current loop, never after

* prof

* test this too
2023-08-18 14:33:13 -07:00
Terry Huang 0c50dd9d0f Ford: Kuga 2022 fingerprint (#29449)
Ford: Kuga 2022 fingerprint
2023-08-18 13:11:50 +01:00
Shane Smiskol 19767da668 CAN fingerprint: test fingerprint response (#29462)
* test finger

* split up
2023-08-18 00:37:32 -07:00
Jason Young f76ffbdbbc interfaces: add common STD_CARGO_KG to mass (#29416)
* cleanup std_cargo_kg

* fix Sonata mass

* remove snowflake construct

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-17 21:06:07 -07:00
Shane Smiskol 8dcd108972 Rename CivicParams (#29459)
* CivicParams -> ReferenceCarParams

* remove usage in interface

* better name

* revert
2023-08-17 21:02:09 -07:00
Shane Smiskol 3563292e65 test_models: remove body standstill exception (#29453)
* remove body exception

* bump to master
2023-08-17 16:26:30 -07:00
Shane Smiskol fd8f8d8785 CAN fingerprinting test (#29427)
* timing test

* test

* fix

* print

* loop

* clean up

* wider range

* Update selfdrive/car/tests/test_models.py

* Apply suggestions from code review

* run many times

* Update selfdrive/car/tests/test_models.py

* run for many its

* run with unittest and print as list

* Update .github/workflows/selfdrive_tests.yaml

* Update .github/workflows/selfdrive_tests.yaml

* total time is super inconsistent (body)

* Update selfdrive/car/tests/test_models.py

* clean up

* clean up

* clean up

* this works!

* draft

* test suite not as modular

* try something like this

* can do kb, but not too representative

* clean up

* remove kb? it depends on signals

* clean up

* more clean up

* rename

* just measure all CANParsers

* can do all this manually

* but this is way simpler

* comment

* stash

* draft

* draft

* remove old script

* clean up

* revert

* use it

* remove test

* opt

* no partial

* remove

* revert test_models

* test can fingerprinting

* so much simpler!

* fix dict resizing

* simplify

* need to do this

* fix

* move to new file

* rename

* comment

* ignore function-uses-loop-variable
2023-08-17 00:57:12 -07:00
Shane Smiskol 9d0d59ac9b Hyundai: match panda standstill check (#29442)
* bump panda

* clean up

* common?

* Revert "common?" (not now)

This reverts commit 197af7cdbb6a8c8e58fcbccca94f7db004ce91e4.

* fix

* no failures!

* remove time

* bump

* bump

* undo
2023-08-17 00:06:38 -07:00
Shane Smiskol 25ac9e2148 fingerprints: prevent global from changing (#29438)
prevent _FINGERPRINTS from changing
2023-08-16 19:52:41 -07:00
Justin Newberry d6c682b401 Subaru: Global gen1 experimental longitudinal (#28872)
* Add longitudinal support for Subaru Crosstrek and Impreza

* Update experimentalLongitudinalAvailable check

* Update supported cars list

* bump panda

* Remove/rename es_lkas_msg to es_lkas_state_msg

* Use stockAeb for AEB passthrough

* bump panda

* bump panda

* remove stockFcw from stockAeb

* Subaru: Add FCW_Cont_Beep to stockFcw signals

* bump panda

* bump panda

* update poetry deps: shellingham

* bump panda

* bump panda

* Revert "update poetry deps: shellingham"

This reverts commit 6e9b20964890c8a5c416a17b8aaad4cc16fddcfc.

* Merge fixes

* bump panda

* bump panda

* update supported cars list

* dont use counters for long control

* fix unittests

* submodules update

* only soft disable in long control

* use common functions and cleanup

* apply hystersis correctly

* move to comma repo

* use CanBus

* cleanup

* explicit copy

* behind a flag

* remove unrequired rpm checks

* add comment

* fix flag issue

* we still need to check rpm

* update docs

* enable long for a test route

* unit tests

* inactive throttle fix

* Update subarucan.py

* Update carcontroller.py

* Update carcontroller.py

* inactive throttle fix

* Delete settings

* fix rate limit

* bump submodules

* bump panda

* bump panda

* bump panda

* bump panda

* simplify initial implementation, remove AEB

* reduce initial complexity by not intercepting cruisecontrol or brake_status

* fix fwd hook test

* show pcb off warning

* cleanup and setup for tuning

* fix sumobuldes

* revert unrelated changes

* only whats required

* only whats required

* clean that up

* better comments

* behind the flag for now

* comments and minimize diff

* align stuff

* cleanup for PR

* apply review suggestions

---------

Co-authored-by: Martin Lillepuu <martin@mlp.ee>
2023-08-16 12:58:09 -07:00
Shane Smiskol b9e36b7faa car_helpers: common CAN fingerprint function (#29417)
* timing test

* test

* fix

* print

* loop

* clean up

* wider range

* Update selfdrive/car/tests/test_models.py

* Apply suggestions from code review

* run many times

* Update selfdrive/car/tests/test_models.py

* run for many its

* run with unittest and print as list

* Update .github/workflows/selfdrive_tests.yaml

* Update .github/workflows/selfdrive_tests.yaml

* total time is super inconsistent (body)

* Update selfdrive/car/tests/test_models.py

* clean up

* clean up

* clean up

* this works!

* draft

* test suite not as modular

* try something like this

* can do kb, but not too representative

* clean up

* remove kb? it depends on signals

* clean up

* more clean up

* rename

* just measure all CANParsers

* can do all this manually

* but this is way simpler

* comment

* stash

* draft

* draft

* remove old script

* clean up

* revert

* use it

* remove test

* opt

* no partial

* remove

* revert test_models
2023-08-16 03:28:50 -07:00
Shane Smiskol 2d636deb4e test_models: check panda cruise state (#29423)
* cruise state test

* add todo

* rename

* clean up

* remove
2023-08-15 23:55:53 -07:00
Shane Smiskol 4073ffb02b test_models: add full internal segment list (#29425)
full internal test models seg list

remove avalon and sienna

volt with ascm on

another volt with ascm on

9bc2ee633c361c3d|2023-07-28--20-17-51--2

dashcam mode

c4e21532b6fe3847|2023-07-05--08-34-05--1

can invalid (missing PSCMStatus)

cf6ba99592c48848|2023-07-01--11-36-56--20
2023-08-15 23:33:52 -07:00
Jason Young e1a64260d3 HKG: Vehicle mass corrections (#29418)
* HKG: Vehicle mass corrections

* not gross

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-15 20:46:57 -07:00
Shane Smiskol e2910d0720 CANParser: perf benchmark on route script (#29324)
* timing test

* test

* fix

* print

* loop

* clean up

* wider range

* Update selfdrive/car/tests/test_models.py

* Apply suggestions from code review

* run many times

* Update selfdrive/car/tests/test_models.py

* run for many its

* run with unittest and print as list

* Update .github/workflows/selfdrive_tests.yaml

* Update .github/workflows/selfdrive_tests.yaml

* total time is super inconsistent (body)

* Update selfdrive/car/tests/test_models.py

* clean up

* clean up

* clean up

* this works!

* draft

* test suite not as modular

* try something like this

* can do kb, but not too representative

* clean up

* remove kb? it depends on signals

* clean up

* more clean up

* rename

* just measure all CANParsers

* can do all this manually

* but this is way simpler

* comment

* fix mypy

* this is correct too

* 3 seconds instead of 1.5
2023-08-15 20:06:15 -07:00
Shane Smiskol 6ec00f5ee2 test_models: more typing (#29420)
* not type checked, but we set this in test_car_model

* type this
2023-08-15 20:01:33 -07:00
Justin Newberry 7ec52da33a Subaru: calculate steering angle rate (#29409)
* calculate rate

* added adeeb's comment

* move to selfdrive/car

* that makes way more sense

* much simpler

* fix rate

* preglobal doesn't have a counter

* update ref

* merge

* update ref after merging
2023-08-15 15:28:46 -07:00
Shane Smiskol 936f8b9817 test_models: some typing (#29413)
* type

* also type check this func

* unused
2023-08-15 15:25:36 -07:00
Jason Young 90c4bbe8e4 car interfaces: cleanup tire stiffness calculation (#28263)
* cleanup tire stiffness calculation

* bump cereal

* think these todos still apply

* gm: same default

* revert comments

* bump

* update refs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-15 14:17:08 -07:00
Shane Smiskol fb235238ad jenkins: re-enable test_models (#29394)
* re-enable test_models

* now?

* Remove bad Volt segment

* Update Jenkinsfile

* use first n segments
2023-08-14 16:08:34 -07:00
quinnp8703 c74daad0b9 volkswagen/audi: Additional S3 2015 firmware (#29366)
Update values.py

fingerprinting for early production 2015 audi s3
2023-08-14 13:34:44 -07:00
Justin Newberry c8cae714c6 Subaru: ES_Distance cruise cancel safety (#29362) 2023-08-13 22:14:13 -07:00
Justin Newberry 106f49a00f Ford: Explorer 2020 fingerprint (#29372) 2023-08-13 16:41:35 -07:00
Jason Wen 3a00149f56 Hyundai CAN-FD: carState cleanup (#29326)
* Hyundai CAN-FD: carstate cleanup

* Looks nicer

* Rearrange

* Fix

* Update selfdrive/car/hyundai/carstate.py

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-08-13 11:28:09 -07:00
Marcus Millspaugh 2c13dea1c8 additional Subaru fwVersion (#29365)
* Update Car/Subaru values.py to support 2022 Crosstrek

Tested via SP, just want support via stock OP

* remove duplicates

* started adding support for toyota bZ4X

* Add files via upload

* Update values.py

* Update values.py

* Update values.py

* Update values.py

* remove duplicates and mistakes

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2023-08-12 22:05:33 -07:00