Commit Graph

6060 Commits

Author SHA1 Message Date
Shane Smiskol 15383d3016 GM: match stock enabling behavior (#26442)
* add first draft enable button timeout

* use allow_enable

* it doesn't count if brakePressed

* enable on rising edge of resume (matches stock)

* not today

* add comment describing the fault this avoids

* cleaner

* handle incrementing speed

* rename

* add test for not changing speed if enabled changes mid-press

* spacey

* ugh

* bumpo

* need this to fix a fault (draft)

* already have

* this should be cancel

* fine to do for all

* fine to do for all

* bump

* bumpo

* bump to master

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* Update ref_commit
2022-11-13 21:13:46 -08:00
Shane Smiskol ca37d0c8cc interfaces: disable on falling edge of cancel button (#26493)
* both

* Update ref_commit
2022-11-13 20:50:28 -08:00
Shane Smiskol e46063086f controlsd: no speed increment if enabled on button rising edge (#26490)
* don't increment speed if we enabled on rising edge

* more realistic test
2022-11-13 16:34:26 -08:00
Shane Smiskol 3524cc7f0b cruise speed tests: match controlsd initialization of cruise speed (#26491)
* helper functions and fix resetting/enabling

* comment (resume not yet tested)

* make it clear how this resets

* this is fine to enable once

* same here
2022-11-13 16:15:17 -08:00
Shane Smiskol 65f494d845 GM: handle run-away set speed (#26480)
* GM: Handle run-away set speed

* bumpo

* This is a test of both PRs combined

* tempbump

* Revert "tempbump"

This reverts commit b73e04fca25e6a1bac889e44afac6430d5ad7c30.

* Revert "This is a test of both PRs combined"

This reverts commit 22cc0e6900e0f0470f14ed55e7846e4b1d570826.

* fix

* bump

* fix that

* Bump to master

* fix fix
2022-11-12 02:02:30 -08:00
Shane Smiskol 870b798185 controlsd: clean up v_cruise updating (#26479)
* clean up

* clean up

* clean up
2022-11-11 23:56:35 -08:00
Shane Smiskol a638afb98e controlsd: add tests around cruise speed (#26478)
* start to add some tests

* test !pcmCruise

* test !pcmCruise

* better test

* fix pylint

* new test for making sure we adjust on falling edge of buttons
2022-11-11 23:11:49 -08:00
Kurt Nistelberger 5f094b8368 CI: regroup devices (#26436)
* regroup ci devices

* cleanup looopback test

* split loopback devices

Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com>
2022-11-11 21:50:09 -08:00
Shane Smiskol d3f971b365 controlsd v_cruise: fix unknown buttons (#26474)
Fix button being None
2022-11-11 20:10:12 -08:00
Shane Smiskol 76ac3d4c99 controlsd: resume does not increment speed while cruise standstill (#25470)
* fix runaway set speed for GM

* fix runaway set speed for GM

* Handle resuming to exit standstill generically

* clean that up

* ugh i want to fix all the formatting

* class that manages v_cruise

* better name

* move around

* add depressed_state

* fine to update on pressed change, better name

* cmt

* we need to check CS. button_change_state only works if we exit standstill on rising edge not falling edge

* no defaultdict
2022-11-11 19:43:30 -08:00
Shane Smiskol 811c096e64 controlsd: add cruise speed helper class (#26472)
* fix runaway set speed for GM

* fix runaway set speed for GM

* Handle resuming to exit standstill generically

* clean that up

* ugh i want to fix all the formatting

* class that manages v_cruise

* better name

* move around

* add depressed_state

* fine to update on pressed change, better name

* revert gm stuff

* revert standstill stuff

* remove

* revert that

* we can put this in here now!

* below update

* actually only used here

* one line
2022-11-11 18:53:48 -08:00
Shane Smiskol 89b88fc7a2 Hyundai: fix button enable controls mismatch (#26471)
* bump panda

* buttonCancel needs to be a noEntry

* bompo

* Update ref_commit
2022-11-11 14:49:38 -08:00
Shane Smiskol 9f80a97eee longitudinal tests: add disabled maneuver (#26470)
* undeclared variable

* run first second disabled

* only test

* test disabled as a new maneuver

* bottom
2022-11-11 14:02:09 -08:00
Shane Smiskol 98206fb92e planner: fix undeclared variable (#26468)
* undeclared variable

* run first second disabled

* revert test

* rev
2022-11-11 13:22:56 -08:00
Adeeb Shihadeh 714ab491b0 boardd: SPI bulk read + write (#26462)
* bulk read

* write

* write

* fix write

Co-authored-by: Comma Device <device@comma.ai>
2022-11-11 12:51:14 -08:00
Jason Wen f6189b3235 HKG: Bump Kia Telluride support to 2022 (#26467) 2022-11-11 11:40:21 -08:00
Harald Schäfer f23296bc87 Add force decel to e2e long (#26448)
* add force decel to e2e

* Update longitudinal_planner.py
2022-11-11 10:46:03 -05:00
Shane Smiskol 74b6e22a7d controls: disengage on regen paddle independently (#26453)
* add regen braking field that's just used to add a pedalPressed

* bump

* bump

* Update ref_commit

* we want the standstill check

we want the standstill check

* see what diff is now

* Update ref_commit
2022-11-10 19:06:31 -08:00
eFini 765761d7d0 Multilang: add missing Chinese (Traditional) translations (#26433)
* update cht translation

* fix ellipsis -> spaces

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-11-10 19:02:58 -08:00
Adeeb Shihadeh f5bf3cd21b boardd: verify SPI checksum (#26454)
* verify checksum

* import from panda

Co-authored-by: Comma Device <device@comma.ai>
2022-11-10 18:37:10 -08:00
Lee Jong Mun df145ae99f Multilang: kor translation update (#26445)
* Multilang: kor translation update

* fix
2022-11-10 16:56:28 -08:00
AlexandreSato 2961f8a7d8 Multilang: Update pt-BR translations (#26444)
* update pt-BR translations

* fix some cutoff texts

* Delete main_pt-BR.ts

* Add files via upload

* Delete main_pt-BR.ts

* Add files via upload
2022-11-10 12:27:25 -08:00
YassineYousfi 7374080668 min lane change speed 20mph (#26434) 2022-11-09 22:04:57 -08:00
Shane Smiskol 4efb01ece2 Toggle titles: proper capitalization (#26438)
* proper caps

* update translations

update translations

update translations

* Update selfdrive/ui/translations/main_pt-BR.ts
2022-11-09 20:33:01 -08:00
Shane Smiskol 0941e40177 ui: static color non-e2e path (#26406)
* remove orientation color changing

* "just green"
2022-11-09 20:31:38 -08:00
Nelson Chen d3122cc77e Toyota: add missing engine FW for RAV4H_TSS2 (#26432)
"rav4 hybrid xse 2020"

From Rogrhoa#2158 on Discord.

Example Route: 64edc30d23cad8cb|2022-11-09--20-02-03
2022-11-09 19:59:12 -08:00
Shane Smiskol af84f1b350 experimental long toggle: adjust description (#26437)
* Spell out AEB

* vanish
2022-11-09 19:42:34 -08:00
Shane Smiskol a3cd50c5bb ParamControl dialog: more explicit confirmation text (#26431)
* Use enable

* vanish

* fill in missing translation

* Update selfdrive/ui/translations/main_pt-BR.ts
2022-11-09 19:38:17 -08:00
Shane Smiskol 5a3c5e7a4b Multilang: clean up translation string (#26435)
* update translations

* do pt

* do pt

* do ko

* do ko

* Update selfdrive/ui/translations/main_pt-BR.ts
2022-11-09 19:33:42 -08:00
Adeeb Shihadeh 1fda075c73 UI: add set speed clarification for e2e long 2022-11-09 18:42:51 -08:00
Shane Smiskol e1001a3036 Toyota: factor on cluster speed to match dash (#26408)
* add a minimum factort

* Update ref_commit
2022-11-09 18:27:30 -08:00
Shane Smiskol 6c03e093c6 Multilang: mark some translations finished (#26430)
* mark finished translations

* fix

* cleanup

* revert
2022-11-09 17:31:58 -08:00
Shane Smiskol bbc14656d9 Multilang badges: assert width exists in xml 2022-11-09 17:30:33 -08:00
Shane Smiskol d8327bd9be multilang badges: no need to handle plurals 2022-11-09 16:58:02 -08:00
Shane Smiskol f540002e3f translation badges: add number of unfinished translations (#26429)
* some clean up and add missing translations

* unfinished

* set proper width

* make this variable common
2022-11-09 16:49:17 -08:00
Lee Jong Mun 26d66ac671 Multilang: Korean translation update (#26424)
fix
2022-11-09 16:15:44 -08:00
AlexandreSato 52378c97ec Toyota: Add missing Corolla Cross FW verions (#26426)
* add geraldo fingerprint

* add to non-H

* Update selfdrive/car/tests/routes.py

* Update non-us cross model years

* add test route

* Update routes.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-11-09 16:06:36 -08:00
Shane Smiskol 048cce2149 Hyundai: add missing Sonata 2022 FW versions (#26428)
* Added FW Versions for 2022 Elantra and 2022 Sonata. 

Added for CAR.ELANTRA_2021 :

Ecu.transmission :  b’\xf1\x87CXMQFM3421815JB2ww\x96y\xaa\x98x\x87\x88wtwTfuwWh\x9f\xff\x8a\xff\xff\xffE\xe3\xf1\x89HT6VA640A1\xf1\x82CCN0N20NS5\x00\x00\x00\x00\x00\x00'

Ecu.engine : 
b'\xf1\x870\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xf1\x82CNDWD0AMFCXCSG8A'


Added for CAR.SONATA :

Ecu.engine : 
b'\xf1\x870\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xf1\x81HM6M1_0a0_J10'

Ecu.transmission: 
b'\xf1\x00T02601BL  T02832A1  VDN8T25XXX832NS8G\x0e\xfeE'

b'\xf1\x87954A02N060\x00\x00\x00\x00\x00\xf1\x81T02832A1  \xf1\x00T02601BL  T02832A1  VDN8T25XXX832NS8G\x0e\xfeE'

b'\xf1\x87954A02N060\x00\x00\x00\x00\x00\xf1\x82VDN8T25XXX832NS8'

* Update values.py

* Removed FW Versions for Elantra_2021.

* fix

Co-authored-by: humza2000 <111622889+humza2000@users.noreply.github.com>
2022-11-09 16:04:19 -08:00
AlexandreSato 584842488f Multilang: update pt-BR (#26420)
* update pt-BR translations

* fix some cutoff texts

* Update pt-BR translations
2022-11-09 15:13:17 -08:00
Cameron Clough f38fe7cfb1 ui: increase toggle confirmation font size (#26413)
* ui: make toggle confirmation text larger

* center title

* reduce line breaks

* slightly reduce font size
2022-11-09 14:53:41 -08:00
Shane Smiskol 0ca9d1810c interrfaces: more complete PID tests (#26422)
* more complete PID tests

* doesn't need to be fancy

* less fancy
2022-11-09 12:10:08 -08:00
Vivek Aithal c64e2c228a [controlsd] Toyota Rav4 TSS2 bugfix (#26421)
bugfix toyota rav4 pid init values
2022-11-09 12:09:55 -08:00
Jason Young 34f580e75e VW PQ: Fix exception with openpilot longitudinal (#26417)
* VW PQ: Fix exception in long control

* move default value to init
2022-11-09 01:55:37 -08:00
Shane Smiskol 191b8081b2 GM Camera: use ECM brake pressed bit (#26400)
* GM camera: use ECM brake pressed bit

* bump panda and use more reliable bit

* bump panda

* back to ECMEngineStatus

* bump

* Update selfdrive/car/gm/carstate.py

* bump panda

* Update ref_commit
2022-11-08 20:52:35 -08:00
Adeeb Shihadeh 9a3f468051 experimental mode (#26416)
* experimental mode

* rename param

* red lights
2022-11-08 14:45:01 -08:00
Adeeb Shihadeh 8ba9a5107b boardd: SPI support (#26374)
* spi handle

* put usb back

* handle eintr

Co-authored-by: Comma Device <device@comma.ai>
2022-11-08 13:21:07 -08:00
Adeeb Shihadeh 5960ba5def UI: widecam only in e2e mode (#26412) 2022-11-08 12:49:22 -08:00
Shane Smiskol 52a644e656 Toyota: add hysteresis to cluster speed (#26386)
* add hysteresis to cluster speed

* add minimum cluster scaling

* fix

* Update ref_commit
2022-11-08 00:03:23 -08:00
Jason Wen d62cdc400c HKG: Car Port for Genesis GV70 2022 (#26373)
* HKG: Car Port for Genesis GV70 2023 thanks to @zunichky!

Co-authored-by: kyle zunich <zunichky@msu.edu>

* Update docs

* Update selfdrive/car/hyundai/values.py

* GV70 does radar SCC, separate them

* One more

* bump panda

* Gate 0x1A0 away from bus 6

* Can't leave out the OG

* EV6 non-HDA2 too?

* bump panda

* bump panda

* Check 0x1a0 based on param

* bump panda

* bump panda

* bit simpler

* fix bit op

* fixes

* bump panda to master

* cmt

* flip

Co-authored-by: kyle zunich <zunichky@msu.edu>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-11-07 23:03:36 -08:00
Shane Smiskol e971bb11c2 Hyundai: bump safety params (#26407)
* bump panda

* bump panda

* bump panda

* update refs

* bump panda

* bump panda
2022-11-07 22:14:47 -08:00