Commit Graph

477 Commits

Author SHA1 Message Date
Shane Smiskol bdaf174154 Support RAV4 2022 with stock longitudinal (#24367)
* support for ICE 2022 RAV4

* add to releases

* swap

* add fingerprints from a5c341bb250ca2f0

* update test route

* update docs

* add test for rav4

* values.py is a comma file
2022-05-18 19:04:11 -07:00
HaraldSchafer 9f8b03753d Revert torque control (#24565)
* torque reversal start

* Fix carmodel tests

* Update ref

* update ref

* Elif is better than if
2022-05-17 19:00:57 -07:00
omatzyo e08c712a08 Toyota: add 2021 RX350 fingerprint (#24540)
Update values.py

Adding 2021 RX350
2022-05-17 10:59:15 -07:00
cydia2020 3f5afa158a Toyota: correct weight for the Prius V (#24499)
* correct weight for the Prius V 

https://www.toyotacertified.com/content/dam/tcuv/sections/brochures/en/prius-v/2017_priusv_ebrochure.pdf

* Remove comment

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Extra whitespace

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-05-11 21:02:47 -07:00
Shane Smiskol 433fcc0c71 CarInfo: Add harness information (#24085)
* Add harness information

* test harness enum

* add harness info for tucson

* update Tucson harness

* get rid of development

* make global enum

* fix

* add harness info

* add harness info to CARS.md (since we need multiple lines per HKG platform)

* revert this

* Actively Maintained means something! (aka, to bronze with select VW)

* fix caravelle

* add harness tooltip on maintained column

fix

* lol tubaru

* always assume harness

* update honda harnesses

* add Ioniq hybrid 2017-19 harness, todo: not sure

* unused import

* hmm, did they really switch to the C for 1 year??

* add comment

* add comments

* adding tooltips should be fine

* fix santa fe harness

* welcome back, vw

* no need for two harness strings

* seems fine

* fix 19-20 Niro EV harness

* these were taking from old database, so assume correct

* could be d

* pass all car info into template

* no more tool tips

* these use j533 harnesses

* accidentally got removed in merge

* also merge issue

* don't need these

* make harness non-optional
2022-05-11 18:02:21 -07:00
Shane Smiskol 191fbd4f67 Camry TSS2: use torque controller (#24268)
* use measurements from harald

* update from table

* average of hybrid and non-hybrid
2022-05-07 21:34:17 -07:00
HaraldSchafer 29afd53d88 Latcontrol torque: fix integrator induced ping pong (#24458)
* Latcontrol torque: fix integrator induced ping pong

* Reset on disengage since unwind resets anywayh

* Might be overkill

* rm whitespace

* update ref
2022-05-06 22:17:21 -07:00
Shane Smiskol c955e273d4 Toyota: fill steerFaultPermanent (#24410)
* Toyota: fill steerFaultPermanent

* same behavior as before, 0 is also fault (0 is most likely initializing)

* think this was just wrong (2 or 10 would mean we think it's a fault)
2022-05-06 16:56:40 -07:00
Left5566 4beb764aed Toyota: add missing Prius TSS2 engine FW (#24438)
Prius 2021  DongleID/route c3834a2fe82b632b|2022-05-05--19-39-41
2022-05-05 11:59:15 -07:00
Brandon Zimmerman da74085d56 Toyota: add missing FW versions for 2022 Lexus ES 300h (#24431)
* Add 2022 Lexus ES Hybrid f/w - LEXUS_ESH_TSS2

2022 Lexus ES Hybrid

* change carinfo

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-05-05 11:20:53 -07:00
Shane Smiskol 6efb42613b Toyota: Add missing FW versions for RAV4 Hybrid 2022 (#24430) 2022-05-05 10:21:46 -07:00
HaraldSchafer 8cdeaf9aee Latcontrol torque: update tuning (#24357)
* Little more chill

* Update ref

* Update refs
2022-05-02 14:42:18 -07:00
Shane Smiskol 41f62f7604 Toyota: Add FW versions for RAV4 Hybrid 2022 (#24374) 2022-04-29 14:40:29 -07:00
Shane Smiskol c1caca104f Support RAV4 Hybrid 2022 with stock longitudinal (#23969)
* add panda flag for toyota stock long with camera

* clean up

* Add 2022 RAV4 Hybrid from Philly

* fix wrong fw in interface, did this ever work?

* Must be a hybrid

* no radar parsing

* fix can error

* move to own platform

* generate docs

* fix

* Add 2022 Rav4 XSE Australia fingerprint parameters (#24303)

* Update values.py

Add 2022 Rav4 XSE Australia

* add commas

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* bump panda

* wait, the camera doesn't even send 0x343, right?

* use a set instead, more obvious

* don't test without a parser

* bump panda

* flip panda flag

* bump panda

* add commas

* regen and update refs

* set to none by default

* revert parenthesis

* update comment

* bump panda

* regen and update refs

* add test models and update readme

* bump to master

Co-authored-by: BrettLynch123 <34538435+BrettLynch123@users.noreply.github.com>
2022-04-28 22:37:46 -07:00
Shane Smiskol a05487cdf5 Toyota: fill stockFcw signal (#24324)
* fill stockFcw

* only TSS2 car for now
2022-04-27 14:18:27 -07:00
Adeeb Shihadeh 3e098c9ba5 Toyota: add safety param flag for alt brake message (#24341)
* Toyota: add safety param flag for alt brake message

* update refs

* update refs

* bump panda
2022-04-27 12:08:11 -07:00
Erich Moraga 785a228f2b Add missing LEXUS_RX_TSS2 engine & fwdCamera f/w (#24309)
`@jackus1#7254` Lexus RX 350 2022 ICE  DongleID/route 02b50dc00776ca3c|2022-04-24--11-40-30
2022-04-24 11:08:39 -07:00
Jcs Kadupitiya c5a700981c Add missing Highlander Hybrid TSS2 fw (#24289)
Adding a new firmware version for Ecu.esp for the CAR.HIGHLANDERH_TSS2.
2022-04-21 17:52:47 -07:00
Shane Smiskol 17cb65c4b7 Toyota: resolve controls mismatch due to interceptor thresholds (#23710)
* remove gas interceptor exception

* panda

* bump submodules

* bump panda

* forgot carstate change

* revert

* add test route

* bump

* update refs for CS.gas

* bump submodules to master
2022-04-20 22:28:56 -07:00
Erich Moraga 70775df771 Add missing AVALON_TSS2 firmwares (#24273)
`@Frank McTank#5005` 2022 Avalon Limited ICE  DongleID/route 14f1b241a8c4e210|2022-04-20--09-01-39
2022-04-20 11:53:17 -07:00
HaraldSchafer 506650bab6 Latcontrol torque: max_torque rename (#24265) 2022-04-20 11:26:24 -07:00
HaraldSchafer fe0bcdaef6 Lateral torque-based control with roll on TSS2 corolla and TSSP rav4 (#24260)
* Initial commit

* Fix bugs

* Need more torque rate

* Cleanup cray cray control

* Write nicely

* Chiiil

* Not relevant for cray cray control

* Do some logging

* Seems like it has more torque than I thought

* Bit more feedforward

* Tune change

* Retune

* Retune

* Little more chill

* Add coroll

* Add corolla

* Give craycray a good name

* Update to proper logging

* D to the PI

* Should be in radians

* Add d

* Start oscillations

* Add D term

* Only change torque rate limits for new tune

* Add d logging

* Should be enough

* Wrong sign in D

* Downtune a little

* Needed to prevent faults

* Add lqr rav4 to tune

* Try derivative again

* Data based retune

* Data based retune

* add friction compensation

* Doesnt need too much P with friction comp

* remove lqr

* Remove kd

* Fix tests

* fix tests

* Too much error

* Get roll induced error under 1cm/deg

* Too much jitter

* Do roll comp

* Add ki

* Final update

* Update refs

* Cleanup latcontrol_torque a little more
2022-04-19 19:34:31 -07:00
Erich Moraga 1ddcba2ca3 Add missing AVALONH_TSS2 fwdCamera f/w (#24261)
`@Hansal#7177` 2022 Avalon Hybrid Limited  DongleID/route 16a02782fd3d706e|2022-04-18--23-48-48
2022-04-19 14:26:42 -07:00
Erich Moraga 948e3edc31 Add missing LEXUS_NX_TSS2 fwdRadar f/w (#24235)
`@stephengao#5556` 2020 Lexus NX  DongleID/route 0e84e3a3cbc3f537|2022-04-17--17-25-58
2022-04-18 09:37:46 -07:00
Erich Moraga f933d543b2 Extend Lexus RX compatibility to 2022 (#24217)
* Extend Lexus RX compatibility to 2022

Sorry, I should've done it when I submitted this PR a couple months ago...
https://github.com/commaai/openpilot/pull/23691

* Revert "Extend Lexus RX compatibility to 2022"

This reverts commit b6a4c5f82c50713d813e260086b71061f047a70a.

* Extend Lexus RX compatibility to 2022 via CarInfo

* Extend Lexus RX compatibility to 2022 in docs
2022-04-15 08:12:18 -07:00
Adeeb Shihadeh 49c2164814 add alert for CAN bus timeout (#24162)
* add alert for CAN bus timeout

* add alert

* set in interface

* cleanup

* cleanup

* add event

* fix mock

* bump

* bump opendbc

* update refs

* return reader
2022-04-12 22:58:34 -07:00
Shane Smiskol c8f5b21744 Clean up CarInterface.apply and CarControllers (#24060)
* do tesla

* parentheses

* Do Chrysler

* Make sure Hyundai long never actuates when long inactive

.

* clean up Hyundai

* more clear

* formatting

* Stock sets these to zero

* fix params

* move jerk logic into CC

clean up
2022-04-05 23:38:45 -07:00
Kento Tokuhiro c48f2bfb8c Toyota: add FW for 2019 Toyota Corolla (#24061) 2022-03-29 23:55:28 -07:00
Erich Moraga f7e9f93c38 Add missing CAMRYH_TSS2 fwdRadar (#24047)
`@SloshyZebra#8815` 2022 Toyota Camry Hybrid  DongleID/route 34c6eea208b2f059|2022-03-26--13-14-41
2022-03-27 15:42:58 -07:00
Shane Smiskol 85d8997a8a docs: support for automatically generating website vehicles page (#24020)
* add vehicles.vue template

* add original vue file

* stash

* stash

* clean up a bit

* add template for now

* implement footnotes and tier copy

* no more generator

* convert to 2 spaces

* should work, now onto vue

* does GH handle this html well?

* fix

* auto-generate descriptions and make tiers' maps non-str

* remove old files

* move template specific variable into templates, should be a bit simpler

* js template is simplier too now

js template is simplier too now

js template is simplier too now

* add video links from the nice car_info

* make rows attributes

* clean up

* fix

* remove template

* experiment with video links in GH

add image

how does this look?

fix

* Revert "experiment with video links in GH"

This reverts commit 8375e717b563f7b4ecf009ffae00174de1a0b8e9.

* sort tier_car_info in place

* unused Tuple

* no type check

* fix script
2022-03-23 13:42:53 -07:00
Shane Smiskol 15368ec3d1 Support Toyota Alphard Hybrid 2021 (#24003)
* add 2021 Alphard Hybrid

revert

* fix fp name

* run docs generator

* Add to releases

* test route

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-20 16:40:25 -07:00
Shane Smiskol 247b66f4a8 Toyota: Support Avalon Hybrid 2022 (TSS2.5) (#23892)
* Add Avalon Hybrid 2022

* update docs

* set a tune

* add test route

* uploaded route
2022-03-19 13:14:04 -07:00
Adeeb Shihadeh 2219cb4478 cars: cleanup CS usage (#23957) 2022-03-18 15:39:22 -07:00
Shane Smiskol 31a6b141d6 Docs: auto-generate supported cars documentation (#23762)
* make CAR class enum, and values.py formatting

* Revert "make CAR class enum, and values.py formatting"

This reverts commit 04d9817e9d5d6ab5c027754018fc445f2cd3067a.

* stash

* add supported packages and model years

* don't change model years in fps

* move Lexus to info dict and make int enum

* remove sometimes wrong model years from name string

* use enum names

* convert Honda's values

* nice names

* use name

* GM

* Mazda, Ford

* Hyundai: WIP

* finish Hyundai

* fix

* Nissan

* Subaru

* Tesla

* formatting is for another PR

* Chrysler: todo: unify the Pacificas?

* do volkswagen

* this isn't a zoo

* skip enums for now

* Update selfdrive/car/volkswagen/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

* set All

* temp cars

* auto-generate CARS.md

* update type hinting

* add generated file

* add longitudinal star to cars that support disabling radar

* add TODO

* add notes

* add min_steer_speed exception for hatchback

* add minimum steering speeds

* Add exceptions and run generator

* Missing Telluride

* fix Prius v

* missing Prius Prime

generate

* start to convert years to strings

* Fixup Hyundai

* convert year sets to strings

* handle this

* missing S3

* Fix and add all missing cars (verified with script

* Supported Package fixes

* add get_tiered_cars

* Check radarOffCan for removing most Honda from op long

* Update for Avalon stop and go update on master

* Fix missing car params

* add my temporary script i'm using to verify new generated DBC

add my temporary script i'm using to verify new generated DBC

* generate with jinja template

* add header and footer

* clean up

* rename

rename

* add exceptions. jinja is nice, but why are its loop indexes starting at 1?

* add list of known car videos

* See how these look

* Add nice table formatting for column description

Add nice table formatting for column description

* generate

* consisten br tag

* small clean up

* temp

* Move car videos into CarInfo

* add new copy and rename to footnotes

* Revert "temp"

This reverts commit 93c3fce1d3ab406f80cbfb9c00c2237d109c7846.

clean up

* generate

* replace with svg

* simplify a bit

* add footnotes to CarInfo

* move some variables to docs.py

* Add video link for Acadia

* Make Footnote an enum so we don't use random ints

* static analysis fixes

* move to CARS.md

* fix last missing footnote

* add to release files

* rm test file

* use svg

generate

* fix sorting

* not needed

* not sure how this got here

* remove Sedan/Couple and add Diesel footnote

* finish todos

* move make specific footnotes to selfdrive/car/*/values.py

rename

* change to zeros

* align bottom to center

* Apply some suggestions

* Update selfdrive/car/mock/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update copy

* Try headers + bullet points

* somehow better

somehow better

* finish updating copy

* move template and add links to sups

* stars shouldn't be clickable

that didn't work

try this

try this

this is better

* add type hints to CarInfo

add more type hinting

* optional needs a type and any covers all (?)

* move good steering torque to */values.py

* dataclasses are much nicer than attr

* use tuple

* Update docs/cars.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* suggestions

* suggestions

* suggestions

remove

* clean up a bit

* add more type hints

* center stars and remove hardcoding from template

* update copy

* Add test

* Fix types

Fix types

* add supported cars documentation test

* clean up

* replace with docs_definitions

* Add back Footnote enums

* Ah so these are like fstrings!

* Update selfdrive/car/CARS_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update year from master merge

* Fix longitudinal star from merge

* sort properly stars by Column enum

* clean up

* HKG: Sorry guys

* Prius V gets FSR star, like others

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update comment

* No Prius docs change for now

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-16 21:27:05 -07:00
Shane Smiskol facf6c109d Toyota: clean up CarInterface apply function (#23714)
* clean up CarController with intermediate variables only accessed once or twice

* format

* fixes and move frame to CarController
2022-03-16 20:06:17 -07:00
Adeeb Shihadeh bae78dd46b don't read params in car interfaces (#23978) 2022-03-16 15:17:47 -07:00
cydia2020 d7c758d4bf Toyota: parking brake state (#23970) 2022-03-14 19:19:31 -07:00
Adeeb Shihadeh 5c3f3e44bc break up selfdrive.config (#23959)
* break up selfdrive.config

* add to release files

* fix import order
2022-03-13 21:42:39 -07:00
Shane Smiskol 629399a449 carControl: add long and lat active fields (#23859)
* proof of concept

* actuators packet describes which actuators are active

* bump cereal

* fixes

* not needed for this PR

* Do Toyota

* add back controlsState.active

* bump cereal

* rest of cars

* in actuators

* add active back

* which

* use controlsState.active for now

* will make an issue

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move local lat_active checks into CC.latActive

* remove redundant checks

* move comment

move comment

* fix joystick mode

* get enabled from carcontrol

* do standstill check in controlsd

* make sure we consider the gas press case for GM

* use CC.actuators

* fix

* capitalization

* Bump cereal

Bump cereal

* make intermediate actuators

* similar convention to before

* clean that up

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-13 20:58:44 -07:00
Shane Smiskol 156337475e 2019+ Avalon: allow stop and go (#23952)
* Avalon actually has SNG

* update readme

* Revert "update readme"

This reverts commit 076561a0578bcc626fd6710bc411330ef13334d4.

* update readme

* fix

* variants as it includes hybrids
2022-03-11 19:45:30 -08:00
Shane Smiskol 77fd64ee30 Move 2020 Lexus NX 300 fw fingerprints to TSS2 (#23893)
* Revert "Toyota: add Leuxs NX fingerprint (#23808)"

This reverts commit 4f999b44c6.

* Add engine and fwRadar fw
2022-03-02 13:31:51 -08:00
Adeeb Shihadeh 87849f93b1 better steer fault names (#23890)
* better steer fault names

* bump cereal
2022-03-01 22:53:55 -08:00
sintman 4f999b44c6 Toyota: add Leuxs NX fingerprint (#23808) 2022-02-27 22:01:55 -08:00
Shane Smiskol a1875ac6f0 Toyota: fix learning bad offsets for some models (#23810)
* Update carstate.py

* comments

* use initializing

* bump opendbc

* bool

* check both

* bump opendbc

* and on TSS-P the initializing bit isn't set
2022-02-26 00:54:35 -08:00
Ross Fisher 49c42c3cd4 Toyota: remove outdated comment (#23844) 2022-02-23 17:03:24 -08:00
Adeeb Shihadeh 0965155a5b Toyota: fix flaky EV detection (#23825) 2022-02-22 16:15:09 -08:00
Erich Moraga b9f0991df4 Add missing CAMRYH_TSS2 fwdCamera f/w (#23796)
`@Ty.ler#0303`  2022 Toyota Camry SE Hybrid  DongleID/route 9477a77ffc4e8bd4|2022-02-18--15-40-25
2022-02-19 13:53:53 -08:00
Vivek Aithal 3e915cf628 controlsd: Fix Toyota steer angle sensor race condition (#23747)
* fix steer angle race condition

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2022-02-11 13:54:17 +01:00
Erich Moraga 3e094bc7c4 Toyota: Add missing LEXUS_RX_TSS2 engine & fwdCamera (#23691) 2022-02-01 23:32:40 -08:00
Shane Smiskol 31af75f2e3 Toyota: merge Lexus ESH params into similar vehicles (#23673)
* merge LEXUS_ESH

* min and max of all variants
2022-01-31 17:30:48 -08:00