Commit Graph

196 Commits

Author SHA1 Message Date
Shane Smiskol 8bff75c010 GM: remove unused CANParser flag (#29244)
setting to 0 does same thing
2023-08-04 21:42:34 -07:00
Kacper Rączy 1774b4fc61 Revert "radard: tie radard frequency to modelV2 (#29063)" (#29243)
This reverts commit 255f5c13f2.
2023-08-04 20:25:40 -07:00
Kacper Rączy 255f5c13f2 radard: tie radard frequency to modelV2 (#29063) 2023-08-03 22:10:21 -07:00
Vivek Aithal 3612c12b14 [GMC ACADIA DENALI 2018] Move to torque control, non-linear feed-forward (#28923)
* move GMC ACADIA to torque control, with a Bolt-like feedforward

* update offline values

* update offline values

* reduce friction

* update values

* update values

* cleanup
2023-07-21 11:28:48 -07:00
Shane Smiskol 653daba9ed GM ASCM: don't apply gas when stopping (#28699)
* don't apply gas when stopping

* simpler?

* todo

* fixme
2023-07-14 05:58:17 -07:00
Shane Smiskol 82f2f9448b GM: allow enabling down to a stop for Silverado/Sierra (#28708)
* Silverado: allow enable down to 0 without user brake

* update docs

* firmly

* better comments, fix docs

* revert docs
2023-06-27 00:36:53 -07:00
morrislee 2914fa9d12 GM camera ACC: add camera diagnostic address to fingerprints (#28331)
* add missing addresses FP for silverado

* add for all camera acc gm

* add test

* check both rx and tx

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-06-25 20:13:55 -07:00
Shane Smiskol 024abe6455 car docs: document parts of parts (#28292)
* more stuff

* even more

* all parts func

* start to use it

* include self in parts

* use car_parts_new

* not used

* more usages

* remove get_parts

* remove more commented stuff

* remove iter

* clean up some more stuff

* more

more

* ford

* optional

optional

* nissan

* use new classes

* fix tests

* fix

* order

* no more required

* connector

* CARS.md

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
2023-05-31 21:30:50 -07:00
Maxime Desroches 9f5f8b603c car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-22 10:17:33 -07:00
Shane Smiskol 3d94423108 GM: explicitly copy signals to forward (#28243)
* gm

* same order as DBC
2023-05-20 18:09:57 -07:00
Maxime Desroches 70677fe5fc add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-15 15:33:54 -07:00
Shane Smiskol 5aebdb0ad0 Car docs: pass docs flag to car interfaces (#27311)
* docs

* docs

* docs

* docs

* use docs in gm
2023-04-18 12:22:22 -07:00
Yong-seok, Jang e1ad8df519 GM: Trailblazer 2021-22 support (#27830)
* Add trailblazer support

* Update routes.py

* Update routes.py

* Update CARS.md

* Fix incorrect torque name

* Update values.py and CARS.md

* Change to update another route

* update docs

* only 2021 https://en.wikipedia.org/wiki/Chevrolet_Trailblazer_(crossover)

only 2021

* new FP with missing addrs

* Update selfdrive/car/gm/interface.py

* tune the torque params

* update docs

* remove as a new platform

* Revert "remove as a new platform"

This reverts commit c9c65f29dbb1e1a5926540bb75433928325d6c0e.

* add comment and comment out FP

* need it to be in all_known_cars to test_model

* add to releases

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-04-12 23:32:03 -07:00
Adeeb Shihadeh 088cbfc9d5 car docs: add field for min compatibility requirements (#27805) 2023-04-04 17:47:49 -07:00
royjr 2ab05f96c3 Cleanup: GM remove unnecessary variable (#27779) 2023-04-01 15:24:29 -07:00
Vivek Aithal 15b880c0ea Bolt EUV: Non-linear torque function (#27696)
* add erf based ff

* silly bug; diff of nonlinear != nonlinear of diff

* add sigmoid based ff, ensure slope at 0 > 1

* reduce steer down limit and increase driver allowance

* rebase panda

* atry without friction, and with tanh nonlinear

* finalize the nonlinear function

* do not disable friction compensation in the ff

* bump panda

* bump panda

* update refs

* update refs

* resolve comments

* Add type hints

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-03-29 15:10:39 -07:00
Shane Smiskol aefe636cc1 GM: common longitudinal actuator delay (#27357)
* common longitudinal actuator delay

* comment

* remove dup

* move

* clean up

* Update ref_commit
2023-03-22 00:23:51 -07:00
koch-cf ae423a6868 GM: Buick LaCrosse 2017-19 support (#27332)
* Added Buick LaCrosse 2017

* Added Buick LaCrosse as candidate

* Added Buick LaCrosse CAR_INFO and Fingerprint

* Added Buick LaCrosse to non_tested_cars

* Added Buick LaCrosse

* Updated number of supported cars to 237

* Added ACC and LKAS description to Buick LaCrosse

* Updated CAR_INFO for Buick LaCrosse

* Added the Escalade which was recently updated

* Update selfdrive/car/gm/values.py

Suggested fingerprint by @sshane

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* Premium is a trim with ACC. Use package name instead

* lacrosse custom FF;
fit info:
describe(steer_offsets) = DescribeResult(nobs=1649402, minmax=(-0.7127894163131714, 5.3997602462768555), mean=3.3090523060153645, variance=0.3130325564084465, skewness=-1.5986155151533736, kurtosis=8.18810418298873)
Samples: 1357787
Regularizing...
Regularized samples: 1140
speed: DescribeResult(nobs=1140, minmax=(8.478170424241286, 35.837870224662446), mean=27.888804767013475, variance=34.16742353763829, skewness=-1.068587303119431, kurtosis=0.6193071765927134)
angle: DescribeResult(nobs=1140, minmax=(-21.057768565637094, 28.516874490999708), mean=-0.4328602593886506, variance=43.19046813273241, skewness=0.001966426701503317, kurtosis=0.20547357649038434)
steer: DescribeResult(nobs=1140, minmax=(-0.8432471203007578, 0.9634959333674695), mean=-0.021981142946747863, variance=0.20152217060233915, skewness=0.03202313890158864, kurtosis=-1.2318826088567174)
Performing fit...
Fit: [5.85397825e-01 3.27650818e-01 4.60531117e-03 1.32307599e+01
 1.37194709e-01 1.33099557e-01 6.14782304e-02]
ANGLE_COEF = 0.58539783
ANGLE_COEF2 = 0.32765082
ANGLE_OFFSET = 0.00460531
SPEED_OFFSET = 13.23075991
SIGMOID_COEF_RIGHT = 0.13719471
SIGMOID_COEF_LEFT = 0.13309956
SPEED_COEF = 0.06147823
MAE old 0.2098, new 0.0309
STD old 0.1021, new 0.0273
deg 00-03:457, deg 03-06:258, deg 06-09:218, deg 09-12:132, deg 12-15:62
deg 15-18:6, deg 18-21:4, deg 21-24:1, deg 24-27:0, deg 27-30:2
deg 30-33:0, deg 33-36:0, deg 36-39:0, deg 39-42:0, deg 42-45:0

mph 10-15:0, mph 15-20:1, mph 20-25:18, mph 25-30:12, mph 30-35:30
mph 35-40:26, mph 40-45:52, mph 45-50:54, mph 50-55:73, mph 55-60:86
mph 60-65:204, mph 65-70:228, mph 70-75:179, mph 75-80:176, mph 80-85:1
mph 85-90:0,

* Update routes.py

* remove from non tested routes

* use torque controller

* update docs

* update releases

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Tim Wilson <twilsonco@gmail.com>
2023-03-20 13:10:19 -07:00
Shane Smiskol 581fd62d26 steer limits: rename common dist to meas function (#27453)
* rename function

* make a wrapper function (ford uses dynamic up/down limits

* make two functions consistent

* make torque function convert to int
2023-02-26 17:32:52 -08:00
Adeeb Shihadeh 1504c10760 GM: revert steering limits update (#27413)
* Revert " GM: update steering limits (#27331)"

This reverts commit 1cdf80003d.

* update refs

* bump panda
2023-02-21 15:48:10 -08:00
Adeeb Shihadeh 2008332bd4 GM: revert custom Bolt torque tune (#27403)
* Revert "GM: cleanup torque feedforward function (#27347)"

This reverts commit 8c099dd4e5.

* Revert "Chevrolet Bolt: Non-linear torque tune (#27344)"

This reverts commit e49748d571.

* update refs
2023-02-21 15:27:48 -08:00
Shane Smiskol 79749a306c GM: add longitudinal delay to Escalade (#27406)
* add delay to escalade too

* order
2023-02-20 16:12:11 -08:00
Shane Smiskol 14d44e4444 GM: remove redundant CarController class variable (#27280)
* clean up

* fix check

* only set ts_nanos on update
2023-02-20 15:33:15 -08:00
Eric Brown c3ba2a025b GM: detect unplugged or missing radar (#27245)
* Add flashed Volt fingerprint

* Add another fingerprint

* Detect radar header message

* dashcamOnly if ASCM vehicle with radar unavailable

May be able to change this in the future to OP long off with experimental long available

* no submodule update

* Revert minEnableSpeed

* combine into one fingerprint

* Don't use GM radar DBC

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* unused

* add new FP

* update docs

* use_off_car_defaults

use_off_car_defaults

* update docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-02-20 15:28:32 -08:00
Ricky Gilleland b76795d7f0 GM: Escalade 2017 support (#27276)
* Initial 2017 Escalade values

* update docs/CARS.md

* revert back to v1 fingerprint & add test route

* revert bad merge

* update fingerprint

* update

* update

* Update selfdrive/car/gm/values.py

* Update selfdrive/car/gm/values.py

* no engine

* Try global tune

* pcm

* Driver Assist Package has ACC, and includes LKAS from previous package

* update docs

* add to releases

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-02-15 17:07:24 -08:00
Shane Smiskol 89934b35d0 Car interfaces: assert reasonable centerToFront range (#27356)
* assert reasonable centerToFront values

* comment

* fix Bolt centerToFront

* Update ref_commit
2023-02-15 16:27:00 -08:00
Shane Smiskol 8c099dd4e5 GM: cleanup torque feedforward function (#27347)
no numpy
2023-02-14 22:06:23 -08:00
Vivek Aithal e49748d571 Chevrolet Bolt: Non-linear torque tune (#27344)
* add non linear tune

* update refs

* rerun tests
2023-02-14 16:20:28 -08:00
Vivek Aithal 1cdf80003d GM: update steering limits (#27331)
* reduce steer down limit, driver allowance

* update refs

* update refs
2023-02-14 13:22:49 -08:00
Shane Smiskol 6474e16a72 GM: add permanent ACC fault signal (#27306)
* bump opendbc

* check signal

* bump opendbc
2023-02-11 00:12:33 -08:00
Shane Smiskol 5831a83c90 GM: add hysteresis to cluster speed (#27301)
* add cluster hysteresis

* Update ref_commit
2023-02-10 16:14:53 -08:00
Shane Smiskol 29ca52bc48 GM: split steering speeds (#27277)
* split steering speeds

* update docs

* Update ref_commit
2023-02-09 16:53:16 -08:00
Shane Smiskol 8f5057ff2d GM: enforce steering command message timing (#27250)
* draft

* bump opendbc

* still draft

* that's not right

* superset of the changes, 33hz

* cleanup

* this should work

* remove line

* pass it in again

* actually no need to check updated now

* now_nanos

* consistent name

* fix replay

* one line isn't that bad

switch

switch

* fix CarController tests

* Update ref_commit
2023-02-09 15:37:39 -08:00
Shane Smiskol 9aac0806e3 GM: increase min steer speed to avoid temporary faults (#27274)
* increase min steer speed to avoid temp volt faults

* actually 10.15 is safe

* Update ref_commit
2023-02-09 13:24:52 -08:00
Shane Smiskol ec6a55057f Rename GM CS variable to be consistent to the CAN parsers 2023-02-08 17:51:53 -08:00
Shane Smiskol 5b9f2c3fcd GM: refactor steering control code (#27251)
* hopefully easier to understand?

* space

* no confusing elif, move comment to relevant part

* better
2023-02-08 00:09:49 -08:00
Shane Smiskol 86d86fa9da GM: reduce steering message rate (#27201)
* Lower active rate and raise limits to compensate

* bump panda

* bump panda

* Update ref_commit

* bump panda to master
2023-02-07 23:38:05 -08:00
Adeeb Shihadeh 6fa9b555a4 rename carState.radarOffCan to radarUnavailable (#27187)
* rename carState.radarOffCan to radarUnavailable

* bump cereal
2023-02-02 11:38:09 -08:00
Shane Smiskol 022ef679e6 GM camera ACC: reliable relay closing (#27164)
* Reliable relay open

* Reliable relay close

* ign in a loop

* fixes

* we need this

* log

* comment to remind me tmrw

* ign fix

* this makes it 2x more reliable, but messyyy

* Revert "this makes it 2x more reliable, but messyyy"

This reverts commit 03401dc4a705cfacbe5a7048d95dccb6fa80d57f.

* revert non-related stuff

* comments, spaces

* a stands for indefinite article

* not applicable for non-camera acc

* something...

* Revert "something..."

This reverts commit de8a158488efd5ef257434fbc3c55aefff800cb7.

* Update ref_commit
2023-01-31 20:26:33 -08:00
Shane Smiskol 09cd0b4900 GM camera ACC: reliable relay open init (#27163)
Reliable relay open
2023-01-31 01:09:36 -08:00
Shane Smiskol 47cca343ec docs: open footnotes in new tab 2023-01-12 15:07:14 -08:00
Tim Wilson a40efbdfcc GM camera ACC: always set long tune (#26892)
* GM: set long tune for camera car w/o exp. mode

* same tuning

* update refs

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-01-09 15:01:55 -08:00
Eric Brown b994b93b16 GM: check radarOffCan in radar_interface (#26885)
Remove hardcoded vehicle list, replace with radarOffCan check
2023-01-06 16:46:21 -08:00
Shane Smiskol aab33b1c5f Lateral jerk unit test (#25759)
* stash

* more test

* less test

* clean test

* no angle

* add tolerance

* fix gm

fix gm

* test both

* lower some rates on hkg

* stash

* simpler

* bump panda

* Revert "bump panda"

This reverts commit f2137c221145cca723fe6ee3378ba947b7061965.

* only torque

* make kona pass

* duplicate __init__

* move

* half clean up

* half clean up

* more clean up

* more clean up

* fix static analysis

* calculate over 0.5 seconds

* limit to max steer

* type annotation

* calc once
2022-12-15 21:52:07 -08:00
Jason Shuler 2f83b9872f GM: add checksum to button message (#26014)
* Add GM button msg checksum

* checksum that works for both, fix missing bit

* bump opendbc

* update comment

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-12-12 17:26:30 -08:00
Shane Smiskol f36a3664b0 CarController: log steer sent to the car (#26743)
* log value sent to the car

* rename

* bump

* Update ref_commit
2022-12-10 02:03:40 -08:00
Shane Smiskol 3e2a49c6e5 GM: add Bolt EV test route (#26681)
* bolt ev!

* releases

* it's a trim
2022-12-02 22:09:42 -08:00
Shane Smiskol 860f441e2f Car interface: set common params after port (#26613)
* remove pylint exception, _get_params takes no defaults

* clean up

* mock uses it too

* unused

* unused

* fix that

* bump

* Update selfdrive/car/interfaces.py
2022-11-29 11:49:13 -08:00
Shane Smiskol 9fdbe9f397 GM Cam: log when cruise not adaptive (#26581)
* bump opendbc

* log when nonAdaptive

* Update ref_commit
2022-11-22 15:18:10 -08:00
Shane Smiskol 1367f84425 Car docs: add a make-specific init function (#26565)
* add a hook function for makes to implement custom docs logic

* don't need this

* use the pre-defined list for honda's harnesses

* one line 😎

* Update selfdrive/car/docs_definitions.py

* i didn't know you didn't need a pass!

* don't change docs order
2022-11-21 18:01:08 -08:00