mawei/dragonpilot
1
0
Fork 0
mirror of https://github.com/dragonpilot/dragonpilot.git synced 2026-06-26 16:32:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

map_helpers: pass parameters by const reference (#25701)

Browse Source 
pass parameters by const reference
This commit is contained in:
Dean Lee
2022-09-09 02:56:39 +08:00
committed by GitHub
parent 015090de92
commit d9ca45ed1b
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
selfdrive/ui/qt/maps/map_helpers.cc
+3 -3
View File
@@ -56,7 +56,7 @@ QMapbox::CoordinatesCollections model_to_collection(
return collections;
}
QMapbox::CoordinatesCollections coordinate_to_collection(QMapbox::Coordinate c) {
QMapbox::CoordinatesCollections coordinate_to_collection(const QMapbox::Coordinate &c) {
QMapbox::Coordinates coordinates;
coordinates.push_back(c);
@@ -85,7 +85,7 @@ QMapbox::CoordinatesCollections capnp_coordinate_list_to_collection(const capnp:
}
QMapbox::CoordinatesCollections coordinate_list_to_collection(QList<QGeoCoordinate> coordinate_list) {
QMapbox::CoordinatesCollections coordinate_list_to_collection(const QList<QGeoCoordinate> &coordinate_list) {
QMapbox::Coordinates coordinates;
for (auto &c : coordinate_list) {
@@ -143,7 +143,7 @@ QList<QGeoCoordinate> polyline_to_coordinate_list(const QString &polylineString)
return path;
}
std::optional<QMapbox::Coordinate> coordinate_from_param(std::string param) {
std::optional<QMapbox::Coordinate> coordinate_from_param(const std::string &param) {
QString json_str = QString::fromStdString(Params().get(param));
if (json_str.isEmpty()) return {};
selfdrive/ui/qt/maps/map_helpers.h
+3 -3
View File
@@ -21,10 +21,10 @@ QMapbox::CoordinatesCollections model_to_collection(
const cereal::LiveLocationKalman::Measurement::Reader &calibratedOrientationECEF,
const cereal::LiveLocationKalman::Measurement::Reader &positionECEF,
const cereal::ModelDataV2::XYZTData::Reader &line);
QMapbox::CoordinatesCollections coordinate_to_collection(QMapbox::Coordinate c);
QMapbox::CoordinatesCollections coordinate_to_collection(const QMapbox::Coordinate &c);
QMapbox::CoordinatesCollections capnp_coordinate_list_to_collection(const capnp::List<cereal::NavRoute::Coordinate>::Reader &coordinate_list);
QMapbox::CoordinatesCollections coordinate_list_to_collection(QList<QGeoCoordinate> coordinate_list);
QMapbox::CoordinatesCollections coordinate_list_to_collection(const QList<QGeoCoordinate> &coordinate_list);
QList<QGeoCoordinate> polyline_to_coordinate_list(const QString &polylineString);
std::optional<QMapbox::Coordinate> coordinate_from_param(std::string param);
std::optional<QMapbox::Coordinate> coordinate_from_param(const std::string &param);
double angle_difference(double angle1, double angle2);