Log more FW/VIN errors in qlogs (#25901)

* log VIN query errors

* Update fw_versions.py

* use exception

* post-commit
This commit is contained in:
Shane Smiskol
2022-09-27 20:17:42 -07:00
committed by GitHub
parent 12998520b9
commit ba1c3cda41
2 changed files with 3 additions and 5 deletions
+1 -2
View File
@@ -1,5 +1,4 @@
#!/usr/bin/env python3
import traceback
from collections import defaultdict
from typing import Any, Optional, Set, Tuple
from tqdm import tqdm
@@ -270,7 +269,7 @@ def get_fw_versions(logcan, sendcan, query_brand=None, extra=None, timeout=0.1,
car_fw.append(f)
except Exception:
cloudlog.warning(f"FW query exception: {traceback.format_exc()}")
cloudlog.exception("FW query exception")
return car_fw
+2 -3
View File
@@ -1,6 +1,5 @@
#!/usr/bin/env python3
import re
import traceback
import cereal.messaging as messaging
from selfdrive.car.isotp_parallel_query import IsoTpParallelQuery
@@ -28,9 +27,9 @@ def get_vin(logcan, sendcan, bus, timeout=0.1, retry=5, debug=False):
vin = vin[1:18]
return addr[0], rx_addr, vin.decode()
print(f"vin query retry ({i+1}) ...")
cloudlog.error(f"vin query retry ({i+1}) ...")
except Exception:
cloudlog.warning(f"VIN query exception: {traceback.format_exc()}")
cloudlog.exception("VIN query exception")
return 0, 0, VIN_UNKNOWN