pre-commit also handles pylint

.github/workflows/test.yaml

@@ -36,8 +36,7 @@ jobs:
                          external/bin selfdrive/modeld/runners $TEST_DIR
 
         # need these so docker copy won't fail
-        cp Pipfile Pipfile.lock pylint_openpilot.sh .pylintrc \
-           cppcheck_openpilot.sh .coveragerc-app .pre-commit-config.yaml $TEST_DIR
+        cp Pipfile Pipfile.lock .pylintrc cppcheck_openpilot.sh .coveragerc-app .pre-commit-config.yaml $TEST_DIR
         cd $TEST_DIR
         mkdir laika laika_repo tools release
     - name: Build Docker image
@@ -73,8 +72,6 @@ jobs:
           submodules: true
       - name: Build Docker image
         run: eval "$BUILD"
-      - name: pylint
-        run: $RUN "cd /tmp/openpilot/ && ./pylint_openpilot.sh"
       - name: pre-commit
         run: $RUN "cd /tmp/openpilot/ && git init && git add -A && pre-commit run --all"
       - name: cppcheck

Dockerfile.openpilot

@@ -78,7 +78,6 @@ RUN mkdir -p /tmp/openpilot
 
 COPY SConstruct \
      cppcheck_openpilot.sh \
-     pylint_openpilot.sh \
      .pylintrc \
      .pre-commit-config.yaml \
      .coveragerc-app \

pylint_openpilot.sh

@@ -1,11 +0,0 @@
-#!/usr/bin/env bash
-
-python3 -m pylint --disable=R,C,W $(eval echo <(find cereal) <(find opendbc) $(cat release/files_common release/files_common | tr '\n' ' ') | tr ' ' '\n' | grep "\.py$")
-
-exit_status=$?
-(( res = exit_status & 3 ))
-
-if [[ $res != 0  ]]; then
-	echo "Pylint found errors in the code. Please fix and try again"
-	exit 1
-fi