Commit Graph

28 Commits

Author SHA1 Message Date
Adeeb Shihadeh 16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b69af19306143fc4def02fb5769405d2
2023-08-20 20:49:55 -07:00
Justin Newberry 7b677910df Linter: Fix >160 line length test (#29287)
* test

* fix line length

* fix line length

* fix file size

* revert poetry

* cleanup for PR
old-commit-hash: cf64b27168614f851087adab2d7f766425922f64
2023-08-08 17:13:35 -07:00
Shane Smiskol 906c07f3e6 Nissan: explicitly copy signals to forward (#28305)
* nissan

* missing counter

* add comment from carstate
old-commit-hash: 26baac2ff4a57fa8dc7de46bd1292f2734a4d179
2023-05-25 23:12:50 -07:00
Shane Smiskol b3de62035d Nissan: set LKA active with latActive (#28055)
Update carcontroller.py
old-commit-hash: 577374215beb5807d7522d0c61f2a2021b04d388
2023-05-15 23:23:55 -07:00
Shane Smiskol ebb698b430 Nissan: use raw speed to calculate angle limits (#28097)
use vEgoRaw for calculating limited angle
old-commit-hash: cd570033d3ecf52958d26f0fb316dba5a1eb2684
2023-05-04 00:29:03 +00:00
Shane Smiskol d57006f829 cars: various small cleanups (#28031)
* finally fix subarucan formatting

* no need for intermediate variables

* make this check explicit
old-commit-hash: 9689e9c5675835a611a749c4a024551263f5daa3
2023-04-26 01:43:07 -07:00
Shane Smiskol acc8e38111 GM: enforce steering command message timing (#27250)
* draft

* bump opendbc

* still draft

* that's not right

* superset of the changes, 33hz

* cleanup

* this should work

* remove line

* pass it in again

* actually no need to check updated now

* now_nanos

* consistent name

* fix replay

* one line isn't that bad

switch

switch

* fix CarController tests

* Update ref_commit
old-commit-hash: 8f5057ff2dbea4ebc85bc8f55bc7a37e4d5969b6
2023-02-09 15:37:39 -08:00
Shane Smiskol ae26b6fb0f Car controls: common angle limiting function (#26732)
* common angle limiting function

* save a line
old-commit-hash: 41667d020ac8eb8d518e9437de32d8d9d09b6b15
2022-12-08 16:26:41 -08:00
Adeeb Shihadeh 04af978260 let can packer handle counter (#25240)
* let can packer handle counter

* diff is expected

* update refs

* clean that up

* bump opendbc

* fix sim
old-commit-hash: 0ca62bf7df0fe81829c744fd8689c9b97cb6a36b
2022-07-21 20:54:53 -07:00
Shane Smiskol 0d83812f86 Clean up CarControllers (#25008)
* do VW

* Do the rest

* unused

* ford cc formatting

* final clean ups

* also just return update output
old-commit-hash: d2c2154a32db0876036f4f6b61b912de0c90fc5a
2022-06-30 17:23:12 -07:00
Adeeb Shihadeh bd71c594a2 pylint: enforce indentation (W0311) (#24039)
* pylint: enforce indentation (W0311)

* few more
old-commit-hash: 8af20af66ddaa6bc06d7f72f9134aa9afeed3ed8
2022-03-24 23:23:29 -07:00
Shane Smiskol 3e61c7e6ae carControl: add long and lat active fields (#23859)
* proof of concept

* actuators packet describes which actuators are active

* bump cereal

* fixes

* not needed for this PR

* Do Toyota

* add back controlsState.active

* bump cereal

* rest of cars

* in actuators

* add active back

* which

* use controlsState.active for now

* will make an issue

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move local lat_active checks into CC.latActive

* remove redundant checks

* move comment

move comment

* fix joystick mode

* get enabled from carcontrol

* do standstill check in controlsd

* make sure we consider the gas press case for GM

* use CC.actuators

* fix

* capitalization

* Bump cereal

Bump cereal

* make intermediate actuators

* similar convention to before

* clean that up

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 629399a44925080b2c35b6dde35c093cc2e32035
2022-03-13 20:58:44 -07:00
Adeeb Shihadeh eabc0b5289 cars: remove duplicated cancel logic (#23956)
old-commit-hash: b9484a6a99b4abe3a0c60d83a0ad1b43926cba45
2022-03-13 20:22:49 -07:00
Adeeb Shihadeh 71da8d1250 No actuation while in pre-enabled state (#23658)
* No actuation while in pre-enabled state

* update refs
old-commit-hash: 72e00a07686fa112dde7928fa48ab4a56ed7a7f5
2022-01-28 16:03:44 -08:00
Dean Lee 98de810849 check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: a653461dec18b1313148905172ba54bac9f5fdfd
2022-01-10 16:36:51 +01:00
Willem Melching 7b3e330def Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
old-commit-hash: 4f1eb4278a83a3abebebef67a081961e27594d90
2021-12-16 13:08:20 +01:00
CrispinFlowerday 4f02e178db Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
old-commit-hash: 7458e143e3c0123a95680b0b2db6c7a1f94405fa
2021-06-07 15:06:28 -07:00
Andre Volmensky 465f57f2db Nissan altima (#2742)
* Altima port

* Add Nissan Altima 2020 to README.md

* Added Nissan Altima test route

* Fixed up checks
old-commit-hash: 11785fe32170a1394e09eed26f0868697ecea3fd
2021-02-19 23:27:55 -08:00
Adeeb Shihadeh 05eb44115e cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65ebd01abfa8493ae12c9e6b14f7ada976.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
old-commit-hash: 312b681a46b8153314a8420611b6479dd6f70dfc
2021-02-16 21:39:32 -08:00
Julian Pieles ba082ebe50 support for Nissan Leaf with ADAS ECU in alt location (instrument cluster) (#19619)
old-commit-hash: 2e32f18d064dcaf022277b46e5d1801da59145c9
2021-02-05 11:04:45 -08:00
Willem Melching 4daa6f05cf Move all CarControllerParams into values.py (#19663)
* toyota

* use scale from values.py

* nissan

* subaru

* honda

* gm

* toyota combine into CarControllerParams

* nissan refactor

* chrysler refactor

* mazda refactor

* hyundai refactor

* subaru refactor
old-commit-hash: e4cf43c6fcc2f442318df815fdc38fb26a74bdb7
2021-01-06 11:20:44 +01:00
Andre Volmensky 2809e447ad Nissan: Tweaking steeringPressed/LKAS_MAX_TORQUE (#1865)
* Tweaking steeringPressed/LKAS_MAX_TORQUE

* Update ref commit
old-commit-hash: da5dc7693edc12dd281ce365a655dab56fb62494
2020-07-20 16:30:40 -07:00
Andre Volmensky d106ccc0fb Added Rogue 2019/Leaf 2019 fingerprints (#1605)
* Added Rogue 2019/Leaf 2019 fingerprints

* Added Rogue as new car. Updated readme

* Added route to test_car_models.py. Fixed if statements to check against rogue/x-trail

* Fixed paste error

* Merged Leaf fingerprints

* Assume Rogue is MPH until we work out the mph/kph bit
old-commit-hash: 9fc826cb5c6fc46ebd0fe5c1ecd322a472da44ef
2020-05-30 20:25:32 -07:00
Andre Volmensky 218a8cb04c Nissan set speed (#1289)
* LKA_ACTIVE should be set with enabled, not cruiseState.enabled. Was causing panda violations

* Added cruiseState.speed to Nissan X-Trail

* Bump opendbc

* Remove redundant if statement

* Fix tests

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 9c16ad8e184171f8d07bfc764e89a1067f4d1086
2020-03-29 15:28:06 -07:00
Willem Melching 0d03fad5b6 Nissan leaf (#1275)
* split out leaf and xtrail

* Add brake pedal

* This should work

* Fix test car models + bump panda

* Combined cruise enabled detection in single message

* Proper frequency checks

* Add doors

* Blinkers and doors

* Seatbelt

* Gear

* Add cancel message

* Unify steering pressed

* Remove angle limit

* Add steer saturation alert for angle based control

* Add set speed

* Change wheel speed factor

* Fix offset in set speed

* Timeout on engage for steer saturated

* Put counter back

* try cancel using seatbelt

* Try different cancel message

* Rename cancel signal

* Add LKAS alert

* Add missing fingerprint values

* Update test car models

* Add some comments
old-commit-hash: 1df6b67511e0872c134edef0eb8535d71e0b2cfd
2020-03-27 21:44:59 -07:00
Andre Volmensky b4523da2c8 Nissan lane change (#1236)
* Scaled LKAS_MAX_TORQUE based on dbc change

* Bump opendbc
old-commit-hash: 6b3ff455e2639c06aa333e42e81c7f82ac34ed33
2020-03-12 14:45:24 -07:00
Andre Volmensky ff7588f6d2 Added LKAS HUD line detection/steer status/hand on wheel warning (#1225)
old-commit-hash: e0227c9a1d02e8c2edbffb1c48ec9aef0c142832
2020-03-11 12:21:08 -07:00
Willem Melching 0a47a0cb3e Nissan port - dashcam only (#1203)
* Nissan port

* add x-trail to release notes

* update readme and model

* remove from releases until tested

* Don't test Nissan for now

* Forced dashcam in test_car_models

old-commit-hash: 6db044c86cad910235a0cbcaf5f5f91775fe4e26
2020-03-05 15:40:07 -08:00