Commit Graph

473 Commits

Author SHA1 Message Date
Madnevil 0b19109c4c Honda: add FW for Civic Sport 2023 (#30316)
* Update values.py

* Update values.py

* Update values.py

* removing duplicate

* Update values.py

* Update values.py

* this is from a logging request

* Add missing FW

* bump MY

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 82291a247f13b592d5cc1ec0b25385619b283586
2023-10-25 14:57:08 -07:00
Justin Newberry 58936aa0cb Use StrEnum for car classes (#30114)
* str enum

* import sort

* fix car helpers

* fix that

* fix static analysis
old-commit-hash: 6ae465e4af76e21c6a31c541f37555f6bd0727fc
2023-09-30 17:15:34 -07:00
Shane Smiskol a48dbc33f6 Honda: add missing Ridgeline 2021 FW version (#29991)
add missing combo meter
old-commit-hash: 16f0829404947da8bdc248cf60086c053c171537
2023-09-20 02:18:57 -07:00
Shane Smiskol c5a673b998 car interfaces: handle buttons changing state without going unpressed (#26463)
* rename function first and foremost

* the function

* comment

* move usages over

* probably fine

* comments

* btn

* single line

* not comments

* fix keyword

* is it not clear?

* noEntry while holding cancel

* bumpo

* remove

* better?

* better?

* try this

* try this

* loop

* better

* more clear

* Revert "more clear"

This reverts commit 37e0277e4bfe6f1c553dbbcece6f532a280be62e.

* no optional

* fine

* add comment

* clean up honda

* one line

* can also do this

* but unclear

This reverts commit 1984a72cc8680b23c202695b8aeeb1aa28f7160c.

* bumppanda
old-commit-hash: 24f5a6170dc2e3bea9565115a09a1e20e18572de
2023-08-25 16:47:10 -07:00
Adeeb Shihadeh 16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b69af19306143fc4def02fb5769405d2
2023-08-20 20:49:55 -07:00
Shane Smiskol 1a2818d775 Revert "radard: tie radard frequency to modelV2 vol. 2 (#29240)" (#29474)
* Revert "static analysis fixes"

This reverts commit 2271d0adf9a02aee1359717c47cb6280893a6b9b.

* Revert "radard: tie radard frequency to modelV2 vol. 2 (#29240)"

This reverts commit 6757e90415766e84ad1b6c921a2edb29ceb3bbbe.

* update refs
old-commit-hash: 1a08c2986e5600dd4e84bfeaed26c74e679085de
2023-08-18 22:56:43 -07:00
Jason Young ac83f87b36 interfaces: add common STD_CARGO_KG to mass (#29416)
* cleanup std_cargo_kg

* fix Sonata mass

* remove snowflake construct

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: f76ffbdbbcef50ba201edc0349f777e4e372b515
2023-08-17 21:06:07 -07:00
Shane Smiskol 183515c04b Rename CivicParams (#29459)
* CivicParams -> ReferenceCarParams

* remove usage in interface

* better name

* revert
old-commit-hash: 8dcd108972b7a434d91dd00686de669236edf148
2023-08-17 21:02:09 -07:00
Jason Young b4614b3c28 car interfaces: cleanup tire stiffness calculation (#28263)
* cleanup tire stiffness calculation

* bump cereal

* think these todos still apply

* gm: same default

* revert comments

* bump

* update refs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 90c4bbe8e4ee11f3c1289a0dbb93262824fa430c
2023-08-15 14:17:08 -07:00
Shane Smiskol 4c47e5fd21 static analysis fixes
old-commit-hash: a1e85f3661d2a464ec452294a57e7c0462044a28
2023-08-11 18:22:42 -07:00
Kacper Rączy 4017b1707c radard: tie radard frequency to modelV2 vol. 2 (#29240)
* radard: tie radard frequency to modelV2

Accumulate parsed messages until state is updated (toyota)

Same for honda

Rename rr to something more descriptive

* Change _update method name, since signature has changed

* Update ref commit

* Some renames

* Check for number of cans
old-commit-hash: 460f5c8e0b2fd2c420e211b09b70d1d79834a929
2023-08-11 18:07:06 -07:00
Shane Smiskol 151b707901 Car interfaces: remove hard-coded signal definitions (#27773)
* What if: no signals! 🙅🤌🎆

* do hyundai

* honda!

* do gm

* and vw! (sorry comments)

* do those

* -500

* little more

* fix subie

* change back

* bumpopendbc

* oof lol

* messages

* some clean up

* here too

* clean up honda radar_interface.py

fix

rm

* bump opendbc to master

* add todo

* rename checks in tesla/radar_interface

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: cbfcc405715ae4fa45b3beea03dd82ba925495c4
2023-08-10 20:30:35 -07:00
Justin Newberry 7b677910df Linter: Fix >160 line length test (#29287)
* test

* fix line length

* fix line length

* fix file size

* revert poetry

* cleanup for PR
old-commit-hash: cf64b27168614f851087adab2d7f766425922f64
2023-08-08 17:13:35 -07:00
Kacper Rączy c92e7265a6 Revert "radard: tie radard frequency to modelV2 (#29063)" (#29243)
This reverts commit 4b221cb4fd271664ab7d39c5cfefb4225ca07c2a.
old-commit-hash: 1774b4fc61c8f92fae16545a68854238660737e6
2023-08-04 20:25:40 -07:00
Kacper Rączy 79fa322d4a radard: tie radard frequency to modelV2 (#29063)
old-commit-hash: 255f5c13f2d8c6796fd960b248856f11a3c1b05a
2023-08-03 22:10:21 -07:00
Shane Smiskol 1b5e039afd Honda: set autoResumeSng for docs (#28458)
set autoResumeSng for Honda
old-commit-hash: 7a64385fcd5354efd3bd9dcf6972669c46d99c10
2023-06-09 11:20:42 -07:00
Jason Young fa69932a0e Honda: Add FW for 2023 Honda Passport (#28343)
* Honda: Add FW for 2023 Honda Pilot/Passport

* push update
old-commit-hash: deb4b11d110cd0b437c5752d79f3bf0c48c90fe4
2023-06-02 16:41:48 -07:00
Shane Smiskol 31c1e66a01 car docs: document parts of parts (#28292)
* more stuff

* even more

* all parts func

* start to use it

* include self in parts

* use car_parts_new

* not used

* more usages

* remove get_parts

* remove more commented stuff

* remove iter

* clean up some more stuff

* more

more

* ford

* optional

optional

* nissan

* use new classes

* fix tests

* fix

* order

* no more required

* connector

* CARS.md

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
old-commit-hash: 024abe6455d44c7616ca7c694643c5324d0d371c
2023-05-31 21:30:50 -07:00
Shane Smiskol d609b70296 cars: log non-critical car faults (#28338)
* log non-noEntry acc faults

non

* adasFaulted

* bump

* bump again

* bump agaiiinn

* remove event

* bump to master

* add fixme comment and fix

* whoops

* switch
old-commit-hash: 2ff1eadb1153a26a177a55f1f29426ebf328b655
2023-05-30 20:46:44 -07:00
Shane Smiskol b5aff78ee0 Honda: use CS accFaulted field (#28339)
* log accFaulted

* bool

* also bool
old-commit-hash: 80e84a2158df7e4cacf1a21aee71206293ff7f5d
2023-05-30 15:05:57 -07:00
Maxime Desroches 734b6481b7 car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 9f5f8b603cf69b06c4804632268491cf38cfac7e
2023-05-22 10:17:33 -07:00
Maxime Desroches 4626add29c add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 70677fe5fc044bff0ea99eab6bba5a6d02d5a85f
2023-05-15 15:33:54 -07:00
ecaslak cf802d6bc1 Add fingerprint for 2022 Honda Passport (#28175)
* Update CARS.md for 2022 Honda Passport

Changed latest supported model year from 21 to 22

* Update values.py: 2022 Honda Passport Fingerprint

Added ECU fingerprints for 2022 Honda Passport

* add missing fw

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: c293cb71c713d4fff993986283220bf4c4f83d16
2023-05-15 13:57:33 -07:00
Shane Smiskol aec9b99854 Honda: Ridgeline 2023 is supported (#27979)
* Update values.py

* update docs
old-commit-hash: b9149795f10232747a8ab5b5ca37625d5a0d4137
2023-04-19 20:40:30 -07:00
Shane Smiskol d916e0ed2d Car docs: pass docs flag to car interfaces (#27311)
* docs

* docs

* docs

* docs

* use docs in gm
old-commit-hash: 5aebdb0ad0e7e527f5deb553ffd193abea02a357
2023-04-18 12:22:22 -07:00
AlexandreSato 4a7535fd17 Honda: HR-V 2023 port (#27731)
* initial commit

* HR-V is diff enought to split from Civic22

* Add US HR-V 2023

* update CARS.md

* Update RELEASES.md

* Use a alternative brake signal

* US HR-V have a weird noise in the BrakeSwitch

* Shane tunning

* this is added automatically

* sorry jyoung

* civic22_stop_faster

limit stopAccel to current safety model

* relax calib temporarily (12 deg)

relax calib temporarily (10 deg)

* compute accel (car overshoots requests at low speed)

* revert brake pressed caused controls mismatches

* fix crash

* cause a cruise fault

* Revert "cause a cruise fault"

This reverts commit 09a6469ac6fc38ebd38dd1c5d464712a15d0fde1.

* no brake error

* use alt brake

* Update selfdrive/car/honda/carcontroller.py

* change HONDA_BOSCH_ALT_BRAKE_SIGNAL to CP.flags

* Revert "change HONDA_BOSCH_ALT_BRAKE_SIGNAL to CP.flags"

This reverts commit e0f8123b33db3218f27c4b64a7b2a0b1f740860f.

* remove FPv2 from brazilian HR-V

* bump panda

* fix a bug

* revert calib threshold

* new test route

* separate pr

* update

* update that

* thought i removed this

* revert steer ratio

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 93c18105225ee03aa30d0a213ad5c4e4b1de624b
2023-04-14 03:12:10 -07:00
royjr cbc793b970 Honda Bosch Radarless: check cruise faults (#27814)
* add signal checks

* add radarless

* not yet

* nestless

* append instead

* bump

* match check above

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 882a2adc8b392f7c32d7fbaeee706f02015aef0e
2023-04-14 02:56:10 -07:00
royjr e29dcfe135 Honda: add 2022 civic video link (#27821)
old-commit-hash: eb6112e94e64857e8b80ed679d889eaf4b904e78
2023-04-07 11:20:32 -07:00
royjr 74777c8323 Honda: Added fingerprints for a 2022 Acura RDX (#27812)
* Added fingerprints for a 2022 Acura RDX

* whoops
old-commit-hash: 6381546075f75c32bd6f4a2a064ee3614b021118
2023-04-06 21:38:13 -07:00
Adeeb Shihadeh 9410a4f513 car docs: add field for min compatibility requirements (#27805)
old-commit-hash: 088cbfc9d506ab24fe79e37c0ca4dd76f3883e45
2023-04-04 17:47:49 -07:00
eFini 8fc2a81830 Cleanup: Honda interface already checks vehicle model for BSM (#27775)
old-commit-hash: a50fbe17c8b56acd3f61f2fa71fbaa8f9faa3a44
2023-04-01 15:21:26 -07:00
Shane Smiskol 730450d71e Honda Bosch Radarless: use CarControllerParams variable
old-commit-hash: 51c3f43205048948d49d1c969c71ebb46c3fc53e
2023-03-30 12:19:48 -07:00
royjr 77ce14cf0b Honda Bosch Radarless: update stopAccel to match actuation limits (#27740)
* civic22_stop_faster

* limit stopAccel to current safety model

* Update selfdrive/car/honda/interface.py

* Update selfdrive/car/honda/interface.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: fe49fbf8ec56733c0cbab45cde31df916f7a9fd3
2023-03-30 12:18:32 -07:00
royjr 37a03aa6eb Honda Civic 2022: match stock Auto Idle Stop behavior (#27722)
* honda_idlestop_timer

* whoops

* simplify

* just use stopping counter and move bosch radarless specific logic into the function

* it's actually 4 seconds

* Update selfdrive/car/honda/hondacan.py

* check equal to 0

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: e377305ea84dc6e50367f500897f553376583728
2023-03-29 19:04:33 -07:00
royjr f4d0b68a21 Honda Bosch Radarless: experimental longitudinal support (#25364)
* civic22_long

* Stock requests -4

* add standstill bit

* bump

* fix standstill

* bump

* bump

* bump panda

* Update hondacan.py

* bump panda

* add docs

* bump panda

* bump panda

* fix control_on value

* set control_off

* fix cars.md

* Update panda

* Update opendbc

* Update panda

* Update panda

* allow more braking

* Revert "allow more braking"

This reverts commit ecd2493a436a095b621d815e8b0c7591fa6b93a9.

* Update panda

* fix speed mismatch

* Revert "fix speed mismatch"

This reverts commit ca795dc5bd9d6e841225e1ac1ff93a1f78618513.

* Update panda

* fix speed mismatch and standstill

* delay stopped message to match stock behavior

* green cruise only when enabled

* Update panda

* Revert "green cruise only when enabled"

This reverts commit d21aa5b541a42fa6d1c87e3b065f720af28ff38b.

* lesser nester

* simplify

* simplify control_on

* simplify common signals

* simplify CONTROL_ON

* lessest nester

* hide speed on gas_override to match stock behavior

* tiny simplification, lesser nester

* flip common acc control values around

* move magic number to global variable

* Revert "move magic number to global variable"

This reverts commit 160be0e0872dc08a8786d97fc2125b2eb131362d.

* remove stopped logic

* remove unused variable

* looks ok

* looks better

* simplify override

* clarify CONTROL_OFF signal comment

* civic22_long_bettercontroloff

shorten delay

init

selfless

whoops

move to carcontroller

selfmore

lower time, currently take 5s to kick in

just right

deline

* Rename CONTROL_OFF -> IDLESTOP_ALLOW

This tells the car its ready to turn off the engine, which does so when the car is standstill.

* Update panda

* Update opendbc

* Update panda

* fix docs

* Update panda

* Update panda

* Update opendbc

* Update panda

* Update panda

* Update panda

* Update panda

* bump panda

* idlestop in another PR

* radarless doesn't need tester present

* simplify that

* helper

* one line is fine

* test bump

* bumpback

* disallow

* reduce diff

---------

Co-authored-by: sshane <shane@smiskol.com>
old-commit-hash: 1853d6f40edc07a49a910f6fb8cedab96e9f3521
2023-03-28 01:53:48 -07:00
Shane Smiskol cdcf06e9e2 boardd: ability to switch between ELM safety params (#27656)
* indecisive

* rename to generic FW query

* remove code and update comment

* we need this to start off, unless we set multiplexing immediately

* draft

* draft 2

* try that

* can't do this either, boardd might read Enabled after removing, but before setting new Request param

* this should work

* use one less param

* fix params

* match behavior (set all pandas to safety param of 1, disabling multiplexing for fingerprinting

* clean up (some tests may temp break)

* fix param name and sort

* time it

* yes it does matter

* add to hyundai's bus 5 query

* remove hyundai for now

* this should work

* clean up

* clean up

* flip argument around, clean up

* fix test_startup

* some clean up

* rm line

* comment makes more sense

* required typing

* clean up common type

* comments

* Update selfdrive/car/car_helpers.py

* line

* whoops, need to set before vin!

* fix debug

* annoying

* more debugging

* bug fix (needs both keys always)

* debuGG

debuGG

* Revert "debuGG"

This reverts commit 55b2f429324c0b92d5cfb2cabf8b20db1e166248.

* Revert "more debugging"

This reverts commit 02934c3403ad5270f03093508b704c151d1ccb2a.

* Revert "annoying"

This reverts commit 8b4e5e09989f9a0217e3ec1c0ba68735929b7366.

* clean that up

* bumpback

* bumpback

* every second write param

* flip

* stuff

* move up?

* fix timing out in CI

* rm
old-commit-hash: 42449b482d46565242341ca2d7e3a7255572f6a2
2023-03-23 00:14:31 -07:00
Shane Smiskol c63da0423b test: fix Honda and Hyundai tests (#27606)
test honda and hyundai
old-commit-hash: fe358102f2df380c070b3cfaed28cd3c9d2ea91b
2023-03-16 14:31:55 -07:00
javenzy d473ea8a82 Add China HONDA ACCORD HYBRID 2018 finger (#27462)
* Add China HONDA ACCORD HYBRID 2018 finger

Add finger to support China HONDA ACCORD HYBRID 2018,use ACCORDH model.

* remove FW for logging

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: d50d8de63787a09b57c294c54b6f88a1236ec2bc
2023-03-01 16:00:08 -08:00
Rob Chouinard 42626606dd Allow Honda Nidec vehicles with comma pedal to drive at max speed. (#26902)
Without this Honda Nidec vehicles with the comma pedal will drive around 2 mph under the max speed.
old-commit-hash: d4c5b8d6f4ba7606f6823ce523c66a7e270b924b
2023-02-14 22:24:13 -08:00
Shane Smiskol cc456ad691 Honda Bosch: gather available ECUs from camera (#27180)
* add flag

* actually use in fw_versions.py

* simpler

* not here

* Comment

* better name

* add param and block

* keys

keys

* block

* with a value

with a value

* add query for bosch PT bus

* different name

* fix

* .

* fix test

fix test

* add cloulogs

* mark as logging
old-commit-hash: c4b84783a003479bc105e2f7a93d5e71c2e1c38f
2023-02-14 17:55:41 -08:00
Shane Smiskol cdfd691644 FPv2: log responses from data collection queries (#27345)
* log responses from logging/debugging queries

* don't add logging FW to FW dict for fingerprinting

* flip?

* fine before

* log if extra in debug ecus

* clean up

* test extra ecus too

* Revert "test extra ecus too"

This reverts commit 8f7867844db95f48631348551551148bf504e37b.

* bump to master
old-commit-hash: f29e19cf4238199eec142f9c7eab5936874e04de
2023-02-14 16:59:20 -08:00
Shane Smiskol acc8e38111 GM: enforce steering command message timing (#27250)
* draft

* bump opendbc

* still draft

* that's not right

* superset of the changes, 33hz

* cleanup

* this should work

* remove line

* pass it in again

* actually no need to check updated now

* now_nanos

* consistent name

* fix replay

* one line isn't that bad

switch

switch

* fix CarController tests

* Update ref_commit
old-commit-hash: 8f5057ff2dbea4ebc85bc8f55bc7a37e4d5969b6
2023-02-09 15:37:39 -08:00
jayvin100 df4619fac5 Add support for Malaysian Civic 2022 (#27126)
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 603e03116e4ef8dac20f0b957c38369f6cad9c7f
2023-02-02 23:16:43 -08:00
Adeeb Shihadeh 20fbb0a8fd rename carState.radarOffCan to radarUnavailable (#27187)
* rename carState.radarOffCan to radarUnavailable

* bump cereal
old-commit-hash: 6fa9b555a435cc9639193cca516b78a22189356c
2023-02-02 11:38:09 -08:00
Shane Smiskol a928082484 Honda: test all FW is in correct format (#27078)
* test honda FW is expected

* fix static
old-commit-hash: 845a63d884ae30f03831e112e636c8d3b06dcaeb
2023-01-25 00:10:22 -08:00
Shane Smiskol 98d1decfaf Honda FPv2: log extra UDS identifier (#27076)
* Add debugging uds ID

* add comment

* remove spaces

* try chaining the queries (temp debug)

this works

* works! - Revert "try chaining the queries (temp debug)"

This reverts commit c53d0f64aecdbd6224b0fd524f96637d29320cd1.
old-commit-hash: f2966e9ef4548c6365715f8e5bd55f4e4838dcdc
2023-01-24 22:30:29 -08:00
Shane Smiskol 3703533fdf Honda Civic 2022: gather FW versions for unknown ECU (#27074)
* Add unknown civic 2022 extra ecu

* Update selfdrive/car/honda/values.py
old-commit-hash: 95d45a8d64f5e7bd54cd3e96aec83f44177a0fa7
2023-01-24 21:24:33 -08:00
Shane Smiskol 455335ac57 Civic 2022: add camera versions (#27073)
* Add fwdRadar for Honda Civic 2022

* remove debug cmt
old-commit-hash: a68633283f7269bb6ab2c2670cce0473512992ec
2023-01-24 20:36:44 -08:00
Shane Smiskol 700c143146 Honda Nidec: gather available ECUs from camera (#27071)
Query bus 0 for Nidec data collection
old-commit-hash: 1e9ac45221104923708a08a9198d35099a1df23d
2023-01-24 18:37:00 -08:00
Shane Smiskol bf31067e92 Honda: merge Passport platform into Pilot (#27061)
* Move Passport FW versions to Pilot

* lol, all duplicates already in pilot

* No Passport

* Better params for both
old-commit-hash: b2c6d5d34a1cc194aaf98c4963677a5581bf0a94
2023-01-23 20:16:50 -08:00