Commit Graph

87 Commits

Author SHA1 Message Date
ShaneSmiskol 23ea456f4f Fixup joystick (#21129)
* some common changes

* rename to joystick

* add alert and update controlsd to work with joystick

* update joystickd

* Update Joystick readme

* assume we have inputs

* only send gb or steer when engaged_toggle is true

* Update instructions

* fix --ip

* Easier to understand at a glance

* much better

* -a

* receive events and send msg in same loop

* always import

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/controls/lib/events.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* combine logic and clean up

* use argparse

* outdated, and use normal class

* rm

* bit of a refactor

* refactor part 2 / 3

* much better (3 / 3)

* Simplify

* bump cereal and update readme

* capitalize

* Update tools/joystick/joystickd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update tools/joystick/joystickd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* make joystick abstraction class clearer

* use interp, clearer without comments

* no need to use apply_deadzone

* more explicit

* define btns and axes once

* split function by use_keyboard again, but simpler

* we can use handle_button as a reset function

* need to flip sign

* remove

* invert axes map for kb, easier to read the button mapping

* apply changes from review

* new lateral log for debug mode

* bump

* add saturated

* static alert

* joystick_mode

* conditionally subscribe

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move params instantiation

* Spoof active and enabled

* Only allow car to engage

* no startup alert if joystick

* Update controlsd.py

* Should be orange not enabled, green enabled

* no more button states

* should work

* blue

* submaster conflates, so only send when we have an update

* final change

* remove msg

* clean up a bit

sort of clean up

clean up a bit

remove msg

* this was right

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* lowercase

* suggestions from code review

* forgot laptop

* bump to latest

* fixes

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: vanillagorillaa <31773928+vanillagorillaa@users.noreply.github.com>
old-commit-hash: ae77f693a26527ffbee044f852cc4185718c2433
2021-06-11 14:33:17 -07:00
Willem Melching eb0fdfecf1 Alerts documentation (#21172)
* Alerts documentation

* fingerprinting

* comment not necessary

* spelling

* openpilot

* Apply suggestions from code review

Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>

* Apply suggestions from code review

Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>
old-commit-hash: ec17fad41a851369383173530bdaa3dfbfc1c671
2021-06-09 10:58:01 +02:00
CrispinFlowerday 4f02e178db Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
old-commit-hash: 7458e143e3c0123a95680b0b2db6c7a1f94405fa
2021-06-07 15:06:28 -07:00
Adeeb Shihadeh 5dfc430d47 startup alert for no fw returned (#21177)
old-commit-hash: d4ab1f1e274bc5e36b47fb9e6f76a977e04d1f1a
2021-06-07 14:15:09 -07:00
speedking456 2bcc0c0ada Add chime to lane changed blocked alert (#21159)
* Update carcontroller.py

* Lane change blocked orange + audible alert

* Actually make it make sound

* Update carcontroller.py

* leave priority the same
old-commit-hash: 24b6b4a341bbd02551756b3e0fd5ba2120e66eef
2021-06-07 01:38:08 -07:00
Adeeb Shihadeh e7cb6f6512 bump cereal
old-commit-hash: f2a9b134980e5ef7af86da71a13f01f2b23d017f
2021-06-04 16:06:57 -07:00
HaraldSchafer f0f36a0a06 Many localizer resets alert (#21116)
* add excessive reset

* add alert

* add event
old-commit-hash: 1c926d23da0c73ceb246ca6d61db6ed1c48a1ab9
2021-06-03 09:26:53 -07:00
Adeeb Shihadeh 41f8f5c7ce per camera alerts (#20992)
* per camera alert

* bump cereal

* cleanup

* space
old-commit-hash: 12ed986333856086c774b3142659dfbaecdf654b
2021-05-21 14:53:30 -07:00
Adeeb Shihadeh 340a080c3b alert for errors in camera stack (#20932)
* camera error alert

* check crcs

* cleanup

* bump cereal

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 2defc730db18f7f9c0b08b0c8b0f6806cc513ac4
2021-05-19 21:28:16 -07:00
Adeeb Shihadeh 3fbeb1299e boardd: set can and pandaState valid flags (#20899)
* boardd: set can and pandaState valid flags

* add event

* bump cereal

* consistency
old-commit-hash: e694f0b4d6f8cfe55e2c8d36a78cf86fe0c86f1a
2021-05-14 21:26:02 -07:00
Willem Melching 523c00acdc Improve community feature alert text (#20803)
old-commit-hash: b38e57eb2b1c5b6b438fb238b1752f40b4a9e188
2021-05-03 11:59:01 +02:00
Adeeb Shihadeh ec7913cbe5 delay controls start (#20761)
* delay controls start

* shouldn't need this stuff anymore

* only delay board

* bail after 2s

* fix loopback test

* fix process replay

* update refs

* bump cereal

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: f9a961f6fb69f36f8a113246920b2d71e6af8ae1
2021-04-30 13:55:17 -07:00
Adeeb Shihadeh cc29fdfed2 less harsh steering unavailable alert when overriding (#20718)
* less harsh steering unavailable alert when overriding

* just steer

* 1s

* orange

* update refs
old-commit-hash: 836668f1050e1dbc185af7d472e2016627711aeb
2021-04-20 21:01:28 -07:00
Willem Melching ee0e80a6d4 Fuzzy match on ECU FW versions (#20687)
* Fuzzy match on 3+ ECUs

* reuse dict

* exclude some shared ecus to be sure

* show alert for fuzzy match

* use title case

* require community toggle

* refactor

* do both exact and fuzzy in test script

* update test script

* add fuzz test and lower matches to >= 2

* strip alert length

* sort mismatches

* add fw tests to test_startup

* bump cereal
old-commit-hash: e4f73fbda5c2dd07cbb15816ac1bf30b010408fe
2021-04-20 12:00:36 +02:00
Adeeb Shihadeh 99b2c0d024 Alerts update (#20567)
* steer temp unavailable should be a soft disable

* no mute

* these should be no entries

* sound

* better name

* deprecated

* make vehicleModelInvalid a soft disable

* update refs

* bump cereal

* bump cereal

* update refs
old-commit-hash: 2fa1b2572dfb63e367cfe2868da576090b227ca4
2021-04-07 12:18:58 -07:00
Adeeb Shihadeh 092db4eadc show persistent dashcam mode alert (#20483)
* always show dashcam mode alert

* show persistent dashcam mode alert

* lowest

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 367aec54d1c4c5ed8d3f651d0b2f8b80fb0ac0e5
2021-03-25 21:37:38 -07:00
Willem Melching f1dc58a5f6 make vehicleModelInvalid a NoEntry
old-commit-hash: 2ca5bf99920dd20162957f1897b461e6db746444
2021-03-15 12:15:27 +01:00
HaraldSchafer 7b243b8747 Better high speed alert message (#20322)
old-commit-hash: 0223578461bd30ef3a388891ede60c8e0d01cf8d
2021-03-11 17:01:29 -08:00
Adeeb Shihadeh 05eb44115e cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65ebd01abfa8493ae12c9e6b14f7ada976.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
old-commit-hash: 312b681a46b8153314a8420611b6479dd6f70dfc
2021-02-16 21:39:32 -08:00
Adeeb Shihadeh 966945880b Cereal cleanup (#20003)
* start cleanup

* fan speed

* cleanup dm

* fix cereal

* hwType -> pandaType

* update refs

* update refs

* bump cereal

* freeSpacePercent

* cereal master
old-commit-hash: 000bd226aa9902da01e6010bf26762fca2c20df0
2021-02-03 19:57:30 -08:00
Willem Melching 9d1220b117 manager.py broadcast process states (#19880)
* broadcast managerstate

* Remove boardd

* show alert

* only trigger on actually receiving a manager state

* add managerstate to simulation exclude for longitudinal test

* broadcast managerState in process replay

* update alert text

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: b6a220a133640c24fc596f6c3b181f5d0dd921a2
2021-01-26 14:49:55 +01:00
Adeeb Shihadeh a633eaf660 GPS malfunction alert (#19756)
* GPS malfunction alert

* fix process replay

* fix long tests

* fix long tests again
old-commit-hash: c114316d94d91f09a759f575ed915436425dd177
2021-01-14 14:45:10 -08:00
Adeeb Shihadeh 6913b7d763 remove old event
old-commit-hash: 389649d6ac67d2f55b2e0816c3c1d1f43970f925
2020-12-21 15:55:30 -08:00
Adeeb Shihadeh 91fc6d21a0 don't go onroad if internet needed (#19572)
old-commit-hash: 41b31a17566e0786b58ac0ac21cea44bc06985d1
2020-12-21 15:13:20 -08:00
Willem Melching 455145dd34 remove commIssueWarning from events
old-commit-hash: 776a67ad2e8d6141c91ed520b2fff621ab1df94f
2020-12-17 22:25:22 +01:00
Shane Smiskol aa326065b8 don't wait for 4 seconds before it starts steering again after steering fault (#19520)
old-commit-hash: 89a600884138c59397670f2513bc5d0ba0ebc2b1
2020-12-16 12:24:42 -08:00
Adeeb Shihadeh 3e6abdd8bd oneplus deprecation (#2748)
* oneplus deprecation

* lowercase

* too long

* no udpates
old-commit-hash: 6a151dcd9c9f988301368312a7969aa9f413d346
2020-12-12 12:51:12 -08:00
Willem Melching 2658685895 fix typo in event name
old-commit-hash: d5a806e564afcc1b4de0b934a6073e4695cc7f96
2020-12-03 17:07:03 +01:00
Willem Melching 2ddbb49742 Add event for commIssueWarning
old-commit-hash: 93e90898ddbd1bf85fd5809a43227f07cd15f1db
2020-12-03 16:54:54 +01:00
Adeeb Shihadeh 238b9a35c7 don't need that
old-commit-hash: 9d18b45cd0153a929cc198938ce24b74b069a6ec
2020-11-24 22:47:44 -08:00
Willem Melching 69440d8037 Typing experiments (#1633)
* add more types

* car

* no abc

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 40acdc4524eb5d3365c363ac7441daf407f4adbd
2020-11-24 22:45:37 -08:00
George Hotz 8a35cce75f remove model lag warning, leave red alert at 20
old-commit-hash: 160fd207a5087754408d829f39b24d1f1c508df2
2020-11-24 13:02:56 -08:00
Adeeb Shihadeh d2710f2fcf model lag warning (#2608)
old-commit-hash: 2d7a194f9fd5e5b26b55e3aa9e33efc95c97be6e
2020-11-23 13:42:18 -08:00
Adeeb Shihadeh f25cec394e grey panda is unsupported (#2458)
old-commit-hash: 47c21f10f598639307994392e96f4d9293b295c7
2020-11-03 19:56:25 -08:00
Adeeb Shihadeh 48e5211f23 grey panda deprecation (#2406)
old-commit-hash: d92ec9642e49f4e4681006c71e7d90cfc8bd7d1d
2020-10-26 23:09:06 -07:00
Adeeb Shihadeh b7c4c26012 camera malfunction alert (#2391)
* camera malfunction alert

* bump cereal

* fix process replay

* ugh, needs refactor
old-commit-hash: 88b956528e614dc7429d525d5d7e09b5431d7b38
2020-10-22 16:28:54 -07:00
ZwX1616 e9d58939d2 infinite sound (#2372)
* make sound infinite loopable

* Update selfdrive/ui/android/sl_sound.cc

* fix loop

* fix test threshold

* more fix

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 53bd3050ee90ca18445ddc41b837f5f927cc0c6a
2020-10-20 17:42:19 -07:00
Adeeb Shihadeh aea2faaa98 Alert cleanup (#2274)
* no more focus recover active

* consistency

* more permanent

* dm alerts

* sanity check test

* no please

* clean that up

* update refs

* one more

* bump cereal
old-commit-hash: ae4b4bd1256c11153035e4236cd801738f135c51
2020-10-14 15:56:18 -07:00
Adeeb Shihadeh 5dc58abbbe clear irrelevant alerts on state transition (#2318)
* cleanup

* clear warnings

* more types

* needs refactor

* update refs

* update refs
old-commit-hash: 1c6905cac1c5b4528e60dac3279357959c2e2bc3
2020-10-14 14:08:15 -07:00
Logan Lasiter dd0c9d0796 Present alert if fan isn't spinning (#2258)
* Present alert if fan isn't spinning

* allow entry

* Small updates

Moving to fan malfunction event

Only trigger event for uno or dos

* Changed checking fanSpeed > 50%

* Update text for fan malfunction alert.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Alert if fan isn't spinning for 5 sec

* Alert edit

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 1a2efdc139868f3588a4a35505e8833eacee735d
2020-10-07 12:15:09 +02:00
Adeeb Shihadeh 69946508db bump cereal
old-commit-hash: 70bc935210c8b948ab20f1d72fd2c6a6884d4cfd
2020-10-05 18:43:21 -07:00
cydia2020 ca29e033e9 add 1 second delay to acc pedal alert (#2221)
So that the screen wouldn't appear to "flicker" when openpilot is engaged while the acc pedal is being released
old-commit-hash: 6d5b2af3f2290d9cf99c4eee3eb9c412a069fbb4
2020-09-28 16:17:21 -07:00
Adeeb Shihadeh 6f96ed3c59 remove unused alert
old-commit-hash: cdcf2350252059e937b032ea2448584ff3c512a9
2020-09-22 13:47:30 -07:00
Adeeb Shihadeh 8221c26fab type hints for alerts and fix community feature alert (#2196)
* fix startup alert for community features

* type hints for alerts

* more type hints

* fix dashcam only alerts

* more type hints
old-commit-hash: a81a18205e85ac576a5cf5e330e3f7b99fcb4152
2020-09-17 22:06:31 -07:00
ZwX1616 6f3c2fba6e Cut down unnecessary DM uncertain alerts (#2157)
* cut down high std alerts

* clean comments

* uncertain curve tune

* update test gt

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: a2adfdb155f2293d9a2e7be11e81af8c020f011b
2020-09-14 10:43:19 -07:00
Adeeb Shihadeh 6dbfe6fb9e prevent reversing alert from showing while changing gears
old-commit-hash: a4a4e28c1a9948297d36f562aad6343294380d47
2020-09-12 17:21:30 -07:00
Adeeb Shihadeh 64a9728f2e Reduce paramsd and calibrationd CPU usage (#2119)
* reduce paramsd cpu

* reduce calibrationd cpu usage

* calibration_helpers was mostly unused

* more calibration cleanup

* update refs

* fix thresholds in CPU test
old-commit-hash: e0004d09810d9c3bcb8681bca110bf5bbd09445a
2020-09-10 12:16:29 -07:00
Adeeb Shihadeh 5b9466a76e hide camera view when in reverse (#2144)
* partially hide camera view when in reverse

* lowest priority

* update ref commit

* fix type

* update refs
old-commit-hash: 9cd88526b513250aae592761a4d554a0eae4acc0
2020-09-09 00:11:12 -07:00
Adeeb Shihadeh e17575f36d make calibrationInvalid a permanent alert
old-commit-hash: 86f4d86cd7ae704d97efea1638f1a510d950c9bc
2020-09-04 13:20:48 -07:00
ZwX1616 fca076b982 not show soft recover alerts
old-commit-hash: 9731e7a0d7af7aec44097e0028c10427681d4e8c
2020-08-27 17:59:26 -07:00