Commit Graph

1245 Commits

Author SHA1 Message Date
Jafar Al-Gharaibeh 80a6d76ce5 Mazda: Slower rate for ACC cancel msg to avoid cruise disable (#1615)
* Slower rate for ACC cancel msg to avoid cruise disable

 Sending ACC cancel message at 10hz may end up disabling
main cruise state. That is because stoc ACC use the same
signal for both functions. If cruise is already enabled
the signal canceles it, otherwise cruise is disabled.
10hz seems to be still fast in some cases not allowing
the state to sync up between OP and the Stock state.
5hz avoids that issue. Also, the resume message was also
updated to 5hz as that seems to work better as well.

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Round up 27.96 to 28mph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
old-commit-hash: 41fbce59067569d370b38f40cd1ef09b61c08df2
2020-06-01 02:04:47 -07:00
Adeeb Shihadeh 37a67a2a14 enable flake8 E502: backslash is redundant between brackets
old-commit-hash: 6466ec982aa47bcbbc7c6a3a7cf60cec0163be84
2020-05-31 17:41:18 -07:00
Adeeb Shihadeh 8b3418b0f9 enable flake8 E251: unexpected spaces around keyword / parameter equals
old-commit-hash: ebed2d1dcc53f092696b61fd1e004045c9bde893
2020-05-31 17:34:47 -07:00
Adeeb Shihadeh 9823f1164c enable flake8 E303: too many blank lines
old-commit-hash: f3dcf861c73b47c52b5dd77a8f1f8858005ae18b
2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
Willem Melching e048a1f054 Add alternate Accord tuning
old-commit-hash: 02c130731c2c041cbe95cef8717a93a0b6d67b48
2020-05-31 13:37:55 -07:00
Willem Melching 5fb17dc296 Enable new params learner for improved vehicle model estimation
old-commit-hash: a0adc4482108a3b89b6e4cb3fe27b8f51291bc08
2020-05-31 13:36:27 -07:00
Willem Melching 168ac65d9e White panda no longer supported
old-commit-hash: 106cddb49a3c60449a0413ff28dbbe50479c43bf
2020-05-31 13:33:56 -07:00
Willem Melching 60f8bb0188 Bump version to 0.8.0
old-commit-hash: ea74edf71be344b09eb9c5802405ef9aefc6b614
2020-05-31 13:31:44 -07:00
Adeeb Shihadeh be0b43f339 enable flake8 E231: missing whitespace after comma
old-commit-hash: efd5dffb1e727c70065fdbe7499ec9e009dfd282
2020-05-31 12:49:11 -07:00
Adeeb 7965569766 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
old-commit-hash: 6051061ff8e7809960cc1f2bad9a582801d5a83e
2020-05-31 00:48:47 -07:00
Andre Volmensky d106ccc0fb Added Rogue 2019/Leaf 2019 fingerprints (#1605)
* Added Rogue 2019/Leaf 2019 fingerprints

* Added Rogue as new car. Updated readme

* Added route to test_car_models.py. Fixed if statements to check against rogue/x-trail

* Fixed paste error

* Merged Leaf fingerprints

* Assume Rogue is MPH until we work out the mph/kph bit
old-commit-hash: 9fc826cb5c6fc46ebd0fe5c1ecd322a472da44ef
2020-05-30 20:25:32 -07:00
Adeeb 5e857427ba Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
old-commit-hash: d9bf9f0a4036f55411f6dfbb438990a5eb7f4930
2020-05-30 20:14:58 -07:00
Willem Melching 2ee34128d0 add some sanity checks on returned params
old-commit-hash: 4fcf47812bee79a82919799d9a9b9cac115dea99
2020-05-30 17:15:41 -07:00
Willem Melching e04d6772d8 Improved tune for VW Golf Mk7. #1603
commit 012049274fd5573bdc5d2d0f198817646dfd5a1b
Author: Willem Melching <willem.melching@gmail.com>
Date:   Sat May 30 10:40:49 2020 -0700

    update ref

commit d50cc2d81fd73dcfccfe1a8e2726879941ec5327
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:32:25 2020 -0400

    Discard no-longer-used import

commit c092e6f5092535a3b4bb5cabb6f5ecf83ef754c7
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:21:57 2020 -0400

    Improved tune from community

old-commit-hash: b5a2cec913f44438aa15b8b49e2cfee2b033c5e6
2020-05-30 17:04:38 -07:00
Adeeb Shihadeh 25f83a654e remove file that shouldn't have been committed
old-commit-hash: 18afb979fe5ef00ebb9079991a0fcbfdf3734eb1
2020-05-30 14:40:00 -07:00
Willem Melching 672b9ff1f0 add RAV4H_TSS2 EPS firmware version
old-commit-hash: d9202905449b8e2ea25ddb2ebb392eccb384471b
2020-05-30 13:38:42 -07:00
Willem Melching 5d897a743c Fix indentation in board.cc
old-commit-hash: 4cec8bcc30ed93136a0378f55bed55c34d89644f
2020-05-30 10:31:40 -07:00
Kishan Karunaratne 433cd9843a [GM] Show FCW from OP on dashboard UI / LED (#1596)
old-commit-hash: 9256530a1d41a4ad65616815f8e9ab047c63f61e
2020-05-30 10:17:04 -07:00
Dean Lee b72fcb69e2 driving.cc: Pass ModelDataRaw by reference (#1600)
* pass ModelDataRaw by reference

* pass NVGpaint by refer
old-commit-hash: af36aa28abeb55a4445cbc1ff13ac55993d989d9
2020-05-30 10:08:44 -07:00
Erich Moraga 0df6d7d187 CAR.SIENNA Engine, ESP, and DSU f/w was missing (#1597)
DongleID 307249a92f279059... verified working via TeamViewer, as FPv2 switched to `fingerprintsource = fw`
old-commit-hash: 94b2d4d522108c8897b89a1c0727b394ad3c5892
2020-05-30 10:07:23 -07:00
Yahya Lmallas 8e6224cfd2 Call to gmtime is potentially dangerous (#1598)
* Call to gmtime is potentially dangerous

* Revert "Call to gmtime is potentially dangerous"

This reverts commit cc531e4e1969f7a615230d8462f0be3258ba3378.

* Call to gmtime is potentially dangerous

* oops

* not a pointer

* Little identation fix
old-commit-hash: 3ddbb7fe5baac45b561f9c0efbac05e2f552637c
2020-05-30 10:06:29 -07:00
martinl e8fea4d187 Add Subaru blindspot monitoring signals (#1374)
* Add blindspot signals to carstate

* Change blindspot signals to boolean
old-commit-hash: 7b54dad0b8635d745d976073cd6551beee7177e5
2020-05-29 23:32:51 -07:00
VirtuallyChris 29287c3939 Add Camry Hybrid 2018 Engine FW
old-commit-hash: 3d7cd9ec78c07d25489078c890bee4249475ef68
2020-05-29 17:26:05 -07:00
Adeeb Shihadeh 974b9317bc update refs
old-commit-hash: 2d898bc0edb2cef132e90c695e77911c2720c026
2020-05-29 12:41:20 -07:00
Adeeb Shihadeh 2feaebfc80 break canError into two separate events
old-commit-hash: 916448af25d61a9acf1d35356fafccdfc800c440
2020-05-29 12:00:41 -07:00
Jafar Al-Gharaibeh a476d51333 Bounty: Mazda (#988)
* Mazda Port

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update checksum to account for steer angle signal used in some cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add test drive/segment ID to pass CI tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Process gear and brake signals, add new fingerprints

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor some car interface code

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop redundant call, use Ecu, move warning to carstate, fix cruise speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop unused variables, cleanup handsoff tracking

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update to steerError and steeringRate

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor parse gear, update lkas signals from the new dbc

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Better tracking of engage and warning events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* remove commented lines, update speed_kph to match panda

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Steer Error

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Set lkas enable speed to 52 kph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop block signal use, fix LGTM alerts

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* When gas is pressed OP will disengage, sync local state with it

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use car's speed signal instead of wheel speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Tidy up disengage events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Rebase/Refactor with upstream

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Sync stock ACC state with OP

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* mazda dbc file renamed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Improve acc stock and go by removing the 3 seconds limit

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Dashcam

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* PR Feedback

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Send ACC cancel only if we are sure cruise is enabled

Otherwise we run the risk of disabling main cruise

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* updated route

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* no process replay for now

* add to release files

* Revert "updated route"

This reverts commit 233db4f1bc2d8eefaa86488be4f6f88360d20793.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 34b9b5e849fcd192bbd8c3060ce725ef61d725ab
2020-05-28 22:15:19 -07:00
Adeeb Shihadeh 5ab1d48f90 Fix below steer speed alert text not updating
old-commit-hash: 7961d5ffd71328f4e104c01244cc6e08152d76fa
2020-05-28 20:39:13 -07:00
Willem Melching 2ac27def5a Running pre-commit in CI (#1590)
* Running pre-commit in CI

* fix dockerfile syntax

* dont run on submodule repo folders

* Fix some import errors in ci

* more stuff

* That should be the last one
old-commit-hash: ba2ac1207a554d277e01af5b9514de4500d4f66a
2020-05-28 15:40:48 -07:00
Dean Lee 7db5410f10 UI: better read_model (#1586)
* update model struct inplace

* refer params

* pass path by refer
old-commit-hash: 108a13ead84ea5f06bba77d81cae371a08c020c6
2020-05-28 15:10:49 -07:00
Willem Melching 2b60ee9531 Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
old-commit-hash: 3d08dcc3b27936cb14c0eae63605be9a6c077380
2020-05-28 15:05:04 -07:00
Willem Melching 4022d92155 make pre-commit pass without xx present
old-commit-hash: bee15f8abef98b35d070e931d5b34fd01ca8128e
2020-05-28 13:20:28 -07:00
Willem Melching 4489056d30 bump opendbc
old-commit-hash: 44851ae93441fc918fabde908078058befde8323
2020-05-28 11:53:17 -07:00
Erich Moraga 1bcac33021 Added CAR.COROLLA_TSS2 EPS f/w x018965B12520 (#1587)
As seen in Discord, for DongleID/route 35794509ea3b423e|2020-05-28--14-51-06 (Euro Toyota Corolla Hatchback Hybrid)...
https://discord.com/channels/469524606043160576/524327905937850394/715579226186579985
old-commit-hash: 2bcab668d4db5ca940d6f82ee43dd486f13cad3a
2020-05-28 09:07:07 -07:00
Willem Melching 12a306021d flake8 in pre-commit(#1583)
old-commit-hash: 29aaa44740b5dae3c1cc0c273c72c7eb53135e5e
2020-05-27 20:33:05 -07:00
Willem Melching c0866d9edb pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
old-commit-hash: bd0643424357864287ae0485da03f66df85e1fb1
2020-05-27 20:00:14 -07:00
Harald Schafer 2fca7f3900 Revert "better values"
This reverts commit 7ac7e5f994b1e9311d50c595706dd92ca38f6205.

old-commit-hash: 5a841c28560e79f613f1f4e2fcd72877bb42379d
2020-05-27 17:11:27 -07:00
Willem Melching 03a268fd0b add gpsOK flag to liveLocationKalman
old-commit-hash: 8ea8f405db489f262d396989626209a3e92b23ac
2020-05-27 15:14:13 -07:00
HaraldSchafer 3488486258 Minor fixes (#1571)
* was 5 seconds not .2!

* threshold for moving car highers, this can give FPw
old-commit-hash: 67017d69fe02d9ed6a9cfba54565a403e59afcc4
2020-05-27 14:35:01 -07:00
Harald Schafer 4974754159 better values
old-commit-hash: 109ba298b118e79644c7513eed6d08ace00abf83
2020-05-27 12:16:05 -07:00
HaraldSchafer 9dae9d6910 pure init (#1569)
old-commit-hash: 7c8d6cbdeff7b6c7ea5af9c4ed8843fea97c58a1
2020-05-26 20:49:14 -07:00
Adeeb f4ef9ae00a Remove incomplete Hyundai Ioniq port (#1570)
old-commit-hash: c78602e8ccf242be6f8a1806ba9e2f0e4f79275b
2020-05-26 20:48:41 -07:00
Adeeb Shihadeh 4221ed5d56 update refs after radarState fields populated
old-commit-hash: a1ffcdd2535b82ff1883879bd53a16f17042419f
2020-05-26 18:12:12 -07:00
Adeeb Shihadeh 6f0c5834e7 Fix blank mdMonoTime and controlsStateMonoTime in radard
old-commit-hash: 2ecc7d9f6f85818765da23cfac614d186111abb7
2020-05-26 17:53:55 -07:00
Thaixican 53a18127e6 Add 2020 Lexus RX Hybrid support (#1547)
* Add 2020 Lexus RX Hybrid support

* Add 2020 Lexus RX Hybrid to IGNORED_FINGERPRINTS and route to test_car_models per @pd0wm
old-commit-hash: dd16990952980bfd5c8eac919309052be084a7ee
2020-05-26 13:49:18 -07:00
Willem Melching 56bddd9105 Fix #1566, athena status flicker in sidebar
old-commit-hash: 4de2c57bd104b18557a0364f7b3e08aa1df45827
2020-05-26 13:41:02 -07:00
Willem Melching 91f1082394 -Werror (#1567)
* werror

* -Wno-inconsistent-missing-override

* Silence ffmpeg deprecation warnings

* add some more pragmas to ignore warnings

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 50f3f1d3357b356c5b1144c518f35375f5bb9924
2020-05-26 13:27:01 -07:00
Dean Lee 38e7d99d2f change light_sensor to atomic variable (#1560)
old-commit-hash: b3ab7ae3921e19c237284ec02683e739e68387f3
2020-05-26 09:59:49 -07:00
Dean Lee 9d31c0194f reduce the scope of mutex (#1561)
old-commit-hash: d5858955ee5aa9c8fae7c9f26e7754e86353377a
2020-05-26 09:57:14 -07:00
Tunder (Chris in RL) bcb52c06b9 add missing 2020 stinger value (#1565)
1371: 8 (not always present on startup, causes intermittent dashcam mode)
old-commit-hash: a63814866bfa561e3fb6a57f916f9c09e147bb30
2020-05-26 09:43:05 -07:00