Commit Graph

142 Commits

Author SHA1 Message Date
HaraldSchafer f7edd5f3d3 Car interface: set max lateral torque from table (#24789)
* json

* better naem

* Read from table

* formatting and default to nan

* Generate docs

* Read from table

* this should be the same

* Prius v is full

* test we always set the tunes correctly

add to release files

* Set for all cars

Set for all cars

* Revert tuning changes

Revert tuning changes

* remove that

* fixes

* update ref commit for new maxLateralAccels

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 3066ad81a8b2f89a22ddfc86a879395c573ce0f5
2022-06-10 17:57:23 -07:00
Adeeb Shihadeh 25b55d4b98 bypass HDA2 dashcam with file (#24803)
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 53724e8b6cbcfc6c9d49ebd0834624fa23d0f6e9
2022-06-09 19:29:54 -07:00
Shane Smiskol cc9e67d5ac Hyundai: Tucson 2021 support (#24791)
* add support for 2021 Hyundai Tucson

base configuration and fingerprints

* fix fcw again and don't use mando radar for tucson

* last fixes for working tucson

* Apply suggestions from code review

* add to cars

* increase steerRatio

* missing car info

* one platform

* rename

* add min enable speed

* update releases

Co-authored-by: bluesforte <harry3b9@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 47f80e7add8635e2d80a395f72906cd40c956459
2022-06-09 17:44:58 -07:00
Shane Smiskol 1a2bf8412c Car documentation: set steering torque star using car interface (#24709)
* Set good torque using torque controller tuning

* should be equal to

* save lateral accel to car params

* use maxLateralAccel

* always

* same convention

* nan will always evaluate to false

* The great good torque purge

* adjust default friction

* Add data for more cars

* adjust name

* Welcome back, guys. Only adjust good torque if maxLatAccel is set

* Update refs (1.7 is 1.7000001...)
old-commit-hash: c6bc03311c04bec31677170782d5f3e1f404c2a7
2022-06-03 17:41:20 -07:00
Shane Smiskol 7a2d0b64eb Hyundai longitudinal: handle mid-press button change (#24674)
* send additional button event for previous if we switch buttons mid-press

* add comment

* remove

* comment
old-commit-hash: dd10a83708a17b04fb9b217c7fee4234b8ed7dfe
2022-06-02 01:27:34 -07:00
Shane Smiskol ddf2d5b63c Button-enable cars: common functions for button events (#24678)
* function for creating button events

* fix

* one line

* alphabetical

alphabetical

* only needed once

* common function for enable events

* add to list

* extend

* fixes

* add type hints

* flip around
old-commit-hash: eed6803ccc55ecbfab4bd52a7ea62c9942243aea
2022-06-01 12:03:34 -07:00
HaraldSchafer 39886246c9 Rerevert torque control (#24649)
* Revert "Revert torque control (#24565)"

This reverts commit 93f434d047a92366c4ccefeece86fe101ed98d02.

* Move tune out of car specific stuff

* Update ref commit
old-commit-hash: d9289721503976cd99ac90216c502a841988c1a6
2022-05-24 17:52:33 -07:00
Adeeb Shihadeh 46ff882add Kia EV6 (#24485)
* ev6 squash

* test route

* cleanup

* remove those

* resume spam

* setme

* more reliable button pressing

* new steer signals

* for now

* update docs
old-commit-hash: 53a134f1c35502729eb758c8ebb18f59f9dacde5
2022-05-23 19:16:17 -07:00
haram-KONA 561e9bac2f Hyundai: fix wheelbase and steeringratio for Kona, Kona HEV , Kona EV (#24464)
* Update interface.py

* Update interface.py

* Update selfdrive/car/hyundai/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 0926c269af9ac821cbeda319de2dd34f851bebe5
2022-05-12 15:16:36 +02:00
Shane Smiskol 5469375c91 HKG: only allow engagement on user button press (#24140)
* use deque for prev_cruise_buttons

* stash

* disallow engagement if resume or decel isn't pressed

* fix buttons

* reduce chances of causing 30-frame fault

Fix clu11

drive down cancel times

* Revert "reduce chances of causing 30-frame fault"

This reverts commit 0f54c051bf5a22b1f584718ec46e78bc3a82a0dd.

* consider pause/resume button

* stash

* Revert "stash"

This reverts commit 551ca7be6c45729f0747abc81cd81894cd621c32.

* sadly some cars need 8 op frames (identical to 4 updates from CLU11)

* add main button

* 6 should be safe

* use max

* clean up

* change to 4 samples and process all messages received, like panda

* bump panda

* test: replay segments with known re-engagements on-device

* Revert "test: replay segments with known re-engagements on-device"

This reverts commit 9730c3c14f942b82b6ed5ef2e81b8ae0126f3006.

* need prev_cruise_buttons as we don't run every CAN message through carstate

* more generic

* extend

* Update selfdrive/car/interfaces.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* 3% faster at 1000000 loops

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: efa98d2a0694b9a33a2fda3bebfae50fb4ba33cc
2022-04-26 13:27:28 -07:00
Jason Wen fc6d8b7d7b Hyundai: Car Port for Ioniq Plug-in Hybrid 2019 (#24089)
* Add car port: Hyundai Ioniq Plug-In Hybrid 2019

* Add additiona FW version

* Add test route

* Add test route - fix typo

* Update CARS.md and RELEASES.md

* remove from legacy safety mode

* Update carcontroller.py

* Update to INDI lateral tune

* update spacing and capitalization

* generate docs

* Update selfdrive/car/hyundai/carcontroller.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: f6034ecece7cad2d3b33833235800bfe89a0769c
2022-04-18 15:15:38 -07:00
Adeeb Shihadeh 3789587df1 add alert for CAN bus timeout (#24162)
* add alert for CAN bus timeout

* add alert

* set in interface

* cleanup

* cleanup

* add event

* fix mock

* bump

* bump opendbc

* update refs

* return reader
old-commit-hash: 49c2164814e07c1243ef2b979957760d64c9eb35
2022-04-12 22:58:34 -07:00
Jason Wen c1771aba84 Hyundai: Car Port for Tucson Diesel 2019 (#24082)
* Add car port: Hyundai Tucson Diesel 2019

* SCC + LKAS trims only

* Add test route

* Update CARS.md

* remove from legacy safety mode

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 6214991d9861fd3bb425fa1133a847c3a24342d4
2022-04-08 11:32:18 -07:00
Shane Smiskol f23e6da50f Hyundai: clean up CarInterface apply function (#24000)
* clean up Hyundai CarController

* remove
old-commit-hash: 7a2f3c023e0054d1a8fd64b004f8185611323de6
2022-03-18 21:08:15 -07:00
Shane Smiskol e426e2ba2b Hyundai: set radarOffCan by radar DBC (#23981)
old-commit-hash: 3a7edeea32cc3afa31c3ae227d5729b8ab6fb365
2022-03-16 20:27:21 -07:00
Adeeb Shihadeh 3327348aeb don't read params in car interfaces (#23978)
old-commit-hash: bae78dd46b817bea26c6de05322eed5cab0bfba8
2022-03-16 15:17:47 -07:00
Adeeb Shihadeh 94e02bcb3f add parkingBrake to carState (#23968)
* add parkingBrake to carState

* fix gm
old-commit-hash: ae19308e83991c4809a785bb698d300cf7afe7e1
2022-03-14 16:32:20 -07:00
Adeeb Shihadeh 805a00b5f3 cleanup selfdrive/test (#23967)
* move test routes and test_models

* move fingerprints

* little more

* remove that
old-commit-hash: 8718a5933049d5934cc53ef31af9b5ded3223a7c
2022-03-14 15:46:16 -07:00
Adeeb Shihadeh ec47e0fef0 break up selfdrive.config (#23959)
* break up selfdrive.config

* add to release files

* fix import order
old-commit-hash: 5c3f3e44bc7b25c9ce502419bcd0261c12ec2b0d
2022-03-13 21:42:39 -07:00
Shane Smiskol 3e61c7e6ae carControl: add long and lat active fields (#23859)
* proof of concept

* actuators packet describes which actuators are active

* bump cereal

* fixes

* not needed for this PR

* Do Toyota

* add back controlsState.active

* bump cereal

* rest of cars

* in actuators

* add active back

* which

* use controlsState.active for now

* will make an issue

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move local lat_active checks into CC.latActive

* remove redundant checks

* move comment

move comment

* fix joystick mode

* get enabled from carcontrol

* do standstill check in controlsd

* make sure we consider the gas press case for GM

* use CC.actuators

* fix

* capitalization

* Bump cereal

Bump cereal

* make intermediate actuators

* similar convention to before

* clean that up

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 629399a44925080b2c35b6dde35c093cc2e32035
2022-03-13 20:58:44 -07:00
Shane Smiskol e57c3413df Hyundai: move unused cars to dashcam only (#23767)
* Move OptimaH to dashcamOnly

* Elantra GT also has no users for a year

* Update selfdrive/car/hyundai/interface.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 7176f5c4013e09142bfac577952b4a524db77cfb
2022-02-15 14:07:13 -08:00
Adeeb Shihadeh 71da8d1250 No actuation while in pre-enabled state (#23658)
* No actuation while in pre-enabled state

* update refs
old-commit-hash: 72e00a07686fa112dde7928fa48ab4a56ed7a7f5
2022-01-28 16:03:44 -08:00
Dean Lee 98de810849 check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: a653461dec18b1313148905172ba54bac9f5fdfd
2022-01-10 16:36:51 +01:00
Shane Smiskol d05c173fe6 Longcontrol: remove starting state (#23328)
* remove starting state

* new ref

* ready for merge

* try this

* cereal now on master

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: cf9792dc536db343447cfa64edecc72565c4eefd
2022-01-04 15:40:39 -08:00
Dean Lee 0a762c27ce interfaces/apply: follow capnp best practices (#23371)
old-commit-hash: 05b905d140cc920f25cf654c81371ede997892d1
2022-01-04 11:34:49 +01:00
Jason Wen 5eeb916f0e Hyundai: Car Port for 2022 Santa Fe Plug-in Hybrid (#23332)
* Add car port: Hyundai Santa Fe Plug-in Hybrid 2022

* Add test route
old-commit-hash: bd399693b6e2239522e06d6c10d5f2938a06f0d2
2021-12-31 17:28:07 -08:00
Willem Melching 7b3e330def Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
old-commit-hash: 4f1eb4278a83a3abebebef67a081961e27594d90
2021-12-16 13:08:20 +01:00
Adeeb Shihadeh 66aac35dd9 Hyundai: remove longitudinal whitelist (#22976)
* Hyundai: remove longitudinal whitelist

* move legacy safety mode into values.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 9abfc02148ea6fa5552f3f1563cf6d5310b73044
2021-11-19 14:20:03 +01:00
Andrew d9d7a55099 Genesis G70 2020 port (#22692)
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 2a6816b8935d3f4a863e42b37361c7ef6f104ddf
2021-11-18 20:45:32 -08:00
Cruise Brantley b63bc90632 Hyundai: Add Elantra to allowed longitudinal cars (#22974)
old-commit-hash: d77438b4e3cc4b1b3e9af778d3c5beab61421060
2021-11-18 18:41:09 -08:00
Jason Wen 65b9766e22 Hyundai: Car Port for 2022 Santa Fe Hybrid (#22962)
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 73d66ada8dbd8a2aaea9ffbc333d6d53f5c44bdc
2021-11-18 17:33:10 -08:00
sshane 8472503305 Toyota: handle brake hold (#22810)
* disallow engagement if brake hold active

* we can check once

* move to common events

revert

* fix

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: a0e5eccb70ac9209307d0994252f5bf089ae48ae
2021-11-08 14:26:30 -08:00
Willem Melching 3a83022853 assert openpilotLongitudinalControl not enabled for Hyundai legacy safety mode (#22778)
old-commit-hash: 246a52166ebf94fbea7bb45cfd0c4896b35b3a6c
2021-11-02 11:22:38 +01:00
Jason Wen 618e4c64e1 Hyundai: Car Port for 2022 Hyundai Ioniq Hybrid (#22610)
* Add car port: Hyundai Ioniq Hybrid 2022

* Update RELEASES.MD

* Update CARS.md

* Add test route: Hyundai Ioniq Hybrid 2022
old-commit-hash: d01c340f1fec72b8d13ded7076cfe2f77034e441
2021-10-19 16:59:10 -07:00
Greg Hogan 824e71c885 hyundai: match stock when aeb is disabled (#22580)
* match stock when aeb is disabled

* add comment about instrument cluster warning
old-commit-hash: 3b60a250106063b81e6e46997eafd80ae7bea7af
2021-10-18 10:55:53 -07:00
Robbe Derks 58c99158a1 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
old-commit-hash: 91987f38d425e2a5dc61d09571933cffb9536113
2021-10-08 17:54:34 +02:00
Greg Hogan cfa43cec71 Hyundai Palisade: adjust tire_stiffness_factor (#22444)
old-commit-hash: c1a8fe143f2503dc39af88a6473847d55d257a3a
2021-10-07 10:46:42 +02:00
Lee Jong Mun f569655e61 hyundai clean up interface.py (#22408)
* Update interface.py

santa_fe / santa_fe_2022 same value 
kia_k5_2021 single value

* hyundai fw sort

# fwdRadar, fwdCamera, eps, esp, engine, transmission

kia ceed esp double fix 0x7d4 eps

* Update selfdrive/car/hyundai/interface.py

* Revert "hyundai fw sort"

This reverts commit 8ab24ffeeb84c3cb11f5fa44ae45fa35ed50ac06.

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: de88349ef045a1529d140772284c7f7208d97a26
2021-10-05 09:41:20 +02:00
Jason Wen 5c5ca61e4b HKG: Car Port for 2021 Kia K5 (#22347)
* HKG: Kia K5 2021 Car Port

* Update CARS.md and RELEASES.md

* Add test route: Kia K5 2021

* Update firmware format due to recent query change

* Update CARS.md: not all 2021 Kia K5 have SCC

* Update test_routes.py
old-commit-hash: 6018bda2bac3e383228de84475fc79fb7f8205aa
2021-09-30 14:35:14 -07:00
Adeeb Shihadeh 821f1f6cb6 remove community supported cars from community features (#22330)
* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
old-commit-hash: 649af76fd4ade524df8eb6c56cc8bb09b3772e7c
2021-09-23 17:34:52 -07:00
Jason Wen a0e9d9b02c Hyundai: Car Port for 2022 Hyundai Santa Fe (#22325)
* Add fingerprint: Hyundai Santa Fe 2022

* Update LFAHDA_mfc: Add 2022 Hyundai Santa Fe

* Add car port: Hyundai Santa Fe 2022

* Add test route: Hyundai Santa Fe 2022

* Update RELEASES.md

* Update CARS.md

* Update RELEASES.md

* Remove FPv1 due to deprecation
old-commit-hash: 9acc592cd938739f9147f9f711a9de1d0f826d2e
2021-09-23 16:03:28 -07:00
Greg Hogan 68b0b43f15 hyundai: resume from stop faster (#22274)
* hyundai: resume from stop faster

* update ref_commit
old-commit-hash: 793ceb6b560214aa5cf84dd1ecc0ef5aedbfe8d3
2021-09-23 13:20:25 -07:00
Cruise Brantley 3628c92892 Radar tracks for Santa Fe (#22270)
* Radar tracks for Santa Fe

* add radar DBC

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 75730c28caa1a08f83893a82ab9e877d21171749
2021-09-21 15:04:14 -07:00
Kyle Greenlaw b7ceb31c26 Add Hyundai Sonata Hybrid Radar FW for OP Long support (#22259)
* add mondo dbc to Sonata Hybrid

* 2021 Sonata Hybrid radar FW

* Add Sonata Hybrid to openpilotLongitudinalControl

* Whoops... ,
old-commit-hash: 839147a333e2f671994bd4f84c9bb1e64660d92d
2021-09-17 19:12:54 -07:00
Willem Melching 4e529f843b Hyundai radar parser (#22241)
* add radar parser for 0x5XX range

* fix speed

* enable based of fingerprint

* fix speed scale

* use proper signal names

* add to release files

* hyundai: script to enable radar points

* typo

* add comment

* fix tests

* cleanup

* add note about persistent

* Update selfdrive/car/hyundai/radar_interface.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* fix bugs in hyundai enable radar points script

* accidentally removed comment

* add some other cars

* add cosine to dRel

* fw versions do not match openpilot

* bump opendbc

* include state 4

Co-authored-by: Greg Hogan <gregjhogan@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 6fd980c63e803b433c25e75e423193cef9287f9c
2021-09-15 15:43:01 -07:00
Willem Melching d688b62c62 Add upper/lower bounds for longitudinal lag (#22235)
* Add upper/lower bounds for longitudinal lag

* add ref

* update ref

* bump cereal

* bump cereal
old-commit-hash: 417e229624583a3a618aaf7fe6bd48162dfc35b6
2021-09-14 18:57:16 -07:00
Willem Melching a8ce1288fd Hyundai longitudinal prerequisites (#22121)
* panda

* bring over changes

* dont check car model

* remove comment

* fix typo

* more stuff gated behind long

* not

* not used

* gate that too

* try honda tuning

* clip accel values

* fix up merge

* fix stopping

* add retry logic around knockout

* increase timeout

* keep flipping lead bit

* true for now

* less tuning

* update comment

* 0.1 s is fine now

* merge honda and hyundai knockout

* more lead fields

* another obj bit

* increase timeout

* fix stopping flag

* only lag compensate for braking

* no lead

* less tuning

* only do knockout if not readonly

* try controlling using jerk

* tuning

* try higher stopping rate

* set stopping flag at higher speed

* clip upper jerk when stopping

* remove comments

* tester present 1hz

* use positive start accel

* 1.0 to maybe improve low speed stuff

* no point going over 0

* bump panda

* bump panda

* revert that change

* update ref
old-commit-hash: c4bac6bd68ce2a91beb15bb4f4472d76525288e0
2021-09-13 22:03:08 -07:00
Willem Melching b079219b93 Use CP.vEgoStopping and clean up CP.startAccel (#22199)
* use CP.vEgoStopping and clean up

* update ref
old-commit-hash: 1e62b09e5dd70cae6721d2da9f7bcef59aa87c10
2021-09-11 17:13:30 -07:00
speedking456 e9ebd076f7 Remove Kia Seltos from Legacy Safety Model (#22179)
old-commit-hash: 1f639e38b2577c9f2db69b9ddc97e31ab926849f
2021-09-10 08:19:58 -07:00
HaraldSchafer a73a820338 Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 1ac89f14aa7c45c56049e8dbb0d6c5bb83a0fc6b
2021-08-30 09:32:52 -07:00