* re-enable test_models
* now?
* Remove bad Volt segment
* Update Jenkinsfile
* use first n segments
old-commit-hash: fb235238addb73e04f59fca941040e3785be103e
* check relay malfunction in test_models
* draft
* actual relay malfunction (or ASCM was turned on)
* rav4: not dashcam and op enabled, but we're not sending anything
* clean up
* spaces
* more space
* flip
* better?
* combine
* for
* move up
old-commit-hash: 1099b3486a8c38c56873caceac88ea252f972771
* enable flake8-builtins
* replace any with contains
* fix typo in pack
* fix type
* format is from the parent module, has to be enabled
* item_id
* fix item_id
* disable for id since that's what the remote server returns
old-commit-hash: 8793cbff40662a92bff16d75b51479c80517305a
* move to openpilot
* draft
* support internal urls
* not used
* update seg list
* regen segment list
* regen seg list
* regen
* regen
* regen
* no dirty segments
* regen seg list with no fuzzy or fixed fp
* regen segments with hda2 exception
* regen with added filters
* regen without bad dongle
* regen
* regenerate!
* regenerate, only OP enabled
* regen
* regenerate!
* regenerate!
* stash
* use SegmentName
* new route list
* add temp comment
* remove comment
* let's see if this works
* comment out other tests to speed up
* fix agent
* ?
* hmm
* oh whoops...
* add matrix
* fix
* how many levels do we need?
* fix values
* matrix can't be in parallel
* how about this
* try this
* Revert matrix
Revert "try this"
This reverts commit 8d0d91fd70c467c1fbb4e4e9aed511d15b2a30ef.
Revert "how about this"
This reverts commit a8e4fc53234824e77cbfb1e471277bc033e9dea1.
Revert "matrix can't be in parallel"
This reverts commit daaa6fcc3c75c74cbb90e97c565099a94123994c.
Revert "fix values"
This reverts commit df554b6a3371d124a574eb8d26bc51ef5b5b8fde.
Revert "how many levels do we need?"
This reverts commit 1a17320fa1c5e7220ef60e29981bbb3bb7da16c6.
Revert "fix"
This reverts commit e7eb6e404358fbd2eac3fea1901a8d30ea92d729.
Revert "add matrix"
This reverts commit a1b57e5725417d3c2f639f8edfc0c889b84b6753.
* use pytest instead! (5 jobs is ~150 mins)
* split lines, uncomment
* This Sienna seg has a fault SDSU that stopped forwarding/sending msgs
* picked a route with no PSCMStatus and no panda errors, recent routes are working
* this cadillac was dashcammed (no radar)
* opened an issue for this, it's 'expected' right now
* small clean up
* small clean up
* i don't think that worked
* is this needed?
* add to new PC tests
* cache
* draft
* Revert "draft"
This reverts commit 3b7f740dd4883118747300bc3687074c2d3c2116.
* probably should be function
* draft
* clean up
* add todo
* 600 random segments
* debug
* does this fix pythonpath issues?
fix
* try this
* mount?
* pytest again!
* no need for PYTHONPATH now
* Update Jenkinsfile
* ?
* convention
* clean up
* would be even more complex (have to unset ci which is class level)
* track
* is lfs pulled at all?
* ah no it's not
old-commit-hash: 70b1e9dd756cd2f6929cdf33dd1061a33f3b52b1
* test
* draft
* draft
* clean up
* clean up
* better test
* clean up
* check car info
* uncomment
* rm space
* no loop
* use dbc
* more clear
* one line
old-commit-hash: 225ed2ed5a7221974e44c6d1307f959678f237ea
* test
* draft
* draft
* clean up
* clean up
* better test
* clean up
* check car info
* uncomment
* rm space
* no loop
* use dbc
* more clear
* one line
old-commit-hash: 6a678cde6c3ed95ffb5d7236108e9a317517370b
* draft
* assertrue
* this is way too complicated, even with unittest discover
* works
* test we can send resume button
* nice catches this
* fix
* fixed
* not needed
* draft
* works
* comment out to let catch
* clean up into a function
* clean ups
* final clean up
* no this is final
* bump
* simplify
* simplify
* pass
* bump
* globals don't work inside methods
* space
old-commit-hash: 80bbba14f74e57bbe90216dfd0a99f6f68d77ca2
* bump
* should be bytes
* draft fuzzy car params
* stash
* bump
* bump
* this is explored!
* some clean up
* more clean up
* clean up
* can't easily
* clean up
* no import
* Apply suggestions from code review
* move into a function
* Update selfdrive/car/tests/test_car_interfaces.py
* Update selfdrive/car/tests/test_car_interfaces.py
* Update selfdrive/car/tests/test_car_interfaces.py
* come onn
* we know it will return a dict here
old-commit-hash: c9f80e89b7ab837b9a5402723e4e028155354dde
* Revert "Nissan FPv2: log different diagnostic session types (#28585)"
This reverts commit 7b90843ea98d6034327e311c7025b9abc519055c.
* switch to standard KWP2000 diagnostic session type
* we're speedy again
old-commit-hash: 35aaf90587536e9ef5edfc1ec30c3fa2f1506aef
* fix CAN FD fingerprinting for now
* comment
* this is the simplest for now
* revert
* cmt
* todo and fixme!
old-commit-hash: 047bb46d3a0e73d1c7160252bcb6f2f7358980ee
* bump
* should be bytes
* draft fuzzy car params
* stash
* bump
* bump
* this is explored!
* some clean up
* more clean up
* clean up
* do we need draw??
* draft
* this was confusing
* revert
* draft
* Revert "draft"
This reverts commit c593a03474b04d4df2648d8149798196c991a108.
* draft
* more typing!
* complete typing
* fix that
* cleanup
* better
old-commit-hash: f495c21805583f19e5cd4bd56b8b0445c74f35b3
* HKG: Car Port for Kia Carnival (China only) 2023 (HDA1)
* add FW
* seems to be radar SCC
* Update CARS.md
* Update CARS.md
* Add test route
* Fix docs
* New route
* Fix docs formatting
* update with US model
* 2 total
* Update RELEASES.md
* add FW for US carnival 2023
* fix docs
* update test routes
* no rlogs for chinese route
* update docs
* revert chinese to merge now
* Apply suggestions from code review
* fine to fully remove
* less precise
* remove from releases
* Apply suggestions from code review
* Update selfdrive/car/tests/routes.py
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: f1c604bde7a84036a0dd16e0cc2ee34c8ff96181
* Revert "Revert "simple fuzzing test for all processes (#28584)""
This reverts commit a5be0640a3780156fdd5c04c1e6204fa41b307a8.
* determinism
* fingerprint
old-commit-hash: 0ebec253d0443144f71f523118f6fadc93cf1eeb
* request callbacks
* support in IsoTpParallelQuery
* tiny bit simpler
* shorter lines
* need to check length again, could return empty list
* takes in prev response
* typing
* test
* only test
* simple test
* revert this
* subtest!
old-commit-hash: 16203cc856f5f1fed779f34f94234d3eed9d978c
* put one subaddr in parallel_addrs
* p
* remove print
* update test refs
* test
* revert that
* clean up
* clean up
* fix
* print results
* fixup cmt
* move down
old-commit-hash: 3f8c976d999d7290fb0357b095339ed0fdf70f87
* put one subaddr in parallel_addrs
* p
* remove print
* update test refs
* test
* revert that
* clean up
* clean up
* only clean up
* clean up
* rm
* type
* one line
* this is fine
old-commit-hash: ed86a4ae62fc84b8beb153ea89cb062a2ae27bcd
* standard KWP2000 diagnostic session type
* draft
* clean up
* not needed
* update FP refs
* should log logging
old-commit-hash: 2f2b94758bfa3c5bb8790c3828db420e7da9f0dc
* random car control
* format
* struct generation
* math
* staying real
* really staying real
* move
* split this
* format
* Revert "format"
This reverts commit a70a73952ee3833c4ae839d7b2729ee2a1e1a85b.
* Revert "split this"
This reverts commit ae96be63cbfbee230101e69a0f84c874f321fafa.
* space
old-commit-hash: 3fc104fb6d9db5f4853b61c4c525b581e0caad72
* get gas/ev/hev from FW (not all correct, poc)
* add test for essential ecus for fuzzy fingerprinting
* kinda works
* stash
* clean up
* add code
* simpler
* use the function
* test it with our cars
* no re
no re
no re
* debugging
* handle empty dict
* simpl
* this is promising
start on making existing fingerprinting functions use the config, instead of entirely replacing them
* needs to allow 1 match
* lay out how this should look
* changes
* executable
* some work
* use config
* fuzzy ecus
* config test
* comment and some clean up
* test platform codes
* use regex, simpler and fixes bug
* in func
* rm bad func
* typing for new func and remove old from dc
* todo done
* tested!
* remove fake platform codes
* thought we needed this, but actually...
* not needed
* not applicable any more
* use config for essential ecus
* first draft of test to make adding/removing fuzzy FP platform intentional
* compile
* clean up test
* even cleaner
* fix default ecus type
* temp fix
* this is mostly in tests now
* test every fuzzy ecu fw returns one platform code
* experiment with dates
* Revert "experiment with dates"
This reverts commit 3251b9cc5c3ca41ca92c8b75ad9b2234b720aa0b.
* clean that up
* comment
* test
* work on all cars
* fix fuzz_fw_fingerprint
* comment
* get first by search
* bit more clean up
* and more
* use compiled pattern for nicer syntax
* default
* flip dat around, much cleaner
* clean up hyundai test a bit
* flip order
same here
* rename test and flip subTest
* fix pylint
* revert fw changes
revert fw changes
* line
* add original functions to test
* needs to be a list
* cmt
* draft (need to count one ecu as a match)
* tiny clean up
* todo: date range
* only in notebook
* remove comment (still can be either list or set)
* same, only notebook
* more consistent signature
* copilot inspired
* copilot no good
* test for date parsing
* better name
* good, now we don't have to worry about the dates mismatching in another test/logic
* comment up+
* some stuff
* clean up
fix test
fix test
* test
* comment
* use utils
* clean up (utils are cleaner and less buggy)
* clean up (utils are cleaner and less buggy)
* fixup test
* use a dash (prettier) and remove some platforms that can fingerprint now!
* compile global pattern
* same as what we do in values
* remove comments
* fuzzy_get_platform_codes is one or none here
* more clean up
* sort imports
* woah woah woah
* add comment
* fix reassigning different types
* add types
* adapt fuzzy test recently added (nice it caught this!)
* update lock
* options
comments
* stash
* comments and fixes
* better comments
* better
* test: run on exact fuzzy matching logic, same results!
* use match_fw_to_car
* test all fw
* ex
* unused random
* this is a possibility
* this is more clear
* fix
* revert
* revert to needing both ECUs to match to reduce false positives, test
* fix excluded platform test :( but it's ok
* add comment
* we actually want to only test fuzzy ecus to make it explicit
* fix mypy
* comment for tomorrow
* just add matches with fuzzy FP
* add comment
* this was the cleanest I could think of, but still working on it. not very easy to understand
* think this is better, but also worse...
* comment: reframing how this works
* revert back to what we did before
* was swapped
* else set
* remove old comment
* fixes from merge
* remove fuzzy_min_match_count from this pr
* fix static analysis
* also unused
* different method first draft
* copy existing fuzzy func
* check all possible ecus exist, only platform codes, slightly refactor main loop
* fix
* Revert recent
Revert "fix"
This reverts commit 5cdb7bda835f1e48e750ab4195e891afe08e11ea.
Revert "check all possible ecus exist, only platform codes, slightly refactor main loop"
This reverts commit d3e918fa20fa4ce881445850f5f7428a3c11adf8.
Revert "copy existing fuzzy func"
This reverts commit 34c8c0545097c84f55f4b4f61907606c93760ddd.
Revert "different method first draft"
This reverts commit b91139055d7d1802c1eb726504798c156a183c9c.
* new func
* fixup test
* remove changes from v1 from fw_versions.py
* clean up a bit
* return part as part of code
* fix test
* add original fuzzy function
* add an ecu match if the date is within range (or date doesn't exist)
* add format for what we're going to do
* not working stash
* the exact matching function does more of what we want with less code and less custom logic
* we don't care about found versions, only codes and dates
* actually we do have an exception
* this works pretty nicely now
* up here
* this is better
* some minor clean up
* old function=now junk
* fix platform code test
* remove old platform code function
* now rename _new to
* use FW_QUERY_CONFIG
* clean up imports
* rename that too
* one line
* correct typing
correct typing
* draft tests
* so that works
* fixup excluded platform test now too
* this is tested by excluded platform test
* test parts and dates
* remove old comment
* old import
* take platform code stuff out of FwQueryConfig
* fix test
* revert debug script
* flip order
* make this a set by default
* revert this part
* correct typing
* clean up comments
* clean that test up too/pylint
* combine these three tests ina clean way
* not right
* more general
* be consistent with quotes
* comment
* comment
* comment in fw_versions
* flip order
* this is more readable
* could test all this, but it's tested in test_hyundai and doesn't do a lot here
* only assert brands which use this
* invalidate all CAN FD ICE and hybrid
* tuple
* can get away without filtering
* add comment reasons
* fix
* some review suggestions
* this works (first draft)
* this is better
* script to print platform codes and dates
* sanity check for dates are in correct ecus and platforms
* mypy
* better variable name and comment
* rename
* same
* slightly better name
* subset
* exclude platforms and live car without dates
* consistent
* self explan
* better name
* test to make sure the functions agree
* clean that up
* comment
* we get other responses from queries not in DB, only check any
* not used or typed
old-commit-hash: f788edb6a5c8d3f516076f886fe0d831ee43b580
* bring platform codes out of config for now (can re-introduce later)
* clean that up
* flake8
* comment
* comments and better test names
* typo
* Update selfdrive/car/hyundai/tests/test_hyundai.py
* Update selfdrive/car/hyundai/tests/test_hyundai.py
old-commit-hash: 572a221a86d8048baba3fe50d6a950e4775f6f9f
* add config options
* you know what, platform codes don't need to be related to fuzzy fingerprinting at all
* better comment?
* add comment
* add test from other PR
* add platform code function to hyundai
* comment and add eps!
* clean up config test
* fix test
* add error message to test
* until we have multiple ways a brand can set up fuzzy FP, let's leave func name fuzzy-specific
* rename in comment too
* hyundai tests
* simpler test!
* check all ecus with platform codes
* add types-python-dateutil = "^2.8.19.13"
* these aren't used any more
* Update selfdrive/car/hyundai/tests/test_hyundai.py
* not to imply this is active yet
old-commit-hash: f5e032b67f6e37d2c12dcd90168a2b33b3b78831
* test empty fw lists
* fix
* generic test name
* can rmeove this check now
* and here!
* can remove that
* add to print
old-commit-hash: f976fce7d0142088244ae4af8a1116691b621843
* first attempt trying to do it implicitly bad
* back to lists and explicitly do this
* continue checking if candidate switches on these, that's fine to check
* debugging
* clean up
* more clean up
* spot free
* only need to create/update on change
* fix test
* draft
* Revert "draft"
This reverts commit dbe32f58b172eddc8f9699044c6a5956e753305d.
* Revert "fix test"
This reverts commit 1d34269fe2de35d314aa0658fa47a78a08d93e08.
* fix test for real
* first draft of test
* this should be good
* can replace existing fuzzy test
* rm
* matching
* test non-empty fws
* TEST DOWN HERE
* no test
* unique + fix skip message + comment + clean up
* less confusing
* ing
* better
old-commit-hash: 9e8936be9863ea27c598685ee1b14775aa12cac4
Shane Smiskol