Commit Graph

42 Commits

Author SHA1 Message Date
Shane Smiskol f38a98fc09 Metered Wi-Fi toggle (#35293)
* draft

* here too

* fixes

* fix

* ugh more fix, wifiManager is craze

* more

* be optimistic and let refresh happen naturally, the immediate refresh causes some paths/active connect to temporarily be unavailable

selfdrive/ui/qt/network/wifi_manager.cc: DBus call error: "Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the re
ply timeout expired, or the network connection was broken."
selfdrive/ui/qt/network/wifi_manager.cc: DBus call error: "Object path cannot be empty"

* nm is slow -- it takes 2s to commit to disk, and dbus errors are raised if you try again while previous is running (this is an ubuntu 24.04 bug)

* nice experience

* rm

* minor

* clean up

* self-explanatory

* rename

* rm this too

* revert

* draft

* Revert "draft"

This reverts commit 15283d977880fc60b8f9732772256e8337d6ac8e.

* Reapply "draft"

This reverts commit 8629921b0086ca71b88746d77ec7b8d3af3cd289.

* rm colors

* trinary, bit more code

* choose default when disabled

* only if enabling, wait for disable as normal

* remove original binary toggle

* clean up

* collapse

* clean up wifimanager

* update comment

* lite is a word
2025-05-21 20:45:47 -07:00
Shane Smiskol 6d0cac5305 MultiButtonControl (#35307)
* copy

* remove params from it

* split out
2025-05-20 17:32:27 -07:00
Shane Smiskol 1ab2ec26e1 ListWidget: fix stretch (#34003)
fix stretch
2024-11-12 15:55:03 -08:00
Shane Smiskol ebfc450fac longitudinal personality: change via steering wheel distance button (#31792)
* start at param

* start by sending personality

* change to personality

* POC: button changes personality

* what's wrong with this?

* fix

* not really possible but fuzzy test catches this

* there's always a typo

* dang, we're dropping messages

* clean up

* no comment

* bump

* rename

* not all cars yet

* works but at what cost

* clean up

* inside settings

* write param so we save the distance button changes

* setChecked activates buttonToggled and already writes param!

* don't need this, we update from longitudinalPlan on changes

* some clean up

* more

* ui

* allow some time for ui to receive and write param

* plannerd: only track changes in case no ui

* Revert "plannerd: only track changes in case no ui"

This reverts commit 2b081aa6ceb92c67a621b74592b2292756d29871.

* write in plannerd as well, I assume this is atomic?

* don't write when setting checked (only user clicks)

* better nane

* more

* Update selfdrive/controls/lib/longitudinal_planner.py

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>

* doesn't write param now

* ParamWatcher is nice

* no debug

* Update translations

* fix

* odd drain sock proc replay behavior

* vanish

* Revert "odd drain sock proc replay behavior"

This reverts commit 29b70b39413e1852bb512155af6b6a94a5bd9454.

* add GM

* only if OP long

* move personality to controlsState, since eventually it won't be exclusive to long planner

more

bump

* diff without translations

* fix

* put nonblocking

* CS should start at up to date personality always (no ui flicker)

* update toggle on cereal message change

* fix

* fix that

* ubmp

* mypy doesn't know this is an int :(

* update translations

* fix the tests

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
old-commit-hash: 3d63c7093afec7ba24f447a44f02f7bea1f7282b
2024-03-13 01:05:02 -07:00
Shane Smiskol 2c33c76170 ButtonParamControl: use buttonClicked (#31817)
old-commit-hash: d651bc802b540089acb4c3b9d5d984fb8b554487
2024-03-10 00:12:18 -08:00
Dean Lee 2a948de1f6 ui/ParamControl: do not create ConfirmationDialog on every click (#30496)
old-commit-hash: 011b1a6e6a1db1047b2c72bc7e9e273a358ab18d
2023-12-08 13:48:31 -08:00
Dean Lee 97e9d55588 cpplint: build/include_what_you_use (#29556)
* include_what_you_use

* remove comments

* include <memory>

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 2d99521e7500902070d0aacce69528bcfd8b9964
2023-08-23 13:25:17 -07:00
Dean Lee c25ca091ff ui: cleanup controls (#28809)
* cleanup controls

* restore LayoutWidget
old-commit-hash: 2d37c219e794cc4d8ed0de031b38b183af281db3
2023-07-05 10:50:14 -07:00
Cameron Clough b6e6f008f1 UI: improved nav destination entry (#28476)
old-commit-hash: bc5a8990241311e347455ea8d69a064bd0693266
2023-06-22 19:57:29 +01:00
Dean Lee e5f294783f ui: disable longitudinal personality settings when using stock long (#28443)
* disable longitdinal personality settings

* disable title label

* Revert "disable title label"

This reverts commit ef315ac2770191f1309f774185266e0cd9fe54b0.

* gray checked button on disable
old-commit-hash: 9295aca8eaebaadbc7ec96e82ece55dcaa3b668e
2023-06-08 16:03:18 -07:00
Shane Smiskol 633cdf0d0a ButtonParamControl: minimum button width (#28442)
* min width

* param
old-commit-hash: a92cd659cef7c517b40e7fd1455a12bacb3184b9
2023-06-07 01:11:41 -07:00
Dean Lee bfecfe3f8e ui: refactor ButtonParamControl (#28425)
* refactor ButtonParamControl

* add pressed style

* connect to buttonToggled

* typo
old-commit-hash: 7f41047178b5390581b9f18435939ba43a43a423
2023-06-06 01:18:17 -07:00
Harald Schäfer 36aa81cdc3 Driving Personality setting (also changes follow distance) (#24742)
* Skeleton

* Adjustable follow parameter

* fix rebase

* long planner

* typo

* Add ui toggle

* Fix icon

* Improve text

* Better toggle position

* Im a UX engineer now

* add param reader

* CHange jerk to have same crash test performance

* Try reading param

* Unused comment

* translate ui text

* std stoi

* Parametrized buttons

* Empty strings are ints

* Move to generic

* Update translations

* Fix translation diffs

* Release notes

* update refs

* tweaks

* Misc fixes

* No param is standard
old-commit-hash: 205c900742a18ca4662f4535a1a4008624c05995
2023-06-05 22:17:41 -07:00
Shane Smiskol 097f501e0d ui: handle two dynamic toggle icon cases (#26517)
handles two cases
old-commit-hash: 797c626984080e1ff17206b99e67a11bba87992f
2022-11-15 21:07:11 -08:00
Shane Smiskol cd33325949 ui: toggle control supports active icons (#26514)
* support active icons

* function

* fix crash if not setting icon but active icon

* revert

* clean up
old-commit-hash: 62024176c6e0386401374873e73512ab76f4204a
2022-11-15 20:52:31 -08:00
Shane Smiskol f53cdd6857 ui: function for setting toggle confirmation settings (#26516)
function for setting confirmation settings
old-commit-hash: b3f75b0c5b151cbcb048a31bb33c8f49b2a818b1
2022-11-15 20:46:42 -08:00
Shane Smiskol 74aa9e5b80 offroad ui: support storing confirmation of a toggle (#26510)
* show confirmation toggle on first toggle of experimental mode

* don't store confirmation if users toggle off *after* this PR

* refactor

* cleaner

* not true

* try here
old-commit-hash: 2ad9a4f95a82bf922c86b373026c0e96f9971a80
2022-11-15 16:44:03 -08:00
Shane Smiskol b2e82d028a ParamControl dialog: more explicit confirmation text (#26431)
* Use enable

* vanish

* fill in missing translation

* Update selfdrive/ui/translations/main_pt-BR.ts
old-commit-hash: a3cd50c5bbb924eaf40ab18d76f603edfc2f5a2a
2022-11-09 19:38:17 -08:00
Cameron Clough 07282a9aeb ui: increase toggle confirmation font size (#26413)
* ui: make toggle confirmation text larger

* center title

* reduce line breaks

* slightly reduce font size
old-commit-hash: f38fe7cfb1b3011ea48a34b0500f352338e05b25
2022-11-09 14:53:41 -08:00
Cameron Clough f46b6ed70a ui: toggle confirmation and dialog redesign (#26331)
* toggle confirmation

* change text

* not for e2e

* get current description

* remove are you sure

* merge rich text and confirmation dialogs

* add some line breaks

* font colour

* fix padding a little

* revert

* updated toggle design
old-commit-hash: 91a1f1a91e8ac321ad2a69c3a44f41464147fc19
2022-11-04 15:37:41 -07:00
Adeeb Shihadeh 2bb68d4c29 UI: show git commit date (#26240)
* show version description while offroad

* ui fixups

* parse date

* cleanup
old-commit-hash: 4639862baecfc8ed708827580f441a34731ba137
2022-10-25 15:21:43 -07:00
Adeeb Shihadeh 46cfb5c45b good updater experience (#25724)
* good updater experience

* set params on startup

* no fetch on first loop

* little type hinting

* little more

* update translations

* always set params with valid overlay

* wrap check

* use the param

* more wrapping

* vanish

* cleanup

* remove that
old-commit-hash: c4e63d14ab158118efc6eadd0e20d8d533f9e046
2022-09-15 15:12:36 -07:00
Adeeb Shihadeh 03f6c8e269 ui: fix network page crash
old-commit-hash: 613686855779187db9b20ecee34a4f8b1dd5ce67
2022-09-08 11:39:54 -07:00
Adeeb Shihadeh c6e4fb646d split out experimental long toggle (#25698)
* split out experimental long toggle

* clean up

* update translations
old-commit-hash: 3ef37fe2e848689dd3ef1e28b6cf14213c9fe069
2022-09-07 20:38:04 -07:00
Adeeb Shihadeh e4f9781c17 single longitudinal toggle for e2e and disable radar (#25688)
* single longitudinal toggle for e2e and disable radar

* write disable radar param

* rename

* better param name

* clean that up

* update refs

* update translations

* not live for experimental

* write it out

* vanish
old-commit-hash: 655a64b60318ce44ef0271e03de16e8b135b5268
2022-09-07 17:12:49 -07:00
Adeeb Shihadeh 95df2c9b48 updated: add branch switching (#25200)
* switch param

* add to ui

* fix that

* fetch for new branch

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: cc3857eb62cd169be05a4cb22c844a8b2ec94139
2022-07-18 21:18:10 -07:00
Dean Lee 92da40952f UI: fix unable to scroll on 'Regulatory' page (#25014)
* fix unable to scroll on 'Regulatory' page

deleteLater after hide

* remove alert

* override exec

* set MousePressEventDelay to 0

* set to 0.01

* cleanup

* check event->pos()
old-commit-hash: dc3d94d662654a6bb2bf40560c2a17ed2303fa80
2022-07-07 15:01:02 -07:00
Adeeb Shihadeh f4675fc260 Merge common/ and selfdrive/common (#24556)
* Merge common/ and selfdrive/common

* fix that

* fix version

* fix unit tests
old-commit-hash: cb8885cffb313bea258c012c3026461a22bf8135
2022-05-18 14:11:57 -07:00
Shane Smiskol 769c76a773 ui: repaint toggles after offroadTransition (#24038)
* repaint after offroadTransition

* Update selfdrive/ui/qt/widgets/controls.h

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 4802c864d5ccfc606c7392a73ead858a5a2a2bcf
2022-03-25 13:52:22 -07:00
Dean Lee b462e5584f move LayoutWidget,ClickableWidget to controls (#23207)
old-commit-hash: d4b8cba0f6614138a7a836559712baeb894f7163
2021-12-14 11:00:01 +01:00
Dean Lee 2fefa32476 UI: new class ListWidget (#21273)
* ListWidget

* continue

* remove function horizontal_line

* cleanup

* default spacing 25

* fix networkpanel margin on EON

* solid expanding

* 0 width

* cleanup

* apply reviews

* remove function addLayout,make it looks like QLIstWidget

* rename addWidget to addItem

* rebase master

* rebase master

* merge master

* cleanup

* fixed title bar position

* no flash while folding

* cleanup

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: abffc8b2ade75eb9365552cb25a1885442d7e011
2021-09-19 15:14:54 -07:00
Adeeb Shihadeh 706542a7b2 nav: add button to clear current route (#22167)
* nav: add button to clear current route

* fix scroll

* retab

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: d5475ba9462ad9c6a18db05e96a4fa9d3bf9772a
2021-09-07 17:39:24 -07:00
Dean Lee bdc758e769 ui: clickable ElidedLabel (#21773)
* ElidedButton

* rename to ClickableLabel

* move to ElidedLabel
old-commit-hash: 1786416e3cefcd6562f18954aa81b759d0fcf2f4
2021-08-30 22:16:48 -07:00
Adeeb Shihadeh c5959d74a8 UI: update toggles on show (#21812)
old-commit-hash: 0ffe920a863e5034f305812f14bf232ef087186c
2021-07-30 16:21:42 -07:00
Adeeb Shihadeh 17faf6e48f UI: button released -> clicked (#21606)
old-commit-hash: 92157480800d604b9a53873a66ecb7fcdd622535
2021-07-17 13:58:09 -07:00
Dean Lee 24563f4b11 Qt: new class ElidedLabel (#21277)
* shorten ssid

* truncate with ellipsis

* rename to trancate

* truncate 22 characters

* elidedLabel

* trimmed

* remove function elidedString

* cache elidedTest

* rebase master

* minimizeSizeHint

* add sizeHint

* cleanup

* revert

* inherit from QLabel

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: aee2b893a7467a05b6d49c16c5b6e0b6cf2f9275
2021-07-10 01:43:47 -07:00
Dean Lee 95a9e22120 UI: refactor ButtonControl (#21315)
old-commit-hash: 8675c970d49499d541c38172b1c5516dec7df480
2021-06-17 23:17:52 -07:00
Dean Lee d8ac1df789 Qt: cleanup includes (#21282)
* cleanup includes

* remove include <qtwidgets>

* more
old-commit-hash: 2c6d27f4828bc57e69f86aed0d1f48364233dffb
2021-06-16 00:08:02 -07:00
Dean Lee 71b346b3e8 UI: refactor SoftwarePanel (#21244)
* refactor

cleanup

* one params

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 7009ba0344834f18adc93b34960fa97d1ebf2efc
2021-06-12 21:36:35 -07:00
Maxime Desroches 88ae07b37b UI: add missing override identifiers (#21081)
old-commit-hash: 3c058e0b646c7918650c7779928ea67fe1627c9b
2021-05-30 10:12:11 +02:00
Dean Lee e333e4f189 Cleanup selfdrive/ includes (#20822)
* cleanup include path

* continue

* format includes

* fix testraw.cc

* remove include path from SConstruct

* regroup

* rebase master

* almost done

* apply review

* rename FileReader.xx to filereader.xx

* rename Unlogger.x->unlogger.x

* rename FrameReader.xx -> framereader.xx

* apply reviews

* ui.h

* continue

* fix framebuffer.cc build error:mv util.h up

* full path to msm_media_info

* fix qcom2 camerad

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 7222d0f20dc8edfe0d2f3417d1ce7c84fbd32805
2021-05-08 22:15:17 -07:00
Dean Lee 9a827fea20 c++ cleanup: standardize file extensions to .cc and .h (#20800)
* c++ cleanup: standardize file extensions to .cc and .h

* cleanup files_common
old-commit-hash: 81491dc57f5080c602a0be58dd5f9feba2fa31b9
2021-05-03 11:53:11 +02:00