Commit Graph

51 Commits

Author SHA1 Message Date
Greg Hogan 363e020ce6 cabana: SG_ parse allow no space before colon (#33785) 2024-10-14 13:37:51 -07:00
Shane Smiskol 4f019b5f60 move selfdrive/car to opendbc (#32630)
* move most of /car

* move some car tests

move some car tests

* fix selfdrive/car/tests

* fix selfdrive/controls tests

* fix the rest of the selfdrive tests

* bump opendbc

* fix all tests

* few more non-test references

* remove opcar and move docs to car

fix these debugging scripts

fix docs

* bump opendbc and panda

forgot panda
old-commit-hash: e735a7f3796e208cdc1ecc651ace09e1daf6009a
2024-08-17 00:54:51 -07:00
Dean Lee a18df70a3f cabana: simplify stream management and remove problematic autosave feature (#32945)
simplify code and remove problematic code
old-commit-hash: c17c34187b6e9c14b3c00135386625bbb601ed22
2024-07-10 15:10:24 -07:00
Dean Lee dbf095522f cabana: bug fixes and improvements (#32934)
bug fixes and improvements
old-commit-hash: 36815cc6d536ab8926f6335574ea587947c4e222
2024-07-08 14:50:31 -07:00
Dean Lee f372bf3a1b cabana: some improvements (#32161)
some improvements
old-commit-hash: 2d1078ee5bcddc12122a06ffaefef31f9656ef65
2024-04-24 15:56:25 -07:00
Dean Lee e756325451 cabana: improve DBCFile::parse() (#32160)
improve parse()
old-commit-hash: a6396be53e54aa81644a10c2936706d0f1a2d6e8
2024-04-24 15:55:58 -07:00
Dean Lee 9118013d9c cabana: refactor HistoryLog for simplification and enhancements (#32284)
old-commit-hash: 5e61775561b6f7cfee9867a8a2a14f73a7b3b78f
2024-04-23 09:53:50 -07:00
Cameron Clough 5dbd836091 cabana(DBCFile): handle escaped quotes (#31889)
* cabana(DBCFile): VAL_ allow empty description

Even though this doesn't make much sense, we should still be able to
parse it.

* cabana(DBCFile): allow escaped quotemarks in signal comment

* also message comments

* escape/unescape quotes

* test empty val desc

* test generating DBC with escaped quotes in comment

* seperate test case

* fix trailing space

* remove empty val

* trailing whitespace again
old-commit-hash: d09e77d1aff2a9df096fb519345337379379d9cf
2024-04-03 19:19:55 -07:00
Justin Newberry f387b87f42 migrate lowercase mock (#32074)
* add mock migration

* fix

* this
old-commit-hash: 1c0161589b5fa183d7fc87a30692c92865d61065
2024-04-01 15:27:29 -07:00
Shane Smiskol 5508759124 Simplify cabana dbc dict (#32041)
* so needlessly complex!

* inside generate_dbc_json

* this is good

* clean up!

* spaces

* so much clean up
old-commit-hash: d6d8e459319bfc2ce10d8dabf82b44c5401fbf2f
2024-03-28 16:26:16 -07:00
Justin Newberry bce4276d06 cabana: migrate dbc map (#31920)
* fix cabana

* within platform map
old-commit-hash: 1f424bf7dcbe13a6a60212816cfd3057da6f5a1f
2024-03-20 10:57:41 -07:00
thenhnn 77d6d1a8f1 PlatformConfig: automatically get platform_str from the enum name (#31868)
* get platform_str from the enum name

* fix tests

* add migration table

* remove impossible todo

* Add link to PR in MIGRATION table

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Remove useless brand name comments and rename RAM_1500 to RAM_1500_5TH_GEN

* rename RAM_HD to RAM_HD_5TH_GEN

* rename references to RAM_HD and RAM_1500

* change "mock" to "MOCK" and rename torque data of Nissan Leaf 2018 IC

* remove MOCK from fingerprints.py

* change hard-coded car model in test_can_fingerprint.py/test_timing

* migration

* update ref

* space

* prius

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: justin newberry <justin@comma.ai>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
old-commit-hash: 489528dcae3888311f92075ba9e0f68626725121
2024-03-19 11:16:02 -07:00
Cameron Clough 0ca2fdb545 cabana(DBCFile): preserve original header (#31900)
* cabana(DBCFile): preserve original header

* add trailing space
old-commit-hash: 5a805df3402c8a0661a9b663d88378313b19784e
2024-03-18 22:37:45 -07:00
Cameron Clough 764c5cdae4 cabana(DBCFile): interleave msg and signal comments (#31899)
This matches the behaviour of CANdb++
old-commit-hash: 3e816e7df89eccb6375f87c8ae4276312116e5ad
2024-03-17 11:17:29 -07:00
Justin Newberry e6dbf6d614 cars: remove CAR_INFO map (#31739)
* no carinfo map

* smaller diff

* not on mock
old-commit-hash: 25ccb2426c0b54dbf823b9e7e6d63607b37d9c5a
2024-03-06 11:22:12 -08:00
Dean Lee 8056fe5aff cabana: add csv export (#30800)
export csv
old-commit-hash: 5f045176775c8c2cdd7f85e7229f78cf26f0c013
2023-12-19 11:50:16 -08:00
Dean Lee 280bef4b0c cabana: cleanp code (#30666)
old-commit-hash: aa744e84373ecacbbb45382e1a0e4cdd3d5c05fb
2023-12-09 08:12:11 -08:00
Dean Lee 18f8bc79e6 cabana: remove dependence on opendbc (#30329)
* remove dependence on opendbc

* move into function
old-commit-hash: bf932c6277c25294857d68cf1a333ce9d151140c
2023-11-02 22:37:56 -07:00
Dean Lee be9d291dad cabana: support suppress highlighted bits (#30336)
* support suppress highlighted bits

d

* faster filtering and sorting

* improve livestream

* specify the context in the connections

* remove inline
old-commit-hash: 01610128bb340f83ebf08b344404330806178825
2023-10-30 09:47:23 -07:00
Dean Lee 0396152d98 cabana: fix parsing multiple line comment (#30178)
fix parse error
old-commit-hash: 29f10fd2aa0730681986631838f866462eb9af55
2023-10-05 01:48:56 -07:00
Dean Lee 97aa8b0606 cabana: support ECU node names (#29897)
* support display&edit node name

* cleanup

* set validator for Node name

* modify validator to support multiple receivers

* set default to XXX in updateMsg

* add DEFAULT_NODE_NAME

* Update tools/cabana/commands.h

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: c4df40a04a57478883609748c08d1abed539b017
2023-09-15 00:27:44 -07:00
Dean Lee 97e9d55588 cpplint: build/include_what_you_use (#29556)
* include_what_you_use

* remove comments

* include <memory>

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 2d99521e7500902070d0aacce69528bcfd8b9964
2023-08-23 13:25:17 -07:00
Adeeb Shihadeh 16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b69af19306143fc4def02fb5769405d2
2023-08-20 20:49:55 -07:00
Dean Lee 241cbb2808 cabana: preserve msg transmitter & signal receiver when saving DBC (#28825)
preserve transmitter&receiver_name
old-commit-hash: 940609956d3fe10ffd3033156f4fe62bcdcac42e
2023-07-06 12:39:58 -07:00
Dean Lee c7425def28 cabana: fixed the issue of parsing multiplexed signals (#28660)
old-commit-hash: 6cc600e84f3a42bcf402730073d22fe6cd16b8d3
2023-06-23 13:14:11 -07:00
Dean Lee 88840e9fe4 cabana: simplifying endian conversion (#28601)
old-commit-hash: 3c398b2e2f2afdc4f81d968e4b0fb025d8190cab
2023-06-20 10:56:40 -07:00
Dean Lee b31de7db56 cabana: fixed the multi-threading issues of AbstractStream (#28590)
* fix multi-threading issues

* protect masks with mutex
old-commit-hash: e80440dc5d76c12cd6782b6a3446b12f6c62016e
2023-06-19 10:21:16 -07:00
Cameron Clough b3055ca4ff cabana: round signal raw value for value description
old-commit-hash: e57f3ab4daeb18ac1c8786b3b5c7d0ad7b000646
2023-06-15 12:46:08 +01:00
Dean Lee 7fc2927b73 cabana: use raw signal value to match value descriptions (#28554)
old-commit-hash: 6f54ebe1103c7960afcd2f3f550e56ba9a7e4667
2023-06-15 11:50:14 +01:00
Dean Lee c5543bf21d cabana: support multiplexed signals (#28309)
* support muxed signals

* write multiplexor in generateDBC

* edit multiplex_switch_value in signalView

* no overlapping warning for mux signals

* group signals by multiplexer indicator

* display freq for each multiplexed signals

* remove all multiplexed signals after switch deleted

* disable switch value

* cleanup

* historyView: use getValue

* sort by switch value

* check address

* rename variables

* rename signale type

* parse multiplexed signals in dbcmanater

* cache signal color in member variable

* cleanup num_decimals

* remove sources from dbcmanager and cleanup code

* fix sort

* check mltiplex in operator==

* fix sizehint

* convert multipledxed to normal after changing multiplxor to normal

* throw error on multiple 'M' signals

* add comment

* parse multipled signals in test case

* cleanup

* change order

* cleanup open

* display multiplexed/overlapping signals in binaryview

* sort overlapped signals by size

* refactor dbcmanager

* trimmed

* parse multiplexed signals in test case

* cleanup

* merge master

* space

* use pointer for sigs

* alldbcFiles

* cleanup

* cleanup sparkline

* use std::vector

* skip draw sparkline if isnull

* bigger capacity
old-commit-hash: e08569b0f31953e185369eba9afb7fb20de714fa
2023-06-13 13:22:03 -07:00
Dean Lee eba8100ea5 cabana: refactor dbc manager (#28445)
* rafactor signal

* cleanup

* refacto dbcmanager

* refactor dbcmanger
old-commit-hash: ff4aae85fe39b6442c03963a6a8cbfc900ba61c3
2023-06-08 13:41:55 -07:00
Angus Gratton 78268323cd cabana dbc: Sort signals by name if start bits are equal (#28399)
old-commit-hash: f659d4d44b1192467a7ad0d34c4f6747ae7382b4
2023-06-04 14:04:09 -07:00
Dean Lee 1156efe3c6 cabana: add a test case for dbc parsing (#28383)
test case for dbc parsing
old-commit-hash: 4e738e64e4394e9d25373917a2fb7a6c0a9041f8
2023-06-02 22:34:37 -07:00
Dean Lee 5f144b5c77 cabana: Support parsing of multi-line comments (#28345)
old-commit-hash: 99398176dfe707c84d591400b90838fdfceda5a3
2023-06-01 20:52:08 -07:00
Dean Lee 90bff752c1 cabana: improve dbc parsing (#28321)
old-commit-hash: 2a6458b44ed4189ec110036de956598e39fe8151
2023-05-27 15:43:42 -07:00
Dean Lee c2e86afc8c cabana: support editing comments for messages (#28299)
old-commit-hash: 54506774f05a867ff0f6ab4ab494eeec792f838f
2023-05-25 13:38:58 -07:00
Dean Lee 6cc979a258 cabana: support editing dbc files without a stream (#28294)
* no stream mode

* disable tools menu if no stream

* disable splitter

* cleanup

* refactor matchMessage
old-commit-hash: d5d1ca11d4a5ba5ffcb067fd842540d5334e9360
2023-05-25 10:51:28 -07:00
Dean Lee 3a838e5342 cabana: use double for minimum value & maximum value (#28252)
old-commit-hash: 36dd49e542968bf13943dcd375424dae6c271b63
2023-05-21 12:35:45 -07:00
Dean Lee 85d4ba325d cabana: use the same double precision as the dbc file (#28234)
old-commit-hash: ac2c87246af2d73f6c0481934d8cc4969aba4b4d
2023-05-19 12:36:11 -07:00
Dean Lee 91ccb8b415 cabana: add #include <QObject> in dbcfile.h (#28219)
old-commit-hash: 5b54f0938fef846525a6e7f3c2444cdbc5585333
2023-05-17 00:08:10 -07:00
Dean Lee c9d56e78a6 cabana: cleanup DBCFile (#28160)
old-commit-hash: 720df4d150913e9ee98165d2bb03a18d7566e746
2023-05-10 13:57:55 -07:00
Dean Lee ca13898b23 cabana: show and edit all messages present in DBC files (#28108)
* show all messages present in DBC files

* set last section stretch

* user can't resize data section

* re-fetch if filtering freq|count|data

* reserve set space

* use contains

* emit signalAdded for all related sources
old-commit-hash: f7e024f2f22139153aa8ee5ce9a9713bd51d99f0
2023-05-07 16:48:47 -07:00
Willem Melching 10215bc44e cabana: add option to suppress already known signals (#28106)
* suppress using static mask

* use mask in updateLastMsgsTo

* store mask in cabana::Msg

* update mask in the right places

* actually build mask

* restore setting

* less diff
old-commit-hash: b53f748a1a328e63dff0a404114c5210eeaf2282
2023-05-04 10:50:28 -07:00
Dean Lee 4a318e17bd cabana: display current time & values in chart (#28042)
* display current time&value in chart

* cleanup

* use macro

* use BrightText

* use x-square

* tiplabel: set point size 9

* add 1 point offset

* change Light color

* lighter color

* use const iterator to avoid implict sharing detachs
old-commit-hash: 45f1f764ea32f05b51e8e8a84ab6ce7ab8eefd95
2023-04-29 13:27:37 -07:00
Willem Melching e32ba8719a cabana: more advanced DBC management features (#27968)
* cabana: improve menu to manage individual DBCs

* remove from single bus

* comments

* close explicitly

* new before open

* whitespace

* remove old code

* clipboard actions

* cleanup actions

* sections instead of nested menu

* consistent bus format
old-commit-hash: 7f5cda00b5040a641c7775caf7c6a38b507c5210
2023-04-19 10:49:30 -07:00
Willem Melching 23d52ccd2d cabana: refactor new msg/signal name generation (#27931)
old-commit-hash: 1016c3f97c9e710c75380249da29c89b0e7ca8e1
2023-04-17 15:37:41 -07:00
Willem Melching 59dfef9d60 cabana: do not try to save empty wildcard DBC (#27898)
* cabana: do not try to save empty wildcard DBC

* use reference
old-commit-hash: d8e9c44c76961363ba633aca2692aacf2e8d006b
2023-04-13 11:09:14 -07:00
Dean Lee 83e9654b58 cabana: fix valgrind warnings related to uninitialized values (#27851)
fix valgrind warnings related to uninitialized values
old-commit-hash: deeb7cff9fcdd9d8e2f282db56b3bb16b3c49550
2023-04-10 19:07:05 -07:00
Dean Lee 0f49992718 cabana: do not emit DBCFileChanged if no file changes (#27800)
old-commit-hash: 493d20994a1a4e41c11c33b73550a0d120a2bdb8
2023-04-04 10:47:54 -07:00
Willem Melching b34e314d25 cabana: fix merging sources for already open DBC file (#27715)
* fix build

* fix merging sources
old-commit-hash: e0afaa4eeec1dd36ede1aea809d34637ef968385
2023-03-29 13:17:46 -07:00