Commit Graph

132 Commits

Author SHA1 Message Date
ZwX1616 deab0f86aa tici front/wide encodeIdx msgs (#2564)
* different msgs

* also add timestamps

* keep impatient log, remove the other

* meaningless
old-commit-hash: f244b7c7e156cd109be13a68ba1096dc2d25f3d0
2020-11-19 16:12:02 -08:00
ZwX1616 6b238ea78d remove duplicate enc_idx logging (#2562)
old-commit-hash: e113a1270292130ea3e7ef07a05b59aeb98c5ce7
2020-11-18 16:02:19 -08:00
ZwX1616 7f85b498be stop pc from spamming logs (#2544)
old-commit-hash: cf21720e1ae451286e6fd26fd6192d55914afa41
2020-11-13 16:26:30 -08:00
Adeeb Shihadeh d5990d0ef7 only qcom
old-commit-hash: d5a8444d6c9457bffbf929fe9314dfd210cf9e94
2020-11-12 16:19:28 -08:00
Adeeb Shihadeh ada81dda94 remove old loggerd priority
old-commit-hash: e88775a224502667be18bbedc655fa647ae83bd9
2020-11-08 15:44:04 -08:00
Adeeb Shihadeh 035ee027ff give loggerd min rt priority
old-commit-hash: 8f44e695835edbba79b913607d73f7735df060eb
2020-11-08 15:42:08 -08:00
Adeeb Shihadeh a4f4f1d828 Log last 1000 lines of tmux output in bootlog (#2149)
* log last 1000 lines of tmux output in bootlog

* add to bootlog

* fix tmux capture
old-commit-hash: 6b4957cba10985507c5ba2337ee08b6392f86ddb
2020-10-20 21:07:12 -07:00
Willem Melching 651d4ce031 --std=c++17 (#2330)
* switch to c++17

* more 17

* 1z

* use std::clamp

* Fix types in clamp

* bump submodules

* bump laika

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 339d1967cb1e8ca73aeb1f0066a23b0933706ae5
2020-10-17 13:33:12 -07:00
Comma Device 3d5e2004c3 fix encoder build
old-commit-hash: 4e2f9d915f34be5c1e27531ee3040d8e5ddf9e19
2020-10-15 11:23:42 +00:00
Willem Melching 498ecbdf3c Params refactor, simplified (#2300)
* always c++

* Create C++ params class

* get works

* tests hang now

* passes tests

* cleanup string formatting

* handle interrupt in blocking read

* fix memory leak

* remove unused constructor

* Use delete_db_value directly

* Rename put -> write_db_value

* filename cleanup

* no semicolons in cython

* Update common/SConscript

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* add std::string version of delete_db_value

* This is handled

* cleanup encoding

* Add clear method to clear all

* add persistent params

* fix android build

* Should be called clear_all

* only import params when needed

* set params path on manager import

* recusrively create directories

* Fix function order

* cleanup mkdirp

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 2e182e5c574ea1468678b5fd8d0597e34ed5898d
2020-10-13 16:23:23 +02:00
Willem Melching a331861873 Remove czmq part 1 (#2332)
* remove czmq

* remove streaming mode from loggerd

* Add include for usleep
old-commit-hash: a4ccfcffe8247bf467bddfb0e6c5b3eb8851e21a
2020-10-13 16:01:07 +02:00
Adeeb Shihadeh de4c543e63 remove hotspot exceptions in uploader (#2319)
* remove hotspot exceptions

* skip net check while onroad
old-commit-hash: ee37d03c1ffa76d91d7085c2eb9ca2ce762ee647
2020-10-12 13:12:01 -07:00
Willem Melching 5b91f74549 fix loggerd rotate (#2291)
old-commit-hash: b682ebc022959b86e12a106af7bb614737e78c77
2020-10-07 16:59:32 -07:00
ZwX1616 dc2470176b loggerd does not need to babysit this
old-commit-hash: e29fd900583b88f23883afd0a28e7ad06f0ff597
2020-10-06 18:46:22 -07:00
ZwX1616 6d3dc46b8f transient considerations (#2276)
old-commit-hash: 55351859a73f412fdd52b2166298f9ed354ce6c1
2020-10-05 15:41:17 -07:00
ZwX1616 db55c1cca3 Refactor loggerd rotations (#2247)
* loggerd:refactor rotate encoder

* change notify_all to notify_one

* finish

* cancelWait

* start front_encoder_thread on need

* rebase master to resolve conflict

* tici qcam works, but

* ifs are ugly

* synced rotate off frame ids

* only start counting frames after modeld alive

* typo

* fix some bugs

* never over rotate

* works

* missing space

* zero frame count tolerance

* lol

* add back omx race protection

* not need that

* not to confuse different locks

* playing with locks is playing with fire

* tici now has qcam

* size is overrated

* make cppcheck happy

* fall back if no camera

* warn

* missing condition

* first is freestyle

* no stream id before connecting

* wait for increment

* first will be imperfect

* wait is futile

* block frames when writing state

* just log write time

* exit loops when exit

* tici qcamera

* fixed

* add atomics

* incl

Co-authored-by: deanlee <deanlee3@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 2b974150c4478f6df69b7fbbc7037548e9e0bbbf
2020-10-03 07:56:16 -07:00
Adeeb Shihadeh 0184a43999 run loggerd tests in CI (#2241)
* run loggerd tests in jenkins

* fast

* check segs on the fly

* missing import

* wait for dir

* no thread

* relax FILE_SIZE_TOLERANCE

* cleanup

* unused

* set ci flag

* wait longer for first seg

* fix race condition with setting RecordFront

Co-authored-by: ZwX1616 <zwx1616@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 427d4a5a9eaf3a593db43ee78315dd38664dbb47
2020-10-01 18:42:43 -07:00
Dean Lee 9af3c25166 fix resource leak when rotating encoder (#2141)
old-commit-hash: 209e7aa4719fd88bd465936321ea3e6cf5f10658
2020-09-29 13:53:32 -07:00
grekiki 079f409e58 Uploader speedup (#2214)
* use caching for getxattr

* fix some git issues

* Scheduled network checks

* attempt optimization

* Delete speed_test.py

* Style fixes

* Fix styling

* fix spaces

* fix spaces

* fix naming

* Update uploader.py

* Update mark_all_uploaded.py

* Add file to release

* Update selfdrive/loggerd/tools/mark_all_uploaded.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: cf46de13d2934c52e9c87691c671fe9c78156ec9
2020-09-22 11:37:24 +02:00
Dean Lee a7c8adcdbe read bool param with read_db_bool (#2205)
* read bool param with read_db_bool

* Update selfdrive/loggerd/loggerd.cc

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 0e5a5efffce15cc507d8104aceb58c132689d7c8
2020-09-21 18:17:35 +02:00
Dean Lee ef811e1105 use MessageBuilder::toBytes (#2167)
old-commit-hash: 272f60221c45cc543660a5e491cb800182c8b8f2
2020-09-14 01:17:00 -07:00
Dean Lee 7cee5aae63 more messagebuilder (#2162)
* more messagebuilder

* little more

* revert

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 9fa56b4eab62b5d793e6c6d714c9dbab47bb3f0a
2020-09-13 13:00:06 -07:00
Adeeb Shihadeh ac3422fc0f message builder (#2161)
* use custom MessageBuilder from cereal

* use MesageBuilder.toBytes

* bump cereal

* unused

* another one

* fix ui msg

Co-authored-by: deanlee <deanlee3@gmail.com>
old-commit-hash: 4d5733924a2fdd8a3bbaf5f48869ac744b983401
2020-09-12 21:48:15 -07:00
ZwX1616 d2fa5662b9 Fix loggerd not rotating encoder if dcamera upload disabled (#2133)
* should only count after the check

* include no dcam

* no need to copy

* run with both param

* independent idx

* not break test if no device

* remove unused

* EON D is half

* needs test for qcamera too

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 6a8cd6e054f53ba6ffdb708c6deaa2976c8e0867
2020-09-06 01:21:26 -07:00
Adeeb Shihadeh ff00f6e4a4 lidar is a scam (#2094)
old-commit-hash: 45b4b6007a188fdb35808bd11397ab6fd87f8f61
2020-08-28 16:21:05 -07:00
Adeeb Shihadeh 6919e06a9c small uploader cleanup
old-commit-hash: 82f40f6ff5f4677fed6c1aa84a3229a29d212356
2020-08-27 14:22:59 -07:00
robbederks 7671d18467 Tici camerad (#2048)
* fix camera config

* typos

* oops

* more typo

* lambless

* forget to send

* visualize hist

* more typo

* 0xC000

* simple

* data loss prevention, clean up later

* loggerd

* back up code

* backup

* fixed memory leak

* fix vsync

* upload ecam

* WB

* 3stream

* fix OMX crash on loggerd rotation

* rewritten debayer kernel

* update viewer

* improved AE

* no artifact lines/grids

* standard trigger

* cleanups

* CCM

* cleanups

* slight tweak

* upd push sock

* build all these

* update tele fl

* update cereal

* upd viewer

* DualCameraState -> MultiCameraState

* cameras_open

* disable frame zmq push by default

* more cleanup

* no apks

* fix submodule error

* wat

* clean up trash

* remove junk

* only build on qcom2

* no need to check these

* update cereal

* some more minor cleanup

* bump panda

* add todo

* minor typo

* Revert "minor typo"

This reverts commit 9233a1df7cac214fae6827cdae3a10cb3bd060d9.

* not care

* use consistent hdr

* some cleanup

* Update selfdrive/camerad/main.cc

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* more cleanups

* remove irrelevant stuff

* this too

* cleanup

* rerun ci

Co-authored-by: ZwX1616 <zwx1616@gmail.com>
Co-authored-by: Tici <robbe@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 37d6472bfa1c0ef9f1f8353162b97444ca66e45c
2020-08-26 19:59:56 -07:00
ZwX1616 06439bef18 Fix OMX error on loggerd rotation when using multiple cameras (#1953)
* cherry pick from f8745d3002afe1acd8b740c8421992f1a459b59d

* update cereal

* missed this line

* add enum

* Update selfdrive/loggerd/loggerd.cc

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/loggerd/loggerd.cc

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* use same logroot

Co-authored-by: Tici <robbe@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 3014280d1a7369c0d1f1f4b5bbc7553e656fe8af
2020-08-26 15:02:51 -07:00
Adeeb Shihadeh 4f4751ec35 missing two f's, loggerd should really work on pc
old-commit-hash: 7bee1dbdbfcf0255f0d2338df6787fb6d0a1a961
2020-08-26 13:48:54 -07:00
Adeeb Shihadeh 12e718f670 add frame count check to loggerd rotation test
old-commit-hash: ff5d98f85fbc348db8817c864b6595ee4052731a
2020-08-26 13:06:32 -07:00
Willem Melching 16fe1bb2ad Hardware abstraction class (#2080)
* hardware abstraction class

* De Morgan

* Rename pc hardware class

* Fix sound card in controlsd

* Pc get sim info

* fix hardware in test

* two more

* No more random imei on android

* no randomness on android

* Need to return something that looks like imei for registration to work

* Return proper network strength

* Unused import

* Bug fixes + gpsd is only android
old-commit-hash: c7152d54192605c833912b69cf85514ac2e1b1fc
2020-08-26 14:57:17 +02:00
ZwX1616 61ce097e7d wait longer for tici camerad startup
old-commit-hash: 521b6688ea6f32e6712ac4bdb382c393963b2e07
2020-08-25 21:07:50 -07:00
ZwX1616 275123e6d4 Loggerd rotation test (#2077)
* loggerd test

* delete afterwards

* add ccc

* fix pylint

* cleanup rotation test

* this works

* bump tolerance

* clear the data after test

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 87473fbc41055f8e768089475616d642f3d45ffe
2020-08-25 18:31:49 -07:00
Adeeb Shihadeh e5637bc5de Disable raw upload while onroad (#1894)
* disable raw upload while onroad

* fix tests
old-commit-hash: c8f880665a6331aaed7799b37b12ea639e899c77
2020-07-20 15:21:39 +02:00
Adeeb Shihadeh cdfb090c7a Wunused (#1841)
* enable Wunused, first pass

* unused stuff in snpe model

* these are used on phone

* handle sigint and sigterm in modeld

* fix phone build

* camera qcom

* QCOM build works

* delete unused camerad vars

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: eb1aa3d831fd0d7fffd9aacec1accb0a5bdb0304
2020-07-09 09:25:32 -07:00
Dean Lee 7f84cb0e3f remove duplicate calls to visionstream_destroy (#1843)
old-commit-hash: 3754ddf9ba3329dce8b5a1c93111a33095439c87
2020-07-08 21:47:22 -07:00
Dean Lee 5fb85ede56 add function read_db_bytes (#1662)
old-commit-hash: 90d97de74ddc4672b35a5186e868794468a44345
2020-06-09 13:46:49 -07:00
Willem Melching 55c3a89421 slow down upload check when offroad (#1634)
old-commit-hash: f4e8df7ee6de2998968bfa93f09f2359ca21b89e
2020-06-03 19:28:41 -07:00
Adeeb d035394ce7 Add pre-commit hooks (#1629)
old-commit-hash: ab83e48ec4f7c7ddaa742d9797b0d38646fdb268
2020-06-03 12:54:49 -07:00
Willem Melching a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh 68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
Adeeb Shihadeh be0b43f339 enable flake8 E231: missing whitespace after comma
old-commit-hash: efd5dffb1e727c70065fdbe7499ec9e009dfd282
2020-05-31 12:49:11 -07:00
Adeeb 5e857427ba Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
old-commit-hash: d9bf9f0a4036f55411f6dfbb438990a5eb7f4930
2020-05-30 20:14:58 -07:00
Willem Melching c0866d9edb pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
old-commit-hash: bd0643424357864287ae0485da03f66df85e1fb1
2020-05-27 20:00:14 -07:00
Willem Melching 91f1082394 -Werror (#1567)
* werror

* -Wno-inconsistent-missing-override

* Silence ffmpeg deprecation warnings

* add some more pragmas to ignore warnings

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 50f3f1d3357b356c5b1144c518f35375f5bb9924
2020-05-26 13:27:01 -07:00
Willem Melching 7f0b3180a4 Use C++ version of SubMaster and PubMaster (#1548)
* add PubMaster & SubMaster

remove 'delete msg'

remove headers

* use constructor to initial all submster

* modify drain sockets

* fix typo in ssconscript.remove lines

no checkValid in loggerd

last modify

handle_message:event->&event

fix type

remove heads

event to auto

* new interface

* api changed

* Revert "use constructor to initial all submster"

This reverts commit 73be7ea46250a325ce41d3a0445e34395a2ae692.

* change to new api

* revert loggerd

* dd

* use new PubSub api

* update to new interface

don't modify loggerd

reset panda

reset opendbc

remove empty lines

* switch to new pubMaster

* update to the new inteface

change

remove error code

. to ->

merge paramsd.cc

update panda

fix typo

simplify

fix typo

* Fix build

* always conflate

Co-authored-by: deanlee <deanlee3@gmail.com>
old-commit-hash: ab5af232b243ba8137695f68c125f922fb412d44
2020-05-21 16:04:33 -07:00
robbederks 5a12fc32e7 Ambient light calibration parameters on persist partition (#1429)
* WIP: light sensor persistent params

* fix params writing

* Persistent params argument in C params lib. Fixed symlink flow

* Removed debug prints

* fix boardd

* fix ui

* remove debug print
old-commit-hash: 71bebc4fca91681669c86b5600b67bf2b7f899bf
2020-05-08 19:39:18 -07:00
Adeeb Shihadeh 7bc6491502 these don't need json
old-commit-hash: 9670f8fb9f081a14d1de24f92e0800ebffbb123b
2020-05-04 23:37:07 -07:00
George Hotz 16cbb5e255 Revert "Bypass alignment related copy whenever possible (#1443)"
This reverts commit 235d4f8957ee4566d6217783638fa58a586bb35a.

old-commit-hash: d5ca841b0f18d2e707eb1f73afac842ede9be7e8
2020-05-04 09:54:05 -07:00
George Hotz 6fbcde48e5 Using lgtm.com and fixing found alerts (#1452)
* lgtm in readme, and mac nui fixes

* call super inits in radars

* unused imports, dup lines

* more radars, more unused imports

* pass CP into RadarInterfaceBase

* more fixups

* unused imports

* delete unused lines

* ugh, new unused import

Co-authored-by: George Hotz <geohot@gmail.com>
old-commit-hash: 1295cfe06cd80a2c2f40e0af97697ee818037f08
2020-05-02 12:07:34 -07:00