mawei/StarPilot
1
0
Fork 0
mirror of https://github.com/firestar5683/StarPilot.git synced 2026-07-21 01:02:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix insecure temporary file creation (#1890)

Browse Source 
* Fix insecure temporary file creation

* minor error fix

tmp_path.name (NamedTemporaryFile().name) is required to return the filename string.
old-commit-hash: a34b9f5cb5a691b2153f6a2ba905e6f1f84af341
This commit is contained in:
Mufeed VH
2020-07-18 12:19:57 +05:30
committed by GitHub
parent 370a68623e
commit 9b94e0ae8b
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/params.py
+3 -3
View File
@@ -319,14 +319,14 @@ def write_db(params_path, key, value):
lock.acquire()
try:
tmp_path = tempfile.mktemp(prefix=".tmp", dir=params_path)
with open(tmp_path, "wb") as f:
tmp_path = tempfile.NamedTemporaryFile(mode="wb", prefix=".tmp", dir=params_path, delete=False)
with tmp_path as f:
f.write(value)
f.flush()
os.fsync(f.fileno())
path = "%s/d/%s" % (params_path, key)
os.rename(tmp_path, path)
os.rename(tmp_path.name, path)
fsync_dir(os.path.dirname(path))
finally:
os.umask(prev_umask)