mawei/StarPilot
1
0
Fork 0
mirror of https://github.com/firestar5683/StarPilot.git synced 2026-07-21 01:02:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Multilang: check format arguments are consistent (#29441)

Browse Source 
* format args

* global
old-commit-hash: 103d39259f874678a3ea8818d8e4a5632c1b25d0
This commit is contained in:
Shane Smiskol
2023-08-16 21:30:47 -07:00
committed by GitHub
parent 1097d3b53d
commit 96c8511c37
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
selfdrive/ui/tests/test_translations.py
+8 -1
View File
@@ -11,6 +11,7 @@ from selfdrive.ui.update_translations import TRANSLATIONS_DIR, LANGUAGES_FILE, u
TMP_TRANSLATIONS_DIR = os.path.join(TRANSLATIONS_DIR, "tmp")
UNFINISHED_TRANSLATION_TAG = "<translation type=\"unfinished\"" # non-empty translations can be marked unfinished
LOCATION_TAG = "<location "
FORMAT_ARG = re.compile("%[0-9]+")
class TestTranslations(unittest.TestCase):
@@ -75,6 +76,7 @@ class TestTranslations(unittest.TestCase):
- that the correct format specifier is used (%n)
Non-plural:
- that translation is not empty
- that translation format arguments are consistent
"""
for name, file in self.translation_files.items():
with self.subTest(name=name, file=file):
@@ -95,11 +97,16 @@ class TestTranslations(unittest.TestCase):
for nf in numerusform:
self.assertIsNotNone(nf, f"Ensure all plural translation forms are completed: {source_text}")
self.assertIn("%n", nf, "Ensure numerus argument (%n) exists in translation.")
self.assertIsNone(re.search("%[0-9]+", nf), "Plural translations must use %n, not %1, %2, etc.: {}".format(numerusform))
self.assertIsNone(FORMAT_ARG.search(nf), "Plural translations must use %n, not %1, %2, etc.: {}".format(numerusform))
else:
self.assertIsNotNone(translation.text, f"Ensure translation is completed: {source_text}")
source_args = FORMAT_ARG.findall(source_text)
translation_args = FORMAT_ARG.findall(translation.text)
self.assertEqual(sorted(source_args), sorted(translation_args),
f"Ensure format arguments are consistent: `{source_text}` vs. `{translation.text}`")
def test_no_locations(self):
for name, file in self.translation_files.items():
with self.subTest(name=name, file=file):