WifiManager: no need to update networks in as many places v2 (#37405)

* debug

* todo

* clean up

* clean up

* fix test

system/ui/lib/tests/test_handle_state_change.py

@@ -25,6 +25,7 @@ def _make_wm(mocker: MockerFixture, connections=None):
   wm._need_auth = []
   wm._activated = []
   wm._update_networks = mocker.MagicMock()
+  wm._update_active_connection_info = mocker.MagicMock()
   wm._get_active_wifi_connection = mocker.MagicMock(return_value=(None, None))
   return wm
 
@@ -291,7 +292,7 @@ class TestActivated:
     assert wm._wifi_state.ssid == "MyNet"
 
   def test_activated_side_effects(self, mocker):
-    """ACTIVATED persists the volatile connection to disk and triggers _update_networks."""
+    """ACTIVATED persists the volatile connection to disk and updates active connection info."""
     wm = _make_wm(mocker, connections={"Net": "/path/net"})
     wm._set_connecting("Net")
     wm._get_active_wifi_connection.return_value = ("/path/net", {})
@@ -299,7 +300,8 @@ class TestActivated:
     fire(wm, NMDeviceState.ACTIVATED)
 
     wm._conn_monitor.send_and_get_reply.assert_called_once()
-    wm._update_networks.assert_called_once()
+    wm._update_active_connection_info.assert_called_once()
+    wm._update_networks.assert_not_called()
 
 
 # ---------------------------------------------------------------------------

system/ui/lib/wifi_manager.py

@@ -424,6 +424,7 @@ class WifiManager:
     # prev_state guard: real auth failures come from CONFIG (supplicant handshake).
     # Stale NEED_AUTH from a prior connection during network switching arrives with
     # prev_state=DISCONNECTED and must be ignored to avoid a false wrong-password callback.
+    # TODO: sometimes on PC it's observed no future signals are fired if mouse is held down blocking wrong password dialog
     elif ((new_state == NMDeviceState.NEED_AUTH and change_reason == NMDeviceStateReason.SUPPLICANT_DISCONNECT
            and prev_state == NMDeviceState.CONFIG) or
           (new_state == NMDeviceState.FAILED and change_reason == NMDeviceStateReason.NO_SECRETS)):
@@ -445,12 +446,12 @@ class WifiManager:
         cloudlog.warning("Failed to get active wifi connection during ACTIVATED state")
         self._wifi_state = wifi_state
         self._enqueue_callbacks(self._activated)
-        self._update_networks()
+        self._update_active_connection_info()
       else:
         wifi_state.ssid = next((s for s, p in self._connections.items() if p == conn_path), None)
         self._wifi_state = wifi_state
         self._enqueue_callbacks(self._activated)
-        self._update_networks()
+        self._update_active_connection_info()
 
         # Persist volatile connections (created by AddAndActivateConnection2) to disk
         conn_addr = DBusAddress(conn_path, bus_name=NM, interface=NM_CONNECTION_IFACE)
@@ -652,7 +653,6 @@ class WifiManager:
         conn_addr = DBusAddress(conn_path, bus_name=NM, interface=NM_CONNECTION_IFACE)
         self._router_main.send_and_get_reply(new_method_call(conn_addr, 'Delete'))
 
-      self._update_networks()
       self._enqueue_callbacks(self._forgotten, ssid)
 
     if block: