mawei/StarPilot
1
0
Fork 0
mirror of https://github.com/firestar5683/StarPilot.git synced 2026-08-21 08:14:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

exact matching: use set for invalid (#28537)

Browse Source 
use set
old-commit-hash: fcc268b8be70e72654252e5424840ca37ad04196
This commit is contained in:
Shane Smiskol
2023-06-13 20:00:54 -07:00
committed by GitHub
parent 5400564d71
commit 1b7d771059
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
selfdrive/car/fw_versions.py
+3 -3
View File
@@ -106,7 +106,7 @@ def match_fw_to_car_exact(fw_versions_dict, log=True) -> Set[str]:
FW versions for a list of "essential" ECUs. If an ECU is not considered
essential the FW version can be missing to get a fingerprint, but if it's present it
needs to match the database."""
invalid = []
invalid = set()
candidates = FW_VERSIONS
for candidate, fws in candidates.items():
@@ -130,10 +130,10 @@ def match_fw_to_car_exact(fw_versions_dict, log=True) -> Set[str]:
continue
if not any([found_version in expected_versions for found_version in found_versions]):
invalid.append(candidate)
invalid.add(candidate)
break
return set(candidates.keys()) - set(invalid)
return set(candidates.keys()) - invalid
def match_fw_to_car(fw_versions, allow_exact=True, allow_fuzzy=True, log=True):