mawei/StarPilot
1
0
Fork 0
mirror of https://github.com/firestar5683/StarPilot.git synced 2026-06-27 17:42:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

[cabana] fix clang17 warning (#30490)

Browse Source 
[cabana] Improve signal timing calculation in findsingal.cc

The variables `first_sec` and `last_sec` have been separately initialized first before being used in `std::minmax` for signal timings. This resolves compilation warnings and potential risks of using temporary values of these variables.
old-commit-hash: 2a9986d9480063bb9b53d69a0cca47692c52b6ac
This commit is contained in:
DevTekVE
2023-11-19 08:05:10 +01:00
committed by GitHub
parent 4f1ed42285
commit 0f985f5d13
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/cabana/tools/findsignal.cc
+3 -1
View File
@@ -214,7 +214,9 @@ void FindSignalDlg::setInitialSignals() {
sig.factor = factor_edit->text().toDouble();
sig.offset = offset_edit->text().toDouble();
auto [first_sec, last_sec] = std::minmax(first_time_edit->text().toDouble(), last_time_edit->text().toDouble());
double first_time_val = first_time_edit->text().toDouble();
double last_time_val = last_time_edit->text().toDouble();
auto [first_sec, last_sec] = std::minmax(first_time_val, last_time_val);
uint64_t first_time = (can->routeStartTime() + first_sec) * 1e9;
model->last_time = std::numeric_limits<uint64_t>::max();
if (last_sec > 0) {