Commit Graph

2616 Commits

Author SHA1 Message Date
Shane Smiskol cfe294dde0 GM: allow enabling down to a stop for Silverado/Sierra (#28708)
* Silverado: allow enable down to 0 without user brake

* update docs

* firmly

* better comments, fix docs

* revert docs
old-commit-hash: 82f2f9448b
2023-06-27 00:36:53 -07:00
Shane Smiskol 43dee7f6fb Toyota: check Lane Tracing Assist (LTA) EPS faults (#28711)
* check LTA faults if using LTA

* add test

* add LTA_STATE

* add comment for 0 state

* why did test_models not catch this?

* code 21

* same behavior as LKA (only if LTA is used)

* common definitions!

* more comment

* directly

* fault

* :
old-commit-hash: 07e276d5cf
2023-06-26 23:57:59 -07:00
Shane Smiskol cb8a01a67b Toyota: cleanup steering fault definitions (#28716)
* check LTA faults if using LTA

* add test

* add LTA_STATE

* add comment for 0 state

* why did test_models not catch this?

* code 21

* same behavior as LKA (only if LTA is used)

* common definitions!

* more comment

* revert LTA

* no lta here

* revert test

* no period

* -LTA

* init
old-commit-hash: 7171e052bf
2023-06-26 23:52:34 -07:00
Erich Moraga ca704d8fc9 Toyota: add missing CAR.CAMRY engine f/w (#28679)
`@natey_af` 2019 Camry (ICE)  DongleID|route e308e578239ae93e|2023-06-24--10-30-22
old-commit-hash: a58272cf59
2023-06-26 14:59:39 -07:00
Shane Smiskol 1e0217ddf1 Toyota: set radarUnavailable (#28707)
toyota: set radarUnavailable
old-commit-hash: 84965525b8
2023-06-26 14:27:43 -07:00
morrislee 9bd006f551 GM camera ACC: add camera diagnostic address to fingerprints (#28331)
* add missing addresses FP for silverado

* add for all camera acc gm

* add test

* check both rx and tx

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 2914fa9d12
2023-06-25 20:13:55 -07:00
Shane Smiskol bd874a4053 Lexus: add missing NX 300H 2021 FW (#28678)
* add missing FW

* rm line
old-commit-hash: e171364601
2023-06-25 20:12:28 -07:00
Jason Young 46ba8f8169 VW PQ: Extended standstill for FtS with EPB (#28248)
* VW PQ: Extended standstill for FtS with EPB

* update refs

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 0c223b4814
2023-06-24 21:28:10 -07:00
Jason Young e04a4c7202 VW: Prep for MLB, EPS timer cleanup (#27624)
* VW: Cleanup EPS timer handling, add Event

* add event

* revert that

* bump cereal

* remove accFaultedTemp
old-commit-hash: 336a9ed54a
2023-06-24 21:26:51 -07:00
Shane Smiskol 4be4904143 FPv2: test timing for present ECUs and VIN queries (#28676)
* put one subaddr in parallel_addrs

* p

* remove print

* update test refs

* test

* revert that

* clean up

* clean up

* fix

* print results

* fixup cmt

* move down
old-commit-hash: 3f8c976d99
2023-06-24 05:47:55 -07:00
Shane Smiskol bd4ea24008 FPv2: cleanup FW query timing test (#28677)
* put one subaddr in parallel_addrs

* p

* remove print

* update test refs

* test

* revert that

* clean up

* clean up

* only clean up

* clean up

* rm

* type

* one line

* this is fine
old-commit-hash: ed86a4ae62
2023-06-24 05:09:11 -07:00
Shane Smiskol d3f0f1ef30 Toyota: more ECU documentation (#28674)
* more comments

* only

* by

* it exists, just doesn't respond
old-commit-hash: a763712779
2023-06-24 04:36:30 -07:00
Shane Smiskol eb3da44bf3 Toyota: add alternate hybrid control ECU (#28671)
add alt address for hybrid control
old-commit-hash: 0ae5e9dd50
2023-06-24 00:42:02 -07:00
Shane Smiskol 0776d4b05d Toyota: add HVAC ECU (#28670)
add comment for 2nd abs, could be missing one from non_essential_ecu cars
old-commit-hash: 1b3965a0c4
2023-06-23 22:42:23 -07:00
Shane Smiskol 204fd75347 Toyota: add ECU comments (#28667)
* add some comments about toyota ecus

* updates

* revert that

* update comms

* just move
old-commit-hash: 613128062e
2023-06-23 22:29:43 -07:00
Shane Smiskol 3b148d3bac Toyota: add alternate transmission address (#28666)
* A few cars have a tester present response on this address

* add comment

* another comment

* remove duplicate comment

* Revert "remove duplicate comment"

This reverts commit 51c822ddaa2d063e873693fdf77edbaf491a9192.

* revert 2

* revert 2

* revvy

* commenty

commy
old-commit-hash: b1ae79f381
2023-06-23 20:51:11 -07:00
Vivek Aithal 3ca826028c [SUBARU OUTBACK 6TH GEN] Modify offline torque parameters (#28663)
* add new valkues for subaru, to try

* update refs

* update refs
old-commit-hash: c9f02ae905
2023-06-23 17:06:57 -07:00
Justin Newberry 18cb3e6cb3 Subaru: Signals Cleanup (#28602)
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>

old-commit-hash: 803c077dc1
2023-06-23 21:24:27 +01:00
Shane Smiskol 29310fc6d9 Toyota: add central gateway ECU (#28653)
* add comment about central gateway

* add as ecu

* bump ref

* add to whitelists
old-commit-hash: 164dd5015e
2023-06-22 23:30:34 -07:00
Shane Smiskol 832d374726 Toyota: remove one hybrid control computer ECU address (#28652)
this one isn't queried by techstream
old-commit-hash: 8dc35c14d5
2023-06-22 23:09:39 -07:00
Shane Smiskol fc0426bcfe Toyota: add transmission ECU (#28649)
* add transmission! this is not present on hybrids, since the hybrid computer controls the planetary gears (E-CVT)

* whitelist transmission

* comments
old-commit-hash: 3941aef89b
2023-06-22 21:45:24 -07:00
Adeeb Shihadeh ffcc2e4c61 Revert "simple fuzzing test for all processes (#28584)"
This reverts commit 0e98836e857583849aa4e960b097103a4aeb863d.

old-commit-hash: 7783dc602c
2023-06-22 14:59:50 -07:00
Cameron Clough 9cc4291d77 Ford: add some missing types
old-commit-hash: a485e474c8
2023-06-22 12:14:26 +01:00
Shane Smiskol 9028326c74 Toyota: add combination meter and SRS airbag ECUs (#28633)
* add combination meter and srs airbags

* whitelist
old-commit-hash: af42caa394
2023-06-22 03:59:14 -07:00
Shane Smiskol 6f5f69e735 Toyota: add note about available ECUs (#28632)
add comment
old-commit-hash: 306aa9778c
2023-06-22 01:58:43 -07:00
Shane Smiskol c895586ff3 Toyota: query hybrid vehicle control computer ECU (#28628)
* add comments

* we query abs

* lower

* add hybrid controller

* bump cereal to master

* another PR

* add hybrid to whitelists

* consistency

* check data for this
old-commit-hash: 08112ebc37
2023-06-22 01:53:32 -07:00
Shane Smiskol 703550e855 Chrysler FPv2: rename Ecu.hcp to Ecu.hybrid (#28629)
rename hcp to hybrid
old-commit-hash: d42231b51a
2023-06-22 01:27:15 -07:00
Shane Smiskol 17a3653e4b car_helpers: add variable to disable FW cache (#28626)
* Update car_helpers.py

* actually caches the fw

* simpler
old-commit-hash: 4bec6b7ab7
2023-06-22 01:20:40 -07:00
Shane Smiskol ae58ed5473 Toyota FPv2: log telematics ECU (#28613)
* add electronic parking brake ecu

* add

* add to whitelists

* update refs
old-commit-hash: ae0d1635b4
2023-06-21 00:32:40 -07:00
Shane Smiskol b3f4985151 Toyota FPv2: log electronic parking brake ECU (#28612)
* add electronic parking brake ecu

* add comment

* bump

* screw sequential subaddrs
old-commit-hash: 12be5afb8a
2023-06-20 23:53:20 -07:00
sebmueller01 ea3c526593 Toyota: add missing engine FW for 2023 RAV4 LE (LTA) (#28611)
old-commit-hash: 0416fe5183
2023-06-20 22:55:39 -07:00
Shane Smiskol e830fa0591 Toyota: remove bad FW (#28607)
Never seen last 720 days on this car
old-commit-hash: 8660f69416
2023-06-20 14:54:11 -07:00
Shane Smiskol 65e9468da3 Toyota: rename KWP FW request (#28608)
rename toyota request to kwp (read ecu id)
old-commit-hash: 07fe88b517
2023-06-20 14:54:00 -07:00
Maxime Desroches 7be2b51229 simple fuzzing test for all processes (#28584)
* working test

* classmethod

* review

* add to ci
old-commit-hash: bac193bdd5
2023-06-20 10:57:02 -07:00
Jason Young fbce1c9863 VW MQB: Add FW for 2023 Volkswagen Taos (#28596)
old-commit-hash: 2b49a4754b
2023-06-19 09:52:57 -07:00
Cameron Clough c451cd3017 docs: fix footnote typo
old-commit-hash: b2295c979e
2023-06-17 12:24:20 -07:00
Cameron Clough 7e9f1e1b79 Ford: remove Focus Mk4 from dashcam only (#28551)
old-commit-hash: 78bb637993
2023-06-17 15:16:59 +01:00
Shane Smiskol b02345b12d Nissan FPv2: log different diagnostic session types (#28585)
* standard KWP2000 diagnostic session type

* draft

* clean up

* not needed

* update FP refs

* should log logging
old-commit-hash: 2f2b94758b
2023-06-17 02:39:58 -07:00
martinl 91e7bf83b8 Subaru: log stock AEB (#28052)
* Subaru: log stock AEB

* Remove stockFcw from stockAeb

* Subaru: Add FCW_Cont_Beep to stockFcw signals

* add ES_Brake

* use actuation bit

* bump opendbc

* remove aeb from UI

fix

* Update selfdrive/car/subaru/carstate.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 5cb9360fa0
2023-06-16 22:48:09 -07:00
Shane Smiskol 8e94cb76e6 Ford: add new engine FW for Bronco Sport (#28586)
add new FW

d5f0cbd9ceba7d0c|2023-06-16--17-14-20
old-commit-hash: 6459d46086
2023-06-16 22:45:13 -07:00
Jafar Al-Gharaibeh 75d84438f0 Mazda: Fix BSM detection with blinkers (#27919)
* Mazda: Fix BSM detection

Submitted-by: Samuel <samuel95_54@hotmail.com>
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* bump opendbc

* use new signals

---------

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 354b5be9c3
2023-06-15 20:50:21 -07:00
wilderko e600e4d8b4 Added new fingerprint of VW California 2021 (#28504)
* Added new VW California 2021

* duplicate eps

* hex

---------

Co-authored-by: Pavol Luptak <wilder@pop-os.localdomain>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 10a392a7f1
2023-06-15 18:48:15 -07:00
Maxime Desroches 6355215f81 test: car interface fuzzy testing + generating capnp structs (#28530)
* random car control

* format

* struct generation

* math

* staying real

* really staying real

* move

* split this

* format

* Revert "format"

This reverts commit a70a73952ee3833c4ae839d7b2729ee2a1e1a85b.

* Revert "split this"

This reverts commit ae96be63cbfbee230101e69a0f84c874f321fafa.

* space
old-commit-hash: 3fc104fb6d
2023-06-15 17:01:13 -07:00
Jason Young 38ed81468e VW MQB: Add FW for 2016 SEAT Leon (#28561)
old-commit-hash: 150cda68c2
2023-06-15 16:46:25 -07:00
Shane Smiskol 6e2a086252 FPv2: don't add debug candidates to versions globally (#28562)
* debugging

* this test works, but find a better place

* make test more generic to start testing more than timings

no need to run again in another test function. eventually we
can simulate ECUs and have IsoTpParallelQuery work properly

* Revert "make test more generic to start testing more than timings"

This reverts commit 58e8536b1d8b138902d373e1e1194e70c9eb4b24.

* 2nd try

* clean up

* not even MappingProxyType works

* works

* test that too

* clean up

* refactor to avoid modification online

* revert tests

* more revert

* no longer needed

* clean up
old-commit-hash: 56614124f0
2023-06-15 16:32:32 -07:00
Jason Young b43b2d6a7b VW MQB: Add FW for 2017 Volkswagen Golf (#28559)
old-commit-hash: 4b63feddec
2023-06-15 13:18:35 -07:00
Shane Smiskol 5f3569faf2 HKG: use platform codes to fuzzy fingerprint (#28531)
* get gas/ev/hev from FW (not all correct, poc)

* add test for essential ecus for fuzzy fingerprinting

* kinda works

* stash

* clean up

* add code

* simpler

* use the function

* test it with our cars

* no re

no re

no re

* debugging

* handle empty dict

* simpl

* this is promising

start on making existing fingerprinting functions use the config, instead of entirely replacing them

* needs to allow 1 match

* lay out how this should look

* changes

* executable

* some work

* use config

* fuzzy ecus

* config test

* comment and some clean up

* test platform codes

* use regex, simpler and fixes bug

* in func

* rm bad func

* typing for new func and remove old from dc

* todo done

* tested!

* remove fake platform codes

* thought we needed this, but actually...

* not needed

* not applicable any more

* use config for essential ecus

* first draft of test to make adding/removing fuzzy FP platform intentional

* compile

* clean up test

* even cleaner

* fix default ecus type

* temp fix

* this is mostly in tests now

* test every fuzzy ecu fw returns one platform code

* experiment with dates

* Revert "experiment with dates"

This reverts commit 3251b9cc5c3ca41ca92c8b75ad9b2234b720aa0b.

* clean that up

* comment

* test

* work on all cars

* fix fuzz_fw_fingerprint

* comment

* get first by search

* bit more clean up

* and more

* use compiled pattern for nicer syntax

* default

* flip dat around, much cleaner

* clean up hyundai test a bit

* flip order

same here

* rename test and flip subTest

* fix pylint

* revert fw changes

revert fw changes

* line

* add original functions to test

* needs to be a list

* cmt

* draft (need to count one ecu as a match)

* tiny clean up

* todo: date range

* only in notebook

* remove comment (still can be either list or set)

* same, only notebook

* more consistent signature

* copilot inspired

* copilot no good

* test for date parsing

* better name

* good, now we don't have to worry about the dates mismatching in another test/logic

* comment up+

* some stuff

* clean up

fix test

fix test

* test

* comment

* use utils

* clean up (utils are cleaner and less buggy)

* clean up (utils are cleaner and less buggy)

* fixup test

* use a dash (prettier) and remove some platforms that can fingerprint now!

* compile global pattern

* same as what we do in values

* remove comments

* fuzzy_get_platform_codes is one or none here

* more clean up

* sort imports

* woah woah woah

* add comment

* fix reassigning different types

* add types

* adapt fuzzy test recently added (nice it caught this!)

* update lock

* options

comments

* stash

* comments and fixes

* better comments

* better

* test: run on exact fuzzy matching logic, same results!

* use match_fw_to_car

* test all fw

* ex

* unused random

* this is a possibility

* this is more clear

* fix

* revert

* revert to needing both ECUs to match to reduce false positives, test

* fix excluded platform test :( but it's ok

* add comment

* we actually want to only test fuzzy ecus to make it explicit

* fix mypy

* comment for tomorrow

* just add matches with fuzzy FP

* add comment

* this was the cleanest I could think of, but still working on it. not very easy to understand

* think this is better, but also worse...

* comment: reframing how this works

* revert back to what we did before

* was swapped

* else set

* remove old comment

* fixes from merge

* remove fuzzy_min_match_count from this pr

* fix static analysis

* also unused

* different method first draft

* copy existing fuzzy func

* check all possible ecus exist, only platform codes, slightly refactor main loop

* fix

* Revert recent

Revert "fix"

This reverts commit 5cdb7bda835f1e48e750ab4195e891afe08e11ea.

Revert "check all possible ecus exist, only platform codes, slightly refactor main loop"

This reverts commit d3e918fa20fa4ce881445850f5f7428a3c11adf8.

Revert "copy existing fuzzy func"

This reverts commit 34c8c0545097c84f55f4b4f61907606c93760ddd.

Revert "different method first draft"

This reverts commit b91139055d7d1802c1eb726504798c156a183c9c.

* new func

* fixup test

* remove changes from v1 from fw_versions.py

* clean up a bit

* return part as part of code

* fix test

* add original fuzzy function

* add an ecu match if the date is within range (or date doesn't exist)

* add format for what we're going to do

* not working stash

* the exact matching function does more of what we want with less code and less custom logic

* we don't care about found versions, only codes and dates

* actually we do have an exception

* this works pretty nicely now

* up here

* this is better

* some minor clean up

* old function=now junk

* fix platform code test

* remove old platform code function

* now rename _new to

* use FW_QUERY_CONFIG

* clean up imports

* rename that too

* one line

* correct typing

correct typing

* draft tests

* so that works

* fixup excluded platform test now too

* this is tested by excluded platform test

* test parts and dates

* remove old comment

* old import

* take platform code stuff out of FwQueryConfig

* fix test

* revert debug script

* flip order

* make this a set by default

* revert this part

* correct typing

* clean up comments

* clean that test up too/pylint

* combine these three tests ina clean way

* not right

* more general

* be consistent with quotes

* comment

* comment

* comment in fw_versions

* flip order

* this is more readable

* could test all this, but it's tested in test_hyundai and doesn't do a lot here

* only assert brands which use this

* invalidate all CAN FD ICE and hybrid

* tuple

* can get away without filtering

* add comment reasons

* fix

* some review suggestions

* this works (first draft)

* this is better

* script to print platform codes and dates

* sanity check for dates are in correct ecus and platforms

* mypy

* better variable name and comment

* rename

* same

* slightly better name

* subset

* exclude platforms and live car without dates

* consistent

* self explan

* better name

* test to make sure the functions agree

* clean that up

* comment

* we get other responses from queries not in DB, only check any

* not used or typed
old-commit-hash: f788edb6a5
2023-06-15 02:50:45 -07:00
Shane Smiskol df924490d9 HKG: test list of platforms with no fwdCamera dates (#28555)
* no dates test

* sorted
old-commit-hash: 2166adda5f
2023-06-15 02:14:33 -07:00
Shane Smiskol 8e29e20860 FPv2: rename live FW versions dict (#28550)
rename
old-commit-hash: e771660fa3
2023-06-15 01:29:55 -07:00
Shane Smiskol cfc79b5e8d HKG: add script to view platform codes (#28549)
add script
old-commit-hash: c453771492
2023-06-14 15:54:04 -07:00