Commit Graph

146 Commits

Author SHA1 Message Date
Shane Smiskol d6f6b0de91 Car interface: set tire stiffness in common function (#26625)
* common stiffness

* GM uses factors
old-commit-hash: 712b9014d7
2022-11-29 12:50:27 -08:00
Shane Smiskol 8aadc8dda6 Car interface: set common params after port (#26613)
* remove pylint exception, _get_params takes no defaults

* clean up

* mock uses it too

* unused

* unused

* fix that

* bump

* Update selfdrive/car/interfaces.py
old-commit-hash: 860f441e2f
2022-11-29 11:49:13 -08:00
martinl 94e14da8aa Add FPv2: 2022 Subaru Outback Wilderness (#26540)
Add FPv2: 2022 Outback Wilderness / @valtou
old-commit-hash: 62ad278829
2022-11-21 15:34:20 -08:00
brownspaceman 3a02dc4557 Subaru: add missing engine FW for 2019 Impreza (#26385)
added fw for 2019 subaru impreza
old-commit-hash: ea813a9a7d
2022-11-07 16:48:54 -08:00
Shane Smiskol d064794e80 Subaru: log stock FCW (#26012)
* log stock FCW

* Update selfdrive/car/subaru/carstate.py

* never seen 1 (could be aeb?)
old-commit-hash: f31aa68533
2022-10-08 23:28:33 -07:00
Shane Smiskol 346c543ad6 Subaru: Add missing FW for 2021 Legacy (#25914)
Add missing 2021 Legacy FW from 9936b4bbf75a5fe4|2022-09-26--20-29-47
old-commit-hash: 685533a3a1
2022-09-28 14:06:34 -07:00
Shane Smiskol fa87f05dac Subaru: match panda standstill (#25789)
* subaru: match panda standstill

* subaru: match panda standstill

* actually test standstill

* bump panda to master
old-commit-hash: 86062fee6b
2022-09-14 19:11:49 -07:00
Brandon Bennett 0c480f7b3a Subaru: Add missing 2020 Ascent f/w (#25725)
* add missing ascent fw version

Ascent had recall service for transmission ecu. New values added.

* Update selfdrive/car/subaru/values.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 56b05d55eb
2022-09-12 22:24:11 -07:00
Shane Smiskol ae77b7edc7 FPv2: move car-specific configuration into interfaces (#25711)
* Add VMCU address for EV6

* Rename vmcu

* add to tests

add to tests

* rename to more generic name

* more explicit

* remove print

* Like this much better, removes subtle fingerprinting problems

* clean up

* add test and clean up

* remove hyundai stuffs

* global

* Fpv2Config class

* fix missing fw versions from import order

* unused

* revert for now

* test for fpv2 configs with subtests

* subtests don't work that way

* do toyota as an example

* revert

revert

* do chrysler

* do rest

* stash

* much smaller of a diff than the alternative

* remove unused test

* fix tests

* remove brand from Request

* Make StandardQueries class

* add missing_ecus

clean up

* rename file

* unused

* test implemented

* add comment and rename

add comment and rename

add comment and rename

* should be impossible now

* this is a fixme

* rename to fw_query

* rename this too

* and this

* move vin queries to class

* order

* can use p16!

* formatting

* whoops, this wasn't gated on not len(found_versions)

* make this clear

* Standardize manufacturer software version query
old-commit-hash: 0ef6bb48df
2022-09-09 16:24:29 -07:00
Adeeb Shihadeh e4f9781c17 single longitudinal toggle for e2e and disable radar (#25688)
* single longitudinal toggle for e2e and disable radar

* write disable radar param

* rename

* better param name

* clean that up

* update refs

* update translations

* not live for experimental

* write it out

* vanish
old-commit-hash: 655a64b603
2022-09-07 17:12:49 -07:00
Cameron Clough 2347e913a0 rename esp ECU to abs (#25640)
* rename esp ecu to abs

* bump cereal
old-commit-hash: e9c87daef6
2022-09-07 14:25:57 -07:00
Justin Newberry a333729bc8 Subaru Legacy 22 fingerprint (#25665)
old-commit-hash: 98484697cb
2022-09-05 13:24:17 -07:00
Shane Smiskol 1fcc31aac6 Car docs: add auto-resume column (#25572)
* Move auto resume in sng to car interface

* Update docs

* shorter name, star

* order

* resumes?

* add hidden detail sentence

* good to know this works, but revert

* VW auto resume

* bump cereal to master

* Update ref_commit

* match cereal

* try this

* ?

?

* like this
old-commit-hash: 452d5e42ec
2022-08-30 17:54:40 -07:00
Adeeb Shihadeh 2865664679 Subaru: Legacy 2020-22 support (#25313)
* Subaru: Legacy 2020 support

* clean that up

* force for now

* update years

* test route
old-commit-hash: a21780dbea
2022-08-18 09:02:33 -07:00
Shane Smiskol 40b1ba348b Subaru: add missing Impreza 2017 FW versions (#25424)
* this is from hyundai query

* These are also from Hyundai

* Add missing FW versions from 5c3a4dc9bd0b2eaa|2022-08-12--18-01-46

* more FW
old-commit-hash: 5f5d944368
2022-08-12 19:53:44 -07:00
Adeeb Shihadeh e5130eeb29 Subaru: new harness is on the shop (#25406)
* Subaru: new harness is on the shop

* subaru a
old-commit-hash: 96e8d5c9fe
2022-08-11 17:23:51 -07:00
martinl 41f75ed2a6 Subaru: Add missing Forester 2021 engine fw (#25322)
FPv2: Add Forester 2021 engine fw
old-commit-hash: 09800b623e
2022-08-01 14:32:42 -07:00
Shane Smiskol 537d42c234 Prepare for new supported vehicles webpage (#25021)
* add well maintained footnote

* stash

* some updates for the website

* one extensible sort function, pass sort function into template, continue to use "openpilot ACC"

* use items

same

* return a final dict

* Fix descriptions

* Required

* Add detail sentence

* Make string packages into namedtuple

* add temp year parsing

* revert this

* one unified class like harness

* fix static analysis

* Fix body

Fix body

* Make specifics strong

* remove years

* Make Camry footnote more clear

* Revert this too

* Add notCar text, fix steer speed > enable speed (remove comma, no speed mention)

* fix missing years

* group_by_make

* Use full package text

* Only use full package text

* Check car name if notCar, fix imports

* add_years no longer needed, remove 'with Stop and Go'

* fix that

fix that

fix that

* Exception for Nissan and Subaru

* Adjust DSU footnote text

* Fix speed overrides in sentence, CR-V package imp

* init() was being called multiple times, only need to run once to set row
old-commit-hash: c8a90ef586
2022-08-01 13:26:24 -07:00
Adeeb Shihadeh 3c275a5b26 Subaru: set cruiseState.standstill (#25320)
* Subaru: set cruiseState.standstill

* only global
old-commit-hash: 9eb27259c7
2022-08-01 09:48:03 -07:00
martinl 2108b7f061 Subaru: Add ES_Distance Cruise_Soft_Disable (#24474)
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 811365800c
2022-07-31 19:33:27 -07:00
Adeeb Shihadeh 063f9c46f2 outback harness isn't on the site yet
old-commit-hash: e076b2bd34
2022-07-31 12:47:17 -07:00
Adeeb Shihadeh b34f0129e2 Subaru: 2020 Outback support (#25248)
* Subaru: 2020 Outback support

* bump panda

* bump panda

* update refs

* update refs
old-commit-hash: efa326e208
2022-07-31 12:43:27 -07:00
Adeeb Shihadeh 9dc723b322 Subaru: log EPS torque (#25304)
* Subaru: log EPS torque

* update refs
old-commit-hash: 7fee45ad6c
2022-07-28 16:42:42 -07:00
Adeeb Shihadeh 512590034e Subaru: move all pre-global cars to torque tune (#25281)
* Subaru: move all pre-global cars to torque tune

* pid init
old-commit-hash: 5d4d2c3b0d
2022-07-25 15:55:43 -07:00
Adeeb Shihadeh 5263356958 remove CS.steeringRateLimited (#25251)
* remove CS.steeringRateLimited

* bump cereal

* update refs
old-commit-hash: d462a08056
2022-07-24 14:56:55 -07:00
Adeeb Shihadeh 04af978260 let can packer handle counter (#25240)
* let can packer handle counter

* diff is expected

* update refs

* clean that up

* bump opendbc

* fix sim
old-commit-hash: 0ca62bf7df
2022-07-21 20:54:53 -07:00
chengyu-k 2d7b72edae Impreza 2017: add missing eps FW (#24892)
* Update carFw for Impreza 2017

* Update selfdrive/car/subaru/values.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 063cd137ef
2022-07-21 14:05:02 -07:00
Shane Smiskol 1f2fb8a4ac Subaru Forester: 2022 requires new harness (#25229)
* Revert to 2021

* update docs
old-commit-hash: af1c8e5412
2022-07-20 21:15:33 -07:00
Adeeb Shihadeh 2750e0b70b Subaru: use CANPacker for counter (#25216)
* Subaru: use CANPacker for counter

* bump opendbc

* bump panda
old-commit-hash: 5f021ac1d6
2022-07-19 17:21:07 -07:00
Adeeb Shihadeh 86c7913d23 update compatibility docs with VIN data (#25134)
* start with genesis

* chrysler

* honda

* toyota

* subaru
old-commit-hash: ecac734160
2022-07-12 13:51:25 -07:00
martinl 163599aaad Subaru: XV is supported (#25034)
* Subaru: add XV to supported models

* Update docs
old-commit-hash: eaa8b08510
2022-07-05 16:42:53 -07:00
Shane Smiskol b5ca722f34 car docs: remove steering torque hard-coding (#25019)
remove good torque hardcoding
old-commit-hash: e11bb76a64
2022-07-01 19:11:28 -07:00
Shane Smiskol 0d83812f86 Clean up CarControllers (#25008)
* do VW

* Do the rest

* unused

* ford cc formatting

* final clean ups

* also just return update output
old-commit-hash: d2c2154a32
2022-06-30 17:23:12 -07:00
Shane Smiskol 7f7ea75033 compatibility docs: fixup steering torque star (#24940)
* Ascent has good torque, hard code Toyota, print all unexpected torque star cars

* update docs

* Use subtests

* hardcode CHR for now

generate

* Hard code Impreza

* update refs
old-commit-hash: 789f2d195c
2022-06-22 01:03:29 -07:00
HaraldSchafer b0b1aff5cc Rocket league model (#24869)
* dd9a502d-c8e2-4831-b365-804b0ae0739d/600 80041070-d276-4fed-bdb9-0075e5442908/420

* no elementwise op

* 9dabf0fe-2e60-44bf-8d3a-d20a74aca072/600 ae746590-0bb5-4a16-80db-15f02d314f03/300 c4663a12-b499-4c9b-90dd-b169e3948cb1/60

* explicit slice

* some copies are useful

* 1456d261-d232-4654-8885-4d9fde883894/440 c06eba55-1931-4e00-9d63-acad00161be0/700 af2eb6ba-1935-4318-aaf8-868db81a4932/425

* 154f663e-d3e9-4020-ad49-0e640588ebbe/399 badb5e69-504f-4544-a99e-ba75ed204b74/800 08330327-7663-4874-af7a-dcbd2c994ba7/800

* set steer rate cost to 1.0

* smaller temporal size

* Update model reg

* update model ref again

* This did upload somehow

* Update steer rate cost

Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
old-commit-hash: 9283040d84
2022-06-15 15:29:42 -07:00
HaraldSchafer f7edd5f3d3 Car interface: set max lateral torque from table (#24789)
* json

* better naem

* Read from table

* formatting and default to nan

* Generate docs

* Read from table

* this should be the same

* Prius v is full

* test we always set the tunes correctly

add to release files

* Set for all cars

Set for all cars

* Revert tuning changes

Revert tuning changes

* remove that

* fixes

* update ref commit for new maxLateralAccels

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 3066ad81a8
2022-06-10 17:57:23 -07:00
George Hotz cc71e68aee EyeSight standard on all 2019+ Ascent and Forester (#24799)
* on all 2019+ Ascent Forester

* update docs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 8c101c61a8
2022-06-09 15:11:32 -07:00
Shane Smiskol 1a2bf8412c Car documentation: set steering torque star using car interface (#24709)
* Set good torque using torque controller tuning

* should be equal to

* save lateral accel to car params

* use maxLateralAccel

* always

* same convention

* nan will always evaluate to false

* The great good torque purge

* adjust default friction

* Add data for more cars

* adjust name

* Welcome back, guys. Only adjust good torque if maxLatAccel is set

* Update refs (1.7 is 1.7000001...)
old-commit-hash: c6bc03311c
2022-06-03 17:41:20 -07:00
Shane Smiskol 7464b42368 CarInfo: Add harness information (#24085)
* Add harness information

* test harness enum

* add harness info for tucson

* update Tucson harness

* get rid of development

* make global enum

* fix

* add harness info

* add harness info to CARS.md (since we need multiple lines per HKG platform)

* revert this

* Actively Maintained means something! (aka, to bronze with select VW)

* fix caravelle

* add harness tooltip on maintained column

fix

* lol tubaru

* always assume harness

* update honda harnesses

* add Ioniq hybrid 2017-19 harness, todo: not sure

* unused import

* hmm, did they really switch to the C for 1 year??

* add comment

* add comments

* adding tooltips should be fine

* fix santa fe harness

* welcome back, vw

* no need for two harness strings

* seems fine

* fix 19-20 Niro EV harness

* these were taking from old database, so assume correct

* could be d

* pass all car info into template

* no more tool tips

* these use j533 harnesses

* accidentally got removed in merge

* also merge issue

* don't need these

* make harness non-optional
old-commit-hash: 433fcc0c71
2022-05-11 18:02:21 -07:00
Shane Smiskol 17d33f9d65 Subaru: Add fwdCamera FW for 2018 Crosstrek (#24377)
old-commit-hash: 24b5164ce6
2022-04-29 18:23:47 -07:00
martinl 6c971feb84 Subaru: Add missing FW versions for Forester 2019 and Impreza 2020 (#24225)
* Add FPv2: Subaru Crosstrek 2020 Sport (Canada), a2af7643da1d4017|2022-04-14--12-00-31

* Add FPv2: 2021 Subaru Forester Sport, c2f528d49fe19d53|2022-04-13--20-11-17

* Add FPv2: 2020 Subaru Crosstrek Limited, 0f33f7a9d1949fa6|2022-04-13--14-44-02

* Update FPv2: 2019 Subaru Forester Sport, f6e178e18ba27ca1|2022-04-08--18-22-50

* Update FPv2: 2021 Subaru Forester Touring, 6fcb17b9ef924548|2022-04-14--05-37-28

* Add FPv2: 2019 Subaru Forester Limited, a447729c1d15ff89|2022-04-13--17-54-27

* Add fw for a2af7643da1d4017|2022-04-14--18-21-57 for IMPREZA SPORT 2020

* Add fw for a447729c1d15ff89|2021-12-27--15-35-46 for FORESTER 2019

* Add fw from c2f528d49fe19d53|2022-02-19--13-44-43 for FORESTER 2019

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: df13b26971
2022-04-26 20:34:41 -07:00
martinl 752ccac435 Subaru: remove A/C fw version (#24224)
* Subaru: remove A/C fw version

* add test to ensure the ecu isn't added again

* check CP.carName

* clean up

one line

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 599b1ab3ff
2022-04-25 16:41:34 -07:00
David Peterson a6b0cf3feb docs: add video link for 2019 Subaru Crosstrek (#24251)
* Update values.py

Add video_link :     SubaruCarInfo("Subaru Crosstrek 2018-19", good_torque=True),video_link="https://youtu.be/Agww7oE1k-s"),

* fix syntax

* timestamp to start of openpilot use

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: ce74bd4143
2022-04-19 13:25:56 -07:00
Adeeb Shihadeh b4d25060fa Subaru: remove rest of CAN fingerprints (#24195)
old-commit-hash: c810198815
2022-04-13 11:48:14 -07:00
Adeeb Shihadeh 3789587df1 add alert for CAN bus timeout (#24162)
* add alert for CAN bus timeout

* add alert

* set in interface

* cleanup

* cleanup

* add event

* fix mock

* bump

* bump opendbc

* update refs

* return reader
old-commit-hash: 49c2164814
2022-04-12 22:58:34 -07:00
Shane Smiskol 32389d3293 Subaru: add missing Impreza fw versions (#24194)
* add missing impreza fw versions

* these are duplicate

* this fw version flipped on the 5th for michael and never switched back
old-commit-hash: 3ff14adbd6
2022-04-12 17:15:27 -07:00
martinl 808c139479 Subaru: update supported model years and steering torque (#24118)
* Subaru: update carinfo supported model years and good steering torque

* update torque

* model year 2020 was added to IMPREZA_2020, split out

update docs

* order

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 5e1095e881
2022-04-05 13:04:46 -07:00
Adeeb Shihadeh bd71c594a2 pylint: enforce indentation (W0311) (#24039)
* pylint: enforce indentation (W0311)

* few more
old-commit-hash: 8af20af66d
2022-03-24 23:23:29 -07:00
Adeeb Shihadeh b74dac6080 cars: cleanup CS usage (#23957)
old-commit-hash: 2219cb4478
2022-03-18 15:39:22 -07:00
Shane Smiskol bf8262394f Docs: auto-generate supported cars documentation (#23762)
* make CAR class enum, and values.py formatting

* Revert "make CAR class enum, and values.py formatting"

This reverts commit 04d9817e9d5d6ab5c027754018fc445f2cd3067a.

* stash

* add supported packages and model years

* don't change model years in fps

* move Lexus to info dict and make int enum

* remove sometimes wrong model years from name string

* use enum names

* convert Honda's values

* nice names

* use name

* GM

* Mazda, Ford

* Hyundai: WIP

* finish Hyundai

* fix

* Nissan

* Subaru

* Tesla

* formatting is for another PR

* Chrysler: todo: unify the Pacificas?

* do volkswagen

* this isn't a zoo

* skip enums for now

* Update selfdrive/car/volkswagen/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

* set All

* temp cars

* auto-generate CARS.md

* update type hinting

* add generated file

* add longitudinal star to cars that support disabling radar

* add TODO

* add notes

* add min_steer_speed exception for hatchback

* add minimum steering speeds

* Add exceptions and run generator

* Missing Telluride

* fix Prius v

* missing Prius Prime

generate

* start to convert years to strings

* Fixup Hyundai

* convert year sets to strings

* handle this

* missing S3

* Fix and add all missing cars (verified with script

* Supported Package fixes

* add get_tiered_cars

* Check radarOffCan for removing most Honda from op long

* Update for Avalon stop and go update on master

* Fix missing car params

* add my temporary script i'm using to verify new generated DBC

add my temporary script i'm using to verify new generated DBC

* generate with jinja template

* add header and footer

* clean up

* rename

rename

* add exceptions. jinja is nice, but why are its loop indexes starting at 1?

* add list of known car videos

* See how these look

* Add nice table formatting for column description

Add nice table formatting for column description

* generate

* consisten br tag

* small clean up

* temp

* Move car videos into CarInfo

* add new copy and rename to footnotes

* Revert "temp"

This reverts commit 93c3fce1d3ab406f80cbfb9c00c2237d109c7846.

clean up

* generate

* replace with svg

* simplify a bit

* add footnotes to CarInfo

* move some variables to docs.py

* Add video link for Acadia

* Make Footnote an enum so we don't use random ints

* static analysis fixes

* move to CARS.md

* fix last missing footnote

* add to release files

* rm test file

* use svg

generate

* fix sorting

* not needed

* not sure how this got here

* remove Sedan/Couple and add Diesel footnote

* finish todos

* move make specific footnotes to selfdrive/car/*/values.py

rename

* change to zeros

* align bottom to center

* Apply some suggestions

* Update selfdrive/car/mock/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update copy

* Try headers + bullet points

* somehow better

somehow better

* finish updating copy

* move template and add links to sups

* stars shouldn't be clickable

that didn't work

try this

try this

this is better

* add type hints to CarInfo

add more type hinting

* optional needs a type and any covers all (?)

* move good steering torque to */values.py

* dataclasses are much nicer than attr

* use tuple

* Update docs/cars.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* suggestions

* suggestions

* suggestions

remove

* clean up a bit

* add more type hints

* center stars and remove hardcoding from template

* update copy

* Add test

* Fix types

Fix types

* add supported cars documentation test

* clean up

* replace with docs_definitions

* Add back Footnote enums

* Ah so these are like fstrings!

* Update selfdrive/car/CARS_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update year from master merge

* Fix longitudinal star from merge

* sort properly stars by Column enum

* clean up

* HKG: Sorry guys

* Prius V gets FSR star, like others

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update comment

* No Prius docs change for now

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 31a6b141d6
2022-03-16 21:27:05 -07:00