mawei/MoreTore
1
0
Fork 0
mirror of https://github.com/MoreTore/openpilot.git synced 2026-08-04 15:56:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

cabana: fix QMenu leak (#29956)

Browse Source 
fix qmenu leak
This commit is contained in:
Dean Lee
2023-09-19 02:25:35 +08:00
committed by GitHub
parent da4d4cff7d
commit a450eff89f
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/cabana/messageswidget.cc
+4 -4
View File
@@ -424,7 +424,7 @@ void MessageView::updateBytesSectionSize() {
}
void MessageView::headerContextMenuEvent(const QPoint &pos) {
QMenu *menu = new QMenu(this);
QMenu menu(this);
int cur_index = header()->logicalIndexAt(pos);
QAction *action;
@@ -434,9 +434,9 @@ void MessageView::headerContextMenuEvent(const QPoint &pos) {
// Hide show action
if (header()->isSectionHidden(logical_index)) {
action = menu->addAction(tr("  %1").arg(column_name), [=]() { header()->showSection(logical_index); });
action = menu.addAction(tr("  %1").arg(column_name), [=]() { header()->showSection(logical_index); });
} else {
action = menu->addAction(tr("✓ %1").arg(column_name), [=]() { header()->hideSection(logical_index); });
action = menu.addAction(tr("✓ %1").arg(column_name), [=]() { header()->hideSection(logical_index); });
}
// Can't hide the name column
@@ -450,7 +450,7 @@ void MessageView::headerContextMenuEvent(const QPoint &pos) {
}
}
menu->popup(header()->mapToGlobal(pos));
menu.exec(header()->mapToGlobal(pos));
}
MessageViewHeader::MessageViewHeader(QWidget *parent) : QHeaderView(Qt::Horizontal, parent) {