From e4aada10a400552f63ba4cda11371841071bdf24 Mon Sep 17 00:00:00 2001 From: Nayan Date: Sun, 26 Oct 2025 21:43:30 -0400 Subject: [PATCH] Bug: Model UI Crash Fix (#1431) Model UI Crash Fix --- selfdrive/ui/sunnypilot/qt/offroad/settings/models_panel.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/selfdrive/ui/sunnypilot/qt/offroad/settings/models_panel.cc b/selfdrive/ui/sunnypilot/qt/offroad/settings/models_panel.cc index c3f795e18c..4d89ea58b0 100644 --- a/selfdrive/ui/sunnypilot/qt/offroad/settings/models_panel.cc +++ b/selfdrive/ui/sunnypilot/qt/offroad/settings/models_panel.cc @@ -310,9 +310,8 @@ void ModelsPanel::handleCurrentModelLblBtnClicked() { QList sortedModels; QSet modelFolders; QRegularExpression re("\\(([^)]*)\\)[^(]*$"); - const auto bundles = model_manager.getAvailableBundles(); - for (const auto &bundle : bundles) { + for (const auto &bundle : model_manager.getAvailableBundles()) { auto overrides = bundle.getOverrides(); QString folder; for (const auto &override : overrides) { @@ -392,7 +391,7 @@ void ModelsPanel::handleCurrentModelLblBtnClicked() { showResetParamsDialog(); } else { // Find selected bundle and initiate download - for (const auto &bundle: bundles) { + for (const auto &bundle: model_manager.getAvailableBundles()) { if (QString::fromStdString(bundle.getRef()) == selectedBundleRef) { params.put("ModelManager_DownloadIndex", std::to_string(bundle.getIndex())); if (bundle.getGeneration() != model_manager.getActiveBundle().getGeneration()) {