From 6336a51cb55e34264b44594694e6e0be1d2eefe9 Mon Sep 17 00:00:00 2001 From: Jason Wen Date: Mon, 19 Feb 2024 17:17:39 +0000 Subject: [PATCH] Screen Recorder: Fix blank video files --- selfdrive/ui/qt/screenrecorder/screenrecorder.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/selfdrive/ui/qt/screenrecorder/screenrecorder.cc b/selfdrive/ui/qt/screenrecorder/screenrecorder.cc index fa6ac96e20..8f686977fe 100644 --- a/selfdrive/ui/qt/screenrecorder/screenrecorder.cc +++ b/selfdrive/ui/qt/screenrecorder/screenrecorder.cc @@ -131,7 +131,7 @@ void ScreenRecoder::start() { } void ScreenRecoder::encoding_thread_func() { - uint64_t start_time = nanos_since_boot() -1; + uint64_t start_time = nanos_since_boot(); while (recording && encoder) { QImage popImage; @@ -155,10 +155,11 @@ void ScreenRecoder::stop() { recording = false; update(); + if (encoding_thread.joinable()) { + encoding_thread.join(); + } closeEncoder(); image_queue.clear(); - if (encoding_thread.joinable()) - encoding_thread.join(); } }