From 5fadc71a3aa9f484abac2ded7476fa6bd2290e02 Mon Sep 17 00:00:00 2001 From: PeterPhuTran Date: Fri, 7 Aug 2026 13:37:57 -0700 Subject: [PATCH] swaglog: delete oldest logs on rollover, not newest (#38322) --- openpilot/common/swaglog.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/openpilot/common/swaglog.py b/openpilot/common/swaglog.py index 8b629b3fba..7a8c119c6b 100644 --- a/openpilot/common/swaglog.py +++ b/openpilot/common/swaglog.py @@ -45,7 +45,8 @@ class SwaglogRotatingFileHandler(BaseRotatingHandler): fp = os.path.join(base_dir, fn) if fp.startswith(self.base_filename) and os.path.isfile(fp): log_files.append(fp) - return sorted(log_files) + # newest first, matching _open()'s insert(0, ...) so doRollover()'s pop() deletes the oldest + return sorted(log_files, reverse=True) def shouldRollover(self, record): size_exceeded = self.max_bytes > 0 and self.stream.tell() >= self.max_bytes