From 4f07bf2504ce40df168e46a67d4e45fa3a38ef3b Mon Sep 17 00:00:00 2001
From: Jason Wen <haibin.wen3@gmail.com>
Date: Wed, 4 Oct 2023 15:02:16 -0400
Subject: [PATCH] ui: Hide description on `SPAbstractControl` init

---
 selfdrive/ui/qt/offroad/settings.cc            | 1 +
 selfdrive/ui/qt/offroad/sunnypilot_settings.cc | 2 ++
 selfdrive/ui/qt/widgets/controls.cc            | 2 +-
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/selfdrive/ui/qt/offroad/settings.cc b/selfdrive/ui/qt/offroad/settings.cc
index a3e375f355..58f48a45e0 100644
--- a/selfdrive/ui/qt/offroad/settings.cc
+++ b/selfdrive/ui/qt/offroad/settings.cc
@@ -105,6 +105,7 @@ TogglesPanel::TogglesPanel(SettingsWindow *parent) : ListWidget(parent) {
                                              "In relaxed mode openpilot will stay further away from lead cars."),
                                           "../assets/offroad/icon_speed_limit.png",
                                           longi_button_texts);
+  long_personality_setting->showDescription();
   for (auto &[param, title, desc, icon] : toggle_defs) {
     auto toggle = new ParamControl(param, title, desc, icon, this);
 
diff --git a/selfdrive/ui/qt/offroad/sunnypilot_settings.cc b/selfdrive/ui/qt/offroad/sunnypilot_settings.cc
index b3722d3d9d..07b234ac45 100644
--- a/selfdrive/ui/qt/offroad/sunnypilot_settings.cc
+++ b/selfdrive/ui/qt/offroad/sunnypilot_settings.cc
@@ -330,6 +330,7 @@ SPControlsPanel::SPControlsPanel(QWidget *parent) : ListWidget(parent) {
     "../assets/offroad/icon_blank.png",
     dlp_settings_texts
   );
+  dlp_settings->showDescription();
 
   for (auto &[param, title, desc, icon] : toggle_defs) {
     auto toggle = new ParamControl(param, title, desc, icon, this);
@@ -750,6 +751,7 @@ SPVisualsPanel::SPVisualsPanel(QWidget *parent) : ListWidget(parent) {
     sidebar_temp_texts,
     255
   );
+  sidebar_temp_setting->showDescription();
   addItem(sidebar_temp_setting);
 
   // trigger updateToggles() when toggleFlipped
diff --git a/selfdrive/ui/qt/widgets/controls.cc b/selfdrive/ui/qt/widgets/controls.cc
index 412407b183..5319e74b75 100644
--- a/selfdrive/ui/qt/widgets/controls.cc
+++ b/selfdrive/ui/qt/widgets/controls.cc
@@ -82,7 +82,7 @@ SPAbstractControl::SPAbstractControl(const QString &title, const QString &desc,
   description->setContentsMargins(0, 20, 40, 20);
   description->setStyleSheet("font-size: 40px; color: grey");
   description->setWordWrap(true);
-  description->setVisible(true);
+  description->setVisible(false);
   main_layout->addWidget(description);
 
   main_layout->addStretch();