From 11093e743e6e8cbefdc0e7db6f04c5880271c65a Mon Sep 17 00:00:00 2001 From: Trey Moen <50057480+greatgitsby@users.noreply.github.com> Date: Sun, 13 Sep 2026 14:44:13 -0700 Subject: [PATCH] cabana: improve dark slider track contrast (#38899) --- openpilot/tools/cabana/ui/theme.cc | 2 ++ openpilot/tools/cabana/ui/theme.h | 1 + openpilot/tools/cabana/ui/util.cc | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/openpilot/tools/cabana/ui/theme.cc b/openpilot/tools/cabana/ui/theme.cc index 696a933b82..14d0949835 100644 --- a/openpilot/tools/cabana/ui/theme.cc +++ b/openpilot/tools/cabana/ui/theme.cc @@ -19,6 +19,7 @@ constexpr Palette DARK_PALETTE = { .header = rgb(0x2f65ca), .header_hovered = rgb(0x414e65), .header_active = rgb(0x2f65ca), .accent = rgb(0x2f65ca), .border = rgb(0x282828), .separator = rgb(0x353535), .scrollbar_grab = rgb(0x484b4d), + .slider_track = rgb(0x777777), .tab = rgb(0x353535), .tab_hovered = rgb(0x484b4d), .table_header = rgb(0x484b4d), .grid = rgb(0xbbbbbb, 50.0f / 255.0f), .badge = rgb(0x808080), .bit_background = rgb(0xffffff, 20.0f / 255.0f), @@ -34,6 +35,7 @@ constexpr Palette LIGHT_PALETTE = { .header = rgb(0x308cc6), .header_hovered = rgb(0xe7f3fb), .header_active = rgb(0x308cc6), .accent = rgb(0x308cc6), .border = rgb(0xb6b6b6), .separator = rgb(0xd0d0d0), .scrollbar_grab = rgb(0xb6b6b6), + .slider_track = rgb(0xd0d0d0), .tab = rgb(0xe5e5e5), .tab_hovered = rgb(0xefefef), .table_header = rgb(0xefefef), .grid = rgb(0x000000, 50.0f / 255.0f), .badge = rgb(0xa0a0a4), .bit_background = rgb(0xffffff, 0.0f), diff --git a/openpilot/tools/cabana/ui/theme.h b/openpilot/tools/cabana/ui/theme.h index 020b137c62..9c8653cfe9 100644 --- a/openpilot/tools/cabana/ui/theme.h +++ b/openpilot/tools/cabana/ui/theme.h @@ -14,6 +14,7 @@ struct Palette { ImVec4 header, header_hovered, header_active; // selections ImVec4 accent; ImVec4 border, separator, scrollbar_grab; + ImVec4 slider_track; ImVec4 tab, tab_hovered, table_header; ImVec4 grid; ImVec4 badge; // the fill behind the time labels drawn over a chart diff --git a/openpilot/tools/cabana/ui/util.cc b/openpilot/tools/cabana/ui/util.cc index 64e1b914be..1b7a2a7837 100644 --- a/openpilot/tools/cabana/ui/util.cc +++ b/openpilot/tools/cabana/ui/util.cc @@ -656,7 +656,7 @@ bool fusionSliderInt(const char *label, int *v, int min, int max, float width) { const float hx = x0 + (x1 - x0) * t; ImDrawList *dl = ImGui::GetWindowDrawList(); const float groove_y0 = cy - groove_h * 0.5f, groove_y1 = cy + groove_h * 0.5f; - dl->AddRectFilled(ImVec2(bb_min.x, groove_y0), ImVec2(bb_max.x, groove_y1), u32(palette().separator), groove_h * 0.5f); + dl->AddRectFilled(ImVec2(bb_min.x, groove_y0), ImVec2(bb_max.x, groove_y1), u32(palette().slider_track), groove_h * 0.5f); dl->AddRectFilled(ImVec2(bb_min.x, groove_y0), ImVec2(hx, groove_y1), u32(palette().accent), groove_h * 0.5f); drawSliderHandle(dl, ImRect(ImVec2(hx - SLIDER_LENGTH * 0.5f, cy - handle_h * 0.5f), ImVec2(hx + SLIDER_LENGTH * 0.5f, cy + handle_h * 0.5f)));