From 5b8fba9403bb5b332cdb413474ea68af5412202c Mon Sep 17 00:00:00 2001 From: Jason Wen Date: Sun, 15 Dec 2024 21:19:21 -0500 Subject: [PATCH] Apply suggestions from code review --- selfdrive/car/card.py | 2 -- sunnypilot/mads/helpers.py | 1 - 2 files changed, 3 deletions(-) diff --git a/selfdrive/car/card.py b/selfdrive/car/card.py index de27851f3e..1852dccf74 100755 --- a/selfdrive/car/card.py +++ b/selfdrive/car/card.py @@ -116,8 +116,6 @@ class Car: self.CP.alternativeExperience |= ALTERNATIVE_EXPERIENCE.DISABLE_DISENGAGE_ON_GAS # mads - data_services = list(self.sm.data.keys()) + ['selfdriveStateSP'] - self.sm = messaging.SubMaster(data_services, poll='selfdriveStateSP') MadsParams().set_alternative_experience(self.CP) MadsParams().set_car_specific_params(self.CP) diff --git a/sunnypilot/mads/helpers.py b/sunnypilot/mads/helpers.py index e905c1c191..9c156c5ae1 100644 --- a/sunnypilot/mads/helpers.py +++ b/sunnypilot/mads/helpers.py @@ -34,7 +34,6 @@ from opendbc.sunnypilot.car.hyundai.values import HyundaiFlagsSP class MadsParams: def __init__(self): self.params = Params() - self.allow_always = False def read_param(self, key: str): return self.params.get_bool(key)