diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
old mode 100755
new mode 100644
diff --git a/.github/workflows/repo.yml b/.github/workflows/repo-maintenance.yaml
similarity index 65%
rename from .github/workflows/repo.yml
rename to .github/workflows/repo-maintenance.yaml
index 1445aa635d..060b7f3e6c 100644
--- a/.github/workflows/repo.yml
+++ b/.github/workflows/repo-maintenance.yaml
@@ -1,4 +1,4 @@
-name: repo
+name: repo maintenance
on:
schedule:
@@ -6,13 +6,17 @@ on:
workflow_dispatch:
jobs:
- pre-commit-autoupdate:
- name: pre-commit autoupdate
+ updates:
+ name: updates
runs-on: ubuntu-20.04
container:
image: ghcr.io/commaai/openpilot-base:latest
steps:
- uses: actions/checkout@v3
+ - name: poetry lock
+ run: |
+ pip install poetry
+ poetry lock
- name: pre-commit autoupdate
run: |
git config --global --add safe.directory '*'
@@ -21,8 +25,8 @@ jobs:
uses: peter-evans/create-pull-request@5b4a9f6a9e2af26e5f02351490b90d01eb8ec1e5
with:
token: ${{ secrets.ACTIONS_CREATE_PR_PAT }}
- commit-message: Update pre-commit hook versions
- title: 'pre-commit: autoupdate hooks'
- branch: pre-commit-updates
+ commit-message: Update Python packages and pre-commit hooks
+ title: 'Update Python packages and pre-commit hooks'
+ branch: auto-package-updates
base: master
delete-branch: true
diff --git a/.github/workflows/selfdrive_tests.yaml b/.github/workflows/selfdrive_tests.yaml
index 5c5f8d78d7..b2c1bac822 100644
--- a/.github/workflows/selfdrive_tests.yaml
+++ b/.github/workflows/selfdrive_tests.yaml
@@ -26,6 +26,7 @@ env:
RUN_CL: docker run --shm-size 1G -v $PWD:/tmp/openpilot -w /tmp/openpilot -e PYTHONWARNINGS=error -e PYTHONPATH=/tmp/openpilot -e NUM_JOBS -e JOB_ID -e GITHUB_ACTION -e GITHUB_REF -e GITHUB_HEAD_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_RUN_ID -v $GITHUB_WORKSPACE/.ci_cache/scons_cache:/tmp/scons_cache -v $GITHUB_WORKSPACE/.ci_cache/comma_download_cache:/tmp/comma_download_cache -v $GITHUB_WORKSPACE/.ci_cache/openpilot_cache:/tmp/openpilot_cache $CL_BASE_IMAGE /bin/sh -c
UNIT_TEST: coverage run --append -m unittest discover
+ PYTEST: pytest --continue-on-collection-errors --cov --cov-report=xml --cov-append --durations=0 --durations-min=5
jobs:
build_release:
@@ -248,23 +249,9 @@ jobs:
timeout-minutes: 40
run: |
${{ env.RUN }} "export SKIP_LONG_TESTS=1 && \
- $UNIT_TEST common && \
- $UNIT_TEST opendbc/can && \
- $UNIT_TEST selfdrive/boardd && \
- $UNIT_TEST selfdrive/controls && \
- $UNIT_TEST selfdrive/monitoring && \
- $UNIT_TEST system/loggerd && \
- $UNIT_TEST selfdrive/car && \
- $UNIT_TEST selfdrive/locationd && \
- $UNIT_TEST selfdrive/test/longitudinal_maneuvers && \
- $UNIT_TEST system/tests && \
- $UNIT_TEST system/ubloxd && \
+ $PYTEST && \
selfdrive/locationd/test/_test_locationd_lib.py && \
./system/ubloxd/tests/test_glonass_runner && \
- $UNIT_TEST selfdrive/athena && \
- $UNIT_TEST selfdrive/thermald && \
- $UNIT_TEST system/hardware/tici && \
- $UNIT_TEST tools/lib/tests && \
./selfdrive/ui/tests/create_test_translations.sh && \
QT_QPA_PLATFORM=offscreen ./selfdrive/ui/tests/test_translations && \
./selfdrive/ui/tests/test_translations.py && \
@@ -275,8 +262,7 @@ jobs:
./tools/replay/tests/test_replay && \
./tools/cabana/tests/test_cabana && \
./system/camerad/test/ae_gray_test && \
- ./selfdrive/test/process_replay/test_fuzzy.py && \
- coverage xml"
+ ./selfdrive/test/process_replay/test_fuzzy.py"
- name: "Upload coverage to Codecov"
uses: codecov/codecov-action@v3
@@ -375,7 +361,7 @@ jobs:
- name: Test car models
timeout-minutes: 25
run: |
- ${{ env.RUN }} "pytest --cov --cov-report=xml -n auto --dist=loadscope selfdrive/car/tests/test_models.py && \
+ ${{ env.RUN }} "$PYTEST -n auto --dist=loadscope selfdrive/car/tests/test_models.py && \
chmod -R 777 /tmp/comma_download_cache"
env:
NUM_JOBS: 5
diff --git a/.github/workflows/tools_tests.yaml b/.github/workflows/tools_tests.yaml
index e71a4e397f..ccdbef0044 100644
--- a/.github/workflows/tools_tests.yaml
+++ b/.github/workflows/tools_tests.yaml
@@ -33,11 +33,10 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
- - name: Build Docker image
- run: eval "$BUILD"
+ - uses: ./.github/workflows/setup
- name: Build openpilot
timeout-minutes: 5
- run: ${{ env.RUN }} "scons -j$(nproc) --directory=/tmp/openpilot/cereal --minimal"
+ run: ${{ env.RUN }} "scons -j$(nproc) cereal/ common/ --minimal"
- name: Test PlotJuggler
timeout-minutes: 2
run: |
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index d4259dec17..2ea8d99c14 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -1,3 +1,4 @@
+exclude: '^(tinygrad_repo)'
repos:
- repo: meta
hooks:
@@ -14,6 +15,8 @@ repos:
- id: check-yaml
- id: check-merge-conflict
- id: check-symlinks
+ - id: check-executables-have-shebangs
+ - id: check-shebang-scripts-are-executable
- id: check-added-large-files
args: ['--maxkb=100']
- repo: https://github.com/codespell-project/codespell
@@ -35,7 +38,7 @@ repos:
args: ['--explicit-package-bases']
exclude: '^(third_party/)|(cereal/)|(opendbc/)|(panda/)|(laika/)|(laika_repo/)|(rednose/)|(rednose_repo/)|(tinygrad/)|(tinygrad_repo/)|(xx/)'
- repo: https://github.com/astral-sh/ruff-pre-commit
- rev: v0.0.285
+ rev: v0.0.287
hooks:
- id: ruff
exclude: '^(third_party/)|(cereal/)|(rednose/)|(panda/)|(laika/)|(laika_repo/)|(rednose_repo/)|(tinygrad/)|(tinygrad_repo/)'
diff --git a/README.md b/README.md
old mode 100755
new mode 100644
diff --git a/cereal b/cereal
index 82bca3a971..d469732b3b 160000
--- a/cereal
+++ b/cereal
@@ -1 +1 @@
-Subproject commit 82bca3a9714b73c05414fdf848b6016a0ffac17d
+Subproject commit d469732b3b4c37aaa21fa37682a20f2aba9ab91c
diff --git a/common/params_pyx.pyx b/common/params_pyx.pyx
old mode 100755
new mode 100644
diff --git a/selfdrive/test/process_replay/helpers.py b/common/prefix.py
similarity index 70%
rename from selfdrive/test/process_replay/helpers.py
rename to common/prefix.py
index 0af8ff6c76..702b0feae4 100644
--- a/selfdrive/test/process_replay/helpers.py
+++ b/common/prefix.py
@@ -2,11 +2,11 @@ import os
import shutil
import uuid
-from typing import List, Optional
+from typing import Optional
from openpilot.common.params import Params
-class OpenpilotPrefix(object):
+class OpenpilotPrefix:
def __init__(self, prefix: Optional[str] = None, clean_dirs_on_exit: bool = True):
self.prefix = prefix if prefix else str(uuid.uuid4())
self.msgq_path = os.path.join('/dev/shm', self.prefix)
@@ -24,7 +24,10 @@ class OpenpilotPrefix(object):
def __exit__(self, exc_type, exc_obj, exc_tb):
if self.clean_dirs_on_exit:
self.clean_dirs()
- del os.environ['OPENPILOT_PREFIX']
+ try:
+ del os.environ['OPENPILOT_PREFIX']
+ except KeyError:
+ pass
return False
def clean_dirs(self):
@@ -33,17 +36,3 @@ class OpenpilotPrefix(object):
shutil.rmtree(os.path.realpath(symlink_path), ignore_errors=True)
os.remove(symlink_path)
shutil.rmtree(self.msgq_path, ignore_errors=True)
-
-
-class DummySocket:
- def __init__(self):
- self.data: List[bytes] = []
-
- def receive(self, non_blocking: bool = False) -> Optional[bytes]:
- if non_blocking:
- return None
-
- return self.data.pop()
-
- def send(self, data: bytes):
- self.data.append(data)
diff --git a/common/tests/test_params.py b/common/tests/test_params.py
index 72fa4e3f72..fb6f320ea4 100644
--- a/common/tests/test_params.py
+++ b/common/tests/test_params.py
@@ -1,8 +1,6 @@
import os
import threading
import time
-import tempfile
-import shutil
import uuid
import unittest
@@ -10,12 +8,7 @@ from openpilot.common.params import Params, ParamKeyType, UnknownKeyName, put_no
class TestParams(unittest.TestCase):
def setUp(self):
- self.tmpdir = tempfile.mkdtemp()
- print("using", self.tmpdir)
- self.params = Params(self.tmpdir)
-
- def tearDown(self):
- shutil.rmtree(self.tmpdir)
+ self.params = Params()
def test_params_put_and_get(self):
self.params.put("DongleId", "cb38263377b873ee")
@@ -90,19 +83,19 @@ class TestParams(unittest.TestCase):
self.assertFalse(self.params.get_bool("IsMetric"))
def test_put_non_blocking_with_get_block(self):
- q = Params(self.tmpdir)
+ q = Params()
def _delayed_writer():
time.sleep(0.1)
- put_nonblocking("CarParams", "test", self.tmpdir)
+ put_nonblocking("CarParams", "test")
threading.Thread(target=_delayed_writer).start()
assert q.get("CarParams") is None
assert q.get("CarParams", True) == b"test"
def test_put_bool_non_blocking_with_get_block(self):
- q = Params(self.tmpdir)
+ q = Params()
def _delayed_writer():
time.sleep(0.1)
- put_bool_nonblocking("CarParams", True, self.tmpdir)
+ put_bool_nonblocking("CarParams", True)
threading.Thread(target=_delayed_writer).start()
assert q.get("CarParams") is None
assert q.get("CarParams", True) == b"1"
diff --git a/conftest.py b/conftest.py
new file mode 100644
index 0000000000..e139ab8400
--- /dev/null
+++ b/conftest.py
@@ -0,0 +1,10 @@
+import pytest
+
+from openpilot.common.prefix import OpenpilotPrefix
+
+
+@pytest.fixture(scope="function", autouse=True)
+def global_setup_and_teardown():
+ # setup a clean environment for each test
+ with OpenpilotPrefix():
+ yield
diff --git a/docs/CARS.md b/docs/CARS.md
index c2a4dc1170..633f8df4ef 100644
--- a/docs/CARS.md
+++ b/docs/CARS.md
@@ -2,7 +2,7 @@
# Supported Cars
-A supported vehicle is one that just works when you install a comma three. All supported cars provide a better experience than any stock system. Supported vehicles reference the US market unless otherwise specified.
+A supported vehicle is one that just works when you install a comma device. All supported cars provide a better experience than any stock system. Supported vehicles reference the US market unless otherwise specified.
# 262 Supported Cars
@@ -83,14 +83,14 @@ A supported vehicle is one that just works when you install a comma three. All s
|Hyundai|Ioniq 6 (with HDA II) 2023[6](#footnotes)|Highway Driving Assist II|Stock|0 mph|0 mph|[](##)|[](##)|Parts
- 1 Hyundai P connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai C connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai H connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai C connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai C connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai H connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai C connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai H connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai H connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai B connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai G connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai O connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai R connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai R connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here
|
|Hyundai|Kona Hybrid 2020|Smart Cruise Control (SCC)|openpilot available[1](#footnotes)|0 mph|0 mph|[](##)|[](##)|Parts
- 1 Hyundai I connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai H connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 Hyundai R connector
- 1 RJ45 cable (7 ft)
- 1 comma power v2
- 1 comma three
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 J533 connector
- 1 USB-C coupler
- 1 comma three
- 1 harness box
- 1 long OBD-C cable
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 J533 connector
- 1 USB-C coupler
- 1 comma three
- 1 harness box
- 1 long OBD-C cable
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 J533 connector
- 1 USB-C coupler
- 1 comma three
- 1 harness box
- 1 long OBD-C cable
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 J533 connector
- 1 USB-C coupler
- 1 comma three
- 1 harness box
- 1 long OBD-C cable
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 J533 connector
- 1 USB-C coupler
- 1 comma three
- 1 harness box
- 1 long OBD-C cable
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 J533 connector
- 1 USB-C coupler
- 1 comma three
- 1 harness box
- 1 long OBD-C cable
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 J533 connector
- 1 USB-C coupler
- 1 comma three
- 1 harness box
- 1 long OBD-C cable
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy HereParts
- 1 J533 connector
- 1 USB-C coupler
- 1 comma three
- 1 harness box
- 1 long OBD-C cable
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here