From 974a7a3f7d95253f75ea915fa393000927121eb1 Mon Sep 17 00:00:00 2001 From: James Vecellio-Grant <159560811+Discountchubbs@users.noreply.github.com> Date: Fri, 10 Oct 2025 23:47:45 -0700 Subject: [PATCH] ui: improve toggle states in Developer panel (#1352) ui: quickboot toggle race condition Co-authored-by: Jason Wen --- .../ui/sunnypilot/qt/offroad/settings/developer_panel.cc | 7 +++---- .../ui/sunnypilot/qt/offroad/settings/developer_panel.h | 3 --- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.cc b/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.cc index 9c36097f1..021f5b377 100644 --- a/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.cc +++ b/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.cc @@ -56,14 +56,13 @@ DeveloperPanelSP::DeveloperPanelSP(SettingsWindow *parent) : DeveloperPanel(pare addItem(errorLogBtn); QObject::connect(uiState(), &UIState::offroadTransition, this, &DeveloperPanelSP::updateToggles); - - is_release = params.getBool("IsReleaseBranch"); - is_tested = params.getBool("IsTestedBranch"); - is_development = params.getBool("IsDevelopmentBranch"); } void DeveloperPanelSP::updateToggles(bool offroad) { bool disable_updates = params.getBool("DisableUpdates"); + bool is_release = params.getBool("IsReleaseBranch"); + bool is_tested = params.getBool("IsTestedBranch"); + bool is_development = params.getBool("IsDevelopmentBranch"); prebuiltToggle->setVisible(!is_release && !is_tested && !is_development); prebuiltToggle->setEnabled(disable_updates); diff --git a/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.h b/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.h index 7f67512b5..ed64964a5 100644 --- a/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.h +++ b/selfdrive/ui/sunnypilot/qt/offroad/settings/developer_panel.h @@ -22,9 +22,6 @@ private: ParamControlSP *prebuiltToggle; Params params; ParamControlSP *showAdvancedControls; - bool is_development; - bool is_release; - bool is_tested; private slots: void updateToggles(bool offroad);