From 736cf6d9dffd0db6c6a5a2fb532bea018a3e3ead Mon Sep 17 00:00:00 2001 From: Adeeb Shihadeh Date: Wed, 22 Apr 2026 16:01:35 -0700 Subject: [PATCH] clean up deprecated services (#37885) * clean up deprecated services * lil more --- cereal/log.capnp | 16 +++++++--------- cereal/services.py | 9 --------- system/qcomgpsd/tests/test_qcomgpsd.py | 2 +- tools/jotpluggler/runtime.cc | 1 - 4 files changed, 8 insertions(+), 20 deletions(-) diff --git a/cereal/log.capnp b/cereal/log.capnp index 618aad183..c0ee33743 100644 --- a/cereal/log.capnp +++ b/cereal/log.capnp @@ -2449,7 +2449,6 @@ struct Event { boot @60 :Boot; # ********** openpilot daemon msgs ********** - gpsNMEA @3 :GPSNMEAData; can @5 :List(CanData); controlsState @7 :ControlsState; selfdriveState @130 :SelfdriveState; @@ -2474,7 +2473,6 @@ struct Event { qcomGnss @31 :QcomGnss; gpsLocationExternal @48 :GpsLocationData; gpsLocation @21 :GpsLocationData; - gnssMeasurements @91 :GnssMeasurements; liveParameters @61 :LiveParametersData; liveTorqueParameters @94 :LiveTorqueParametersData; liveDelay @146 : LiveDelayData; @@ -2508,7 +2506,6 @@ struct Event { # systems stuff androidLog @20 :AndroidLogEntry; managerState @78 :ManagerState; - uploaderState @79 :UploaderState; procLog @33 :ProcLog; clocks @35 :Clocks; deviceState @6 :DeviceState; @@ -2518,12 +2515,6 @@ struct Event { # touch frame touch @135 :List(Touch); - # navigation - navInstruction @82 :NavInstruction; - navRoute @83 :NavRoute; - navThumbnail @84: Thumbnail; - mapRenderState @105: MapRenderState; - # UI services uiDebug @102 :UIDebug; @@ -2626,5 +2617,12 @@ struct Event { accelerometer2DEPRECATED @101 :SensorEventData; temperatureSensor2DEPRECATED @123 :SensorEventData; driverMonitoringStateDEPRECATED @71 :DriverMonitoringStateDEPRECATED; + gpsNMEADEPRECATED @3 :GPSNMEAData; + uploaderStateDEPRECATED @79 :UploaderState; + navInstructionDEPRECATED @82 :NavInstruction; + navRouteDEPRECATED @83 :NavRoute; + navThumbnailDEPRECATED @84 :Thumbnail; + gnssMeasurementsDEPRECATED @91 :GnssMeasurements; + mapRenderStateDEPRECATED @105: MapRenderState; } } diff --git a/cereal/services.py b/cereal/services.py index c43d3cb9b..8343874de 100755 --- a/cereal/services.py +++ b/cereal/services.py @@ -25,7 +25,6 @@ _services: dict[str, tuple] = { "gyroscope": (True, 104., 104), "accelerometer": (True, 104., 104), "temperatureSensor": (True, 2., 200), - "gpsNMEA": (True, 9.), "deviceState": (True, 2., 1), "touch": (True, 20., 1), "can": (True, 100., 2053, QueueSize.BIG), # decimation gives ~3 msgs in a full segment @@ -54,7 +53,6 @@ _services: dict[str, tuple] = { "gpsLocation": (True, 1., 1), "ubloxGnss": (True, 10.), "qcomGnss": (True, 2.), - "gnssMeasurements": (True, 10., 10), "clocks": (True, 0.1, 1), "ubloxRaw": (True, 20.), "livePose": (True, 20., 4), @@ -73,10 +71,6 @@ _services: dict[str, tuple] = { "drivingModelData": (True, 20., 10), "modelV2": (True, 20., None, QueueSize.BIG), "managerState": (True, 2., 1), - "uploaderState": (True, 0., 1), - "navInstruction": (True, 1., 10), - "navRoute": (True, 0.), - "navThumbnail": (True, 0.), "qRoadEncodeIdx": (False, 20.), "userBookmark": (True, 0., 1), "soundPressure": (True, 10., 10), @@ -98,9 +92,6 @@ _services: dict[str, tuple] = { "livestreamWideRoadEncodeData": (False, 20., None, QueueSize.MEDIUM), "livestreamRoadEncodeData": (False, 20., None, QueueSize.MEDIUM), "livestreamDriverEncodeData": (False, 20., None, QueueSize.MEDIUM), - "customReservedRawData0": (True, 0.), - "customReservedRawData1": (True, 0.), - "customReservedRawData2": (True, 0.), } SERVICE_LIST = {name: Service(*vals) for idx, (name, vals) in enumerate(_services.items())} diff --git a/system/qcomgpsd/tests/test_qcomgpsd.py b/system/qcomgpsd/tests/test_qcomgpsd.py index 75e870759..9b0644734 100644 --- a/system/qcomgpsd/tests/test_qcomgpsd.py +++ b/system/qcomgpsd/tests/test_qcomgpsd.py @@ -26,7 +26,7 @@ class TestRawgpsd: os.system("sudo systemctl restart ModemManager lte") def setup_method(self): - self.sm = messaging.SubMaster(['qcomGnss', 'gpsLocation', 'gnssMeasurements']) + self.sm = messaging.SubMaster(['qcomGnss', 'gpsLocation']) def teardown_method(self): managed_processes['qcomgpsd'].stop() diff --git a/tools/jotpluggler/runtime.cc b/tools/jotpluggler/runtime.cc index 6eb2be80e..3247a5d01 100644 --- a/tools/jotpluggler/runtime.cc +++ b/tools/jotpluggler/runtime.cc @@ -71,7 +71,6 @@ bool should_subscribe_stream_service(const std::string &name) { "livestreamRoadEncodeIdx", "livestreamDriverEncodeIdx", "thumbnail", - "navThumbnail", }}; if (name == "rawAudioData") return false; for (std::string_view skipped : kSkippedServices) {