From 2f2ee6fcd19feab9e8ad48554897803b73c29c88 Mon Sep 17 00:00:00 2001 From: stefpi <19478336+stefpi@users.noreply.github.com> Date: Wed, 8 Apr 2026 11:33:16 -0700 Subject: [PATCH] remove custom uds request --- opendbc/car/body/values.py | 5 ----- opendbc/car/fw_query_definitions.py | 5 ----- opendbc/car/tests/test_fw_fingerprint.py | 4 ++-- 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/opendbc/car/body/values.py b/opendbc/car/body/values.py index 2193ca44a..86b6a287a 100644 --- a/opendbc/car/body/values.py +++ b/opendbc/car/body/values.py @@ -44,11 +44,6 @@ FW_QUERY_CONFIG = FwQueryConfig( [StdQueries.TESTER_PRESENT_RESPONSE, StdQueries.UDS_VERSION_RESPONSE], bus=0, ), - Request( - [StdQueries.TESTER_PRESENT_REQUEST, StdQueries.APPLICATION_SOFTWARE_FINGERPRINT_REQUEST], - [StdQueries.TESTER_PRESENT_RESPONSE, StdQueries.APPLICATION_SOFTWARE_FINGERPRINT_RESPONSE], - bus=0, - ), ], ) diff --git a/opendbc/car/fw_query_definitions.py b/opendbc/car/fw_query_definitions.py index 969c6705e..2d0656fcb 100644 --- a/opendbc/car/fw_query_definitions.py +++ b/opendbc/car/fw_query_definitions.py @@ -65,11 +65,6 @@ class StdQueries: UDS_VERSION_RESPONSE = bytes([uds.SERVICE_TYPE.READ_DATA_BY_IDENTIFIER + 0x40]) + \ p16(uds.DATA_IDENTIFIER_TYPE.APPLICATION_SOFTWARE_IDENTIFICATION) - APPLICATION_SOFTWARE_FINGERPRINT_REQUEST = bytes([uds.SERVICE_TYPE.READ_DATA_BY_IDENTIFIER]) + \ - p16(uds.DATA_IDENTIFIER_TYPE.APPLICATION_SOFTWARE_FINGERPRINT) - APPLICATION_SOFTWARE_FINGERPRINT_RESPONSE = bytes([uds.SERVICE_TYPE.READ_DATA_BY_IDENTIFIER + 0x40]) + \ - p16(uds.DATA_IDENTIFIER_TYPE.APPLICATION_SOFTWARE_FINGERPRINT) - OBD_VERSION_REQUEST = b'\x09\x04' OBD_VERSION_RESPONSE = b'\x49\x04' diff --git a/opendbc/car/tests/test_fw_fingerprint.py b/opendbc/car/tests/test_fw_fingerprint.py index c837e36d5..811347bb3 100644 --- a/opendbc/car/tests/test_fw_fingerprint.py +++ b/opendbc/car/tests/test_fw_fingerprint.py @@ -262,10 +262,10 @@ class TestFwFingerprintTiming(unittest.TestCase): print(f'get_vin {name} case, query time={self.total_time / self.N} seconds') def test_fw_query_timing(self): - total_ref_time = 7.5 + total_ref_time = 7.4 brand_ref_times = { 'gm': 1.0, - 'body': 0.2, + 'body': 0.1, 'chrysler': 0.3, 'ford': 1.5, 'honda': 0.45,