Commit Graph

166 Commits

Author SHA1 Message Date
Shane Smiskol
3454f1e033 Fix hard deceleration after user accelerates above set cruise speed (#1880)
* Fix hard deceleration after user accelerates above set cruise speed

* 2nd required change
old-commit-hash: ebadb39e42d8a39eaf3bc969157777d596e42012
2020-07-20 17:04:05 +02:00
Adeeb Shihadeh
cd317b0780 Fix most remaining LGTM alerts (#1893)
* fixups from LGTM

* short globals

* fix spinner and textwindow

* total ordering

* no spinner/text window when import from manager

* not android
old-commit-hash: 5db81f60ca8fbc0ef28924b7e93f25a1d4bb3764
2020-07-19 16:12:22 -07:00
Adeeb Shihadeh
a1dbb38a0c Alert when modeld is lagging by more than a frame (#1823)
* alert when modeld is lagging by more than 1 frame

* log frameAge in modelData

* set posenet valid

* compute frame_age once
old-commit-hash: 03e824a4b558daa15191408e88b73fee7ab1792f
2020-07-09 17:02:21 -07:00
Greg Hogan
bcf7edf595 k-line 5 init fault type (#1821)
* k-line 5 baud fault type

* update name

* bump cereal

* fix name

* add missing event
old-commit-hash: c458f5a5d3587d0eb87abbebd86c4f399e28c63d
2020-07-06 09:33:16 -07:00
Adeeb Shihadeh
8b2ae9319a fix blindspot detection
old-commit-hash: 64aeb80dcc651de9836d46db08c2b4a17af364f0
2020-06-30 13:44:56 -07:00
robbederks
4b2775add9 Dos (#1795)
old-commit-hash: df86c476c76f53d385d3c8df63d27588dde3dccd
2020-06-29 12:47:48 +02:00
Adeeb Shihadeh
17fc7e2bec Add alert while in preEnabled state (#1791)
old-commit-hash: ce80684f7ec6a61d8e4f08471611a30562707154
2020-06-28 20:29:42 -07:00
Willem Melching
5f97bf6056 fix wrong car mode alert
old-commit-hash: 5e254da8b39bff7b2710652b5a3c5ec0d96abb95
2020-06-24 18:20:30 -07:00
Adeeb Shihadeh
55225dcd56 Block lane change start on blindspot detection (#1712)
* use BSM to block lane change start

* remove duplicate entry

* add approaching
old-commit-hash: c4a3d7afb0a190ea0abcf3deb0ec754b31de2cb3
2020-06-24 17:31:09 -07:00
ZwX1616
9bca4bfb20 recover EON/C2 AF (#1665)
old-commit-hash: 3aa99a01d7a29c69f1b767b3fca30d18a6047425
2020-06-23 14:33:32 -07:00
Adeeb Shihadeh
ab66589a46 fix engage/disengage sounds
old-commit-hash: 51b7dc0e385945faf0341c52b14555e75e804d04
2020-06-23 10:50:24 -07:00
Adeeb Shihadeh
d66c6202bb more generic alert text for wrongCarMode
old-commit-hash: cab96374c5c511adcb83882c52502924a2d08089
2020-06-19 20:36:10 -07:00
Adeeb Shihadeh
e8ced8bee5 Cleanup startup event handling (#1748)
* cleanup startup event

* always show permanent

* lowest

* update refs
old-commit-hash: ccf6b80c7e5aa24b922ed60a519eab91a1d5ec9b
2020-06-19 16:16:48 -07:00
Adeeb Shihadeh
b32859413f hwType is in health
old-commit-hash: fd8514eee339e68df48c27711b79e90cbca43f76
2020-06-18 15:37:21 -07:00
Adeeb Shihadeh
a8edabe453 if sky visible
old-commit-hash: e892d6a9d9efa624ae486d6c8449a452fd1286ee
2020-06-18 14:40:57 -07:00
Adeeb Shihadeh
fb4bdf8c24 update no GPS alert for comma two users
old-commit-hash: b3101998ed6457e83e326f87be9f062ac97c0030
2020-06-18 13:01:28 -07:00
Adeeb Shihadeh
092cb5a021 NEOS update required alert (#1722)
* NEOS update required

* permanent alert

* bump cereal
old-commit-hash: 6c156d7f45ee21f77fbafcb9867fb0712adb53f5
2020-06-16 12:21:41 -07:00
Adeeb Shihadeh
b16559c4a0 Block entry on non-adaptive cruise mode (#1708)
* block entry on non-adaptive cruise mode

* user disable

* toyota
old-commit-hash: 25688f36cc16f4a4ce57e2e6d7a5c33e78cd520f
2020-06-15 18:11:50 -07:00
Adeeb Shihadeh
1dfa960485 bump cereal
old-commit-hash: 9e34ed4e8ccf624125177df4f3a8511d02115a86
2020-06-15 16:01:35 -07:00
Adeeb Shihadeh
f008dc9f61 bump cereal
old-commit-hash: 92c29c426916765b3af8d976a62502ece295f39e
2020-06-12 20:38:45 -07:00
Willem Melching
415c336c41 no gps warning after 5 minutes (#1692)
old-commit-hash: 684f7b2cc073010eb9e9cebfecbf1205be17d5a8
2020-06-12 16:03:35 -07:00
Adeeb
f396864fab Delay alert creation for some events (#1689)
* add creation delay parameter to alerts

* 1s delay for sensorsInvalid and canError

* bump cereal

* update refs
old-commit-hash: 0bbe870b5f90c25427c4d21cabe4a0f78291eee9
2020-06-12 15:32:50 -07:00
Adeeb
ea0292d86e Move driver monitoring out of controls (#1642)
* move dmonitoring out of controls

* run monitoring unit tests in CI
old-commit-hash: d4858e5ff5753f8a800f3e90cb4c0f69213b87f3
2020-06-09 13:25:15 -07:00
Willem Melching
d0f60029cb Remove slow down for turns (#1647)
* Remove slow down for turns

* update ref
old-commit-hash: 15dc6044d44e7f85293cb9b0187c7d2a51a84c55
2020-06-05 16:01:53 -07:00
Jafar Al-Gharaibeh
bbe43de357 Fix rounding of minSteerSpeed in events (#1620)
I thought I was missing a rounding in Mazda code, but it turned
out to be a missing rounding after the recent event refactoring

Python3 interpreter:
>>> print(" %d  %d" % (1.6,1.4))
 1  1
>>> print(" %d  %d" % (round(1.6),round(1.4)))
 2  1
>>> print(" %d  %d" % (int(round(1.6)),round(1.4)))
 2  1
>>> print(" %d  %d" % (int(round(1.6)),int(round(1.4))))
 2  1

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
old-commit-hash: 73db0791997efa270f6793b7acb422aedc22d21f
2020-06-03 14:01:32 -07:00
Willem Melching
dbdbef72d6 vehicle model types (#1631)
old-commit-hash: 240041708450d916bb49ee229ee4cff0e5f5ab59
2020-06-03 13:47:47 -07:00
Willem Melching
db4a918c2a Bounds checks on liveParameters for testing on desk
old-commit-hash: 0f20ac728f4558ee8a849646f366d816a2479b62
2020-06-03 11:31:12 -07:00
Adeeb
8c0971086b Fix speed too low (#1627)
* fix speed too low

* bump ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 165bcf1f31ffc34b56c84cf8e71f41ce224dd7e3
2020-06-02 17:31:59 -07:00
Willem Melching
a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72fb94397a1edf814fa66044c8d92acbf
2020-06-02 16:29:32 -07:00
Willem Melching
a749ebb1c4 speedTooHigh should not be an immediate disable
old-commit-hash: 205cb04ee95f51c0d96f20d71564ef6d1c530d85
2020-06-01 15:53:41 -07:00
Willem Melching
3e630fce60 Make driverview not pin two cores at 100%
old-commit-hash: fab8425f2f5277f3e767e29f01942448674428b0
2020-06-01 13:58:54 -07:00
Adeeb Shihadeh
37a67a2a14 enable flake8 E502: backslash is redundant between brackets
old-commit-hash: 6466ec982aa47bcbbc7c6a3a7cf60cec0163be84
2020-05-31 17:41:18 -07:00
Adeeb Shihadeh
68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c36b82ef4040e536cc918ba8ad77bec
2020-05-31 14:07:29 -07:00
Adeeb Shihadeh
be0b43f339 enable flake8 E231: missing whitespace after comma
old-commit-hash: efd5dffb1e727c70065fdbe7499ec9e009dfd282
2020-05-31 12:49:11 -07:00
Adeeb
7965569766 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
old-commit-hash: 6051061ff8e7809960cc1f2bad9a582801d5a83e
2020-05-31 00:48:47 -07:00
Adeeb
5e857427ba Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
old-commit-hash: d9bf9f0a4036f55411f6dfbb438990a5eb7f4930
2020-05-30 20:14:58 -07:00
Adeeb Shihadeh
2feaebfc80 break canError into two separate events
old-commit-hash: 916448af25d61a9acf1d35356fafccdfc800c440
2020-05-29 12:00:41 -07:00
Adeeb Shihadeh
5ab1d48f90 Fix below steer speed alert text not updating
old-commit-hash: 7961d5ffd71328f4e104c01244cc6e08152d76fa
2020-05-28 20:39:13 -07:00
HaraldSchafer
3488486258 Minor fixes (#1571)
* was 5 seconds not .2!

* threshold for moving car highers, this can give FPw
old-commit-hash: 67017d69fe02d9ed6a9cfba54565a403e59afcc4
2020-05-27 14:35:01 -07:00
Willem Melching
91f1082394 -Werror (#1567)
* werror

* -Wno-inconsistent-missing-override

* Silence ffmpeg deprecation warnings

* add some more pragmas to ignore warnings

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 50f3f1d3357b356c5b1144c518f35375f5bb9924
2020-05-26 13:27:01 -07:00
Willem Melching
4061f1d530 Add permanent CAN error alert (#1549)
* Add permanent CAN error alert

* canValid needs some time to initialize

* update ref
old-commit-hash: fcf879d783c345ccbf80252de23f649427c35fbd
2020-05-21 16:08:05 -07:00
Willem Melching
ce310f3f65 Revert "Add permanent CAN error alert"
This reverts commit 41dfb2a149788a19eb1ee40a3497f2ab35386b74.

old-commit-hash: e6f24f239041da4dc0d889492f8fbcfda111cd7b
2020-05-21 15:30:16 -07:00
Willem Melching
5e4ada7249 Add permanent CAN error alert
old-commit-hash: 0abf99dbe01cfe87617bb293c8eb047d93f709dd
2020-05-21 14:53:40 -07:00
Willem Melching
12d3366c55 Add percent sign to calibration screen
old-commit-hash: 517826c1e1263f0445c125a002223906b73538a8
2020-05-21 14:43:07 -07:00
Willem Melching
6e41973c3c Handle posenet and sensor alerts in locationd (#1541)
* handle posenet and senor alerts in locationd

* defaults now set in capnp file

* Cleanup c++ version of params learner

* update ref commit
old-commit-hash: d099e09fb77544eb00d13ba9aea34a0a3374a52e
2020-05-19 16:45:20 -07:00
eFini
7ec2abcf08 use buttonEvent.type instead of string (#1533)
old-commit-hash: e14dfa3beca9897dafa776fdd68c5076d7a31d4e
2020-05-18 10:15:30 -07:00
Willem Melching
8189186d8e Alert callback functions were returning tuples
old-commit-hash: c18891b936a964493393242020783482e5467ac5
2020-05-15 18:29:22 -07:00
Willem Melching
a6676b8a62 White panda is deprecated (#1516)
* Start white panda deprecation

* Unify alert text

* Add noentry

* Change to no longer supported

* panda is lowercase

* Capitalize

* rerun ci
old-commit-hash: c85b174584b1281ce1f1d168b0b0610d5d540896
2020-05-15 13:00:00 -07:00
Willem Melching
380d1e4f3d Fix two event names
old-commit-hash: 631d0d94d3beb1bd5ac9000b70104847c8c71dac
2020-05-15 12:24:12 -07:00
Adeeb
48340cc8cb Alerts + Events refactor (#1466)
old-commit-hash: d976233f696040cd5f9a5081c7b21742b7aaef66
2020-05-14 15:21:21 -07:00