Commit Graph

225 Commits

Author SHA1 Message Date
Willem Melching fa7d8f6e1b remove unused line in nissan carstate 2020-06-01 14:39:06 -07:00
Andre Volmensky 843b2940c5 Nissan mph bit (#1609)
* Added MPH bit for Rogue/XTrail

* Init seatbeltUnlatched as True
2020-06-01 14:38:20 -07:00
Willem Melching f575a9ec12 Fix low speed engage on stop and go Hondas (#1613)
* fix low speed engage on stop and go Hondas

* update ref commit
2020-06-01 10:14:11 -07:00
Jafar Al-Gharaibeh 41fbce5906 Mazda: Slower rate for ACC cancel msg to avoid cruise disable (#1615)
* Slower rate for ACC cancel msg to avoid cruise disable

 Sending ACC cancel message at 10hz may end up disabling
main cruise state. That is because stoc ACC use the same
signal for both functions. If cruise is already enabled
the signal canceles it, otherwise cruise is disabled.
10hz seems to be still fast in some cases not allowing
the state to sync up between OP and the Stock state.
5hz avoids that issue. Also, the resume message was also
updated to 5hz as that seems to work better as well.

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Round up 27.96 to 28mph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
2020-06-01 02:04:47 -07:00
Adeeb Shihadeh 6466ec982a enable flake8 E502: backslash is redundant between brackets 2020-05-31 17:41:18 -07:00
Adeeb Shihadeh f3dcf861c7 enable flake8 E303: too many blank lines 2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Willem Melching 02c130731c Add alternate Accord tuning 2020-05-31 13:37:55 -07:00
Willem Melching 106cddb49a White panda no longer supported 2020-05-31 13:33:56 -07:00
Adeeb Shihadeh efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Adeeb 6051061ff8 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
2020-05-31 00:48:47 -07:00
Andre Volmensky 9fc826cb5c Added Rogue 2019/Leaf 2019 fingerprints (#1605)
* Added Rogue 2019/Leaf 2019 fingerprints

* Added Rogue as new car. Updated readme

* Added route to test_car_models.py. Fixed if statements to check against rogue/x-trail

* Fixed paste error

* Merged Leaf fingerprints

* Assume Rogue is MPH until we work out the mph/kph bit
2020-05-30 20:25:32 -07:00
Adeeb d9bf9f0a40 Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
2020-05-30 20:14:58 -07:00
Willem Melching 4fcf47812b add some sanity checks on returned params 2020-05-30 17:15:41 -07:00
Willem Melching b5a2cec913 Improved tune for VW Golf Mk7. #1603
commit 012049274fd5573bdc5d2d0f198817646dfd5a1b
Author: Willem Melching <willem.melching@gmail.com>
Date:   Sat May 30 10:40:49 2020 -0700

    update ref

commit d50cc2d81fd73dcfccfe1a8e2726879941ec5327
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:32:25 2020 -0400

    Discard no-longer-used import

commit c092e6f5092535a3b4bb5cabb6f5ecf83ef754c7
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:21:57 2020 -0400

    Improved tune from community
2020-05-30 17:04:38 -07:00
Willem Melching d920290544 add RAV4H_TSS2 EPS firmware version 2020-05-30 13:38:42 -07:00
Kishan Karunaratne 9256530a1d [GM] Show FCW from OP on dashboard UI / LED (#1596) 2020-05-30 10:17:04 -07:00
Erich Moraga 94b2d4d522 CAR.SIENNA Engine, ESP, and DSU f/w was missing (#1597)
DongleID 307249a92f279059... verified working via TeamViewer, as FPv2 switched to `fingerprintsource = fw`
2020-05-30 10:07:23 -07:00
martinl 7b54dad0b8 Add Subaru blindspot monitoring signals (#1374)
* Add blindspot signals to carstate

* Change blindspot signals to boolean
2020-05-29 23:32:51 -07:00
VirtuallyChris 3d7cd9ec78 Add Camry Hybrid 2018 Engine FW 2020-05-29 17:26:05 -07:00
Jafar Al-Gharaibeh 34b9b5e849 Bounty: Mazda (#988)
* Mazda Port

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update checksum to account for steer angle signal used in some cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add test drive/segment ID to pass CI tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Process gear and brake signals, add new fingerprints

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor some car interface code

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop redundant call, use Ecu, move warning to carstate, fix cruise speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop unused variables, cleanup handsoff tracking

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update to steerError and steeringRate

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor parse gear, update lkas signals from the new dbc

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Better tracking of engage and warning events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* remove commented lines, update speed_kph to match panda

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Steer Error

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Set lkas enable speed to 52 kph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop block signal use, fix LGTM alerts

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* When gas is pressed OP will disengage, sync local state with it

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use car's speed signal instead of wheel speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Tidy up disengage events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Rebase/Refactor with upstream

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Sync stock ACC state with OP

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* mazda dbc file renamed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Improve acc stock and go by removing the 3 seconds limit

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Dashcam

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* PR Feedback

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Send ACC cancel only if we are sure cruise is enabled

Otherwise we run the risk of disabling main cruise

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* updated route

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* no process replay for now

* add to release files

* Revert "updated route"

This reverts commit 233db4f1bc2d8eefaa86488be4f6f88360d20793.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-05-28 22:15:19 -07:00
Willem Melching 3d08dcc3b2 Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
2020-05-28 15:05:04 -07:00
Willem Melching 44851ae934 bump opendbc 2020-05-28 11:53:17 -07:00
Erich Moraga 2bcab668d4 Added CAR.COROLLA_TSS2 EPS f/w x018965B12520 (#1587)
As seen in Discord, for DongleID/route 35794509ea3b423e|2020-05-28--14-51-06 (Euro Toyota Corolla Hatchback Hybrid)...
https://discord.com/channels/469524606043160576/524327905937850394/715579226186579985
2020-05-28 09:07:07 -07:00
Adeeb c78602e8cc Remove incomplete Hyundai Ioniq port (#1570) 2020-05-26 20:48:41 -07:00
Thaixican dd16990952 Add 2020 Lexus RX Hybrid support (#1547)
* Add 2020 Lexus RX Hybrid support

* Add 2020 Lexus RX Hybrid to IGNORED_FINGERPRINTS and route to test_car_models per @pd0wm
2020-05-26 13:49:18 -07:00
Tunder (Chris in RL) a63814866b add missing 2020 stinger value (#1565)
1371: 8 (not always present on startup, causes intermittent dashcam mode)
2020-05-26 09:43:05 -07:00
Adeeb Shihadeh 86057f785b fix interface init for mock car 2020-05-23 15:39:28 -07:00
Willem Melching bfe7cbfe5f Split TSS2 RAV4 tuning based on fw version (#1558) 2020-05-22 14:00:20 -07:00
Willem Melching a623ad2ab3 That corolla eps version was probably merged by mistake 2020-05-22 13:46:54 -07:00
VirtuallyChris 676fd8ecbc Add Engine FW (#1556) 2020-05-22 10:37:19 -07:00
Tunder (Chris in RL) ee371919c1 add missing 2020 pacifica value (#1551) 2020-05-22 10:37:05 -07:00
Alice Knag fde1a5e9af add support for Sonata 2019 (#1538)
* add sonata interface

update values.py

update values.py

* change sonata_1 to sonata_2019

* add sonata 2019 and forte 2019 to README

prettier fucked me up pretty hard at first
sdfsd

* update README.md

* mock test
2020-05-20 17:12:00 -07:00
Willem Melching 68ef23f97b Fixup comments 2020-05-20 14:10:55 -07:00
openpilot laptop b8cc31f888 Add single fw requests for hyundai ECUs not supporting multi requests 2020-05-20 14:07:04 -07:00
Willem Melching 1162041ea6 Only send FW query requests for the right brand (#1546)
* only send requests for the right brand

* this works on sonata

Co-authored-by: openpilot laptop <laptop@comma.ai>
2020-05-20 13:02:24 -07:00
TK211X b62ce27483 Add 2016 Optima Print (#1510)
* Add 2016 Optima Print

* Update values.py
2020-05-20 10:57:21 -07:00
Willem Melching bb8bbdd9ee Hyundai fw query (#1540)
* hyundai fw query

* Change query

* this works

* That is not engine

* hyundai fw query

* Change query

* this works

* That is not engine

* Skip FW query in test_car_models

* Those routes don't fingerprint properly after speedup

* only send toyota queries to subaddresses

Co-authored-by: openpilot laptop <laptop@comma.ai>
2020-05-19 13:43:44 -07:00
VirtuallyChris 92f07b92ab Add missing Civic Hatch FW (#1539) 2020-05-18 16:22:04 -07:00
Hylke Jellema 52fe671c53 More RAV4H_TSS2 FW (#1523) 2020-05-18 10:41:19 -07:00
eFini 4b13a58a93 use constant max speed limit (#1521) 2020-05-18 00:02:55 -07:00
Erich Moraga 6daa255c44 Add fwdCamera f/w for CAR.COROLLAH_TSS2 (#1526)
* Add fwdCamera f/w for CAR.COROLLAH_TSS2

@jamcar23#7629  DongleID/route 095142f13f39faf9|2020-05-16--15-54-21

* Forgot x008646G26011A0 to x008646G2601400
2020-05-18 00:02:37 -07:00
Erich Moraga b9a4e8c882 Added fwdCamera f/w for RX350 ICE (#1531)
* Update values.py

@mikoko#7438 / @mikokolee
DongleID/route f2df066cef1b3647|2020-05-17--16-43-43

* Added missing commas
2020-05-18 00:01:05 -07:00
Chris Souers 7abcf71f92 These lines are an unlabeled duplicate of the 4 below it. (#1519) 2020-05-15 18:30:19 -07:00
Chris Souers b9b8e61e93 Add ECM ID for 2018 Civic Hatchback (#1518) 2020-05-15 16:36:07 -07:00
Willem Melching c85b174584 White panda is deprecated (#1516)
* Start white panda deprecation

* Unify alert text

* Add noentry

* Change to no longer supported

* panda is lowercase

* Capitalize

* rerun ci
2020-05-15 13:00:00 -07:00
Adeeb d976233f69 Alerts + Events refactor (#1466) 2020-05-14 15:21:21 -07:00
Willem Melching 49dd37b81b Add code to steer using TSS2 LTA message (#1507)
* try again with toyota LTA

* Fix dbc and send at 50Hz

* Add commented code

* Remove unused import

* Remove that
2020-05-13 19:09:51 -07:00
xps-genesis 2c39133c09 Split G80 from Hyundai Genesis (#1502)
Previous commit moved G80 from G90 grouping to Hyundai Genesis grouping.
Bug found as minSteerSpeed is 0 for G80 but 60 for Hyundai Genesis.
Taking @pd0wm recommendation and  ungrouping G80 to its own.
2020-05-13 15:31:30 -07:00
Chris McCammon b0aa834eaf Remove Brazil Corolla (#1504) 2020-05-13 15:11:10 -07:00