Commit Graph

43 Commits

Author SHA1 Message Date
Adeeb Shihadeh 1e44b99478 Add missing chrysler can parser checks (#1967)
* add missing chrysler can parser checks

* toyota

* toyota cam

* toyota freqs

* chrysler freqs

* doors

* just chrysler for now

* update refs

* update again
2020-08-02 18:11:42 -07:00
Adeeb Shihadeh 892e1162c0 Car cleanup (#1924)
* cleanup car code

* more pruning

* little more

* less pylint disables

* radar stuff

* fix

* udpate refs

* fix honda bosch

* fix test
2020-07-25 15:07:27 -07:00
Adeeb Shihadeh 35a5b057c1 minor cleanups from LGTM 2020-07-17 23:34:38 -07:00
Adeeb Shihadeh 1ef3b20955 2020 Jeep Grand Cherokee fingerprint
Squashed commit of the following:

commit a1a14048375b4d9c9181b2797621e999738104f8
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Mon Jul 13 16:30:54 2020 -0700

    cleanup

commit cf7d4bb162c5018a05b81dd83f124b3ef7826714
Author: Tunder (Chris in RL) <34691234+Tundergit@users.noreply.github.com>
Date:   Sun Jul 12 21:08:59 2020 -0700

    added missed value

commit b91af6eef1b5d966cf4342475a37129ddb46e8de
Author: Tunder (Chris in RL) <34691234+Tundergit@users.noreply.github.com>
Date:   Sun Jul 12 20:52:41 2020 -0700

    Update values.py

commit d3d564fc76db19eae1464d6d938fdc43aa9b6d4e
Author: Tunder (Chris in RL) <34691234+Tundergit@users.noreply.github.com>
Date:   Fri Jul 10 00:23:35 2020 -0700

    add support for 2020 Grand Cherokee
2020-07-13 17:00:27 -07:00
VirtuallyChris 59cbaf88ef Add missing fp value for Jeep Grand Cherokee 2019 2020-06-24 16:11:59 -07:00
Adeeb 367155168a Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
2020-06-03 16:13:34 -07:00
Willem Melching 843a64c72f Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh 6466ec982a enable flake8 E502: backslash is redundant between brackets 2020-05-31 17:41:18 -07:00
Adeeb Shihadeh f3dcf861c7 enable flake8 E303: too many blank lines 2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Adeeb Shihadeh efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Adeeb 6051061ff8 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
2020-05-31 00:48:47 -07:00
Tunder (Chris in RL) ee371919c1 add missing 2020 pacifica value (#1551) 2020-05-22 10:37:05 -07:00
Adeeb d976233f69 Alerts + Events refactor (#1466) 2020-05-14 15:21:21 -07:00
George Hotz 1295cfe06c Using lgtm.com and fixing found alerts (#1452)
* lgtm in readme, and mac nui fixes

* call super inits in radars

* unused imports, dup lines

* more radars, more unused imports

* pass CP into RadarInterfaceBase

* more fixups

* unused imports

* delete unused lines

* ugh, new unused import

Co-authored-by: George Hotz <geohot@gmail.com>
2020-05-02 12:07:34 -07:00
Adeeb 337529d5cb Add steerWarning and steerError to carState (#1444)
* Add steerWarning and steerError to carState

* fix gm and hyundai

* update refs
2020-05-01 13:13:12 -07:00
Adeeb 6ff08f8dee Chrsyler: calculate checksum in CAN packer (#1438) 2020-04-30 15:43:59 -07:00
Willem Melching f7f0a81d13 Remove fake yaw rate from carstate (#1426)
* remove fake yaw rate from carstate

* update ref
2020-04-27 14:10:07 -07:00
donlbooth 912c3ab879 Adding fingerprint for Jeep Grand Cherokee 2019 Trailhawk (#1354)
* Adding fingerprint for Jeep Grand Cherokee 2019 Trailhawk

* Update values.py
2020-04-13 16:17:58 -07:00
Adeeb 8d791d78dd Abstract pcmEnable and pcmDisable events (#1350)
* don't need individual prev state vars since whole CS is copied

* don't need a whole function since toyota alerts were simplified

* better here

* abstract pcmEnable/pcmDisable events

* the flippening came to NEOS

* delete

* unused

* Revert "the flippening came to NEOS"

This reverts commit 91cfb73b2914f637863335f4e5f5952620b3e977.
2020-04-10 16:12:58 -07:00
Drew Hintz 756dbd8e3b add Jeep GC 2019 USA fingerprint from al_nyc (#1339)
* add Jeep GC 2019 USA fingerprint from al_nyc

* merge Jeep GC 2019 USA fingerprint with existing fingerprint
2020-04-10 14:15:50 -07:00
Willem Melching 746f7ed9b1 2020 Chrysler Pacifica (#1297)
* 2020 pacifica support

* Update readme
2020-03-31 15:47:49 -07:00
George Hotz 2ecddbb3b6 Move all non Honda+Toyota to community supported (#1280)
* readme update, still need the gates on the cars themselves

* add community feature gating to other car ports

* promotion note

* from the brand

* readme touchups

* sell the harness

* full ISO

* update ref

Co-authored-by: George Hotz <geohot@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-03-27 10:59:07 -07:00
rkeulemans c317a57feb Remove unused local variable i (#1265) 2020-03-23 09:43:37 -07:00
rbiasini 093d6cb5ff Fingerprint cleanup (#1231)
* upd panda and opendbc

* Delete unnecessary fingerprints, fix RavH occasional test issue, re-enable test error for overlapping fingerprints within the same candidate
2020-03-11 14:32:03 -07:00
rbiasini fe911bcca8 abstract pedalPressed event (#1218)
* abstract pedalPressed event

* Fix bug

* update refs
2020-03-08 23:35:00 -07:00
rbiasini e90d0e832d Add brake press disengagement in Chrysler (#1163)
* Add brake press disengagement in Chrysler
2020-02-27 10:14:21 -08:00
Willem Melching a475b1269d Add missing fingerprint values for Pacifica 2020-02-25 10:59:16 -08:00
rbiasini 7f390b3875 simplify chrysler checksum (#1158)
* simplify obscure chrysler crc function

* update submodules
2020-02-24 17:04:13 -08:00
Willem Melching 149d079aaf Add Chrysler Pacifica Hybrid fingerprint 2020-02-24 13:51:06 -08:00
rbiasini 9685a5a743 Abstract gasPressed for all cars (#1151)
* min_steer_speed alert (with adjusted hysteresis) for all cars, abstracted gas pre_enable event

* move lines a bit

* more GM cleanup

* typo

* move espDisabled to carState packet

* brought back min steer speed alert only in hyundai. It's a bit tricky and behavior should be changed

* ops, wrong change

* bug

* update cereal

* update ref
2020-02-21 18:24:37 -08:00
Willem Melching 85e8bb90d4 Merge 2019 and 2020 Chrysler Pacifica Hybrid (#1142)
* Merge 2019 and 2020 Chrysler Pacifica Hybrid

* fix carcontroller
2020-02-20 16:23:10 -08:00
Adeeb e8cb6ea06a Abstract common events + event cleanup (#1129)
* too many if

* unused

* whitespace

* key

* sefldrive/car/*

* no more gctx

* lower

* start abstracting common events

* all cars

* start small

* all cars

* reverse gear

* wrongCarMode

* wrongGear

* espDisabled

* steerUnvailable

* make linter happy

* c isn't used

* fix esp_disabled in VW

* update ref

* more red

* more cleanup

* fix subaru

* update ref
2020-02-20 16:22:25 -08:00
rbiasini af39d74a5b Abstract std params (#1138)
* get_can_parser and get_cam_can_parser are now standard static methods
2020-02-20 14:06:02 -08:00
rbiasini dc3ea9b08d get_can_parser and get_cam_can_parser are now standard static methods (#1136) 2020-02-20 13:08:43 -08:00
Adeeb 13f60eae91 Abstract CarInterface init (#1131)
* abstract CarInterface init

* unused

* subaru

* gm cleanup

* vw

* typo

* carcontroller

* more cleanup

* fix vw
2020-02-19 20:37:07 -08:00
rbiasini 0c67143c92 Carstate returns capnp struct (#1115)
* Before abstraction, adding speed init from VW as well

* strting to abstract carstate class

* fix bug and update lock?

* revert pipfile change

* another bug

* fix linter

* bug fix

* remove a bunch of diplicated kf code

* better to not have class vars. will abstract __init__ anyway later

* abstract common instance vars in carstate init and a generic gear parser static method

* abstract gear parser for chrysler

* abstract gm gear parser too

* remove unnecessary random vars

* Chrysler: carstate returns capnp struct directly

* revert ref commit

* test ref

* WIP

* more WIP

* ops, missed this conflict

* ford as well

* not sure why this got deleted

* no need to copy

* remove copy

* remove copy import

* remove unnecessary intermediate variable

* remove obsolete comments

* GM: have carstate returning capnp struct directly

* Honda carstate also outputing capnp struct

* hyundai too now returns capnp from carstate

* ops, not meant this

* Subaru carstate also returning capnp

* Toyota: capnp struct as output of carstate

* fix bool

* minor simplififcation in Honda

* no need to negate

* VW carstate returning capnp struct (#1118)

* VW carstate also returning capnp struct

* fixed typo

* Remove unused blinker button (#1119)

* remove unused blinker button

* ops, this wasn't meant

* remove blinker button for VW as well

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-02-18 15:28:15 -08:00
rbiasini 703eb511da Chrysler: carstate returns capnp struct directly (#1110)
* Before abstraction, adding speed init from VW as well

* strting to abstract carstate class

* fix bug and update lock?

* revert pipfile change

* another bug

* fix linter

* bug fix

* remove a bunch of diplicated kf code

* better to not have class vars. will abstract __init__ anyway later

* abstract common instance vars in carstate init and a generic gear parser static method

* abstract gear parser for chrysler

* abstract gm gear parser too

* remove unnecessary random vars

* Chrysler: carstate returns capnp struct directly

* revert ref commit

* test ref

* ops, missed this conflict

* not sure why this got deleted

* no need to copy

* remove copy import

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-02-17 13:35:51 -08:00
rbiasini 5c52be27ca abstract kf and gear parser as static methods (#1103)
* Before abstraction, adding speed init from VW as well

* strting to abstract carstate class

* fix bug and update lock?

* revert pipfile change

* another bug

* fix linter

* bug fix

* remove a bunch of diplicated kf code

* better to not have class vars. will abstract __init__ anyway later

* Abstract gear parser static method (#1107)

* abstract common instance vars in carstate init and a generic gear parser static method

* update opendbc (#1105)

* abstract gear parser for chrysler

* update opendbc (#1106)

* abstract gm gear parser too

* remove unnecessary random vars
2020-02-17 11:53:53 -08:00
Willem Melching f26f085a36 Add fingerprint for 2019 Chrysler Pacifica Hybrid 2020-02-14 15:35:39 -08:00
Drew Hintz 5aff2b6885 support for Chrysler Pacifica 2020 Hybrid (#1021)
* support for Chrysler Pacifica 2020 Hybrid
Thanks to Benson in Discord.
Example segment: 8190c7275a24557b|2020-01-29--08-33-58--7

* Add relevant route to selfdrive/test/test_car_models.py

* fix segment test name
2020-02-03 09:17:45 -08:00
Adeeb dafdb79db2 Clean up ECU redundancy in selfdrive/car/* (#963)
* clean up ecu redundancy in selfdrive/car

* clean up gear parsing
2020-01-18 23:35:10 -08:00
George Hotz 71ead9adea selfdrive/car 2020-01-17 10:58:43 -08:00