Commit Graph

8985 Commits

Author SHA1 Message Date
Adeeb Shihadeh 20a44bb4e9 debug: add summary to check_timings 2024-06-08 21:01:39 -07:00
Adeeb Shihadeh 1093a4ac82 pandad: fix receive buffer size on failed transfer (#32670) 2024-06-08 20:43:25 -07:00
Adeeb Shihadeh 541b5cbf13 tools/sim: remove special docker image (#32659) 2024-06-08 09:18:28 -07:00
Nelson Chen 3b6862030a Change the term "Non-US" to "South America" for the "Corolla Hybrid (Non-US only) 2020-23" entry (#32658)
The term "Non-US" in cars.md for the "Corolla Hybrid (Non-US only) 2020-23" is not precise enough and should be changed to South America

Users may think "Non-US" includes Europe or Canada, which is not the case for this entry.

It has two issues:

* The 2023 Corolla Hybrid in Europe and Canada include a new Toyota Safety Sense 3.0 that has yet to be supported due to it being a new version and the presence of Toyota Security Key.
* The 2020-2022 Corolla Hybrid in Europe is the same as the 2020-2022 Corolla Hybrid in North America, which is supported by Openpilot and has full-speed ACC due to the presence of an electronic parking brake which is not present in the 2020-2022 Corolla Hybrid in South America and the reason why it is listed as not having full-speed ACC.

The entry should be reverted to at least "Corolla Hybrid (South America) 2020-23" which was proposed but not merged in the pull request:

https://github.com/commaai/openpilot/commit/28454c04cc93dc241da3b004a7154e44313e85c9

Pull request for that change that does not include that commit: https://github.com/commaai/openpilot/pull/26943

Examples of confusion throughout the community:

comma.ai Discord:

https://discord.com/channels/469524606043160576/524327905937850394/1235264758580772996

https://discord.com/channels/469524606043160576/524327905937850394/1228090600272691370

https://discord.com/channels/469524606043160576/954493346250887168/1209952008329633813

https://discord.com/channels/469524606043160576/524327905937850394/1182093384647721140

https://discord.com/channels/469524606043160576/954493346250887168/1147751657543848017

openpilot community Discord:

https://discord.com/channels/771493367246094347/771495215570747403/1247737844727021629

> I think that the supported cars list (https://github.com/commaai/openpilot/blob/master/docs/CARS.md) is incorrect.
>
> I have a UK 2020 Toyota Corolla Hybrid
>
> In the cars list it's listed as "no accel below" 17 mph and no resume from > stop.
>
> This is not my experience. For me it works just fine down to a complete stop and it can resume from a stop too.
>
>

CC: @AlexandreSato
2024-06-08 09:18:00 -07:00
Adeeb Shihadeh 57f21abb4f pandad: fix loopback test (#32656)
* pandad: fix loopback test

* clear all params

* try this

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-06-07 23:58:14 -07:00
Shane Smiskol 90523b3b00 remove old fingerprints test (#32654)
* is this even used?

* remove
2024-06-07 23:38:51 -07:00
Adeeb Shihadeh b42b156fcd card: remove old canRcvtimeout field (#32650)
* card: remove old canRcvtimeout field

* deprecate
2024-06-07 17:03:17 -07:00
Adeeb Shihadeh a7ed190df4 controlsd: remove last mention of CAN (#32646) 2024-06-06 16:46:27 -07:00
Harald Schäfer e71ec4e8d7 Split cereal into cereal/msgq (#32631)
* squash

* fix doc

* compile device

* compile device

* Update ref

* add msgq to precommit exclusions

* No service ports

* fix compile

* address comments

* More comments

* Delete logger

* Update opendbc

* Linting

* bump msgq
2024-06-06 14:31:56 -07:00
Vivek Aithal e8857a6713 [Lag] Increase Optima Lag (#32583)
increase lag in optima to 0.2
2024-06-06 01:14:28 -07:00
Dean Lee 983063c3e6 events.py: rename event counters (#32596)
* improve prev event counters

* just rename

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-06-06 00:13:57 -07:00
Dean Lee 3a43f5d784 fuzzy_generation.py: improve performance (#32591)
* improve performance

* remove DEPRECATED

* formatting

* catch kjException

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-06-05 23:48:20 -07:00
Shane Smiskol ae375091db Genesis G70 2020: use common specs (#32641)
use non-2020 specs
2024-06-05 23:44:19 -07:00
Dean Lee 045b9f20b7 improve get_torque_params (#32586)
* Loading torque data only once and reusing it across function calls.

* apply review

* still check only one entry

* fix that

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-06-05 21:21:16 -07:00
Solomon Jones a418c9e40a Fingerprint for 2017 Subaru Forester (#32584)
Fingerprint for 2017 Forester
2024-06-05 21:18:29 -07:00
Dean Lee 91fd918fcb car/interfaces.py: optimize parse_gear_shifter() with predefined dictionary (#32592)
Optimize gear shifter parsing for improved performance
2024-06-05 18:04:03 -07:00
Shane Smiskol 7cfd91bb69 Restore lateral limits report (#32640)
* stash

* staaaaash

* clean up

* more clean up

* fix

fix

* fix

* stash

clean up

* more

* this is just simpler to understand

* explicitly check
2024-06-05 18:03:23 -07:00
Adeeb Shihadeh 260e18f0ae fix linter 2024-06-05 17:32:47 -07:00
Adeeb Shihadeh e828a7bdcf pandad: add more context to spi logs (#32639)
* pandad: add more context to spi logs

* cleanup

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-06-05 17:27:57 -07:00
Adeeb Shihadeh 51fdf23304 thermald is hardwared (#32637)
* thermald is deviced

* hardwared

* rename
2024-06-05 15:58:00 -07:00
Adeeb Shihadeh a46f1c6eba pandad: add jungle spam mode to test (#32636)
Co-authored-by: Comma Device <device@comma.ai>
2024-06-05 15:23:25 -07:00
Adeeb Shihadeh 7b09285817 pandad: move to core 3 (#32402)
* move to core 3

* core is fully offlined now

* move to init

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-06-05 14:50:25 -07:00
Riley Williams 7381872a54 2024 IONIQ 6 (#32302)
* Tweak carspecs for 2023 (and now also 24) ioniq 6 to reflect public info instead of cloning ioniq 5 specs

* Regenerated car docs

* revert specs *for now*

---------

Co-authored-by: Riley Williams <riley@rileyww.dev>
Co-authored-by: Riley Williams <riley@rileyw.dev>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-06-05 14:34:02 -07:00
Adeeb Shihadeh 9526334049 jenkins: fix unsafe checkout when changing submodules (#32635)
do it twice
2024-06-05 14:00:55 -07:00
Shane Smiskol bbc21b9f52 [bot] Fingerprints: add missing FW versions from new users (#32605)
Export fingerprints
2024-06-04 22:09:54 -07:00
Shane Smiskol de61d417b9 Honda: remove programmedFuelInjection ECU (#32626)
* set up for quick test

* remove pgfi

* Revert "set up for quick test"

This reverts commit aa6af2ff838b2cd203a6feaacaa5b4f3b71272ed.

* still query JIC
2024-06-04 21:29:05 -07:00
Adeeb Shihadeh 877b810ac9 pandad: reset CAN comms on checksum failure (#32629) 2024-06-04 21:26:16 -07:00
Adeeb Shihadeh 34e329649d boardd is pandad (#32628)
* boardd is pandad

* rename tests
2024-06-04 19:16:55 -07:00
Dean Lee 23fcd68707 LongControl: storing T_IDXS[:CONTROL_N] in a variable for reuse (#32599)
Improve Control Trajectory Interpolation Efficiency
2024-06-04 17:04:50 -07:00
Shane Smiskol e494d98960 Honda: helpful non-essential ECU comment 2024-06-04 16:37:01 -07:00
Shane Smiskol ba9ea0a25f Hyundai: remove Ioniq EV 2020 CAN fingerprint (#32625)
* add from afc1609bb1584f28

* remove HYUNDAI_IONIQ_EV_2020 CAN fingerprint
2024-06-04 16:31:16 -07:00
Dean Lee 2482ed085e modeld: cleanup commonmodel (#32618)
cleanup
2024-06-04 11:20:17 -07:00
Vivek Aithal 8a4bfcf5b4 [torqued] Reduce friction for some Hyundai cars (#32578)
* reduce friction coeff for ev6 and ioniq6

* Update ref

---------

Co-authored-by: Bruce Wayne <harald.the.engineer@gmail.com>
2024-06-04 11:10:04 -07:00
Dean Lee 25e15846f1 ui/cameraview: fix deadlock on exit due to Qt::BlockingQueuedConnection (#32620)
fix deadlock
2024-06-04 10:25:46 -07:00
Shane Smiskol c7b3ece37e revert marking some files as unexecutable (#32613)
* this is not a test

* these are not tests!
2024-06-03 17:19:27 -07:00
Adeeb Shihadeh 69f57fb6a8 boardd: check CAN in SPI test (#32400)
* test

* little more

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-06-03 17:05:06 -07:00
Adeeb Shihadeh c59887c810 test_*.py files are no longer executable (#32610)
* test_*.py files are no longer executable

* cleanup empty lines

* update precommit

* fixme

* enable

* build
2024-06-03 15:48:56 -07:00
Shane Smiskol 7c4b7ce799 [bot] Fingerprints: add missing FW versions from CAN fingerprinting cars (#32604)
Export fingerprints
2024-06-03 14:11:51 -07:00
Dean Lee 1e70b23855 LongitudinalPlanner: replace hardcoded length with ModelConstants.IDX_N (#32597)
replace hardcoded length
2024-06-02 22:52:45 -07:00
Shane Smiskol 63f55f4915 debug FW fingerprinting: live support (#32585)
* live debug!

* clean up
2024-05-31 22:28:03 -07:00
Dean Lee 9908b729c8 api: cache RSA private key (#32566) 2024-05-31 21:40:53 -07:00
cl0cks4fe 8f4b00c263 cache get_torque_params (#32560)
* cache get_torque_params

* switch to cache

* Update selfdrive/car/interfaces.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-05-31 13:43:12 -07:00
Shane Smiskol f887b8703c add Hyundai CAN FD fingerprinting note 2024-05-30 23:08:14 -07:00
Shane Smiskol 0a43d82428 fw_versions debug: match online vin retry 2024-05-30 22:20:04 -07:00
William Stairs 984ad8833a Add Chassis for VW Arteon Shooting Brake 2020-2023 (#32579)
* Added Arteon "3H" chassis code for Shooting Brake to VWCarDocs.

* Added new engine and transmission FW to Volkswagen fingerprints.py for Arteon Mk1.

* Apply suggestions from code review

* updates docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-05-30 21:35:19 -07:00
Shane Smiskol 57d64279bd ui: re-generate JWT on valid system time (#32571)
* revert me

* Revert "revert me"

This reverts commit 17d815ddfc9a18f7fb9f39f89ec8b4481389b339.

* duh we have timed!

* clean up

* use clocks

* re-initialize map on SSL handshake failure (time)

* this is fine, takes some time to init

* fix

* log errors like map renderer

* more clean up

full message is "loading style failed: SSL handshake failed"

* MOAR

* we still can't swap the token live

* mbgl has its own retries that never work, don't reinit multiple times at once

* simpler

* more

* whoops

* this works

* fix from merge

* rm

* fix cmt

* only an issue calling the function inside itself
2024-05-30 02:08:31 -07:00
Shane Smiskol c2f55a2600 map window: log style load errors (#32573)
log errors
2024-05-30 01:52:43 -07:00
ZwX1616 a16fbdae38 dmonitoringd: set invalid if missing dependence(s) (#32569)
* no step but still send

* no this

* update diff
2024-05-29 15:43:55 -07:00
kacperhq 325dcec06b KIA SPORTAGE 5th HEV 2022 EUR fingerprint (#32558)
Update fingerprints.py

KIA Sportage 5th GEN EUR ver
2024-05-28 15:27:08 -07:00
Shane Smiskol 521ee46c47 [bot] Fingerprints: add missing FW versions from new users (#32552)
Export fingerprints
2024-05-27 22:01:31 -07:00