diff --git a/panda/board/drivers/gmlan_alt.h b/panda/board/drivers/gmlan_alt.h index 6d4ba12b8..2f2e56805 100644 --- a/panda/board/drivers/gmlan_alt.h +++ b/panda/board/drivers/gmlan_alt.h @@ -122,7 +122,12 @@ int get_bit_message(char *out, CAN_FIFOMailBox_TypeDef *to_bang) { return len; } +void TIM4_IRQ_Handler(void); + void setup_timer4(void) { + // register interrupt + REGISTER_INTERRUPT(TIM4_IRQn, TIM4_IRQ_Handler, 40000U, FAULT_INTERRUPT_RATE_GMLAN) + // setup register_set(&(TIM4->PSC), (48-1), 0xFFFFU); // Tick on 1 us register_set(&(TIM4->CR1), TIM_CR1_CEN, 0x3FU); // Enable @@ -236,7 +241,6 @@ void TIM4_IRQ_Handler(void) { gmlan_sendmax = -1; // exit } } - TIM4->SR = 0; } else if (gmlan_alt_mode == GPIO_SWITCH) { if ((TIM4->SR & TIM_SR_UIF) && (gmlan_switch_below_timeout != -1)) { if ((can_timeout_counter == 0) && gmlan_switch_timeout_enable) { @@ -259,10 +263,10 @@ void TIM4_IRQ_Handler(void) { } } } - TIM4->SR = 0; } else { - puts("invalid gmlan_alt_mode\n"); + // Invalid GMLAN mode. Do not put a print statement here, way too fast to keep up with } + TIM4->SR = 0; } bool bitbang_gmlan(CAN_FIFOMailBox_TypeDef *to_bang) { @@ -280,7 +284,6 @@ bool bitbang_gmlan(CAN_FIFOMailBox_TypeDef *to_bang) { set_gpio_mode(GPIOB, 13, MODE_OUTPUT); // 33kbps - REGISTER_INTERRUPT(TIM4_IRQn, TIM4_IRQ_Handler, 40000U, FAULT_INTERRUPT_RATE_GMLAN) setup_timer4(); } return gmlan_send_ok; diff --git a/panda/board/main.c b/panda/board/main.c index a758bf705..8bc4ac78f 100644 --- a/panda/board/main.c +++ b/panda/board/main.c @@ -294,19 +294,11 @@ int usb_cb_control_msg(USB_Setup_TypeDef *setup, uint8_t *resp, bool hardwired) break; // **** 0xb0: set IR power case 0xb0: - if(power_save_status == POWER_SAVE_STATUS_DISABLED){ - current_board->set_ir_power(setup->b.wValue.w); - } else { - puts("Setting IR power not allowed in power saving mode\n"); - } + current_board->set_ir_power(setup->b.wValue.w); break; // **** 0xb1: set fan power case 0xb1: - if(power_save_status == POWER_SAVE_STATUS_DISABLED){ - current_board->set_fan_power(setup->b.wValue.w); - } else { - puts("Setting fan power not allowed in power saving mode\n"); - } + current_board->set_fan_power(setup->b.wValue.w); break; // **** 0xb2: get fan rpm case 0xb2: @@ -716,6 +708,10 @@ void TIM1_BRK_TIM9_IRQ_Handler(void) { if (power_save_status != POWER_SAVE_STATUS_ENABLED) { set_power_save_state(POWER_SAVE_STATUS_ENABLED); } + + // Also disable fan and IR when the heartbeat goes missing + current_board->set_fan_power(0U); + current_board->set_ir_power(0U); } // enter CDP mode when car starts to ensure we are charging a turned off EON diff --git a/panda/board/power_saving.h b/panda/board/power_saving.h index 3ee2170d7..f7e42371a 100644 --- a/panda/board/power_saving.h +++ b/panda/board/power_saving.h @@ -49,10 +49,9 @@ void set_power_save_state(int state) { set_gpio_output(GPIOA, 14, enable); } - // Switch off IR and fan when in power saving + // Switch off IR when in power saving if(!enable){ current_board->set_ir_power(0U); - current_board->set_fan_power(0U); } power_save_status = state;