Fix most remaining LGTM alerts (#1893)

* fixups from LGTM

* short globals

* fix spinner and textwindow

* total ordering

* no spinner/text window when import from manager

* not android

common/spinner.py

@@ -4,14 +4,17 @@ from common.basedir import BASEDIR
 
 
 class Spinner():
-  def __init__(self):
-    try:
-      self.spinner_proc = subprocess.Popen(["./spinner"],
-                                           stdin=subprocess.PIPE,
-                                           cwd=os.path.join(BASEDIR, "selfdrive", "ui", "spinner"),
-                                           close_fds=True)
-    except OSError:
-      self.spinner_proc = None
+  def __init__(self, noop=False):
+    # spinner is currently only implemented for android
+    self.spinner_proc = None
+    if not noop:
+      try:
+        self.spinner_proc = subprocess.Popen(["./spinner"],
+                                             stdin=subprocess.PIPE,
+                                             cwd=os.path.join(BASEDIR, "selfdrive", "ui", "spinner"),
+                                             close_fds=True)
+      except OSError:
+        self.spinner_proc = None
 
   def __enter__(self):
     return self
@@ -40,23 +43,6 @@ class Spinner():
     self.close()
 
 
-class FakeSpinner(Spinner):
-  def __init__(self):  # pylint: disable=super-init-not-called
-    pass
-
-  def __enter__(self):
-    return self
-
-  def update(self, _):
-    pass
-
-  def close(self):
-    pass
-
-  def __exit__(self, exc_type, exc_value, traceback):
-    pass
-
-
 if __name__ == "__main__":
   import time
   with Spinner() as s:

common/text_window.py

@@ -6,20 +6,22 @@ from common.basedir import BASEDIR
 
 
 class TextWindow():
-  def __init__(self, s):
-    try:
-      self.text_proc = subprocess.Popen(["./text", s],
-                                        stdin=subprocess.PIPE,
-                                        cwd=os.path.join(BASEDIR, "selfdrive", "ui", "text"),
-                                        close_fds=True)
-    except OSError:
-      self.text_proc = None
+  def __init__(self, s, noop=False):
+    # text window is only implemented for android currently
+    self.text_proc = None
+    if not noop:
+      try:
+        self.text_proc = subprocess.Popen(["./text", s],
+                                          stdin=subprocess.PIPE,
+                                          cwd=os.path.join(BASEDIR, "selfdrive", "ui", "text"),
+                                          close_fds=True)
+      except OSError:
+        self.text_proc = None
 
   def get_status(self):
     if self.text_proc is not None:
       self.text_proc.poll()
       return self.text_proc.returncode
-
     return None
 
   def __enter__(self):
@@ -31,10 +33,11 @@ class TextWindow():
       self.text_proc = None
 
   def wait_for_exit(self):
-    while True:
-      if self.get_status() == 1:
-        return
-      time.sleep(0.1)
+    if self.text_proc is not None:
+      while True:
+        if self.get_status() == 1:
+          return
+        time.sleep(0.1)
 
   def __del__(self):
     self.close()
@@ -43,29 +46,6 @@ class TextWindow():
     self.close()
 
 
-class FakeTextWindow(TextWindow):
-  def __init__(self, s):  # pylint: disable=super-init-not-called
-    pass
-
-  def get_status(self):
-    return 1
-
-  def wait_for_exit(self):
-    return
-
-  def __enter__(self):
-    return self
-
-  def update(self, _):
-    pass
-
-  def close(self):
-    pass
-
-  def __exit__(self, exc_type, exc_value, traceback):
-    pass
-
-
 if __name__ == "__main__":
   text = """Traceback (most recent call last):
   File "./controlsd.py", line 608, in <module>

common/transformations/coordinates.cc

@@ -10,9 +10,9 @@
 #define RAD2DEG(x) ((x) * 180.0 / M_PI)
 
 
-double a = 6378137;
-double b = 6356752.3142;
-double esq = 6.69437999014 * 0.001;
+double a = 6378137; // lgtm [cpp/short-global-name]
+double b = 6356752.3142; // lgtm [cpp/short-global-name]
+double esq = 6.69437999014 * 0.001; // lgtm [cpp/short-global-name]
 double e1sq = 6.73949674228 * 0.001;